# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@logilab.fr>
# Date 1364307989 -3600
# Node ID 538852f69b480316694754e6b7876dd4c96d4d34
# Parent  d9aaad2c52e9cee95c8db34724978fa136a66b1d
[session] cleanup Transaction.cnxset

The attribute should always be there. It is None when not cnxset exists.

diff -r d9aaad2c52e9 -r 538852f69b48 server/session.py
--- a/server/session.py	Mon Mar 25 17:50:11 2013 +0100
+++ b/server/session.py	Tue Mar 26 15:26:29 2013 +0100
@@ -897,7 +897,7 @@
         if self._closed:
             self.free_cnxset(True)
             raise Exception('try to access connections set on a closed session %s' % self.id)
-        return getattr(self._tx, 'cnxset', None)
+        return self._tx.cnxset
 
     def set_cnxset(self):
         """the session need a connections set to execute some queries"""
@@ -938,11 +938,11 @@
         """the session is no longer using its connections set, at least for some time"""
         # cnxset may be none if no operation has been done since last commit
         # or rollback
-        cnxset = getattr(self._tx, 'cnxset', None)
+        cnxset = self._tx.cnxset
         if cnxset is not None and (ignoremode or self.mode == 'read'):
             # even in read mode, we must release the current transaction
             self._free_thread_cnxset(threading.currentThread(), cnxset)
-            del self._tx.cnxset
+            self._tx.cnxset = None
             self._tx.ctx_count -= 1
 
     def _touch(self):
@@ -1149,7 +1149,7 @@
                  DeprecationWarning, stacklevel=2)
             free_cnxset = reset_pool
         # don't use self.cnxset, rollback may be called with _closed == True
-        cnxset = getattr(self._tx, 'cnxset', None)
+        cnxset = self._tx.cnxset
         if cnxset is None:
             self._clear_thread_data()
             self._touch()
@@ -1286,7 +1286,7 @@
         if self.repo.shutting_down:
             self.free_cnxset(True)
             raise ShuttingDown('repository is shutting down')
-        return getattr(self._tx, 'cnxset', None)
+        return self._tx.cnxset
 
 
 class InternalManager(object):