# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@logilab.fr>
# Date 1355241438 -3600
# Node ID 51068fe1e39a61eaad8c5b86c62d67516724b671
# Parent  b1145ad53999f2d02728f68f25ae8751827e3d08
[web] allow configuration of the Content-disposition value

The `set_content_type` function now takes and optional `disposition` parameter
to control the value of this HTTP header.

Use of `Content-disposition: inline` with a filename parameter are valid, so
the presence of filename does not allows to choose between `attachment` and
`inline`

diff -r b1145ad53999 -r 51068fe1e39a web/request.py
--- a/web/request.py	Tue Dec 11 17:17:40 2012 +0100
+++ b/web/request.py	Tue Dec 11 16:57:18 2012 +0100
@@ -610,15 +610,20 @@
             name = bwcompat
         self.set_cookie(name, '', maxage=0, expires=date(2000, 1, 1))
 
-    def set_content_type(self, content_type, filename=None, encoding=None):
+    def set_content_type(self, content_type, filename=None, encoding=None,
+                         disposition='attachment'):
         """set output content type for this request. An optional filename
-        may be given
+        may be given.
+
+        The disposition argument may be `attachement` or `inline` as specified
+        for the Content-disposition HTTP header. The disposition parameter have
+        no effect if no filename are specified.
         """
         if content_type.startswith('text/') and ';charset=' not in content_type:
             content_type += ';charset=' + (encoding or self.encoding)
         self.set_header('content-type', content_type)
         if filename:
-            header = ['attachment']
+            header = [disposition]
             unicode_filename = None
             try:
                 ascii_filename = filename.encode('ascii')