# HG changeset patch
# User Julien Cristau <julien.cristau@logilab.fr>
# Date 1396864986 -7200
# Node ID 4714d4afd4ea934cf1e97b912182c2ef81404944
# Parent  9a40a62d54bf03f53b3785d97e948c69a9fd4ebb
[devtools] add 'shell' method to RepoAccess, deprecate CubicWebTC's

Lets us control the connection's lifetime.

diff -r 9a40a62d54bf -r 4714d4afd4ea devtools/testlib.py
--- a/devtools/testlib.py	Mon Apr 07 14:44:49 2014 +0200
+++ b/devtools/testlib.py	Mon Apr 07 12:03:06 2014 +0200
@@ -249,6 +249,17 @@
             self._repo.close(self._session.sessionid)
         self._session = None
 
+    @contextmanager
+    def shell(self):
+        from cubicweb.server.migractions import ServerMigrationHelper
+        with repoapi.ClientConnection(self._session) as cnx:
+            mih = ServerMigrationHelper(None, repo=self._repo, cnx=cnx,
+                                        interactive=False,
+                                        # hack so it don't try to load fs schema
+                                        schema=1)
+            yield mih
+            cnx.commit()
+
 
 
 # base class for cubicweb tests requiring a full cw environments ###############
@@ -524,6 +535,7 @@
         """return the application schema"""
         return self.vreg.schema
 
+    @deprecated('[3.19] explicitly use RepoAccess object in test instead')
     def shell(self):
         """return a shell session object"""
         from cubicweb.server.migractions import ServerMigrationHelper