# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1489164366 -3600
# Node ID 3c60180481ac50dede6b764b6bde1527a8a09ec5
# Parent  88bf0ec257b2f8bf38de1346df2955b7c8236e16
[devtools] Stop relying on Session to create connection in RepoAccess

diff -r 88bf0ec257b2 -r 3c60180481ac cubicweb/devtools/testlib.py
--- a/cubicweb/devtools/testlib.py	Fri Mar 10 17:44:03 2017 +0100
+++ b/cubicweb/devtools/testlib.py	Fri Mar 10 17:46:06 2017 +0100
@@ -44,7 +44,7 @@
 
 from cubicweb import (ValidationError, NoSelectableObject, AuthenticationError,
                       BadConnectionId)
-from cubicweb import cwconfig, devtools, web, server
+from cubicweb import cwconfig, devtools, repoapi, server, web
 from cubicweb.utils import json
 from cubicweb.sobjects import notification
 from cubicweb.web import Redirect, application, eid_param
@@ -229,25 +229,14 @@
         self._repo = repo
         self._login = login
         self.requestcls = requestcls
-        self._session = self._unsafe_connect(login)
-
-    def _unsafe_connect(self, login, **kwargs):
-        """ a completely unsafe connect method for the tests """
-        # use an internal connection
-        with self._repo.internal_cnx() as cnx:
-            # try to get a user object
-            user = cnx.find('CWUser', login=login).one()
-            user.groups
-            user.properties
-            user.login
-            session = Session(user, self._repo)
-            user._cw = user.cw_rset.req = session
-        return session
+        with repo.internal_cnx() as cnx:
+            self._user = cnx.find('CWUser', login=login).one()
+            self._user.cw_attr_cache['login'] = login
 
     @contextmanager
     def cnx(self):
         """Context manager returning a server side connection for the user"""
-        with self._session.new_cnx() as cnx:
+        with repoapi.Connection(self._repo, self._user) as cnx:
             yield cnx
 
     # aliases for bw compat
@@ -264,14 +253,16 @@
         """
         req = self.requestcls(self._repo.vreg, url=url, headers=headers,
                               method=method, form=kwargs)
-        with self._session.new_cnx() as cnx:
+        with self.cnx() as cnx:
+            # web request expect a session attribute on cnx referencing the web session
+            cnx.session = Session(self._repo, self._user)
             req.set_cnx(cnx)
             yield req
 
     @contextmanager
     def shell(self):
         from cubicweb.server.migractions import ServerMigrationHelper
-        with self._session.new_cnx() as cnx:
+        with self.cnx() as cnx:
             mih = ServerMigrationHelper(None, repo=self._repo, cnx=cnx,
                                         interactive=False,
                                         # hack so it don't try to load fs schema