# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1311690823 -7200
# Node ID 2f6e37661cf62f9205c7ece9947de6bd6eb6e45b
# Parent  b37f4fdc44d4322e80cb4bc82117539258d6ac92# Parent  bd56a29acaa86e9ac3b023968d855eb841508a36
backport oldstable

diff -r b37f4fdc44d4 -r 2f6e37661cf6 server/sources/storages.py
--- a/server/sources/storages.py	Tue Jul 26 13:11:37 2011 +0200
+++ b/server/sources/storages.py	Tue Jul 26 16:33:43 2011 +0200
@@ -148,6 +148,7 @@
             # We do not need to create it but we need to fetch the content of
             # the file as the actual content of the attribute
             fpath = entity.cw_edited[attr].getvalue()
+            assert fpath is not None
             binary = Binary(file(fpath, 'rb').read())
         else:
             # We must store the content of the attributes
@@ -160,17 +161,23 @@
             #
             # fetch the current attribute value in memory
             binary = entity.cw_edited.pop(attr)
-            # Get filename for it
-            fpath = self.new_fs_path(entity, attr)
-            assert not osp.exists(fpath)
-            # write attribute value on disk
-            file(fpath, 'wb').write(binary.getvalue())
-            # Mark the new file as added during the transaction.
-            # The file will be removed on rollback
-            AddFileOp.get_instance(entity._cw).add_data(fpath)
+            if binary is None:
+                fpath = None
+            else:
+                # Get filename for it
+                fpath = self.new_fs_path(entity, attr)
+                assert not osp.exists(fpath)
+                # write attribute value on disk
+                file(fpath, 'wb').write(binary.getvalue())
+                # Mark the new file as added during the transaction.
+                # The file will be removed on rollback
+                AddFileOp.get_instance(entity._cw).add_data(fpath)
         if oldpath != fpath:
             # register the new location for the file.
-            entity.cw_edited.edited_attribute(attr, Binary(fpath))
+            if fpath is None:
+                entity.cw_edited.edited_attribute(attr, None)
+            else:
+                entity.cw_edited.edited_attribute(attr, Binary(fpath))
             # Mark the old file as useless so the file will be removed at
             # commit.
             if oldpath is not None:
diff -r b37f4fdc44d4 -r 2f6e37661cf6 server/test/data/schema.py
--- a/server/test/data/schema.py	Tue Jul 26 13:11:37 2011 +0200
+++ b/server/test/data/schema.py	Tue Jul 26 16:33:43 2011 +0200
@@ -18,12 +18,15 @@
 
 from yams.buildobjs import (EntityType, RelationType, RelationDefinition,
                             SubjectRelation, RichString, String, Int, Float,
-                            Boolean, Datetime, TZDatetime)
+                            Boolean, Datetime, TZDatetime, Bytes)
 from yams.constraints import SizeConstraint
 from cubicweb.schema import (WorkflowableEntityType,
                              RQLConstraint, RQLUniqueConstraint,
                              ERQLExpression, RRQLExpression)
 
+class BFSSTestable(EntityType):
+    opt_attr = Bytes()
+
 class Affaire(WorkflowableEntityType):
     __permissions__ = {
         'read':   ('managers',
diff -r b37f4fdc44d4 -r 2f6e37661cf6 server/test/unittest_storage.py
--- a/server/test/unittest_storage.py	Tue Jul 26 13:11:37 2011 +0200
+++ b/server/test/unittest_storage.py	Tue Jul 26 16:33:43 2011 +0200
@@ -58,6 +58,7 @@
         self.tempdir = tempfile.mkdtemp()
         bfs_storage = storages.BytesFileSystemStorage(self.tempdir)
         storages.set_attribute_storage(self.repo, 'File', 'data', bfs_storage)
+        storages.set_attribute_storage(self.repo, 'BFSSTestable', 'opt_attr', bfs_storage)
 
     def tearDown(self):
         super(StorageTC, self).tearDown()
@@ -256,6 +257,14 @@
         self.assertEqual(old_path, new_path)
         self.assertEqual(old_data, new_data)
 
+    @tag('update', 'NULL')
+    def test_bfss_update_to_None(self):
+        f = self.session.create_entity('BFSSTestable', opt_attr=Binary('toto'))
+        self.session.commit()
+        self.session.set_pool()
+        f.set_attributes(opt_attr=None)
+        self.session.commit()
+
     @tag('fs_importing', 'update')
     def test_bfss_update_with_fs_importing(self):
         # use self.session to use server-side cache
diff -r b37f4fdc44d4 -r 2f6e37661cf6 skeleton/test/pytestconf.py
--- a/skeleton/test/pytestconf.py	Tue Jul 26 13:11:37 2011 +0200
+++ b/skeleton/test/pytestconf.py	Tue Jul 26 16:33:43 2011 +0200
@@ -19,7 +19,7 @@
 
 """
 import os
-import pwd
+import sys
 
 from logilab.common.pytest import PyTester
 
@@ -28,6 +28,9 @@
     (man 3 getlogin)
     Another solution would be to use $LOGNAME, $USER or $USERNAME
     """
+    if sys.platform == 'win32':
+        return os.environ.get('USERNAME') or 'cubicweb'
+    import pwd
     return pwd.getpwuid(os.getuid())[0]