# HG changeset patch # User RĂ©mi Cardona # Date 1413386969 -7200 # Node ID 292c81246347f045b0a2a0b6fc775c6a1fe2758d # Parent 621646d5f0102092244e0bdd88cb71c268fe8d06 [web] There is no global noop(), use jQuery's instead (closes #4487832) diff -r 621646d5f010 -r 292c81246347 web/data/cubicweb.preferences.js --- a/web/data/cubicweb.preferences.js Fri Oct 10 09:18:28 2014 +0200 +++ b/web/data/cubicweb.preferences.js Wed Oct 15 17:29:29 2014 +0200 @@ -25,7 +25,7 @@ function _toggleFieldset(fieldsetid, closeaction, linklabel, linkhref) { jQuery('#' + fieldsetid).find('div.openlink').each(function() { var link = A({ - 'href': "javascript:noop();", + 'href': "javascript:$.noop();", 'onclick': linkhref }, linklabel); diff -r 621646d5f010 -r 292c81246347 web/data/cubicweb.widgets.js --- a/web/data/cubicweb.widgets.js Fri Oct 10 09:18:28 2014 +0200 +++ b/web/data/cubicweb.widgets.js Wed Oct 15 17:29:29 2014 +0200 @@ -355,7 +355,7 @@ Widgets.SuggestForm = defclass("SuggestForm", null, { __init__: function(inputid, initfunc, varargs, validatefunc, options) { - this.validatefunc = validatefunc || noop; + this.validatefunc = validatefunc || $.noop; this.sgfield = new Widgets.BaseSuggestField(inputid, initfunc, varargs, options); this.oklabel = options.oklabel || 'ok'; this.cancellabel = options.cancellabel || 'cancel'; @@ -369,11 +369,11 @@ 'class': "sgformbuttons" }, [A({ - 'href': "javascript: noop();", + 'href': "javascript: $.noop();", 'onclick': this.onValidateClicked }, this.oklabel), ' / ', A({ - 'href': "javascript: noop();", + 'href': "javascript: $.noop();", 'onclick': this.destroy }, escapeHTML(this.cancellabel))]);