# HG changeset patch
# User Alexandre Fayolle <alexandre.fayolle@logilab.fr>
# Date 1265975749 -3600
# Node ID 2279ba03949455b9d0835ca004e862fd8d45e94a
# Parent  2eb36514ad6d3ee53760883727fca945ad8b396f
use subprocess instead of os.popen to run diff

this avoids argument quoting issues (spaces in path, etc)

diff -r 2eb36514ad6d -r 2279ba039494 toolsutils.py
--- a/toolsutils.py	Tue Feb 09 08:15:20 2010 +0100
+++ b/toolsutils.py	Fri Feb 12 12:55:49 2010 +0100
@@ -10,6 +10,7 @@
 # XXX move most of this in logilab.common (shellutils ?)
 
 import os, sys
+import subprocess
 from os import listdir, makedirs, environ, chmod, walk, remove
 from os.path import exists, join, abspath, normpath
 
@@ -72,8 +73,8 @@
     user decision
     """
     import shutil
-    p_output = os.popen('diff -u %s %s' % (appl_file, ref_file), 'r')
-    diffs = p_output.read()
+    pipe = subprocess.Popen(['diff', '-u', appl_file, ref_file], stdout=subprocess.PIPE)
+    diffs = pipe.stdout.read()
     if diffs:
         if askconfirm:
             print