# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1259754826 -3600
# Node ID 21387ffb07310f013c84ed205e366a99f59d2e96
# Parent  0d592677e55fd11cd415fd89786de6622fbc5ad3
refactor so that we can specify an extra argument to constraints which
will be used as error message

diff -r 0d592677e55f -r 21387ffb0731 schema.py
--- a/schema.py	Wed Dec 02 12:52:55 2009 +0100
+++ b/schema.py	Wed Dec 02 12:53:46 2009 +0100
@@ -608,6 +608,24 @@
     """
     distinct_query = False
 
+    def __init__(self, restriction, mainvars=None, msg=None):
+        super(RQLConstraint, self).__init__(restriction, mainvars)
+        self.msg = msg
+
+    def serialize(self):
+        # start with a comma for bw compat, see below
+        return ';%s;%s\n%s' % (self.mainvars + ';' + self.restriction,
+                               self.msg or '')
+
+    def deserialize(cls, value):
+        # XXX < 3.5.10 bw compat
+        if not value.startswith(';'):
+            return cls(value)
+        value, msg = value.split('\n', 1)
+        _, mainvars, restriction = value.split(';', 2)
+        return cls(restriction, mainvars, msg)
+    deserialize = classmethod(deserialize)
+
     def exec_query(self, session, eidfrom, eidto):
         if eidto is None:
             # checking constraint for an attribute relation
@@ -621,16 +639,24 @@
             rql = 'DISTINCT ' + rql
         return session.unsafe_execute(rql, args, ck, build_descr=False)
 
-    def error(self, eid, rtype, msg):
-        raise ValidationError(eid, {rtype: msg})
-
     def repo_check(self, session, eidfrom, rtype, eidto=None):
         """raise ValidationError if the relation doesn't satisfy the constraint
         """
         if not self.exec_query(session, eidfrom, eidto):
-            # XXX at this point dunno if the validation error `occured` on
-            #     eidfrom or eidto (from user interface point of view)
-            self.error(eidfrom, rtype, 'constraint %s failed' % self)
+            # XXX at this point if both or neither of S and O are in mainvar we
+            # dunno if the validation error `occured` on eidfrom or eidto (from
+            # user interface point of view)
+            if eidto is None or 'S' in self.mainvars or not 'O' in self.mainvars:
+                maineid = eidfrom
+            else:
+                maineid = eidto
+            if self.msg:
+                msg = session._(self.msg)
+            else:
+                msg = '%(constraint)s %(restriction)s failed' % {
+                    'constraint':  session._(self.type()),
+                    'restriction': self.restriction}
+            raise ValidationError(maineid, {rtype: msg})
 
 
 class RQLUniqueConstraint(RQLConstraint):
@@ -639,13 +665,9 @@
     """
     distinct_query = True
 
-    def repo_check(self, session, eidfrom, rtype, eidto=None):
-        """raise ValidationError if the relation doesn't satisfy the constraint
-        """
-        if len(self.exec_query(session, eidfrom, eidto)) > 1:
-            # XXX at this point dunno if the validation error `occured` on
-            #     eidfrom or eidto (from user interface point of view)
-            self.error(eidfrom, rtype, 'unique constraint %s failed' % self)
+    def exec_query(self, session, eidfrom, eidto):
+        rset = super(RQLUniqueConstraint, self).exec_query(session, eidfrom, eidto)
+        return len(rset) <= 1
 
 
 def split_expression(rqlstring):