# HG changeset patch
# User Pierre-Yves David <pierre-yves.david@logilab.fr>
# Date 1364221698 -3600
# Node ID 1b3b7284377fa58f45d2a5a553d0a738a53f2fdc
# Parent  c2bc0b8049828f534206bdafbfbc22bc2ffd41e5
[session] allow writable  tx_attr and use it for commit_state

This keep clarifying the code.

diff -r c2bc0b804982 -r 1b3b7284377f server/session.py
--- a/server/session.py	Mon Mar 25 16:12:39 2013 +0100
+++ b/server/session.py	Mon Mar 25 15:28:18 2013 +0100
@@ -300,15 +300,19 @@
             self.pending_operations.insert(index, operation)
 
 
-
-def tx_attr(attr_name):
+def tx_attr(attr_name, writable=False):
     """return a property to forward attribute access to transaction.
 
     This is to be used by session"""
-    @property
+    args = {}
     def attr_from_tx(session):
         return getattr(session._tx, attr_name)
-    return attr_from_tx
+    args['fget'] = attr_from_tx
+    if writable:
+        def write_attr(session, value):
+            return setattr(session._tx, attr_name, value)
+        args['fset'] = write_attr
+    return property(**args)
 
 def tx_meth(meth_name):
     """return a function forwarding calls to transaction.
@@ -902,11 +906,7 @@
                     doc='transaction mode (read/write/transaction), resetted to'
                     ' default_mode on commit / rollback')
 
-    def get_commit_state(self):
-        return self._tx.commit_state
-    def set_commit_state(self, value):
-        self._tx.commit_state = value
-    commit_state = property(get_commit_state, set_commit_state)
+    commit_state = tx_attr('commit_state', writable=True)
 
     @property
     def cnxset(self):