# HG changeset patch # User Nicolas Chauvat # Date 1249987321 -7200 # Node ID 1800aa0bf3961cc1b8b0c48c61857140a7b9a68e # Parent 23d7a75693f8338555dcc58f9a0644857d10cfd1 R [registry] changes in the API diff -r 23d7a75693f8 -r 1800aa0bf396 vregistry.py --- a/vregistry.py Mon Aug 10 23:33:11 2009 +0200 +++ b/vregistry.py Tue Aug 11 12:42:01 2009 +0200 @@ -125,6 +125,7 @@ # dynamic selection methods ################################################ + @deprecated('use select instead of object_by_id') def object_by_id(self, oid, *args, **kwargs): """return object with the given oid. Only one object is expected to be found. @@ -143,9 +144,9 @@ raise `ObjectNotFound` if not object with id in raise `NoSelectableObject` if not object apply """ - return self.select_best(self[oid], *args, **kwargs) + return self._select_best(self[oid], *args, **kwargs) - def select_object(self, oid, *args, **kwargs): + def select_or_none(self, oid, *args, **kwargs): """return the most specific object among those with the given oid according to the given context, or None if no object applies. """ @@ -153,6 +154,8 @@ return self.select(oid, *args, **kwargs) except (NoSelectableObject, ObjectNotFound): return None + select_object = deprecated('use select_or_none instead of select_object' + )(select_or_none) def possible_objects(self, *args, **kwargs): """return an iterator on possible objects in this registry for the given @@ -160,11 +163,11 @@ """ for appobjects in self.itervalues(): try: - yield self.select_best(appobjects, *args, **kwargs) + yield self._select_best(appobjects, *args, **kwargs) except NoSelectableObject: continue - def select_best(self, appobjects, *args, **kwargs): + def _select_best(self, appobjects, *args, **kwargs): """return an instance of the most specific object according to parameters @@ -194,7 +197,7 @@ [repr(v) for v in winners])) # return the result of calling the appobject return winners[0](*args, **kwargs) - + select_best = deprecated('select_best is now private')(_select_best) class VRegistry(dict): """class responsible to register, propose and select the various