# HG changeset patch
# User Sylvain Thénault <sylvain.thenault@logilab.fr>
# Date 1453274790 -3600
# Node ID 0796b6191cea937d3a70f7ff81b7463d9dc2b17c
# Parent  3fea2f3b25c181d0766bdbcb92af3d3772ba6748
[pylint] more work on the pylint support

* uniformize usage of ClassDef and simplify related import
* don't insert in the ast a python function but an astroid representation of that function
* ignore __pkginfo__ file
* drop attr-rgx, variable-rgx and argument-rgx, put the name in good-names instead
* drop additional-builtins
* add cell_call to the list of methods for which we don't want 'abstract-method'

diff -r 3fea2f3b25c1 -r 0796b6191cea cubicweb/pylintext.py
--- a/cubicweb/pylintext.py	Tue Jan 19 14:07:59 2016 +0100
+++ b/cubicweb/pylintext.py	Wed Jan 20 08:26:30 2016 +0100
@@ -1,7 +1,20 @@
-"""Pylint plugin for cubicweb"""
+"""Pylint plugin to analyse cubicweb cubes
+
+Done:
+* turn functions decorated by @objectify_predicate into classes
+* add yams base types to yams.buildobjs module
+* add data() function to uiprops module's namespace
+* avoid 'abstract method not implemented' for `cell_call`, `entity_call`, `render_body`
 
-from astroid import MANAGER, InferenceError, nodes, scoped_nodes, ClassDef, FunctionDef
+TODO:
+* avoid invalid class name for predicates and predicates
+* W:188, 0: Method '__lt__' is abstract in class 'Entity' but is not overridden (abstract-method)
+* generate entity attributes from the schema?
+"""
+
+from astroid import MANAGER, InferenceError, nodes, ClassDef, FunctionDef
 from astroid.builder import AstroidBuilder
+
 from pylint.checkers.utils import unimplemented_abstract_methods, class_is_abstract
 
 
@@ -9,10 +22,14 @@
     """turn a Function node into a Class node (in-place)"""
     node.__class__ = ClassDef
     node.bases = ()
+    # mark class as a new style class
+    node._newstyle = True
     # remove return nodes so that we don't get warned about 'return outside
     # function' by pylint
     for rnode in node.nodes_of_class(nodes.Return):
         rnode.parent.body.remove(rnode)
+    # add __init__ method to avoid no-init
+
     # that seems to be enough :)
 
 
@@ -38,9 +55,9 @@
     if module.name == 'yams.buildobjs':
         from yams import BASE_TYPES
         for etype in BASE_TYPES:
-            module.locals[etype] = [scoped_nodes.Class(etype, None)]
+            module.locals[etype] = [ClassDef(etype, None)]
     # add data() to uiprops module
-    if module.name.split('.')[-1] == 'uiprops':
+    elif module.name.split('.')[-1] == 'uiprops':
         fake = AstroidBuilder(MANAGER).string_build('''
 def data(string):
   return u''
@@ -60,18 +77,21 @@
         key=lambda item: item[0],
     )
 
-    def dummy_method():
-        """"""
+    dummy_method = AstroidBuilder(MANAGER).string_build('''
+def dummy_method(self):
+   """"""
+''')
+
     for name, method in methods:
         owner = method.parent.frame()
         if owner is classdef:
             continue
         if name not in classdef.locals:
-            if name in ('entity_call', 'render_body'):
+            if name in ('cell_call', 'entity_call', 'render_body'):
                 classdef.set_local(name, dummy_method)
 
 
 def register(linter):
     """called when loaded by pylint --load-plugins, nothing to do here"""
     MANAGER.register_transform(nodes.Module, cubicweb_transform)
-    MANAGER.register_transform(nodes.ClassDef, cubicweb_abstractmethods_transform)
+    MANAGER.register_transform(ClassDef, cubicweb_abstractmethods_transform)
diff -r 3fea2f3b25c1 -r 0796b6191cea pylintrc
--- a/pylintrc	Tue Jan 19 14:07:59 2016 +0100
+++ b/pylintrc	Wed Jan 20 08:26:30 2016 +0100
@@ -1,17 +1,13 @@
 [MASTER]
 load-plugins=cubicweb.pylintext
+ignore=__pkginfo__
 
 [MESSAGES CONTROL]
 disable = too-many-ancestors,too-many-instance-attributes,too-many-public-methods,
       too-few-public-methods,too-many-arguments,import-error
 
-[VARIABLES]
-additional-builtins=_,display_name
-
 [BASIC]
-attr-rgx = (w|[a-z_][a-z0-9_]{2,30})
-variable-rgx = (w|[a-z_][a-z0-9_]{2,30})$
-argument-rgx = (w|[a-z_][a-z0-9_]{2,30})$
+function-rgx = [a-z_][a-z0-9_]{2,35}$
 good-names=w,_
 
 [TYPECHECK]