# HG changeset patch # User Sylvain Thénault # Date 1265785697 -3600 # Node ID 05eadf88b797e2864878e89aa2cb883f7249089c # Parent 85116e75f5611c7686b2e844435858d3a2805df0 rephrase diff -r 85116e75f561 -r 05eadf88b797 server/querier.py --- a/server/querier.py Wed Feb 10 08:07:53 2010 +0100 +++ b/server/querier.py Wed Feb 10 08:08:17 2010 +0100 @@ -662,7 +662,7 @@ # since it's actually realy only needed there (other relations # security is done *before* actual changes, and add/update entity # security is done after changes but in an operation, and exception - # generated in operation's events properly generate a rollback on + # generated in operation's events properly generate a rollback on # the session). Even though, this is done here for a better # consistency: getting an Unauthorized exception means the # transaction has been rollbacked diff -r 85116e75f561 -r 05eadf88b797 server/session.py --- a/server/session.py Wed Feb 10 08:07:53 2010 +0100 +++ b/server/session.py Wed Feb 10 08:08:17 2010 +0100 @@ -484,10 +484,8 @@ operation.failed = True for operation in processed: operation.handle_event('revert%s_event' % trstate) - # res - - # XXX self.pending_operations is supposed to be - # read-only, and we are clearly modifying it here. + # XXX use slice notation since self.pending_operations is a + # read-only property. self.pending_operations[:] = processed + self.pending_operations self.rollback(reset_pool) raise