diff -r d911a73ac8c5 -r f31f9882c90f server/test/unittest_rql2sql.py --- a/server/test/unittest_rql2sql.py Wed Jul 20 14:10:02 2011 +0200 +++ b/server/test/unittest_rql2sql.py Wed Jul 20 14:10:03 2011 +0200 @@ -1643,12 +1643,26 @@ '''SELECT (A || _X.cw_ref) FROM cw_Affaire AS _X''') - def test_or_having_fake_terms(self): + def test_or_having_fake_terms_base(self): self._check('Any X WHERE X is CWUser, X creation_date D HAVING YEAR(D) = "2010" OR D = NULL', '''SELECT _X.cw_eid FROM cw_CWUser AS _X WHERE ((CAST(EXTRACT(YEAR from _X.cw_creation_date) AS INTEGER)=2010) OR (_X.cw_creation_date IS NULL))''') + def test_or_having_fake_terms_exists(self): + # crash with rql <= 0.29.0 + self._check('Any X WHERE X is CWUser, EXISTS(B bookmarked_by X, B creation_date D) HAVING D=2010 OR D=NULL, D=1 OR D=NULL', + '''SELECT _X.cw_eid +FROM cw_CWUser AS _X +WHERE EXISTS(SELECT 1 FROM bookmarked_by_relation AS rel_bookmarked_by0, cw_Bookmark AS _B WHERE rel_bookmarked_by0.eid_from=_B.cw_eid AND rel_bookmarked_by0.eid_to=_X.cw_eid AND ((_B.cw_creation_date=1) OR (_B.cw_creation_date IS NULL)) AND ((_B.cw_creation_date=2010) OR (_B.cw_creation_date IS NULL)))''') + + def test_or_having_fake_terms_nocrash(self): + # crash with rql <= 0.29.0 + self._check('Any X WHERE X is CWUser, X creation_date D HAVING D=2010 OR D=NULL, D=1 OR D=NULL', + '''SELECT _X.cw_eid +FROM cw_CWUser AS _X +WHERE ((_X.cw_creation_date=1) OR (_X.cw_creation_date IS NULL)) AND ((_X.cw_creation_date=2010) OR (_X.cw_creation_date IS NULL))''') + def test_not_no_where(self): # XXX will check if some in_group relation exists, that's it. # We can't actually know if we want to check if there are some @@ -1699,7 +1713,7 @@ def test_regexp(self): self.skipTest('regexp-based pattern matching not implemented in sqlserver') - def test_or_having_fake_terms(self): + def test_or_having_fake_terms_base(self): self._check('Any X WHERE X is CWUser, X creation_date D HAVING YEAR(D) = "2010" OR D = NULL', '''SELECT _X.cw_eid FROM cw_CWUser AS _X @@ -1984,7 +1998,7 @@ yield t - def test_or_having_fake_terms(self): + def test_or_having_fake_terms_base(self): self._check('Any X WHERE X is CWUser, X creation_date D HAVING YEAR(D) = "2010" OR D = NULL', '''SELECT _X.cw_eid FROM cw_CWUser AS _X @@ -2095,7 +2109,7 @@ FROM cw_Personne AS _P''') - def test_or_having_fake_terms(self): + def test_or_having_fake_terms_base(self): self._check('Any X WHERE X is CWUser, X creation_date D HAVING YEAR(D) = "2010" OR D = NULL', '''SELECT _X.cw_eid FROM cw_CWUser AS _X