diff -r 2b91abd9f5a4 -r 1fbcf202882d server/session.py --- a/server/session.py Mon Jun 29 14:12:18 2009 +0200 +++ b/server/session.py Thu Jul 02 10:35:03 2009 +0200 @@ -84,10 +84,6 @@ """return an entity class for the given entity type""" return self.vreg.etype_class(etype) - def entity(self, eid): - """return a result set for the given eid""" - return self.eid_rset(eid).get_entity(0, 0) - def system_sql(self, sql, args=None): """return a sql cursor on the system database""" if not sql.split(None, 1)[0].upper() == 'SELECT': @@ -270,6 +266,7 @@ assert not self.pending_operations self.transaction_data.clear() self._touch() + self.debug('commit session %s done (no db activity)', self.id) return if self.commit_state: return @@ -311,6 +308,7 @@ assert not self.pending_operations self.transaction_data.clear() self._touch() + self.debug('rollback session %s done (no db activity)', self.id) return try: while self.pending_operations: @@ -321,6 +319,7 @@ self.critical('rollback error', exc_info=sys.exc_info()) continue self.pool.rollback() + self.debug('rollback for session %s done', self.id) finally: self._touch() self.pending_operations[:] = [] @@ -359,16 +358,6 @@ self._threaddata.transaction_data = {} return self._threaddata.transaction_data - @obsolete('use direct access to session.transaction_data') - def query_data(self, key, default=None, setdefault=False, pop=False): - if setdefault: - assert not pop - return self.transaction_data.setdefault(key, default) - if pop: - return self.transaction_data.pop(key, default) - else: - return self.transaction_data.get(key, default) - @property def pending_operations(self): try: @@ -457,6 +446,21 @@ description.append(tuple(row_descr)) return description + @obsolete('use direct access to session.transaction_data') + def query_data(self, key, default=None, setdefault=False, pop=False): + if setdefault: + assert not pop + return self.transaction_data.setdefault(key, default) + if pop: + return self.transaction_data.pop(key, default) + else: + return self.transaction_data.get(key, default) + + @obsolete('use entity_from_eid(eid, etype=None)') + def entity(self, eid): + """return a result set for the given eid""" + return self.eid_rset(eid).get_entity(0, 0) + class ChildSession(Session): """child (or internal) session are used to hijack the security system