Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 17 Apr 2014 12:34:51 +0200] rev 10092
[schema] stop using RQLUniqueConstraint (closes #3753250)
The last uses are replaced with unique together constraints.
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 03 Apr 2014 14:17:16 +0200] rev 10091
[dataimport] Have ucsvreader's API match that of csv.reader (closes #3705701)
'separator' and 'quote' are replaced with 'delimiter' and 'quotechar'.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 19 Nov 2014 12:13:32 +0100] rev 10090
[utils] Add a '_cwtracehtml' GET parameter to trace self._cw.w() calls (closes #4601327)
The core of this patch is in UStringIO.write(). When tracing is enabled,
write() doesn't just append the 'value' argument to the underlying list.
Instead, a stack trace is recorded and a special HTML "source" is
formatted.
The output with tracing enabled is an HTML page, with the original HTML
escaped, and made clickable to show the stack trace when the write()
call was done.
This allows answering the recurring question: "who wrote this tag
here?!"
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 19 Nov 2014 11:57:55 +0100] rev 10089
[datafeed] Add a raise_on_error parameter to DataFeedSource.extid2entity
And pass the option from various `process_` methods in existing parsers.
This makes debugging in tests easier.
Closes #4601191.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 02 Dec 2014 11:37:01 +0100] rev 10088
[test/view forms] use the official, undeprecated API
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 27 May 2014 18:47:24 +0200] rev 10087
[rset] kill the rset._rqlst cache
Right now it "works" for the standard, internal uses.
However when we will fold ClientConnection and Connection, it will
hurt, because suddenly we get more cache hits, and the following
situation would become commonplace:
* there is an un-annotated _rqlst given by the querier
* some view (e.g. facets) requests the .syntax_tree, which takes a
copy of _rqlst
* the view actually expects the rql syntax tree to be annotated, but
it was not, hence we crash.
Related to #3837233.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 18:03:43 +0200] rev 10086
[source/native] session -> cnx
Also swap process_results arguments order to make cnx come earlier.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 16:18:46 +0200] rev 10085
[hookstests] change got/expected order
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 09 Jul 2014 15:38:39 +0200] rev 10084
[config] kill a getattr
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 03 Dec 2014 11:36:05 +0100] rev 10083
[tests/web] switch previous commit (136b5f995f8) to the new test api
Related to #3670209.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 22 Oct 2014 14:16:47 +0200] rev 10082
[web] remove unused argument from treeview._init_headers
Julien Cristau <julien.cristau@logilab.fr> [Tue, 21 Oct 2014 11:06:19 +0200] rev 10081
[doc/3.20] mention CWEP-002
Julien Cristau <julien.cristau@logilab.fr> [Thu, 02 Oct 2014 17:18:29 +0200] rev 10080
[web] stop accepting the magic __message form parameter
This has been deprecated for a while, and replaced by _cwmsgid, which
doesn't allow arbitrary content.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 02 Oct 2014 16:34:38 +0200] rev 10079
[web/request] add security_enabled method
Just forward to the underlying repo connection. This can be useful in
the ORM when dealing with a "code-only" attribute, i.e. something that
shouldn't be directly user-visible but must be accessible from a web
request.
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 18 Nov 2014 18:20:08 +0100] rev 10078
[dataimport] Fix use of _create_copyfrom_buffer() (related to #3845572)
This is used indirectly by SQLGenObjectStore when running on a
PostgreSQL database.
Regression introduced by commit 70056633085c.
David Douard <david.douard@logilab.fr> [Wed, 26 Mar 2014 14:45:33 +0100] rev 10077
[c-c configure] make it possible to specify the section for sources configuration (closes #3477678)
Julien Cristau <julien.cristau@logilab.fr> [Wed, 10 Sep 2014 11:34:32 +0200] rev 10076
[server] fix 'cnx' variable confusion in DBG_SQL exception case
The rollback handling expects 'cnx' to be the cubicweb Connection, but
the DBG_SQL block was replacing it with an sql connection, leading to
lulz down the line. Also remove obsolete getattr (the sqlite wrapping
is now done at the cnxset level, so cnx.cnxset.cnx should be the right
thing already).
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 20 Mar 2014 10:41:22 +0100] rev 10075
Provide sufficient context to check 'delete' permission in AjaxEditRelationCtxComponent
Call rdef.check only when both fromeid and toeid are available. Though only
call it once (for the first encountered related entity).
Factorize a bit to keep handling of CSS/JS addition the same.
Closes #3670209.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 01 Dec 2014 11:13:10 +0100] rev 10074
merge 3.19.6 into 3.20 branch
David Douard <david.douard@logilab.fr> [Sun, 30 Nov 2014 21:24:36 +0100] rev 10073
Added tag cubicweb-version-3.19.6, cubicweb-debian-version-3.19.6-1, cubicweb-centos-version-3.19.6-1 for changeset 934341b848a6
David Douard <david.douard@logilab.fr> [Sun, 30 Nov 2014 12:01:57 +0100] rev 10072
[test] missing unittest.main() call in unittest_http_headers.py
David Douard <david.douard@logilab.fr> [Fri, 28 Nov 2014 00:39:31 +0100] rev 10071
[test] make unittest_webconfig independant of CWD
if apphome is unset in ApptestConfiguration constructor, this later looks
for a 'data' directory in CWD, making this test runnable only from
web/test (and pytest do chdir before executing tests, so we did not noticed
this problem).
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 28 Nov 2014 11:51:36 +0100] rev 10070
[webctl] do not ask questions if verbosity is at 0
Closes #4641960.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 28 Nov 2014 10:16:37 +0100] rev 10069
[web] Slight tweak on jQueryUI's colors on links (related to #4564046)
Follow up to commit 16f550b48d57 which was somewhat brutal. This change
only overrides jQueryUI's CSS rules inside tab panes and leaves actual
tab buttons alone.
Rémi Cardona <remi.cardona@free.fr> [Wed, 30 Jul 2014 22:26:18 +0200] rev 10068
[view] Remove unused imports
Rémi Cardona <remi.cardona@free.fr> [Tue, 29 Jul 2014 07:36:41 +0200] rev 10067
Remove obsolete __future__ imports
Generators have been available since 2.3, "with" statements since 2.6.
Rémi Cardona <remi.cardona@free.fr> [Tue, 19 Aug 2014 12:04:23 +0200] rev 10066
[devtools] Remove unused local function
Unused since cw's first commit.
Florent Cayré <florent.cayre@gmail.com> [Sun, 04 May 2014 22:29:20 +0200] rev 10065
[uihelper] Fix a possible NameError in meta_formconfig
could occur when using FormConfig with a custom uicfg object.
Closes #3802298.
Christophe de Vienne <christophe@unlish.com> [Wed, 19 Nov 2014 11:30:18 +0100] rev 10064
[devtools] Avoid db_cache collisions and mis-loading
This is done by stopping to share the db_cache between
TestDataBaseHandler instances
It may seem overkill, but is the only way I could get it to work
properly. I think the whole db caching code needs some rework to better
work with different db handlers.
Closes #4601328
Christophe de Vienne <christophe@unlish.com> [Mon, 06 Oct 2014 12:08:41 +0200] rev 10063
[devtools][pg] Remove a wrong assertion in _backup_database
When using pre_setup_database, a repo gets initialised before calling
backup_database. Hence self._repo is NOT None it that case.
David Douard <david.douard@logilab.fr> [Wed, 26 Nov 2014 16:24:28 +0100] rev 10062
[pkg] prepare 3.19.6
David Douard <david.douard@logilab.fr> [Wed, 26 Nov 2014 17:58:23 +0100] rev 10061
[merge] backport 3.18 fixes
Christophe de Vienne <christophe@unlish.com> [Fri, 19 Sep 2014 13:08:26 +0200] rev 10060
Accept '==' operator in cubes dependencies
'==' is the operator used in the python dependencies specifications.
See PEP 440 http://legacy.python.org/dev/peps/pep-0440/#version-specifiers
Using the same operator in cubes dependencies allow to make setuptools handle
the cubes dependencies while keeping cubicweb happy about the dependencies.
Closes #4375144
Julien Cristau <julien.cristau@logilab.fr> [Tue, 23 Sep 2014 13:51:12 +0200] rev 10059
[session] don't silently ignore commits
commits while in the precommit or postcommit phase are silently ignored.
This is OK in precommit since there'll be a commit afterwards anyway;
OTOH in postcommit it may surprise the developer who didn't read the
documentation for postcommit operations carefully enough. Related to
#4383922.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Nov 2014 11:49:28 +0100] rev 10058
[migration/bootstrap] add explicit index removal for sqlserver, be tolerant to migration replay
Closes #4618944.
David Douard <david.douard@logilab.fr> [Wed, 26 Nov 2014 17:39:59 +0100] rev 10057
Added tag cubicweb-version-3.18.7, cubicweb-debian-version-3.18.7-1, cubicweb-centos-version-3.18.7-1 for changeset cb96f4403cf2
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 25 Nov 2014 12:15:41 +0100] rev 10056
[pkg] prepare 3.18.7
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 19 Nov 2014 12:36:43 +0100] rev 10055
[migration/3.18] speed up the migration and be a little bit more informative
Closes #4619277.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Nov 2014 12:36:17 +0100] rev 10054
[schemaserial] be robust against duplicated CWUniqueTogetherConstrain entities arising from bug in the pre 3.18 era
Closes #4619278.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Feb 2014 15:01:23 +0100] rev 10053
[server] Handle unique constraint violations under recent sqlite
The error message changed from "columns foo, bar, baz are not unique" to
"UNIQUE constraint failed: table.foo, table.bar, table.baz".
Closes #3564510
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Nov 2014 18:43:51 +0100] rev 10052
[merge] backport 3.17 fixes
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Nov 2014 18:40:09 +0100] rev 10051
Added tag cubicweb-version-3.17.18, cubicweb-debian-version-3.17.18-1, cubicweb-centos-version-3.17.18-1 for changeset cda4b066933f
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Nov 2014 17:42:08 +0100] rev 10050
[pkg] prepare 3.17.18
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Nov 2014 16:22:40 +0100] rev 10049
[source/native] handle newer Integrity error messages from sqlite > 3.7
Similar to a0cf2993b6d3 that was done for 3.18.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Nov 2014 15:43:18 +0100] rev 10048
[source/native/backup_restore] have a unique tunable blocksize for the dump phase
Thus we make memory errors much less likely.
Closes #4618949.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 24 Nov 2014 17:43:29 +0100] rev 10047
[urlpublishing] handle sub-types in RestPathEvaluator
Since commit 31a1813d53f3 "[entity/url publishing] fetch_rqlst should
use 'is_instance_of' instead of 'is'", the RestPathEvaluator's input
rset can have more than one etype, so it can't always use sameetypelist.
Related to #3825488
David Douard <david.douard@logilab.fr> [Mon, 24 Nov 2014 14:43:28 +0100] rev 10046
[views] fix ecsvexport selector
introduced by e48e5a597ccc
Fix the view and make web/test/test_views.py pass again.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 17 Oct 2014 12:14:58 +0200] rev 10045
Add custom checker for Password values
We override the default converter to pass Binary values through, but
don't do anything about the checker. This worked previously because
yams allowed StringIO instances, although its converter didn't do the
right thing for them. Fixing this in yams requires that we properly
register a checker.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 22 Oct 2014 15:59:52 +0200] rev 10044
[component] give Links a __repr__
Julien Cristau <julien.cristau@logilab.fr> [Wed, 12 Nov 2014 14:33:12 +0100] rev 10043
[debian] move markdown dependency from cubicweb-web to cubicweb-common
Pointed out by David Douard.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 04 Nov 2014 16:09:42 +0100] rev 10042
[web/auth] stop playing games with locals()
We only want to know if any retriever found something.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 13 Nov 2014 15:48:33 +0100] rev 10041
[entity] rather than crashing with an IndexError on entity creation, raise a meaningful exception
David Douard <david.douard@logilab.fr> [Wed, 12 Nov 2014 22:18:55 +0100] rev 10040
[web] partial backout of #8391bf718485 to restore RelatedObjectsVComponent
Apparently the intended deprecation did not work, and this component is
used in at least the tracker cube.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Nov 2014 10:38:39 +0100] rev 10039
[server] typo fix
Christophe de Vienne <christophe@unlish.com> [Mon, 06 Oct 2014 10:34:38 +0200] rev 10038
[devtools][pg] Activate the non-durability settings of Postgresql.
It speed up the PG tests by a factor of 3.
See http://www.postgresql.org/docs/current/static/non-durability.html.
David Douard <david.douard@logilab.fr> [Mon, 17 Nov 2014 09:32:37 +0100] rev 10037
[server] fix LoginPasswordAuthentifier.authenticate
some kind of typo there.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 07 Nov 2014 10:33:40 +0100] rev 10036
[web] Override jQueryUI's colors on links (closes #4564046)
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 29 Oct 2014 16:39:36 +0100] rev 10035
[hooks] Fix precommit event logging message
Julien Cristau <julien.cristau@logilab.fr> [Thu, 23 Oct 2014 13:51:13 +0200] rev 10034
[service] allow repo_stats for users
It's used by the siteinfo view, which is available to managers and
users. This change prevents a crash in that view.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 11 Sep 2014 15:17:08 +0200] rev 10033
[views] Escape class attribute value in CWGroup incontext view
Julien Cristau <julien.cristau@logilab.fr> [Thu, 25 Sep 2014 10:50:23 +0200] rev 10032
[devtools] use a specific test_db_id when disabling anon
The anonymous user is created (or not) in postcreate, which for tests
means when creating the cached empty database. The
anonymous_allowed=False test classes should thus not share their
template db with other test classes, otherwise either they end up with
an unexpected anonymous user, or the others miss theirs and things fall
apart.
Christophe de Vienne <christophe@unlish.com> [Wed, 19 Nov 2014 11:59:08 +0100] rev 10031
Restrict yams version
CW 3.19 is not compatible with yams >= 0.40
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 20 Oct 2014 12:50:04 +0200] rev 10030
[facets] Honor 'start_unfolded' facet attribute (closes #4502799)
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 20 Oct 2014 12:23:13 +0200] rev 10029
[facets] Correctly look for inputs of type "hidden" (closes #4502768)
jQuery ':hidden' selector looks at CSS visual properties (eg, 'display',
'visibility'). The intent here was probably to look for inputs of type
"hidden", which many facets use to store user selection data (eg,
FacetRangeWidget).
The problem is that regular text inputs (eg the "has_text" facet which
has a '<input type="text"/>') will be picked up by this selector if they
are inside a folded facet. Chaos and destruction ensue.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 15 Oct 2014 18:23:54 +0200] rev 10028
[web] Cache results from 'i18n' ajax controller (closes #4487856)
This is a simple transient cache which will be forgotten as soon as the
user leaves the current page.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 15 Oct 2014 17:29:29 +0200] rev 10027
[web] There is no global noop(), use jQuery's instead (closes #4487832)
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 10 Oct 2014 09:18:28 +0200] rev 10026
[server] Add missing import of logilab.database
Closes #4469407.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Nov 2014 10:37:44 +0100] rev 10025
[migration] hackish black magic to bootstrap addition of formula attr during migration
Turns out we can't add an attribute to CWAttribute before the attribute
exists. add_attribute generates rql with a 'formula' relation, which CW
doesn't know about yet, so things get unhappy. Once that is fixed, we
need to make the CWAttribute addition operation deal with CWAttribute
entities that don't have a formula yet.
Finally, move the migration to bootstrapmigration_repository so it
happens early on, and use add_entity_type rather than add_relation_type
for CWComputedRType.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 04 Nov 2014 14:10:02 +0100] rev 10024
[server] commit after serializing schema
Use separate transactions for schema serialization and postcreate
scripts execution, so that the latter can rely on the schema being
persistently stored. This matters e.g. if something in a postcreate
violates a unique_together constraint, we need the constraint persisted
in order to raise a meaningful error. See #4525069.
David Douard <david.douard@logilab.fr> [Thu, 28 Aug 2014 18:54:21 +0200] rev 10023
[book] fix docstrings to please sphinx
example rst roles in docstring must be protected (in a literal).
David Douard <david.douard@logilab.fr> [Thu, 28 Aug 2014 18:52:41 +0200] rev 10022
[book] several fixes in the rst files
- prevent duplicate markup definitions,
- use existing Workflow markup instead of redefining one (in baseschema.rst)
- include dataimport
- fix non-existant directive autodocfunction
- remove the empty 'embedding.rst' file
David Douard <david.douard@logilab.fr> [Thu, 28 Aug 2014 18:46:41 +0200] rev 10021
[book] activate the viewcode extension
Automagically make link to class/modules/etc. it finds in the documents.
David Douard <david.douard@logilab.fr> [Thu, 28 Aug 2014 16:22:05 +0200] rev 10020
[book] new theme based on pyramid theme (closes #4291287)
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 30 Jul 2014 14:06:38 +0200] rev 10019
Remove unused lgc.interface imports and leftovers
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 17 Jul 2014 14:40:28 +0200] rev 10018
[repository] provide a .new_session entry point
The current .connect only returns a `sessionid` which must be given to
repo._get_session(...) to get the real session object.
Related to #4151635.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 30 Jun 2014 10:49:53 +0200] rev 10017
[devtools/testlib] Use actual 'admin' user configuration values
Previously ``db-user`` and ``db-password`` configuration values were used to
fill ``admlogin`` and `admpassword`` attributes of CubicWebTC. The correct
data for these should read from `[admin]` section.
Closes #4065070.
Anthony Truchet <anthony.truchet@logilab.fr> [Thu, 25 Apr 2013 10:16:25 +0200] rev 10016
[forms] closes #2437859 - Detect and prevent concurrent edition of the same entity.
Add the timestamp of form generation to each entity's meta-information fields.
On form validation, check that no concurrent change is overwritten and raises
a ValidationError in case of concurrent change.
A nicer handling with a message and a link to the new version of the entity
would be a good thing...
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 16:58:58 +0200] rev 10015
[migration] make sure the repo knows about all constraint types
Adding new constraint types is cumbersome. It's easy to forget to do it
in a migration script. So sync the constraint types at the beginning of
each migration.
Closes #3724892
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Jul 2014 16:07:57 +0200] rev 10014
[migration] stop caching the mapping from constraint type name to eid
It's not so frequent that a cache seems necessary, and we were not
invalidating that cache when adding a new constraint type.
Related to #3724892.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Jun 2014 17:53:31 +0200] rev 10013
[web/json] an empty rset is just fine for ejsonexport
The ejsonexport view can just return an empty list for an empty rset.
Closes #4005518
Christophe de Vienne <christophe@unlish.com> [Wed, 30 Apr 2014 21:04:14 +0200] rev 10012
[RichString] Add markdown support
Supporting markdown requires the 'Markdown' python packages, and since it
widely available on the target platforms adding it as a strong requirements
will not be a big constraint.
Closes #3814302
Paul Tonelli <paul.tonelli@logilab.fr> [Thu, 23 Oct 2014 14:57:02 +0200] rev 10011
[ldapfeed] Reduce default value for user-attrs-map option (closes #3824889)
This is needed because lgc.configuration.Configuration does not allow
removing key/value pairs from the default (due to its use of
dict.update() internally).
Since CWUser.login is required, users of the add-source command will
always be able to override it.
Paul Tonelli <paul.tonelli@logilab.fr> [Tue, 29 Apr 2014 11:34:42 +0200] rev 10010
[serverctl] Ask for URL when adding a new source (closes #3824868)
Paul Tonelli <paul.tonelli@logilab.fr> [Mon, 28 Apr 2014 17:34:07 +0200] rev 10009
[serverctl] Ask for parser type when adding a new source (closes #3484231)
Remove 'quick_start' option to load all AppObjects, including feed parsers.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 10:57:28 +0200] rev 10008
[doc/3.20] more details on removed code
related to #3799117
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 02 May 2014 17:58:57 +0200] rev 10007
remove 3.11 bw compat
Closes #3799117.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 02 May 2014 17:57:37 +0200] rev 10006
remove most 3.10 bw compat
Related to #3799117.
The boxes and entityvcomponent objects cannot really be removed as they
are still used throughout the code base (and possible cubes).
This may be caused by a non-working deprecation and needs some more
work.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 02 May 2014 17:41:11 +0200] rev 10005
remove leftover pre 3.9 deprecation warnings
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 22 Jul 2014 15:42:47 +0200] rev 10004
[utils] Remove function-in-the-middle call
Julien Cristau <julien.cristau@logilab.fr> [Tue, 29 Jul 2014 15:45:04 +0200] rev 10003
[web] set Vary response header to "Accept-Language" when using content negotiation
This is slightly annoying because the response actually only varies
based on the language we decide to send, which has much fewer possible
values than Accept-Language, but that's not in the request, so we can't
easily use it. Deployments using varnish or similar and controlling the
set of available languages will likely want to override this to allow
reasonable amounts of caching.
Closes #2105812
Julien Cristau <julien.cristau@logilab.fr> [Tue, 29 Jul 2014 16:27:11 +0200] rev 10002
[web/cors] don't overwrite other Vary headers
Vary is a list of request headers, we shouldn't override others.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 15 Jul 2014 16:07:59 +0200] rev 10001
[web] add support for HttpOnly cookie flag
And use it for session cookies. Closes #4142521.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 17 Oct 2014 18:16:58 +0200] rev 10000
merge 3.19.5 into 3.20 branch
Julien Cristau <julien.cristau@logilab.fr> [Tue, 07 Oct 2014 10:06:24 +0200] rev 9999
Added tag cubicweb-version-3.19.5, cubicweb-debian-version-3.19.5-1, cubicweb-centos-version-3.19.5-1 for changeset 3ac86df519af
Julien Cristau <julien.cristau@logilab.fr> [Mon, 06 Oct 2014 17:50:42 +0200] rev 9998
i18n update
4 strings have disappeared.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 06 Oct 2014 17:32:49 +0200] rev 9997
[pkg] 3.19.5
Julien Cristau <julien.cristau@logilab.fr> [Mon, 15 Sep 2014 10:06:07 +0200] rev 9996
[server] hold connection to the db in tx_actions
We can be called without a cnxset (e.g. from repoapi).
Christophe de Vienne <christophe@unlish.com> [Mon, 15 Sep 2014 17:23:22 +0200] rev 9995
[wsgi] If multipart cannot parse the POST content, let it pass.
multipart can only parse html form data. It the content_type is, for example,
"application/json", get_posted_data should not fail but just stop trying to
read the content.
Closes #4421845
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 01 Sep 2014 14:56:00 +0200] rev 9994
[devtools] Fix JS tests' HTML code
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 01 Sep 2014 10:22:46 +0200] rev 9993
[devtools] "Keep" some temporary files/dirs around to help with debugging
The whole QUnitTestCase runs with an @with_tempdir so it's redundant
anyway.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 01 Aug 2014 19:28:44 +0200] rev 9992
[devtools] Fix Firefox launcher in QUnitTestCase (closes #4294727)
The main changes are:
- stop creating the profile, firefox will create it
- point firefox to a profile directory instead of giving it a profile name
(this has the added bonus of not polluting the user's profile list)
- start firefox once and kill it 5 seconds later to let it finish its profile
creation (along with system-wide extensions setup)
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 25 Sep 2014 17:38:51 +0200] rev 9991
[devtools] allow cross-origin requests for qunit
We have a mix of file:// html and http:// ajax calls. Which we should
at some point fix to all be http, but. Related to #4294727.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 25 Sep 2014 15:49:13 +0200] rev 9990
merge 3.19.4 in 3.20 branch
Christophe de Vienne <christophe@unlish.com> [Mon, 15 Sep 2014 17:24:18 +0200] rev 9989
[cors] Fix CORS headers generators
The Access-Control-Allow-* and Access-Control-Expose-Headers are response
headers, not request headers.
Hence, we need generators for them. Closes #4412575.
Christophe de Vienne <christophe@unlish.com> [Tue, 09 Sep 2014 22:14:20 +0200] rev 9988
[wsgi] Fix posted files filename reading
The filenames are parsed by multipart.parse_form_data, which does the unicode
decoding. Trying to re-decode the filename was leading to an error.
Christophe de Vienne <christophe@unlish.com> [Tue, 23 Sep 2014 11:18:56 +0200] rev 9987
[pkg] Depend on Pillow instead of PIL
The Pillow library is becoming the de-facto replacement for PIL.
It also is way simpler to install with pip than PIL.
Closes #4411354.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 25 Sep 2014 14:42:00 +0200] rev 9986
Added tag cubicweb-version-3.19.4, cubicweb-debian-version-3.19.4-1, cubicweb-centos-version-3.19.4-1 for changeset c4e740e50fc7
Julien Cristau <julien.cristau@logilab.fr> [Thu, 25 Sep 2014 14:24:20 +0200] rev 9985
[pkg] 3.19.4
Julien Cristau <julien.cristau@logilab.fr> [Wed, 24 Sep 2014 18:04:30 +0200] rev 9984
merge 3.18.6 into 3.19
Julien Cristau <julien.cristau@logilab.fr> [Wed, 24 Sep 2014 17:35:59 +0200] rev 9983
Added tag cubicweb-version-3.18.6, cubicweb-debian-version-3.18.6-1, cubicweb-centos-version-3.18.6-1 for changeset d91501356742
Julien Cristau <julien.cristau@logilab.fr> [Wed, 24 Sep 2014 15:08:44 +0200] rev 9982
[pkg] 3.18.6
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 28 Jan 2014 15:27:59 +0100] rev 9981
[hooks/security] allow edition of attributes with permissive permissions
If an attribute has more permissive security rules than the entity
type itself, we should be green and not deny action because of an
early global entity permission check (with the more restrictive
rules).
Only if one attribute with the entity-level permission rules is edited
will the global check be performed.
Note:
* the "if action == 'delete'" check at the entry of
check_entity_attributes is a guard for a condition currently not
happening in cubicweb itself (but application hooks could
conceivably call this function with a 'delete' action)
Closes #3489895.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 29 Jul 2014 14:40:29 +0200] rev 9980
Almost backout afcd46716d6a which breaks _select_best raising an ambiguity exception in debug mode.
The problem is, before afcd4, *tests* ran in debug mode and we want
this (e.g. we want to show, rather than swallow, select ambigüities).
We juste replace the bogus __init__(vreg.config) by __init__(True), which is
practically equivalent and also much more clear.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 12 Sep 2014 09:49:01 +0200] rev 9979
[server] fix anonymous_user predicate in tests
devtools' TestServerConfiguration overrides the anonymous_user method,
but not the anonymous-user config option, so testing for the latter
would give the wrong result. Closes #3996664.
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 28 Jul 2014 16:05:19 +0200] rev 9978
[entities] cw_rest_attr_info() should only consider required attributes (closes #3766717)
This prevents CW from choosing unique but non-required attributes. None/NULL is
a poor choice for RESTful URIs.
Damien Garaud <damien.garaud@logilab.fr> [Fri, 08 Aug 2014 13:05:07 +0200] rev 9977
[views] csvexport accept an empty rset (closes #4236928)
When you tried to apply the 'csvexport' view on an empty rset, the view
couldn't be selected and you got a HTTP 500 error.
Also add two new test cases.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 11 Sep 2014 16:43:20 +0200] rev 9976
[views] Display attributes in entity creation form based on "add" permission
Previously, the "update" permission was used. Hence in case the latter is
more restrictive that the "add" permission, an user may not be able to set
such an attribute, despite she may have "add" permission on it.
As a result of the change of permissions action in `editable_attributes`
method (add/update depending on whether the entity is being created or
modified), the "eid" attribute would have shown up in the edition form. To
avoid this, it is moved in the "hidden" section (where it should arguably
belong anyways).
Closes #4342844.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 18 Sep 2014 11:03:39 +0200] rev 9975
[datafeed] Commit after all deletions in datafeed parser
This avoids misleading validation error because schema constraints could be
temporarily broken depending on the deletion order.
Closes #4372127.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 23 Sep 2014 17:34:36 +0200] rev 9974
[schema] CWComputedRType is a schema type
Hide it from the default views.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 23 Sep 2014 14:19:11 +0200] rev 9973
[doc] proofreading CWEP002 section
Anthony Truchet <anthony.truchet@logilab.fr> [Mon, 10 Feb 2014 11:03:43 +0100] rev 9972
[CWEP002] document computed relations and attributes
Related to #3546717.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 28 Aug 2014 17:41:34 +0200] rev 9971
[CWEP002 migration] support sync_schema_props_perms for computed attribute
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Jul 2014 11:00:21 +0200] rev 9970
[CWEP002 migration] support drop_relation_type/drop_relation_definition/drop_attribute for computed attributes
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 28 Aug 2014 18:31:18 +0200] rev 9969
[CWEP002 migration] support add_relation_type/add_attribute for computed attributes
Related to #3546717.
Lea Capgen <lea.capgen@logilab.fr> [Tue, 16 Sep 2014 15:28:35 +0200] rev 9968
[CWEP002] properly handle serialization of computed attributes
Until this cset, only serialization of computed attribute's formula was
handled (thanks to the relation definition's properties dict).
We now:
* properly serialize/deserialize attribute's formula
* test first if the database has been migrated and contains related
column or not
Related to #3546717
Sylvain Thénault [Tue, 16 Sep 2014 16:39:23 +0200] rev 9967
[CWEP002] Add support for computed attribute synchronization
Related to #3546717.
Test and handle the behaviour with several formulas and identified use cases. To
do so add a birth year and a computed attribute age to Person in the test
schema.
Laura Médioni <laura.medioni@logilab.fr> [Mon, 28 Apr 2014 14:11:23 +0200] rev 9966
[CWEP002] Add schema finalization checks for computed attributes
``finalize_computed_attributes`` essentially checks that computed attributes
types match with the type declaration of the attribute.
Related to #3546717.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 16 Jun 2014 10:08:32 +0200] rev 9965
[CWEP002] Account for attribute formula in schema bootstrap
This isn't enough to have computed attribute support, it is only in order not to
crash when yams 0.40 is used.
Related to #3546717.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 28 Aug 2014 07:44:29 +0200] rev 9964
[CWEP002 migration] support sync_schema_props_perms for computed relations
Laura Médioni <laura.medioni@logilab.fr> [Thu, 28 Aug 2014 08:02:15 +0200] rev 9963
[CWEP002 migration] support add_relation_type for computed relations
Related to #3546717.
Laura Médioni <laura.medioni@logilab.fr> [Thu, 28 Aug 2014 07:55:33 +0200] rev 9962
[CWEP002 migration] support drop_relation_type for computed relations
Related to #3546717.
Laura Médioni <laura.medioni@logilab.fr> [Thu, 28 Aug 2014 07:49:31 +0200] rev 9961
[CWEP002 migration] properly raise exception on (add|drop)_relation_definition for computed relation
Related to #3546717
Laura Médioni <laura.medioni@logilab.fr> [Fri, 27 Jun 2014 12:00:17 +0200] rev 9960
[hooks] do not abuse of inheritance for CWRType hooks
Just copy the selector to ease readability.
Laura Médioni <laura.medioni@logilab.fr> [Mon, 16 Jun 2014 10:08:18 +0200] rev 9959
[schema serial] add some comments
Laura Médioni <laura.medioni@logilab.fr> [Mon, 16 Jun 2014 10:07:57 +0200] rev 9958
[schema] define full_rql on RQLExpression class
without it, we may have an error while displaying error which occured during
some expression initialization because this attribute is not yet defined while
used in the __str__ method.
Laura Médioni <laura.medioni@logilab.fr> [Fri, 29 Aug 2014 07:44:13 +0200] rev 9957
[schema] properly raise BadSchemaDefinition
when some expression mains variables may not be guessed
Lea Capgen <lea.capgen@logilab.fr> [Thu, 28 Aug 2014 18:29:14 +0200] rev 9956
[CWEP002] properly handle serialization of computed relations
We now:
* have CWComputedRelation in the bootstrap schema to store computed relations
* properly serialize/deserialize it
* test first if the database has been migrated and contains the related table
Related to #3546717
[jcr: adjust unittest_querier to pass with the added entity type]
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 27 Jun 2014 16:11:53 +0200] rev 9955
[CWEP002] Plug the computed relation rewriter in the querier
Related to #3546717.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 13 Feb 2014 13:58:28 +0100] rev 9954
[CWEP002] refactor rql read security checking
Split 'check_read_perms' into 'check_relations_perms' which checks relations
'read' permissions and 'get_local_checks' which build dictionary of local
security checks (rql expression) for variables.
This allows to check relations 'read' permissions earlier in the process and so
to prepare insertion of the rql rewriter: we want to check permissions of the
computed relation, not permissions of relations introduced by the associated
rule, to conform to the CWEP.
Related to #3546717
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 16 Jun 2014 10:22:24 +0200] rev 9953
[CWEP002] introduce RQLRelationRewriter
Refactor existing RQLRewriter for later reuse of rewriting relation as specified
by CWEP002. Work is different because we simply want to replace a relation by
another rql snippet and we don't have to bother with EXISTS, subqueries and all.
This rewriter is not yet plugged into the querier.
Depends on yams 0.40 API.
Related to #3546717
Lea Capgen <lea.capgen@logilab.fr>, Sylvain Thénault <sylvain.thenault@logilab.fr>, Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 12 Sep 2014 14:46:11 +0200] rev 9952
[CWEP002] Add schema finalization checks for computed relations (rules)
Related to #3546717
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 12 Sep 2014 14:10:03 +0200] rev 9951
[schema] add utility function to build a CubicWebSchema from a namespace
Will be useful for testing computed attributes and relations.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 28 Aug 2014 18:12:28 +0200] rev 9950
Fix test migration crash waiting to happen due to inferred relations
Avoid crashing when a relation definition which is already known (due to
being inferred) gets explicitly added. As explained in a comment, this
would deserve more thinking, but at least this fixes a test failure with
computed relations.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 28 Aug 2014 07:42:10 +0200] rev 9949
fix typo in syncschema hooks
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Sep 2014 18:01:51 +0200] rev 9948
[test] Make test_undo_api less random
The order in which hooks are run is not predictable if they have the
same 'order' attribute, which is the case for SetOwnershipHook and
SetInitialStateHook. So don't assume in_state will be set before
created_by.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Sep 2014 13:43:31 +0200] rev 9947
merge 3.17.17 into 3.18 branch
Christophe de Vienne <christophe@unlish.com> [Wed, 10 Sep 2014 21:28:33 +0200] rev 9946
[wsgi] Fix unicode decoding in POST
The application/x-www-form-urlencoded sent by firefox or chrome is utf-8
encoded BEFORE being urlencoded.
Hence, decoding must urldecode THEN decode the utf-8 string, and not the
other way around.
Christophe de Vienne <christophe@unlish.com> [Thu, 21 Aug 2014 22:42:48 +0200] rev 9945
[wsgi] add the --debug / -D option to the wsgi command
Christophe de Vienne <christophe@unlish.com> [Mon, 08 Sep 2014 10:55:30 +0200] rev 9944
[wsgi] Fix multiple variables reading in params
Closes #4306081
Christophe de Vienne <christophe@unlish.com> [Tue, 02 Sep 2014 13:00:47 +0200] rev 9943
[wsgi] Set self.vreg
Closes #4306049
Christophe de Vienne <christophe@unlish.com> [Tue, 02 Sep 2014 10:31:13 +0200] rev 9942
[wsgi] Add missing import
Closes #4305988
Christophe de Vienne <christophe@unlish.com> [Tue, 02 Sep 2014 10:30:28 +0200] rev 9941
[wsgi] Fix https detection
- 'HTTPS' is not part of wsgi, it is a CGI variable. The right wsgi variable
is 'wsgi.url_scheme'
- Force https if url starts with '/https/' (and remove the prefix from the
path.
Closes #4305985
Christophe de Vienne <christophe@unlish.com> [Thu, 24 Jul 2014 20:57:14 +0200] rev 9940
[wsgi] Re-set the request content after calling the inherited constructor.
Closes #4191813
Christophe de Vienne <christophe@unlish.com> [Thu, 24 Jul 2014 20:53:21 +0200] rev 9939
[wsgi] Honor the 'CONTENT_TYPE' wsgi variable
See http://legacy.python.org/dev/peps/pep-0333/#environ-variables
Closes #4191812
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 17 Sep 2014 10:31:50 +0200] rev 9938
Added tag cubicweb-version-3.17.17, cubicweb-debian-version-3.17.17-1, cubicweb-centos-version-3.17.17-1 for changeset 57e9d1c70512
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 16 Sep 2014 18:39:07 +0200] rev 9937
[pkg] prepare 3.17.17
Julien Cristau <julien.cristau@logilab.fr> [Tue, 29 Jul 2014 16:26:09 +0200] rev 9936
[web/headers] don't list a request header twice in "Vary"
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Jul 2014 17:22:49 +0200] rev 9935
[test] silence a few more deprecation warnings in unittest_hooks
self.session → cnx.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 25 Jul 2014 16:24:44 +0200] rev 9934
[session] call rollback in Connection.__exit__
If we just free the cnxset and clear the Connection, we're missing the
pending operation's rollback_event callbacks, which may be needed for
cleanup.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Jul 2014 14:52:16 +0200] rev 9933
[devtools] pre_setup_database takes a Connection, not a Session
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 18:00:53 +0200] rev 9932
[source/native] cPickle is available in all supported pythons
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 22 Jul 2014 18:16:23 +0200] rev 9931
devtools: deprecate .req_from_url
Which uses .request()
And instead provide .admin_request_from_url, which
is a context manager yielding the request.
Christophe de Vienne <christophe@unlish.com> [Tue, 17 Jun 2014 11:14:20 +0200] rev 9930
[tests] Add a webtest based TestCase class
Closes #4002134
Christophe de Vienne <christophe@unlish.com> [Tue, 17 Jun 2014 11:53:35 +0200] rev 9929
[tests] Move 'anonymous_allowed' property from CubicWebServerTC to CubicWebTC
The effective set of the property on the config is now done later that before,
ie at the end of CubicWebTC.init_config instead of before.
It is believed not to have an impact on the test suites that uses
`anonymous_allowed`.
Related to #4002134
David Douard <david.douard@logilab.fr> [Tue, 02 Sep 2014 12:22:18 +0200] rev 9928
[compat] Remove imports of "any" and "all" from lgc (closes #4306044)
They're builtin since python 2.5.
Florent Cayré <florent.cayre@logilab.fr> [Tue, 26 Aug 2014 10:12:09 +0200] rev 9927
[css] Remove the `div` tag specification of the pendingDelete css rule
The HTML tag was changed by e2f96b16c3bd from a div to a span without
changing the css rule accordingly.
Closes #4285248.
Alain Leufroy <alain.leufroy@logilab.fr> [Wed, 21 May 2014 16:14:17 +0200] rev 9926
[cwvreg] cleanup the event manager when reloading modules
Closes #3848995
The event manager callbacks are not cleaned during reloading.
So the callback defined in the reloaded module appears twice (old and new
version). This may cause problem when the old version is called.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 12 Jun 2014 12:28:10 +0200] rev 9925
[test] Add missing attribute 'add' permission in test schema
Silences yams warning.
Florent Cayré <florent.cayre@gmail.com> [Thu, 01 May 2014 23:35:56 +0200] rev 9924
[facet html] Add surrounding div with "facetBody" class to "has_text" facet.
This makes its html structure consistent with the other facets
and fixes both css and a javascript behaviour (hide the facet body
when clicking on its title).
Closes #3797501.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 13 Jun 2014 11:00:41 +0200] rev 9923
[cwctl] don't prompt for cube options in automatic mode
Closes #3984223
Julien Cristau <julien.cristau@logilab.fr> [Fri, 13 Jun 2014 11:21:45 +0200] rev 9922
[serverctl] fix default value for db-init config-level
Otherwise cubicweb-ctl db-init --automatic complains that "--automatic
and --config-level should not be used together" when they weren't.
Closes #3984336
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 05 Jun 2014 17:41:14 +0200] rev 9921
[web] Return useful error messages when exceptions arise in ajax controllers (closes #3932503)
The call to super() in RemoteCallException passes 'reason' all the way to
python's Exception.__init__() which is then stored in Exception.args. This way,
CubicWebPublisher.ajax_error_handler() gets a useful error message when calling
unicode(exc).
The change to uilib is just to prepend the exception type name. Just a small
improvement.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Jul 2014 19:42:42 +0200] rev 9920
[test] Fix test breakage uncovered by previous changeset
Now that Binary.__eq__ doesn't always return true, this test started
failing. CWAttribute.defaultval is zpickled, and the description_format
attribute is a String, meaning unicode, so adjust the expected test
result.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Jul 2014 11:33:32 +0200] rev 9919
[etwist] use more specific REQUEST_ENTITY_TOO_LARGE instead of BAD_REQUEST
When a request body exceeds the configured limit, return 413 to the
client instead of a generic 400.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Jul 2014 10:34:50 +0200] rev 9918
[entities, view] delete dead code
The auto_unwrap_bw_compat metaclass calls unwrap_adapter_compat, which
was removed in changeset 697a8181ba30 "remove 3.9 bw compat". So this
can't possibly work anymore, meaning we can get rid of it.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Jul 2014 14:37:08 +0200] rev 9917
[book] stop talking about the hg `forest` extension
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Jul 2014 14:28:26 +0200] rev 9916
[book] update sections about dependencies
This is probably incomplete, but it's a start.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Jul 2014 16:24:17 +0200] rev 9915
[web/component] move unicode() call around
Makes Aurélien happier.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Jul 2014 12:07:50 +0200] rev 9914
[web/js] replace callAddOrDeleteThenReload with more generic callAjaxFuncThenReload
That's going to be a more useful replacement for callUserCallbackThenReload.
Closes #4178566.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Jul 2014 17:45:38 +0200] rev 9913
[hooks/syncsession] try to remove cnx vs session confusion
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Jul 2014 17:22:23 +0200] rev 9912
Fix Binary.__eq__ (closes #4172701)
Due to a typo we always returned true, which was unhelpful.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 16:35:02 +0200] rev 9911
[dataimport] stop ignoring errors on flush
That can only result in database corruption.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 16:31:34 +0200] rev 9910
[dataimport] don't commit on flush
Changeset 26cdfc6dd6f8 introduced this confusion for no apparent reason,
and it doesn't make much sense.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:35:28 +0200] rev 9909
[test] Add test for dataimport's RQLObjectStore
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 16:00:21 +0200] rev 9908
[dataimport] Stop swallowing errors from commit/flush
Silent DB corruption is not OK.
Also drop comment from ObjectStore.commit that I don't understand.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:59:34 +0200] rev 9907
[dataimport] Update RQLObjectStore to Connection API
Take a connection instead of a session. Don't play games with set_cnxset.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:51:58 +0200] rev 9906
[dataimport] remove _rql heresy
1) ObjectStore knows nothing about rql, it just drops it on the floor
2) RQLObjectStore has a session, it can run rql that way
3) setting an object's "_rql" attribute is not a reasonable user-facing
interface
Also drop _commit attribute from base ObjectStore, it doesn't use it.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:40:50 +0200] rev 9905
[dataimport] remove dead code
The only caller of ObjectStore._put is ObjectStore.create_entity, which
RQLObjectStore overrides (and doesn't call up).
Alain Leufroy <alain.leufroy@logilab.fr> [Tue, 03 Jun 2014 12:41:06 +0200] rev 9904
[dataimport] do not use sys.exit() to raise missing argument error
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 17:51:45 +0200] rev 9903
[dataimport] _create_copyfrom_buffer: add the tests
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 15:53:09 +0200] rev 9902
[dataimport] _create_copyfrom_buffer: do not ignore columns if data is a list
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 17:52:43 +0200] rev 9901
[dataimport] _create_copyfrom_buffer: fix datetime converter + add time converter
Include second and microsecond in the output instead of dropping them on the
floor. The time zone is not supported for now, though.
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 15:45:35 +0200] rev 9900
[dataimport] _create_copyfrom_buffer: raise ValueError if conversion cannot be performed
If the conversion fails, there is no reason to continue execution. One should
notify the error.
Continuing after a misconverted data could corrupt the database.
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 13:50:15 +0200] rev 9899
[dataimport] _create_copyfrom_buffer: fix separator check in string converter
The empty string is a valid replace_sep.
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 13:50:15 +0200] rev 9898
[dataimport] _create_copyfrom_buffer: put converters into a list
Cleans up the code to avoid a succession of ifs.
Related to #3845572
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 17:35:25 +0200] rev 9897
merge 3.19.3 into 3.20 branch
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:44:44 +0200] rev 9896
Added tag cubicweb-version-3.19.3, cubicweb-debian-version-3.19.3-1, cubicweb-centos-version-3.19.3-1 for changeset 37f7c60f89f1
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:16:53 +0200] rev 9895
[pkg] prepare 3.19.3
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:14:58 +0200] rev 9894
merge from 3.18 branch
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:11:41 +0200] rev 9893
merge 3.17.16 into 3.18 branch
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 17 Jul 2014 11:08:56 +0200] rev 9892
Remove uses of logilab.common.compat.{all,any}
They're just aliases to the builtin ones on python 2.5+. If anyone needs
convincing:
>>> from logilab.common import compat
>>> compat.any
<built-in function any>
>>> compat.all
<built-in function all>
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 09 Jul 2014 15:44:09 +0200] rev 9891
remove references to global environment variable APYCOT_ROOT
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 11:37:57 +0200] rev 9890
Add warning messages when enabling remote pickle-based repository access
Warn when starting a pyro or zmq-only repo, or when one of these access
methods is enabled. Closes #2919295
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 12:23:01 +0200] rev 9889
[web] Fix expiry of anonymous sessions (closes #4154479)
Things like:
try:
foo
except:
bar
else:
baz
doesn't work very well if you expect baz to run even in the exception
case. Plus, session.cnx.check() is a dbapi remnant, so drop it and just
look at session.mtime.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 16 Jul 2014 17:20:55 +0200] rev 9888
[hooks/syncschema] avoid altering a dropped table
If the constraint's rdef is being removed, CWConstraintDelOp doesn't
need to do anything. Otherwise it may try to alter a removed
table/column. Closes #4154549
Florent Cayré <florent.cayre@logilab.fr> [Thu, 12 Jun 2014 09:59:55 +0200] rev 9887
[js] fix name error
Alain Leufroy <alain.leufroy@logilab.fr> [Tue, 03 Jun 2014 12:37:54 +0200] rev 9886
[devtools] improve error message when postgresql tools are missing
By default in at least Debian, some pg tools are not present in the
PATH. Or they may not be installed. But the tests tools expects them
to be in the PATH, and give an unhelpful 'No such file or directory'
backtrace if they're not found. To help devs using the pg tests we
improve the error message.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 11 Jul 2014 17:13:32 +0200] rev 9885
[server] Replace non portable strftime formatter (closes #4132161)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 12:15:18 +0200] rev 9884
[web/request] use a picklable Counter object for tab index counters
Related to #1381328.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 15 Jul 2014 18:07:31 +0200] rev 9883
[web/auth] The auth retriever's authenticated() callback takes a session, not a cnx
We don't have a cnx at that point.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 11 Jul 2014 16:44:42 +0200] rev 9882
[test] Fix the query-log-file test
Testing this functionality in a CubicWebTC is awkward because the
wrapping happens in handle_request, which tests basically bypass (they
call core_handle directly, and do their own magic for linking the
request with a cnx). The test method worked when ran on its own, but
not together with the rest of the test class. So use a CubicWebServerTC
instead, which goes through the whole stack.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 11 Jul 2014 13:48:07 +0200] rev 9881
[doc/book] spelling fixes in security tutorial
Julien Cristau <julien.cristau@logilab.fr> [Fri, 11 Jul 2014 13:15:11 +0200] rev 9880
[doc/book] spelling fixes in "testing" chapter
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 16:54:31 +0200] rev 9879
[datafeed sources] finish the session -> cnx switch
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 06 Jun 2014 15:56:24 +0200] rev 9878
[doc/book] update examples, using the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 17:20:18 +0200] rev 9877
[test/entities] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 12:52:50 +0200] rev 9876
[web] restore query logging functionality (closes #3972561)
The query-log-file option stopped working when the web stack was moved
from dbapi to repoapi.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Jun 2014 12:03:30 +0200] rev 9875
[cwctl] make cubicweb-ctl versions lighter (closes #4002158)
Set config.quick_start to avoid unnecessary appobjects and schema
loading.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 08 Jul 2014 14:02:43 +0200] rev 9874
Added tag cubicweb-version-3.17.16, cubicweb-debian-version-3.17.16-1, cubicweb-centos-version-3.17.16-1 for changeset a979d1594af6
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Sep 2013 14:55:56 +0200] rev 9873
[forms] consider inline creation form information as linkto info. Closes #3161121
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 07 Jul 2014 19:28:30 +0200] rev 9872
[pkg] prepare 3.17.16
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:37:52 +0200] rev 9871
[reledit] Fix reledit icons jumpiness (closes #4106867)
Introduce an "invisible" class (copied verbatim from Bootstrap) that
only sets the "visibility" property. "display: none" is the reason for
the whole jumpiness as it actually detaches the element from the
rendered layout. "visibility: hidden" only makes it transparent while
keeping its original box properties (width, height, etc).
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:29:37 +0200] rev 9870
[views] Replace poorly named "invisible" class with "list-unstyled"
"li.invisible" actually means "hide bullet". Use a reasonable name
instead, such as bootstrap's "list-unstyled" class.
This patch also changes the DOM element the class is applied to.
"li.invisible" had to be enabled on every "li" tag, whereas the
"list-unstyled" class only needs to be applied to the parent "ul"
element.
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:23:18 +0200] rev 9869
[views] a 'div' with 'display: inline' screams 'span'
(grafted from af6e3db801fcfbd6f562c4a7cfdc89f187042792)
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Jul 2014 14:30:16 +0200] rev 9868
[pkg] remove simplejson dependency
We no longer use it, the stdlib's json module is fine.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Jul 2014 12:18:34 +0200] rev 9867
Added tag cubicweb-version-3.19.2, cubicweb-debian-version-3.19.2-1, cubicweb-centos-version-3.19.2-1 for changeset 8ac2202866e7
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Jul 2014 10:22:36 +0200] rev 9866
[pkg] Fix version number
Note to self: don't phase -p before coffee.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Jul 2014 10:01:58 +0200] rev 9865
[pkg] 3.19.2
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 06 Jun 2014 14:55:26 +0200] rev 9864
[webtests] finish to give all self.view(....) a req=req parameter
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 16:30:58 +0200] rev 9863
[tests/syncsession] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Jul 2014 12:44:04 +0200] rev 9862
[webtests/application] remove unused imports
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 11:56:33 +0200] rev 9861
[webtests/application] .user(...) really wants a request object
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 15:46:16 +0200] rev 9860
[tests/datafeed] use the new connection api (a small leftover)
Test assertions get indented because of self.session -> scoped cnx.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 18:19:47 +0200] rev 9859
[entitiestests/base] don't store an entity on the test case
Make do with an eid.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 17:06:03 +0200] rev 9858
[entitiestests/base] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 15:21:18 +0200] rev 9857
[testlib] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 11:56:19 +0200] rev 9856
[exttests/rest] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:04:40 +0200] rev 9855
[webtests/bookmarks] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:19:56 +0200] rev 9854
[hookstests/integrity] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 18:01:16 +0200] rev 9853
[hookstests/base] use connections instead of web requests
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:55:07 +0200] rev 9852
[hookstests/base] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:54:53 +0200] rev 9851
[hookstests/syncschema] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 13:28:24 +0200] rev 9850
[tests/rqlannotation,querier] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 17:31:54 +0200] rev 9849
[webtests/web] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 14:55:02 +0200] rev 9848
[webtests/navigation] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 14:45:32 +0200] rev 9847
[webtests/basetemplates] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 15:14:13 +0200] rev 9846
[webtests/basecontrollers] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 14:43:07 +0200] rev 9845
[testlib] deprecate .remote_call and provide new connection api friendly .remote_calling
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 12:35:25 +0200] rev 9844
[webtests/propertysheet] kill an "import *"
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 12:27:26 +0200] rev 9843
[webtests/breadcrumbs] break long lines
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 17:20:00 +0200] rev 9842
[webtests/views_editforms] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Jul 2014 17:44:06 +0200] rev 9841
[webtests/urlrewrite] do not store a plain entity on the test, only an eid
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 11:17:09 +0200] rev 9840
[webtests/urlrewrite] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 17:16:38 +0200] rev 9839
[webtests/urlpublisher] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 11:00:50 +0200] rev 9838
[webtests/baseviews] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 15:11:00 +0200] rev 9837
[devtools/testlib,fill] use the new connection api (for auto_populate)
Note that this changes API of CubicWebTC's custom_populate and
post_populate methods to take a connection instead of a cursor, which
may affect some cubes.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 14:42:24 +0200] rev 9836
[webtests/automatic views tests] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 12:41:21 +0200] rev 9835
[devtools/repotest] simplify a very small helper
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 11:34:19 +0200] rev 9834
[tests/repotest] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:10:16 +0200] rev 9833
[tests/querier] use the new connection api (part 3/3)
Some adaptations to devtools/repotest:
* dead code removal
* remove session related code
In the tests:
* many tests actually don't check the querier but some generic rql
property -- when such a test needs several statements to complete a
commit, switch to session.new_cnx
* provide an assertRQLEqual helper
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 14:25:20 +0200] rev 9832
[test/querier] use the new connection api (part 2/3)
A couple of tests need a schema constraint to be dropped to pass with
`.qexecute`.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 13:56:24 +0200] rev 9831
[test/querier] use the new connection api (part 1/3)
In devtools/repotest, we provide a simple `.qexecute` with autocommit,
and we use it (where possible) in unittest_querier.
Note that the .session object is a real session, not the magic property
found in CubicWebTC test classes.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Jul 2014 17:25:25 +0200] rev 9830
[dbapi] allow talking to a pre-3.19 remote repository
Closes #4071285
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Jun 2014 11:56:38 +0200] rev 9829
[migration] don't add new elements to config._cubes in remove_cube
We're expanding dependencies based on the current versions of the cubes,
which may well not be the same as the ones known by the db (we're in the
middle of an upgrade, after all). Listing them in config._cubes
prevents us from calling add_cube() later to actually add them.
Closes #4002156
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 02 Jul 2014 11:43:45 +0200] rev 9828
[web test] repair test broken by 0872ac2a1db0
after the above cset, during test instance's url is set before the creation of
core entities (ie created at database initialization), hence they have now a
valid cwuri.
Damien Garaud <damien.garaud@logilab.fr> [Tue, 06 May 2014 18:32:03 +0200] rev 9827
[dataimport] Drop reference to the 'source' column (closes #4067694).
CW 3.19 drops the multi-source support. This column does not exist in 3.19.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 21 May 2014 22:54:46 +0200] rev 9826
[notification] drop on commit sending of message feature of NotificationView
It duplicates feature already provided by
cw.hooks.notification.notify_on_commit function.
Simplify the API on the way.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 21 Mar 2014 08:28:32 +0100] rev 9825
[datafeed parser] enhance retrieve_url to support POSTing data and custom HTTP headers
Closes #3682069
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 25 Mar 2014 09:20:37 +0100] rev 9824
[datafeed parser] fix retrieve_url to always return urllib2.urlopen compatible output
as one should expect to be able to call geturl/getcode/info on the returned
object whatever the url he gave.
Related to #3682069
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 20 Mar 2014 08:55:44 +0100] rev 9823
[datafeed parser] factor out retrieve_url method from DataFeedXMLParser.parse
Related to #3682069
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 20 Mar 2014 08:49:10 +0100] rev 9822
[datafeed] Allow to override use_cwuri_as_url in configuration of a datafeed source
This is necessary because in some case one will want to write parser which
create entities not one-to-one related to entities from the distant source (for
instance see the `vcrs` cube which create entities holding statistics for code
review, while not importing review entities themselves).
Ideally we should provide a way to the parser to indicate the source that cwuri
should not be used, but that's a start...
Closes #3670210
Julien Cristau <julien.cristau@logilab.fr> [Fri, 27 Jun 2014 11:48:26 +0200] rev 9821
merge from 3.19 branch
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:56:05 +0200] rev 9820
[entity/rset] replace scary warnings about ambiguous rdefs by XXX in the code
users can't do anything about that and shouldn't see those warnings.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 18:35:13 +0200] rev 9819
[web/js] Deprecate baseuri() and replace with BASE_URL (closes #3955372)
Added by commit 8bf2337a6f3b and publicly available since 3.11.2
released more than 3 years ago.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 18:17:44 +0200] rev 9818
[request] Ensure base_url() always has a trailing '/' (closes #3955093)
Just as an example, cubicweb.ajax.js is clearly written under the
assumption that BASE_URL/baseuri() - which simply contains req.base_url() - has a
trailing /.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 10:16:13 +0200] rev 9817
[schema] spelling fixes in doc strings
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:23:18 +0200] rev 9816
[views] a 'div' with 'display: inline' screams 'span'
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 17 Feb 2014 11:27:25 +0100] rev 9815
[views] Rewrite cw.utils.formContents() with jQuery (closes #3747244)
Use jQuery's serializeArray() method instead. Just keep a bit of
compatibility with FCKEditor...
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 26 May 2014 12:10:22 +0200] rev 9814
[web/data] Remove broken backward compatibility function
popupLoginBox() was deprecated in favor of cw.htmlhelpers.popupLoginBox()
However, the use of cw.utils.deprecatedFunction() is broken. In firebug:
>>> popupLoginBox()
TypeError: newfunc is undefined cubicweb.js:113 (ligne 13)
This function was modified back in 2010, so it's been broken for 4 years.
Let's just get rid of it. Closes #4042978
Julien Cristau <julien.cristau@logilab.fr> [Thu, 19 Jun 2014 17:39:12 +0200] rev 9813
[repoapi] make ClientConnection call RequestSessionBase's init
Not calling up means we're missing some attributes, like encoding.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 18:31:09 +0200] rev 9812
[webtests/views_staticcontrollers] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 18:04:35 +0200] rev 9811
[webtests/views_selectors] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 17:21:52 +0200] rev 9810
[webtests/views_json] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 17:01:38 +0200] rev 9809
[webtests/views_errorform] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:52:34 +0200] rev 9808
[webtests/views_actions] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:48:37 +0200] rev 9807
[webtests/views_xmlrss] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:18:06 +0200] rev 9806
[webtest/pyviews] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:13:33 +0200] rev 9805
[tests/sqlutils] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 13:09:14 +0200] rev 9804
[tests/postgres] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 12:36:43 +0200] rev 9803
[tests/repository] use the new connection api (part 2/2)
Some notes:
* module imports cleanup
* the unimplemented `test_transaction_interleaved` is wiped
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 12:28:50 +0200] rev 9802
[repository,tests] use the new connection api (part 1/2)
`add_info` should not play with the cnxset nor the mode.
Static analysis showed that:
* add_info is an internal api called with a non-none cnx.cnxset and
also in write mode
* only the altered test violated this assumption, which is now
somewhat documented
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 17 Jun 2014 14:43:28 +0200] rev 9801
[book] fix various parts of the rql section
* syntax error
* erroneous query
* bad sphinx :func: usage
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 11:47:30 +0200] rev 9800
[repository] session -> cnx renaming (already done in the source object)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:57:55 +0200] rev 9799
[tests/session] remove unused import
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:52:15 +0200] rev 9798
[tests/datafeed] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:46:40 +0200] rev 9797
[tests/checkintegrity] use the new connection api
* serverctl: the db-check command also uses an internal connection
object, which makes more sense in the context of `checkintegrity`.
* checkintegrity: rename srvcnx to just cnx (a bit because in the near
future, there will be one cnx to rule them all)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:40:22 +0200] rev 9796
[tests/schemaserial] kill star import
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:38:14 +0200] rev 9795
[tests/schemaserial] break long lines
Julien Cristau <julien.cristau@logilab.fr> [Mon, 16 Jun 2014 17:22:22 +0200] rev 9794
[tests/ldap] don't leak sessions
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:24:44 +0200] rev 9793
[tests/ldap] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 13 Jun 2014 12:56:45 +0200] rev 9792
[test/migration] fix crash on execution
This assertion is there for unclear reasons.
===================== unittest_migration.py =======================
-> creating tables [====================]
-> inserting default user and default groups.
-> storing the schema in the database [====================]
-> database for instance data initialized.
F
======================================================================
FAIL: test_db_creation (unittest_migration.BaseCreationTC)
make sure database can be created
----------------------------------------------------------------------
Traceback (most recent call last)
File "/home/auc/confs/forges/logilab/common/testlib.py", line 661, in _proceed
testfunc(*args, **kwargs)
File "/home/auc/confs/forges/cubicweb/test/unittest_migration.py", line 106, in test_db_creation
handler.build_db_cache()
File "/home/auc/confs/forges/cubicweb/devtools/__init__.py", line 469, in build_db_cache
self.init_test_database()
File "/home/auc/confs/forges/cubicweb/devtools/__init__.py", line 729, in init_test_database
init_repository(self.config, interactive=False)
File "/home/auc/confs/forges/cubicweb/server/__init__.py", line 217, in init_repository
repo = Repository(config, vreg=vreg)
File "/home/auc/confs/forges/cubicweb/server/repository.py", line 197, in __init__
self.init_cnxset_pool()
File "/home/auc/confs/forges/cubicweb/server/repository.py", line 220, in init_cnxset_pool
config.bootstrap_cubes()
File "/home/auc/confs/forges/cubicweb/devtools/__init__.py", line 176, in bootstrap_cubes
super(TestServerConfiguration, self).bootstrap_cubes()
File "/home/auc/confs/forges/cubicweb/server/serverconfig.py", line 279, in bootstrap_cubes
self.init_cubes(self.expand_cubes(splitstrip(line)))
File "/home/auc/confs/forges/cubicweb/cwconfig.py", line 1022, in init_cubes
super(CubicWebConfiguration, self).init_cubes(cubes)
File "/home/auc/confs/forges/cubicweb/cwconfig.py", line 798, in init_cubes
assert self._cubes is None, repr(self._cubes)
AssertionError: ('card', 'file', 'localperms', 'tag')
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 05 Jun 2014 17:53:27 +0200] rev 9791
[web] Remove unreachable and broken code
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 15 Apr 2014 11:55:37 +0200] rev 9790
[testlib] call init_config once the config has been properly bootstraped
This should be done right after repository instantiation and as such involves
giving CWTC.init_config as a callback to the test database handler (which will
itself gives it to the repository initialization function).
This unfortunatly requires to pass the init_config method to the
server.init_repository function because it has to be called after the config has
been initialized (which is done in Repository.__init__) but before the migration
handler is instantiated (which will call 'server_maintainance' hook, hence may
require the proper config). Another way to fix this would be to change the
initialization sequence, but this is another story.
Closes #3749378
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 17:50:50 +0200] rev 9789
[devtools] even better: use a plain Connection (server-side) object for pre_setup
The previous commit switched from passing a Session to a
ClientConnection.
This fixes unittest_ldapsource's pre_setup_database, which relied on a
server-side object to get at the repo.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:25:31 +0200] rev 9788
[devtools] pre_setup_database should take a connection object
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 11:10:54 +0200] rev 9787
[tests/migration] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 28 May 2014 17:33:16 +0200] rev 9786
[tests/undo] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 14:10:02 +0200] rev 9785
[js/ajax] deprecate user-callback support
Related to #3567793.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 07 Mar 2014 14:03:44 +0100] rev 9784
EditRelationMixIn: stop using user_rql_callback
Add generic add_relation/delete_relation ajax functions and use those.
Related to #3567793
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 28 May 2014 17:57:40 +0200] rev 9783
[tests/storage] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 15:10:04 +0200] rev 9782
[tests/security] use the new connection api
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 10:52:45 +0200] rev 9781
[htmlwidgets] Remove unreachable code
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 24 Apr 2014 12:28:46 +0200] rev 9780
Remove redundant __nonzero__ methods
From https://docs.python.org/2/reference/datamodel.html#specialnames :
When this method is not defined, __len__() is called, if it is
defined, and the object is considered true if its result is nonzero.
Also helpful for an eventual migration to py3k, as __nonzero__ has been
replaced with __bool__, which also defaults to looking at __len__ if
undefined.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 18:12:47 +0200] rev 9779
[etwist] Remove unused host_prefixed_baseurl()
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 12:26:52 +0200] rev 9778
[basetemplate] Remove misleading comment
The <base> tag was removed in commit 8bf2337a6f3b back in 2011.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 28 May 2014 14:48:09 +0200] rev 9777
[tests/security] break lines > 100 chars
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 14:54:18 +0200] rev 9776
[doc/3.19] Mention [gs]et_shared_data deprecation
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 17:01:11 +0200] rev 9775
[hooks] internal_session -> internal_cnx (including a typo)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 02 May 2014 14:26:14 +0200] rev 9774
deprecate get/set_shared_data API
Session or transaction data must be used instead.
We must forward .transaction_data to web/request from
which it was missing (this is indeed a _cw object API).
Closes #3799036.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 14:46:48 +0200] rev 9773
[migration] Stop setting session.data['rebuild-infered']
It's no longer read anywhere since fe267b7336f3 "[migration] always
rebuild infered relation"
Christophe de Vienne <christophe@unlish.com> [Wed, 04 Jun 2014 23:02:06 +0200] rev 9772
Import PIL modules from the PIL namespace to be Pillow-compatible
Closes #3924726
Julien Cristau <julien.cristau@logilab.fr> [Tue, 10 Jun 2014 14:11:59 +0200] rev 9771
merge two stable heads
Julien Cristau <julien.cristau@logilab.fr> [Tue, 10 Jun 2014 09:49:45 +0200] rev 9770
merge 3.18.5 into 3.19 branch
Julien Cristau <julien.cristau@logilab.fr> [Tue, 10 Jun 2014 09:35:26 +0200] rev 9769
merge 3.17.15 into 3.18 branch
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Fri, 16 May 2014 17:01:34 +0200] rev 9768
[vreg] fix bad super call to lgc.registry.Registry()
Registry() expects a debugmode parameter, ovbiously not a
cubicweb config object.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 16:15:29 +0200] rev 9767
Added tag cubicweb-version-3.18.5, cubicweb-debian-version-3.18.5-1, cubicweb-centos-version-3.18.5-1 for changeset 5071b69b6b0b
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 16:13:48 +0200] rev 9766
[pkg] prepare 3.18.5
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:29:25 +0200] rev 9765
[sobjects] update notifications system to 3.19 api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 04 Jun 2014 17:56:54 +0200] rev 9764
[connection] set language on new Connection for the internal manager
For regular users this is handled by _set_user, but for internal
connections (e.g. used for notifications) we need something else.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 03 Jun 2014 15:07:41 +0200] rev 9763
Added tag cubicweb-version-3.19.1, cubicweb-debian-version-3.19.1-1, cubicweb-centos-version-3.19.1-1 for changeset 1fe4bc4a8ac8
Julien Cristau <julien.cristau@logilab.fr> [Tue, 03 Jun 2014 12:52:52 +0200] rev 9762
[pkg] Add missing data files to MANIFEST
Fonts and svg were missing from web/data.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 03 Jun 2014 12:16:20 +0200] rev 9761
[pkg] prepare 3.19.1
David Douard <david.douard@logilab.fr> [Mon, 05 May 2014 11:26:18 +0200] rev 9760
[views] new cubicweb logo (closes #3803681)
- add the new CubicWeb logo
- use it as a css (background-image)
- change the color of the header bar (gradient made with css)
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Wed, 09 Apr 2014 15:42:27 +0200] rev 9759
[serverctl] rename 'add-source' to 'source-add' for consistency's sake (closes #3732169)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 12:02:51 +0200] rev 9758
[test/hook] use the new connection API
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 16:36:56 +0200] rev 9757
[testlib] complete the RepoAccess object (closes #3843614)
It was missing the open_session call.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 22 May 2014 18:29:50 +0200] rev 9756
[debian] version cubicweb-bootstrap Breaks
Apparently 0.6.x is OK with cw 3.19.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 06 May 2014 15:58:20 +0200] rev 9755
[wsgi] Delete unused instance_uri and get_full_path methods on CubicWebWsgiRequest
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 15 Apr 2014 11:59:24 +0200] rev 9754
[test] drop unused import
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 18:05:03 +0200] rev 9753
[sobjects] silent 3.19 warnings in sobjects/supervising.py
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 18:30:45 +0200] rev 9752
[test] update entities/test/unittest_wfobjs to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 10 Apr 2014 10:05:20 +0200] rev 9751
[test] Add missing import to fix old yams warning
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:26:57 +0200] rev 9750
[dataimport, migration] silence find_entities / find_one_entity warning
Deprecate associated methods to unify the API
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:14:25 +0200] rev 9749
[repo] fix extid2entity to ensure connection's has a cnxset
else we'll call source.doexec, which attempt to access to cnxset.cu, and crash
in some case (eg unittest_cwxmlparser in sobjects/test).
Also, manually switch to 'write' mode to ensure cnxset is not released until
commit/rollback when some entity is inserted.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:28:58 +0200] rev 9748
[test] update sobjects/test/unittest_cwxmlparser to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:15:25 +0200] rev 9747
[repo] make it clear in internal_cnx that security is disabled
as explained in its docstring. It was previously relying on internal
connection's fake user (InternalManager) for read security and on disabling
security hooks for write security. Using the security_enabled context manager is
more readable and more reliable: while the older implementation works thanks to
the InternalManager associated to the session, custom hooks should rely
on session.[read|write]_security being correctly set. This change also
allows selecting Password attributes in internal connections without
explicitly disabling read security.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 18:23:02 +0200] rev 9746
[datafeed] update datafeed internals to use connection instead of session
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:57:58 +0200] rev 9745
[test] update sobjects/test/unittest_notification to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:56:00 +0200] rev 9744
[test] simplify setup of sobjects/test/unittest_supervising.py
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:54:29 +0200] rev 9743
[test] update sobjects/test/unittest_supervising to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:53:58 +0200] rev 9742
[test] update sobjects/test/unittest_email to cw 3.19 api
Julien Cristau <julien.cristau@logilab.fr> [Tue, 06 May 2014 16:00:36 +0200] rev 9741
[wsgi] the spec says wsgi.url_scheme *must* be provided
No need to be defensive, anything else is a bug in the gateway.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Mon, 12 May 2014 12:37:19 +0200] rev 9740
[shell] provide autocompletion for rql queries in cubicweb-ctl shell (closes #3560541)
Use the ``rql.suggestions`` component to complete user's input
- readline calls the ``complete`` method with user's input,
- the ``complete`` method asks for each known completers if
it can suggest completions for user's input.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Apr 2014 14:33:40 +0200] rev 9739
[book] avoid '~' in all-in-one.conf, it is not expanded
Closes #3753213
Julien Cristau <julien.cristau@logilab.fr> [Wed, 07 May 2014 09:59:10 +0200] rev 9738
[book] uicfg moved from web to web.views a while ago
Julien Cristau <julien.cristau@logilab.fr> [Tue, 06 May 2014 15:59:39 +0200] rev 9737
[wsgi] look at wsgi.url_scheme to decide if we're on https
The server/gateway is supposed to fill it in for us.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 24 Mar 2014 10:34:58 +0100] rev 9736
[web] Fix HEAD request handling (closes #3677949)
Don't special-case HEAD in CubicWebRequestBase.is_client_cache_valid so
we don't return garbage. HEAD is supposed to return the actual headers
that a GET would return, which we can't do if we bypass all the normal
cubicweb logic. In particular, we no longer always return 200, and
return the right Content-Length/Content-Type/...
Julien Cristau <julien.cristau@logilab.fr> [Fri, 16 May 2014 16:49:29 +0200] rev 9735
[wsgi] avoid reading the entire request body in memory
Import POST form handling code from
https://raw.github.com/defnull/multipart/master/multipart.py to avoid
reading arbitrary amounts of data from the network in memory.
NOTES:
- In the twisted case we limit the max request content-length to 100MB (by
default), which seems kind of arbitrary, but avoids this issue
- werkzeug.formparser has suitable code as well, but I don't know if we want to
add it as a dependency
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 18:47:52 +0200] rev 9734
Added tag cubicweb-version-3.17.15, cubicweb-debian-version-3.17.15-1, cubicweb-centos-version-3.17.15-1 for changeset ee413076752b
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 18:16:18 +0200] rev 9733
[pkg] also bump __pkginfo__
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 17:48:58 +0200] rev 9732
[pkg] prepare 3.17.15
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 13:12:16 +0200] rev 9731
[cache] fix a cache issue with an entity created without relation cache prefill
Prefilling the relation cache has its benefits sometimes, but for
massive imports it may be a memory hog.
The caches should be kept coherent even if there was no prefill.
Closes #3828155.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Apr 2014 16:12:39 +0200] rev 9730
[web/test] add a test for some http response codes
Related to #3648809
David Douard <david.douard@logilab.fr> [Tue, 06 May 2014 14:11:17 +0200] rev 9729
[views] remove reference to the MAPPING_CHECKERS dict (closes #3810219)
Was removed by by the changeset 65d93a4fd11c
([multi-sources-removal] Drop pyrorql and zmqrql sources)
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Mar 2014 17:03:15 +0100] rev 9728
[web/ajax] Always return a json dict with a 'reason' key in case of ajax errors
Sending sometimes a bare unicode string and sometimes a json-encoded
dict seems like a bad idea.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Mar 2014 17:01:58 +0100] rev 9727
[web/ajax] don't override any status code with 500 in ajax_error_handler
If the request produced an error such as Unauthorized or NotFound,
core_handle sets an appropriate status_out. Which is then overridden by
the ajax error handler.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Mar 2014 11:11:28 +0100] rev 9726
[web] Add asserts to the raw header conversion functions
This API is terrible, but at least this might help us catch some errors
in our conversion definitions.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 07 Mar 2014 11:19:24 +0100] rev 9725
[view] Delete dead(?) code from ReloadableMixIn
Nothing seems to ever call user_callback on the Component, only on the
request. Related to #3567793
Julien Cristau <julien.cristau@logilab.fr> [Tue, 04 Feb 2014 15:06:25 +0100] rev 9724
Add a db-statement-timeout option for postgresql sources
Use that new option to set the statement_timeout option when creating
connections, except for maintenance operations (shell and upgrade).
Closes #2547026
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Apr 2014 14:24:52 +0200] rev 9723
[test] use assertNotIsInstance instead of assert_(not isinstance(...))
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:19:37 +0200] rev 9722
[services] register_user now returns the new CWUser
Closes #3804444
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:41:34 +0200] rev 9721
[server/session] remove json dumps around call_service
This backouts changeset b151beea9cb6. With call_service being
in-process and synchronous, there's no RPC use case.
Christophe de Vienne <cdevienne@gmail.com> [Wed, 30 Apr 2014 08:07:59 +0200] rev 9720
[req.find] Use vreg.schema.eschema for eschema lookup
If an etype is non-existant, using vreg.schema[etype] raises a confusing error
complaining about a non-existing relation. This is because of the
implementation of vreg.schema.__getitem__ that look first in entities and then
in relations.
Using directly vreg.schema.eschema restrict the lookup to etypes only, hence
raises a meaningful error when the etype does not exist.
Christophe de Vienne <cdevienne@gmail.com> [Wed, 30 Apr 2014 10:13:10 +0200] rev 9719
[doc] Typo
Christophe de Vienne <christophe@unlish.com> [Tue, 07 Jan 2014 15:10:57 +0100] rev 9718
[formfields] Handle 'placeholder' attribute for text and textarea
See #636930.
Closes #3406713.
Alain Begey <alain@unlish.com> [Mon, 14 Apr 2014 23:00:19 +0200] rev 9717
[forms] Add autocomplete attribute for formrenderers
If you set form.autocomplete = False, the form renderer
in the open form tag will add the html option 'autocomplete=off'.
It allows to disable the functionality of some browsers to fill in
some forms automatically (for instance a profile with login/password)
Closes #3747294
Alain Begey <alain@unlish.com> [Fri, 11 Apr 2014 17:43:26 +0200] rev 9716
[widget] Addition of EmailInput
Simple input widget with type = 'email'
Closes #3741921
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Mon, 13 Jan 2014 14:21:28 +0100] rev 9715
close branch
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 18:38:24 +0200] rev 9714
Added tag cubicweb-version-3.19.0, cubicweb-debian-version-3.19.0-1, cubicweb-centos-version-3.19.0-1 for changeset 1141927b8494
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 18:35:35 +0200] rev 9713
[debian] set release date
Katia Saurfelt <katia.saurfelt@logilab.fr> [Mon, 28 Apr 2014 18:11:21 +0200] rev 9712
[entity] add a new `cw_linkable_rql` method
* the new method returns the entities that are or may be related to the
current one by the relation passed as an argument.
Closes #3738011.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 07 Apr 2014 12:03:31 +0200] rev 9711
[schema] fix buggy composite_rdef_roles and associated test
it should only look at rdefs involving the considered entity type.
Closes #3712982
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 17:43:35 +0200] rev 9710
[doc] update 3.19 release notes
Christophe de Vienne <cdevienne@gmail.com> [Mon, 28 Apr 2014 12:41:41 +0200] rev 9709
[login form] Fix BaseLogForm.form_action()
The method implementation was calling super() with the wrong class
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 11:20:26 +0200] rev 9708
[migration] move 'entities' table changes from 3.19.0 to bootstrap script
The 'mtime' and 'source' columns need to go away before we attempt to do
anything else with the repo, otherwise any addition of an entity is
going to explode.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 12:54:14 +0200] rev 9707
[server/session] add missing rollback when freeing a db connection
When we let go of a cnxset and give it back to the pool, we need to make
sure it's not in the middle of a transaction.
We got bitten by a migration where the connection used by admin's
repo.connect was not rolled back before attempting the migration,
causing a deadlock because it had a lock on a table. This could
potentially also be an issue for e.g. hooks or looping tasks that didn't
explicitly rollback before calling free_cnxset or moving out of a
ensure_cnx_set block.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Apr 2014 17:52:20 +0200] rev 9706
[debian] add Breaks on cubicweb-bootstrap
Need to be versioned once we know which version fixes
https://www.cubicweb.org/ticket/3728939
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 08 Apr 2014 16:08:31 +0200] rev 9705
Drop duplicated content in ITreeAdapter docstring
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 13:31:19 +0200] rev 9704
an -> a (misc)
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 12:29:01 +0200] rev 9703
an utf-8 -> a utf-8
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 12:27:37 +0200] rev 9702
an URI -> a URI
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 12:07:00 +0200] rev 9701
an unicode string -> a unicode string
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 11:54:33 +0200] rev 9700
an URL -> a URL
Christophe de Vienne <christophe@unlish.com> [Tue, 01 Apr 2014 13:57:25 +0200] rev 9699
Remove a misleading comment about self.render() behavior.
The former comment suggested that View.render called with 'row' or 'col' would
set cw_row or cw_col, which is not (anymore ?) accurate.
Related to #3696871.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 06 Mar 2014 18:41:23 +0100] rev 9698
[migractions] add sanity check in rename_relation_type
If the relation is still present in the fs schema, we probably shouldn't
be renaming it (because it's still in use somewhere, possibly in a
different cube). Closes #3608172
Vincent Michel <vincent.michel@logilab.fr> [Mon, 07 Apr 2014 08:46:41 +0000] rev 9697
[dataimport] Add safety belt on "gen_rtype" in MetaGenerator, closes #3712892
Some cubes may well add to the META_RTYPES set, hence
crashing the gen_<somecubemeta> call.
Vincent Michel <vincent.michel@logilab.fr> [Mon, 07 Apr 2014 08:44:56 +0000] rev 9696
[dataimport] Correctly serialize datetime objects in _create_copyfrom_buffer, closes #3712885
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 03 Apr 2014 15:36:33 +0200] rev 9695
[dataimport] Prevent ucsvreader from skipping the first line when ignore_errors is True (closes #3705791)
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 03 Apr 2014 15:30:37 +0200] rev 9694
[dataimport] Avoid double unicode decoding in ucsvreader (closes #3705752)
Christophe de Vienne <christophe@unlish.com> [Fri, 25 Apr 2014 12:22:07 +0200] rev 9693
[doc] Document the user_data dictionnary content
Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Apr 2014 14:44:58 +0200] rev 9692
[debian] break old cubicweb-vcsfile
We removed call_service's async argument, which it used.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:17:42 +0200] rev 9691
[services] catch missing group early in register_user
Better an assertion than a rql syntax error for such a programming error.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:16:46 +0200] rev 9690
[services] rename register_user kwargs to cwuserkwargs
They're attributes/relations for the created CWUser, this makes it clearer.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Apr 2014 15:18:04 +0200] rev 9689
[services] don't hardcode 'users' group for register_user
Let the caller choose which group the user should be in. Related to #3020639
Caveat: this is a possible security hole if untrusted values are allowed.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Apr 2014 15:03:24 +0200] rev 9688
[sobjects/test] check that register_user properly sets user name and email address
Related to #3020639
Vladimir Popescu <vladimir.popescu@logilab.fr> [Fri, 19 Jul 2013 17:38:15 +0200] rev 9687
[server] Refactor Repository.register_user into a CubicWeb service (closes #3020639)
[jcr: move commit to the caller; add item in release notes; fix NameErrors]
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Apr 2014 14:25:36 +0200] rev 9686
[migration] set a cnxset before process_script()
Not pretty, but I don't have a better idea right now and this at least
ensures migration scripts get run in the expected environment and can
access sql stuff as before.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 11:04:13 +0200] rev 9685
[server] make internal_cnx get and keep a connection to the db
- internal_session worked that way
- it's less surprising for users if their internal connections "just
work", rather than having to deal with the cnxset when using low-level
APIs
Includes a backout of 3f62606c01a2 "[repo] Fix register_user" which is
no longer needed.
Depend on logilab-database 1.12.1 to avoid errors due to pointless check
in python's sqlite3 binding.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Apr 2014 14:43:11 +0200] rev 9684
[server/session] make commit/rollback obey ensure_cnx_set
Inside the ensure_cnx_set context manager, commit and rollback aren't
allowed to dispose of the cnxset.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 14:05:54 +0200] rev 9683
[repo] fix deprecation messages for stats and gc_stats
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 17:31:50 +0200] rev 9682
[cwconfig] use "foo not in bar" instead of "not foo in bar"
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 15:28:21 +0200] rev 9681
[debian] Add Breaks on a few cubes that need changes for 3.19
- mercurial_server is affected by composite deletion changes
- forgotpwd relied on session data to be forwarded to notification view
- registration hooks into the authentication stack
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 15:03:01 +0200] rev 9680
[hooks] run cascading delete hook later
Applications may have their own before_delete_entity hooks that rely on the
composite relations still existing.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 13:54:31 +0200] rev 9679
[devtools] set PGPORT/PGHOST when calling pg_ctl start
Helps pg_ctl find the socket on squeeze, otherwise it looks in
/var/run/postgresql.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 17:21:07 +0200] rev 9678
[server/test] update to deal with lgdb sqlserver fix
See https://www.logilab.org/ticket/235748
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 10:59:08 +0200] rev 9677
[test] Fix regressions from 96549de9dd70 "[test] use assertIn where appropriate"
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 18:14:45 +0200] rev 9676
[repo] Fix register_user
Make sure we have a connection to the db around user creation.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Apr 2014 18:00:14 +0200] rev 9675
[test] use assertNotIn where appropriate
Automatically generated with:
find -name unittest_*.py -o -name test_*.py | xargs sed -i -e 's/assertFalse(\([^,]*\) in \([^,]*\))/assertNotIn(\1, \2)/'
plus revert of a couple false matches.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Apr 2014 17:39:39 +0200] rev 9674
[test] use assertIn where appropriate
Automatically generated with:
find -name unittest_*.py -o -name test_*.py | xargs sed -i -e 's/assertTrue(\([^,]*\) in \([^,]*\))/assertIn(\1, \2)/'
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 11:25:45 +0200] rev 9673
[doc] Add removal of old multi-sources to 3.19 release notes
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 11:19:59 +0200] rev 9672
[pkg] Bump to 3.19.0
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 10:51:15 +0200] rev 9671
[web/debug] remove code broken by session refactoring
session.cnx and cnx.check() no longer exist.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 10:49:18 +0200] rev 9670
[web/debug] Fix check for open sessions
itervalues returns an iterator, which never evaluates to False.
Regression from 0bb18407c053 "[toward py3k] rewrite dict.keys() and
dict.values() (part of #2711624)".
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 20 Mar 2014 15:42:23 +0100] rev 9669
[cwconfig] Remove useless 'ui-cube' configuration option (closes #3728904)
The mechanism introduced could never actually be used as it brings dependency
loops to the cube graph. Just get rid of it.
This reverts commit 4032499c701e.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 14:28:47 +0200] rev 9668
[test] Use RepoAccess.shell() in unittest_predicates
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 12:03:06 +0200] rev 9667
[devtools] add 'shell' method to RepoAccess, deprecate CubicWebTC's
Lets us control the connection's lifetime.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 14:44:49 +0200] rev 9666
[repo] make extid2eid work with either a session or a connection
The only place it should matter is for restoring pending_operations in
case of failure. Which is not exercised by the test suite. Here be
dragons.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 14:23:01 +0200] rev 9665
[repository] extid2eid's 'commit' argument no more necessary
This removes the need for creating an internal session.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 12:46:35 +0200] rev 9664
[repository] complete argument is no more needed since we have no more 'true' multisource.
It is always false.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 12:39:59 +0200] rev 9663
[repository] 'session' argument is always given to type[_and_source]_from_eid, make it mandatory and simplify code accordingly
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Apr 2014 14:48:51 +0200] rev 9662
[repository] 'session' argument is always given to extid2eid, make it mandatory and simplify code accordingly
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 28 Mar 2014 14:59:33 +0100] rev 9661
[web/data] Remove broken jquery-json plugin (closes #3590335)
Conversion of Date() objects is somehow broken (don't know why beyond that it's
due to jquery-json's monkeypatched Date.toJSON() method).
Use the now-standard JSON.stringify() instead. http://caniuse.com/#feat=json
says it's supported by all browsers, and even IE going back to version 8.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 27 Jan 2014 14:02:21 +0100] rev 9660
Add missing relation types items in schema global variables
Some of these global variables are used, in particular, to control schema
views (web/views/schema.py).
While they are currently not properly documented (see #3360868), their
definition are currently incomplete (e.g. one could reasonably expect to find
``cw_schema`` in ``SYSTEM_RTYPES``).
Closes #3486114.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Mar 2014 16:57:22 +0100] rev 9659
[web] return 403 for Unauthorized, not 401
401 is reserved to HTTP authentication. Just because it's also called
"unauthorized" doesn't mean it's the same as cubicweb's Unauthorized
exception. Closes #3648809.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:30 +0200] rev 9658
[test] update unittest_repoapi to 3.19 api (sic)
[jcr: while at it, fix typos and add missing __main__ section]
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:19 +0200] rev 9657
[test] update unittest_utils to 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:11 +0200] rev 9656
[test] update unittest_rset to 3.19 api
[jcr: use self.admin_access instead of creating a new one each time]
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:03 +0200] rev 9655
[test] update unittest_rqlrewrite to 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:54:54 +0200] rev 9654
[test] update unittest_req to 3.19 api
[jcr: use self.admin_access instead of creating a new one each time]
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:54:45 +0200] rev 9653
[test] update unittest_predicates to 3.19 api
[jcr: use self.admin_access instead of creating a new one each time]
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 18:35:18 +0200] rev 9652
[web/test] port unittest_reledit to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Apr 2014 11:31:39 +0200] rev 9651
[web/test] port unittest_magicsearch to RepoAccess API
request created in setUp makes context manager usage painful, so create
a context manager to do the setup for each test class.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 16:05:54 +0200] rev 9650
[web/test] use real_error_handling context manager instead of open-coding it
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 16:03:19 +0200] rev 9649
[web/test] port unittest_idownloadable to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 15:51:29 +0200] rev 9648
[web/test] remove useless calls to self.request() from CORS tests
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 15:47:04 +0200] rev 9647
[web/test] port unittest_formfields to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 18:20:23 +0200] rev 9646
[web/test] port unittest_form to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 17:44:32 +0200] rev 9645
[web/test] port unittest_facet to RepoAccess API