backport stable

oops, 'not' missing

[repo] fix bug introduced by 4757:ec9c20c6b9f7, testing for select.selection is not enough to avoid the substep query, we should check there is no interesting restriction (test added)

[rql2sql] fix potential crash when testing _q_invariant on a ColumnAlias instead of a Variable by always considering _q_invariant to false for them

backport stable

fix test broken by meta relation permissions tweaks

fix schema serialization, bad repartition of changes between stable and default

backport stable

remove stuff from default introduced accidentally in stable

applied vgodard patch for jquery rounded corner w/ MSIE >= 8

backport stable

[fix] #731915 use add_onload instead of plain <script> tag for progress bar. This changeset fixes : #731915: missing inprogress style on the project page Content fetched with ajax have their <script> tags removed. (see #734414) We now use the _cw.html_headers.add_onload method to execute the javascript code necessary to draw the progress bar. In the process we removed the ProgressBarWidget and merged it in ProgressTableView.

add render_description method to RSSItemView to improve modularity. The construction of the description marker of and rss entry is currently built by the main cell_call function. This make the job hard for RSSItemView subclass to change the default behaviour. The changeset fix this issue by extracting the description creation into a render_description method. Such extraction are already in place for various rss marquer.

le patch documentation-admin-tips a été importé

[F] views: fix 2 unicode errors 1. You can now use valid unicode strings in ValidationError exception. Previously, if 'err' contains unicode, UnicodeDecodeError was raised by format_errors() >>> templstr = '<li>%s</li>\n' >>> e = ValidationError(None, {None: u'oué, une exception en unicode!'}) >>> templstr % e '<li>None (None): ou\xc3\xa9, une exception en unicode!</li>\n' >>> templstr = u'<li>%s</li>\n' >>> templstr % e u'<li>None (None): ou\xe9, une exception en unicode!</li>\n' 2. The message of an Exception can contains unicode. But it now properly managed by “informal” string representation. We can easily fix the problem by using the Exception.message attribute that still contains the original message. >>> a = AssertionError(u'séfdsdf') >>> a.message u's\xe9fdsdf' >>> str(a) Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 1: ordinal not in range(128) >>> a = ValueError(u'fsdfsdéfsdfs') >>> str(a) Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 6: ordinal not in range(128) >>> a ValueError(u'fsdfsd\xe9fsdfs',) >>> unicode(a) Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 6: ordinal not in range(128) >>> a.message u'fsdfsd\xe9fsdfs'

le patch fix-3.6-deprecation-warning a été importé

Suppress the hidden logform when the user is already connected by adding a conditionned logform

fix a Depression Warning replace self.req._(... by self._cw._(...

fix: Prevent multi pass in restore_previous_post by adding a conditional return add the top of the methode.

merge

[test] check _shutting_down, not empty dict (empty dict test should go in pytestgc patch)

assert we are not already shutting down

[test] call super class teardown after perms restoration

[test] get a chance to get proper garbage collection when running pytest on whole cw

[testlib] properly close dumb sessions

[debug] more (dirty) gc debuging

custom rest publisher instead of using rest_publish. Avoid to keep a ref on the latest context

cleanup

[rest] cleanup, avoid deprecation warning

delete pyro proxy on connection close, properly raise programming error when working on a closed connection

cleanup

[test] get a chance to get proper garbage collection when running pytest on whole cw

more tests

[repo] improve planning of insert/update queries: do not select affected constants so the don't go and back to/from the source.

schema serialization optimization by using eids instead of type names. Heavy refactoring/cleanup on the way

backport stable

[testlib] automatic test shouldn't try to populate default_workflow

minor schema serialization optimization: * remove verbose handling, no more necessary since server.set_debug * remove old bw compat code * other cleanups

cleanups

fix code and tests broken by 4744:13a5d3a7410e (proper permission on eid/has_text/identity relations)

do not check for use template permission when session is super session or integrity hooks are deactivated

do not check for existant entity when relation of single card is added but integrity hooks are deactivated

[schema] tweaks meta-relations and schema/workflow entities attributes permissions

[schema] new constants for permissions definitions

[book/ldap] note on the role of two options

[book/cwctl] reorganize a bit this page (very messy)

[book] more id -> __regid__

[book/entities] a bit of flesh to the interface chapter

[book/admin/pyro] fix pyro options, give a small setup example

[book/faq] cleanup & complete a bit

[book/admin/setup] notes about configuration of sql server

[book] remove seemingly unused old cruft

merge

[book] cleanup (deleting/moving) old stuff

[book] a few autoclasses for renderers, misc tweaks

[primary] navcontentbottom sections should be in the content table as navcontenttop

[book/controllers] add some content (overview, api super sketch) for the cubicweb controllers

[book/ldap] add missing LDAP section

[reledit] add ajax html head div, which allows to get additional css/js up to the browser #620569

fix open/close/open subnode bug #730709

backport stable to default

Added tag cubicweb-debian-version-3.6.1-1 for changeset b9cdfe3341d1

Added tag cubicweb-version-3.6.1 for changeset 4ae30c9ca11b

typo

3.6.1 depending on yams 0.28

merge

Added tag cubicweb-debian-version-3.6.0-1 for changeset d2ba93fcb8da

Added tag cubicweb-version-3.6.0 for changeset 450804da3ab2

3.6.1

merge

tabs/lazy views: provide a link for the no js user agents (lynx, blinds, google) #693670

[test] XXX fix to have pytest succeed on whole cw

typo

fix test, broken by the merge of debug and info views

ensure we don't break xhtml

pylint suggested refactorings

pylint style fixes

don't use module doc string as usage string

kill dead/useless code as suggested by pylint

avoid module import in c-c plugins module, and remind it

proper deprecation warning when import class that should be imported from yams

fix some pylint detected errors

[test] fix test broken by arthur processinfo patch

merge debug and info views plus enhancements: * nicer presentation * proper translations * kill dead (modpython!) code * fix repository stats (active thread count / add looping tasks information)

[i18n] nothing to translate here

i18nupdate

[test] we should properly use vreg method to compute solutions

[pool] properly close existing connection before reconnection

[web] fix #724769: Use RemoteCallFailed in the publisher's error_handler On json_request, errors handled by the publisher should raise RemoteCallFailed exceptions instead of standard StatusResponse so that errbacks get called normally on the client side.

#687194: cubicweb-ctl exlog : fix help message

merge

added stats for munin collecting #615844 - from 027bbff3659f

[dbapi] no more need to monkey patch this in 3.6: vreg/schema/config are all properly accessed through ._cw

[session] fix memory leak: local thread data living in a thread that never finishes (eg, the main thread) may not be properly freed

[session] user.login is usually an unicode string, so implements __unicode__ instead of __str__

fix docstring

[facet] before 3.6 we were sure to have a cw_rset attribute. Restore this for facets

[iprogress] missing js file

[hooks] match_rtype and match_rtype_sets don't need to extend match_search_state The only method actually used by those 2 classes is __str__ that is defined on ExpectedValueSelector, not match_search_state.

[uicfg] section='inlined' is acceptable for inlined forms

[web] fix muledit rendering bug form.cw_col might be None and explicitly passing None to the selector chain may crash. Most __call__ methods of selectors are defined as in : def __call__(self, cls, req, rset, row=None, col=0, **kwargs) and then manipulate col as if it's an integer.

merge

3.6 api update

simplejson may not be available with python 2.4

ensure make_uid return something that may be used as dom id

[test] also hide this message during test

[test] fix test inter-dependancies pb. Pytest ok in each individual test dir, though not yet for whole cubicweb, but for different reasons

[testlib] provide ability to control schema/vreg reset using reset_schema/reset_vreg test class attributes

[test] skipping versions checking during test is enough, no need for monkey patch

[goa] we don't use mx anymore

[integrity] skip auto-delete for internal sessions (but *not* for super session, see 4642:921737d2e3a8)

[integrity] temporary fix auto-delete relation (see 4673:6f8b925a29f4 and 4642:921737d2e3a8): we want no read perms, though we want to check delete perms. Should be properly fixed in 3.7 once we've proper security control and [unsafe_]execute behaviour on the repository side

use set_action_permissions is clearer and avoid @cached issue across tests

[cwctl] use l.c.changelog for version comparison

[form] only set __form_id for the main form, not for sub-forms. Should fix regression introduced by 4668:9f82f81bf13d

don't issue critical message when trying to alter sqlite db during test

[test] cleanup

[test] update tests broken by changes on attributes permissions handling in yams (add/delete replaced by update

remove #<formid> from url used to redirect after a validation error

[test] no more __cubicweb_internal_field__ value displayed on password widget

[test] inline-creation requires petype argument to be selectable. Fix arguments order to make it clearer that 'template' is an argument of the test class .view method

[test] skip test when fop failed

[test] don't display progress bar when testing checkintegrity

[test api] rename _user_session to user_groups_session, fix its arguments and return only the session, not (user, session) to make things clearer

auto-delete relation with single cardinality using execute, not unsafe_execute, so permissions are correctly checked

fix tests

add */*.py to default MANIFEST.in to avoid pb such as #719282 in the future

fix #615379 by checking admin user exists instead of making think everything is fine

cleanup, typos

[form] fix #719285, due to multiple calls to restore_previous_post, by proper refactorings * move __init__ code from FieldsForm to Form. Must behaviour here should actually be in the Form base class * avoid buggy duplicated call to restore_previous_post * move some code that was in the form renderer to the form'__init__ method (__redirectpath & __form_id hidden input handling)) * 'formvid' should now be specified on form selection, not on form rendering

[fix] Apply fulltextindexed change in the actual index Change of the fulltextindexed attribute of a CWAttribute did actually change anything for already existing entity (but apply to new one). This patch fix this behaviour: * A new SingleLastOperation, UpdateFTIndexOp, to reindex entity whose ftindexation changed during a commit. This data is read from session.transaction_data['fti_update_etypes'] * The SourceDbRDefUpdate operation to store Etype who modify they fulltextindexed of attribute in session.transaction_data['fti_update_etypes']. * A new test is added to check the behaviour

3.6 api update (introduced by merge)

when validating a form, we should properly call 'actual_fields(form) on edited field else compound field are not correctly processed

#714109: [selectors] non_final_entity should implement score_class

merge

add XXX note

[form] cache field value in form.formvalues using (field, form) key since in some case the same field instance may be shared accross multiple forms, which may share the formvalues dict in case of sub-forms

cleanup

[form] complete 25de2eb0432b by ignore req parameters by default for all hidden fields

[form] add a new ignore_req_params attribute on field controlling value's retreival for such field, such as eid/__type in entity forms, we don't want to consider values from req.form since we may get undesired value (as reported by #714766). This new attribute allow do specify that we don't want to consider req.form in such case. Also, it seems that retreival of form values after a validation error suffer from the same problem, so don't use form_previous_values for field with ignore_req_params set to True (XXX though I suppose that may not be correct in some cases).

[css] fix disappearing image in menu when a:hover

[cwctl] modify command list to check for cube dependency problems

merge

docstring improvement

import cleanup

restore 3.5 compat for date functions moved to lgc.date in 3.6 (closes #716055)

[devtools/fill] fix date generation and its test

typo: capitalize migration confirmation messages

[views/deleteconf] remove action ppty (useless & clashes with form attr, replace buggy non_final_entity selector with implements workaround

merge

[workflow] fix potential destination for go back transition

[workflow] finish refactoring introduced by 021035b9a7ab for 'go back' transition: * fix SubWorkflowTransition.destination() prototype (must now take an entity as argument) * fix the change state for to give the entity to the transition's destination() method * we need a new method to draw workflow since we've no entity to give and 'go back' transition usually go back to multiple states

deprecate Transition.set_transition_permissions in favor of set_permissions (after all we know we're on a transition entity)

introduce 'go back' transition: transition without destination state will go to the state we were coming from

fix optimisation with super session that may lead to integrity loss at some point I've decided to stop ensuring ?1 cardinality was respected when adding a new relation using a super session, to avoid the cost of the delete query. That was yet discussable because it introduced unexpected difference between execute and unsafe_execute, which is imo not worth it. Also, now that rql() in migration script default to unsafe_execute, we definitly don't want that implicit behaviour change (which already cause bug when for instance adding another default workflow for an entity type: without that fix we end up with *two* default workflows while the schema tells we can have only one. IMO we should go to the direction that super session skip all security check, but nothing else, unless explicitly asked.

[auto/inline forms] reallow nested inline forms #703910

[reledit] fix #713217: reledit doesn't check 'update' permission on attributes

fix dumb name error

cleanup internal forms parameters in postlogin

grmmbl, bad resolve

missed conflict

backport lost stable head

fix sync_schema_props_perms test

fix create_user function introduced in d6ae30c5d055 for database initialization: messup admin user groups when anon is created due to missing restriction

3.6 api update

fix unittest_hooks: attributes have now update_permission instead of [add/delete]_permission

when modifying a persistent schema, erschema may miss some permissions which wil trigger a key error, but we don't want to crash on such cases

fix #694445: related entity generates weird RQL which in turn generates weird SQL which fails on SQL Server quick fix to reuse modification_date if already retreived by the rql query.

fix 4626:c26b4df9fc90 (#703911): use can't rely on peid since it's not an actual eid when we're creating the parent entity

[form fields] nicer behaviour of the password field: don't put internal field value on edition (triggering validation error if one validation without removing the value, due to confirmation mismatch), and don't show the field as required in such case

minor cleanup: don't use builtin 'id' as variable name

[forms/inline] fix #703911: add new link disappears if inline box removed. Since we've the information, we must specify the target type else we get random cardinality on ambiguous relations

this is not the form renderer responsability to check for update permissions. Move this to autoform editable_attributes relation

turn default logging threshold to warning (we usually want them), and log 'no schema for eid' pb using warning instead of error, so we see them in logs but not during migration

pfff, sorry to keep messing with default/stable...

specify db port on backup/restore commands (require forth comming lgc 0.48.1)

move captcha view to a place where it will be loaded by the registry...

backport stable

[security] allow to call .check on rql expression with a user eid specified

[facet] rqlst should be the select node

oops, should have been in my previous commit

fix table view facet retreival, necessary since 95ccd84c892b. Also some cleanup in facet box

Fix: RangeFacet is selected (valid rset) but without any values

fix the bad rqlst syntax tree usage during facets initialization by copying it

[R] dataimport: refine error detection Consider only None as non-expected value after parsing the input file. False is now allowed because of the boolean yesno checker that returns False by default.

added a function to create admin/anon user during db initialization process so one get a chance to monkey patch it

fix unittest_schema, remove deprecation warning

when creating an instance, ask for cubes specific options properly (fix #607349)

avoid loading twice site_cubicweb files on instance creation

oops

[schema security] fix so that when cheking attributes perms for an entity being created, 'owners' and has_*_permission in erqlexpr are considered satisfied

dont add CUBES_DIR to cubes search path if it doesn't exists