kill dead/useless code as suggested by pylint

avoid module import in c-c plugins module, and remind it

proper deprecation warning when import class that should be imported from yams

fix some pylint detected errors

[test] fix test broken by arthur processinfo patch

merge debug and info views plus enhancements: * nicer presentation * proper translations * kill dead (modpython!) code * fix repository stats (active thread count / add looping tasks information)

[i18n] nothing to translate here

i18nupdate

[test] we should properly use vreg method to compute solutions

[pool] properly close existing connection before reconnection

[web] fix #724769: Use RemoteCallFailed in the publisher's error_handler On json_request, errors handled by the publisher should raise RemoteCallFailed exceptions instead of standard StatusResponse so that errbacks get called normally on the client side.

#687194: cubicweb-ctl exlog : fix help message

merge

added stats for munin collecting #615844 - from 027bbff3659f

[dbapi] no more need to monkey patch this in 3.6: vreg/schema/config are all properly accessed through ._cw

[session] fix memory leak: local thread data living in a thread that never finishes (eg, the main thread) may not be properly freed

[session] user.login is usually an unicode string, so implements __unicode__ instead of __str__

fix docstring

[facet] before 3.6 we were sure to have a cw_rset attribute. Restore this for facets

[iprogress] missing js file

[hooks] match_rtype and match_rtype_sets don't need to extend match_search_state The only method actually used by those 2 classes is __str__ that is defined on ExpectedValueSelector, not match_search_state.

[uicfg] section='inlined' is acceptable for inlined forms

[web] fix muledit rendering bug form.cw_col might be None and explicitly passing None to the selector chain may crash. Most __call__ methods of selectors are defined as in : def __call__(self, cls, req, rset, row=None, col=0, **kwargs) and then manipulate col as if it's an integer.

merge

3.6 api update

simplejson may not be available with python 2.4

ensure make_uid return something that may be used as dom id

[test] also hide this message during test

[test] fix test inter-dependancies pb. Pytest ok in each individual test dir, though not yet for whole cubicweb, but for different reasons

[testlib] provide ability to control schema/vreg reset using reset_schema/reset_vreg test class attributes

[test] skipping versions checking during test is enough, no need for monkey patch

[goa] we don't use mx anymore

[integrity] skip auto-delete for internal sessions (but *not* for super session, see 4642:921737d2e3a8)

[integrity] temporary fix auto-delete relation (see 4673:6f8b925a29f4 and 4642:921737d2e3a8): we want no read perms, though we want to check delete perms. Should be properly fixed in 3.7 once we've proper security control and [unsafe_]execute behaviour on the repository side

use set_action_permissions is clearer and avoid @cached issue across tests

[cwctl] use l.c.changelog for version comparison

[form] only set __form_id for the main form, not for sub-forms. Should fix regression introduced by 4668:9f82f81bf13d

don't issue critical message when trying to alter sqlite db during test

[test] cleanup

[test] update tests broken by changes on attributes permissions handling in yams (add/delete replaced by update

remove #<formid> from url used to redirect after a validation error

[test] no more __cubicweb_internal_field__ value displayed on password widget

[test] inline-creation requires petype argument to be selectable. Fix arguments order to make it clearer that 'template' is an argument of the test class .view method

[test] skip test when fop failed

[test] don't display progress bar when testing checkintegrity

[test api] rename _user_session to user_groups_session, fix its arguments and return only the session, not (user, session) to make things clearer

auto-delete relation with single cardinality using execute, not unsafe_execute, so permissions are correctly checked

fix tests

add */*.py to default MANIFEST.in to avoid pb such as #719282 in the future

fix #615379 by checking admin user exists instead of making think everything is fine

cleanup, typos

[form] fix #719285, due to multiple calls to restore_previous_post, by proper refactorings * move __init__ code from FieldsForm to Form. Must behaviour here should actually be in the Form base class * avoid buggy duplicated call to restore_previous_post * move some code that was in the form renderer to the form'__init__ method (__redirectpath & __form_id hidden input handling)) * 'formvid' should now be specified on form selection, not on form rendering

[fix] Apply fulltextindexed change in the actual index Change of the fulltextindexed attribute of a CWAttribute did actually change anything for already existing entity (but apply to new one). This patch fix this behaviour: * A new SingleLastOperation, UpdateFTIndexOp, to reindex entity whose ftindexation changed during a commit. This data is read from session.transaction_data['fti_update_etypes'] * The SourceDbRDefUpdate operation to store Etype who modify they fulltextindexed of attribute in session.transaction_data['fti_update_etypes']. * A new test is added to check the behaviour

3.6 api update (introduced by merge)

when validating a form, we should properly call 'actual_fields(form) on edited field else compound field are not correctly processed

#714109: [selectors] non_final_entity should implement score_class

merge

add XXX note

[form] cache field value in form.formvalues using (field, form) key since in some case the same field instance may be shared accross multiple forms, which may share the formvalues dict in case of sub-forms

cleanup

[form] complete 25de2eb0432b by ignore req parameters by default for all hidden fields

[form] add a new ignore_req_params attribute on field controlling value's retreival for such field, such as eid/__type in entity forms, we don't want to consider values from req.form since we may get undesired value (as reported by #714766). This new attribute allow do specify that we don't want to consider req.form in such case. Also, it seems that retreival of form values after a validation error suffer from the same problem, so don't use form_previous_values for field with ignore_req_params set to True (XXX though I suppose that may not be correct in some cases).

[css] fix disappearing image in menu when a:hover

[cwctl] modify command list to check for cube dependency problems

merge

docstring improvement

import cleanup

restore 3.5 compat for date functions moved to lgc.date in 3.6 (closes #716055)

[devtools/fill] fix date generation and its test

typo: capitalize migration confirmation messages

[views/deleteconf] remove action ppty (useless & clashes with form attr, replace buggy non_final_entity selector with implements workaround

merge

[workflow] fix potential destination for go back transition

[workflow] finish refactoring introduced by 021035b9a7ab for 'go back' transition: * fix SubWorkflowTransition.destination() prototype (must now take an entity as argument) * fix the change state for to give the entity to the transition's destination() method * we need a new method to draw workflow since we've no entity to give and 'go back' transition usually go back to multiple states

deprecate Transition.set_transition_permissions in favor of set_permissions (after all we know we're on a transition entity)

introduce 'go back' transition: transition without destination state will go to the state we were coming from

fix optimisation with super session that may lead to integrity loss at some point I've decided to stop ensuring ?1 cardinality was respected when adding a new relation using a super session, to avoid the cost of the delete query. That was yet discussable because it introduced unexpected difference between execute and unsafe_execute, which is imo not worth it. Also, now that rql() in migration script default to unsafe_execute, we definitly don't want that implicit behaviour change (which already cause bug when for instance adding another default workflow for an entity type: without that fix we end up with *two* default workflows while the schema tells we can have only one. IMO we should go to the direction that super session skip all security check, but nothing else, unless explicitly asked.

[auto/inline forms] reallow nested inline forms #703910

[reledit] fix #713217: reledit doesn't check 'update' permission on attributes

fix dumb name error

cleanup internal forms parameters in postlogin

grmmbl, bad resolve

missed conflict

backport lost stable head

fix sync_schema_props_perms test

fix create_user function introduced in d6ae30c5d055 for database initialization: messup admin user groups when anon is created due to missing restriction

3.6 api update

fix unittest_hooks: attributes have now update_permission instead of [add/delete]_permission

when modifying a persistent schema, erschema may miss some permissions which wil trigger a key error, but we don't want to crash on such cases

fix #694445: related entity generates weird RQL which in turn generates weird SQL which fails on SQL Server quick fix to reuse modification_date if already retreived by the rql query.

fix 4626:c26b4df9fc90 (#703911): use can't rely on peid since it's not an actual eid when we're creating the parent entity

[form fields] nicer behaviour of the password field: don't put internal field value on edition (triggering validation error if one validation without removing the value, due to confirmation mismatch), and don't show the field as required in such case

minor cleanup: don't use builtin 'id' as variable name

[forms/inline] fix #703911: add new link disappears if inline box removed. Since we've the information, we must specify the target type else we get random cardinality on ambiguous relations

this is not the form renderer responsability to check for update permissions. Move this to autoform editable_attributes relation

turn default logging threshold to warning (we usually want them), and log 'no schema for eid' pb using warning instead of error, so we see them in logs but not during migration

pfff, sorry to keep messing with default/stable...

specify db port on backup/restore commands (require forth comming lgc 0.48.1)

move captcha view to a place where it will be loaded by the registry...

backport stable

[security] allow to call .check on rql expression with a user eid specified

[facet] rqlst should be the select node

oops, should have been in my previous commit

fix table view facet retreival, necessary since 95ccd84c892b. Also some cleanup in facet box

Fix: RangeFacet is selected (valid rset) but without any values

fix the bad rqlst syntax tree usage during facets initialization by copying it

[R] dataimport: refine error detection Consider only None as non-expected value after parsing the input file. False is now allowed because of the boolean yesno checker that returns False by default.

added a function to create admin/anon user during db initialization process so one get a chance to monkey patch it

fix unittest_schema, remove deprecation warning

when creating an instance, ask for cubes specific options properly (fix #607349)

avoid loading twice site_cubicweb files on instance creation

oops

[schema security] fix so that when cheking attributes perms for an entity being created, 'owners' and has_*_permission in erqlexpr are considered satisfied

dont add CUBES_DIR to cubes search path if it doesn't exists

fix dumb name error triggering crash when some directory in cubes search path doesn't exist

remove 3.6 deprecation warning

login form style fixes

proper deprecation of TabedPrimaryView

missing call to toolbox in tabbed primary view

use needs_css so you can change login form css without redefining LogFormView

bw compat

backport fixes done accidentaly in default

use class, not klass, in widget.attrs

specify login form dom id, don't render progress div

backport crypto/captcha utilities from the registration cube

use an actual form for the login form ease customization from external cubes (eg rememberme)

add space between a checkbox and its label

ensure cnx is set first (necessary to introduce of a form object to handle the login form)

don't let set_schema making commit_event fail

use constant

fix permission of the condition permission

fix *_permissions schema: using the same cardinality/composite properties for cwgroup/rqlexpr leads to important pbs...

backport stable

DEFAULT_ATTRPERMS is now public

[inlined formos] don't pop attributes from kwargs, so they end-up in cw_extra_kwargs which is then passed to the edition form

[notification] we should use unsafe_execute here

cleanup

[calendar view] fix related to the date_range mess (max value exclusion). Calendar views authors should check if more similar fixes needed

[forms] fix RelationField bug with pending eids (eg inlined forms): we have to override process_form_value to avoid caching when recomputing is needed

[shell] rql() should use unsafe_execute when possible

[autoform] we should consider role when checking delete permission

don't update modification_date in repairing_mode (eg upgrade or shell)

[security] we should save back edited_attributes in case of multiple modification of an entity during the same transaction

tune startup logging

[schema] fix RelationSchema.has_perm to properly works with attribute relations

[schema] refactor/cleanup check_permissions

use a close_form method for consistency w/ open_form and allow overriding

add version info to deprecation warning

remove debug print

follow yams api change: attributes permissions are now defined for an 'update' action, no more 'add' / 'delete' which makes no sense in such case. fix afs.relations_by_section permissions checking of object relation on the way.

fix dumb name error causing error when non managers try to change his properties

fix typo in deprecation warning

remove crappy basket specific code

[views] toolbox must be rendered before the title to appear at top right

[uicfg] make deprecation message easier to understand

[uicfg] allow autoform_section's formtype parameter to be a tuple Typical usage is: afs.tag_attribute(('X', 'y'), formtype=('main', 'muledit'), section='attributes')

merge

branch oldstable

create oldstable branch, remove 3.5 tag

merge 3.6 default/stable

merge 3.5/stable heads

Added tag 3.5 for changeset a0571ff0cb5d

[http cache/json controller] ensure json_view does proper cache validation #390986

merge

typo fix in help string

use subprocess instead of os.popen to run diff this avoids argument quoting issues (spaces in path, etc)

[migration] abort becomes possible when asked for confirmation before migration script

sort on sortvalue, not dc_title to allow customization

merge

fix bug when value is None

Added tag cubicweb-debian-version-3.6.0-1 for changeset 17e88f2485d1

Added tag cubicweb-version-3.6.0 for changeset 5f957e351b0a

added jquery.ui image files

provides a fallback_on_none_attribute field attribute, allowing to specify default value for attributes of *existing* entities

fix match_transition selector: for instance w/ forge version change state form overiding, we want the form with the publication_date selected by the editcontroller, whatever the transition

split introduced in the wrong place

packaging fix: no more test in common (2).

packaging fix: no more test in common. Should remove test from the hooks subpackage in rules for hardy

drop cubicweb-client package (there was only hercule.py inside)

remove ref to hercule.py

cw 3.6, itself

i18nupdate

i18n msg fix

cleanup 2.5 __future__ imports

update translatable docstring

fix test

rephrase

fix auto-rollback on unauthorized error: * don't rollback if a commit is processing * don't free pool on rollback

fix ldap test, our ldap server name has changed

fix name error introduced by bad merging of stable

fix 'click here to see the created entity' link, which may not appear according to language settings

quick fix for typed formfield validation: accept empty string, split

[R] devtools: improve default data import mechanism Validation chain is now possible with checkers Before that the expected values needed to be coherent. Now, we can use ObjectStore to validate the input data * add new input transformers: - uppercase - lowercase * add new input checkers (raise AssertionError on error): - decimal: take care of possible comma character as number separator - integer: cast to int() - yesno: to validate boolean value - isalpha - required: input value *must* not be empty * new control checker: - optional: block possible exception we delete field in the returned dict instead of raising AssertionError (exclusive with required) Helper methods to manipulate indexes: * build_rqlindex() is used to build index based on already created entities * fetch() replace get_one()/get_many() methods by factorizing code Minor changes in reporting: * use tell() for all printing * let new value for askerrors to display automatically the report (used in crontab)

merge

backport stable branch

[cw-shell] do not set arbitrary limit on number of arguments

use 'edit' as defaut path for expect_redirect_publish

propagation hooks cleanup

missing import for 2.4 compat

don't play with the custom_workflow relation in autofill

fix bug w/ object relation used as inlined form

cleanup

backport stable

turn down some info logs into debug

turn down some info logs into debug

fix constraint hook: a session may be involved in multiple transaction at time

fix and begin to document autofill algorithm

unset_attribute_storage, for testing purpose at least

oops

backport stable

when no context specified, should return non-zero score as documented

typo

no need for a specific vid argument here

backport stable

merge

merge

add a note about modifying read only attribute cf. syt's commit message in 81021d62138f

merge

use calendar.gmtime instead of time.mktime to avoid UTC/localtime issues with Flot This is suggested by the Flot documentation on http://people.iola.dk/olau/flot/API.txt

must use in-place modification, pending_operations is a read-only property

avoid to see the same warning twice, one for 3.6 another for 3.3

backport stable

fix session's commit handling: when an operation failed in [pre]commit, call rollback_event as well for already processed operation, not only the revert<event> callback

race condition may makes this assertion fail, we don't want that

unvisible field may have been modified, for instance relation added by an hidden input

AdaptedList -> SameETypeList *NO BW COMPAT*, benefit from cw 3.6 releasing of folder,file and blog which use it to get update at the same time. CMHN and PEGASE will need update (but won't go to 3.6 without update, so seem fine).

now raise UnknownProperty, not KeyError

fix test broken by introduction of ViewSameEType action

kill register_appobject_class method, simplifying autoregistration. Update test accordingly (test which manually registers object should also properly call there __register__ method). Drop the disable-appobjects config file entry: no one used it since its introduction years ago.

backport stable branch and some vreg cleanups: * move initialization_completed from cwvreg to base VRegistry class allowing simplification of CWVregistry * cleanup initialization process: __registered__ is now called after initialization completed, by the relevant registry. * fix/remove deprecated tests

fix security issue #36564 (integrity error w/ RQLUniqueConstraint) by using a global lock serializing commit when some RQLUniqueConstraint is encountered.

errors on postcommit should never occurs, log it as critical

missing test data

reminder, cleanup

initialize property once initialization has been fully completed, close #666573

fix duplicated vregistry initialization during tests

cleanup, don't fail if no context set on the sourcecode directive

we should not use inheritance there but proper view redirection, so if one adapt listitem view, he gets the same thing by default with the adapted list

hidden usage of datetime function which has been moved to lgc

i18nupdate

replace DevCubeConfiguration/DevDepsConfiguration by a single DevConfiguration, fixing recently introduced by w/ i18ncube command on the way

moved to lgc.date as well

oops, forgot that part of 3.2 bw compat

hercule (aka c-c client command) have not (ever?) been used for years, stop supporting it

kill most pre 3.2 bw compat code

kill mx compat code (dropped since 3.2), more efficient merge_args implementation

this test is now useless here

3.6 test api update

db fill api has changed, update test accordingly

no needs for a views package, 3.6 api update

need post_build_callbacks attribute with earlier yams version

update yams/rql dependencies

fix long-waiting symetric typo: should be spelled symmetric. Add auto database migration on schema deserialization

moved generic datetime manipulation function to lgc

fix wrong autoclass inclusion

fix rest syntax error

more selectors doc in the book, mostly extracted from code

reorganize, cleanup and properly document base selectors. Kill the may_add_relation selector.

3.6 api update

clear rest_path __unique cache in clear_all_caches, fix related test

backport stable

copy back __doc__ for proper sphinx doc generation

mimick actual request set_header method

fix typo

[views/treeview] fix non-ITree nodes last element computation

[request] add a note about the encoding mgmt (or lack thereof)

[views/plot] replace bogus jsoncall computation by something (statistically) more reliable (json_request being set to True in the JSoncontroller

[doc] small fixes on security part

misc typos found on my way: NameError / SyntaxError / double __select__, <sigh ...>

fix bad rest

fix bad rest

more details on selectors debugging

add_state/add_transition are now deprecated, only add_workflow remaining

damn me, more stupid sed fix...

add note telling you don't et an UStreamIO for binary views

document the ~ operator

start documenting forms

fix stupid sed

moved content to the dbapi section

nicer docstring

live-server doesn't work, don't make think it does

more stuff in doc's README

update exemples using the 3.6 api and add/fix some sections (schema, vreg, talk about CW_MODE in concepts...). So much to do :'(

backport stable

discriminate against None, not False-ish values

Improve the schema command with filtering option. meta data and workflow data are hidden by default. show-meta and show-workflow option are added to display them. Another "hide-type" option allow to hide additional entities type.

Added tag cubicweb-debian-version-3.5.12-1 for changeset 4281e1e2d76b

Added tag cubicweb-version-3.5.12 for changeset 98af3d02b83e

Updated CW tutorial. * Summarized the list of steps to create a new cube. * Added a subsection on writing entities. * Added a subsection on modifying the schema and updating the corresponding instance.

le patch added_tips a été importé

le patch admin_tips_for_backup a été importé

Add a ``schema`` command to cmd ctrl to generate schema image. This changeset add the new commande and do some refactoring in cwconfig and schema.py to allow the use of CubicWebNoAppConfiguration with CubicWebSchemaLoader.

fix rset.related_entity with variables coming from subquery while some others not

3.5.12

cleanup

fix spurious http cache bug: sometimes last-modified headers is generated using non-english local, which ends up in a date that twisted can't parse and make it feels the page may be cached while it may not

simpler last_modified implementation

merge

fetch all forms, avoid potential initialization pb

missing jsonize, avoid spurious error w/ ff

refactor to use the 3.6 API

merge

merge

partial backport of support for adbh's new interface to backup_command and restore_command these methods can return lists or strings which are passed to subprocess.call without or with the shell=True parameter respectively.

more escapes for the backslashes

escape the backslashes

bugfix

add action to list entities of the CWEType currently displayed

should take arbitrary arguments

i18nupdate

calling unicode instead of gettext...

[entity] small optimization: once an entity has been completed, don't redo it (for nothing)

[treeview] ensure items are ordered according to their dc_title, we can't rely on an ordered rset * is_last has to be computed on the caller now, not possible in the callee * rely on b3f61c38526b to use entity.view() with vid in *view*'s arguments

[entity] rename vid argument of .view(...) into __vid to avoid potential conflicts with kwargs

eschema view is gone away

remove misnamed argument

add version number to deprecation warning

[entities] fix CWUser.is_in_group implementation use self.groups property instead of self._groups which might not be initialized.

missing import

must check for relation inlined in main form type

skip final relations at this point

add missing errno import in etwist/server.py

should not raise KeyError if key's missing

choices function should now take the field as argument

cleanup

missing import

systematically call bool on BooleanField values

by default this is not the widget responsability to turn empty string into None, move this behaviour to the field.

ensure we get a correct key

test fixes

useless, same as test_nonregr_eetype_etype_editing

[forms] propagate aguments given to .vocabulary to .choices if it's a callable. So we can properly uses vocabulary(limit=xxx) in places where we used to call .choices(limit), since field.choices is not meant to be accessed directly. Also, document expected behaviour for custom choices method for relation fields.

reorganize code: move everything related to inlined forms and generic relation from editviews/editforms where there are used, eg in autoforms

[forms] fix backward compat for field.choices arguments

use field.vocabulary instead of field.choices, skip already related eids. Also consider vocabulary when no etype specified

[primary view] activate toolbox

it seems that prefixiter is expected to return child *folder* but was relying on a specific .children implementation, fix this

3.6 api update, cleanup

[forms] let the autoform specify the generic relation field label, no need for a custom fieldset, may be handled as for other fields by the renderer.

simplify messages used for inlined forms

should have been in previous commit (moved below in the module)

[forms] the last touch: handle inlined relation forms as fields by introducing a simple InlinedRelationField. This makese things more flexible while removing a lost of overriding necessary.

fix label handling: when label is explicitly set to None, don't try to guess it

surrounding div necessary for proper error localization

cleanup base class

by default use new jquery widgets for Time/Date/DateTime fields

new jquery based widgets for Time/Date/DateTime, backported from crm

introduce a default render implementation on the base widget, which add_media and then call the newly introduced method _render(form, field, formrenderer), abstract of the base widget class. This allow a litle code factorisation and avoid to forget the call to add_media in subclasses.

[forms] new optional suffix attribute on widget objects, used to generage input name / dom id. Ease reuse of widgets from another widget. Also move base values computing to a separated values(form, field) method.

introduce new _ensure_correctly_typed method on fields, responsible to ensure the value return by the widget is suitable for that kind of field. Also factorize date and time fields.

fix typed_value implementation w/ eidparam field which are actual entity's relation and have .value set for their initial value

cleanup module namespace but only importing the formwidgets module

fix deprecation warnings

fif inlined relation forms pb w/ new ajax forms. We've to ensure the varmaker is properly initialized when generating a form where we may add new subentities, which will use ajax call to generate the subform while this subform expect a varmaker to be set.

now that we are property initializing autoform_section for the 'inlined' form type, use it...

[uicfg] fix autoform_section rtags initialization 1. when a relation is marked as inlined in the 'main' form type, we want its opposite (eg when one the other side of the relation) to be marked as hidden in the 'inlined' form type 2. when no section is specified for the 'inlined' form type, use the same as in the 'main' form type to do this properly, we need two initialization stages. The first one to handle 1., the second to handle what was done before and 2. We can't do this in a single stage because we've to know the bare value of the "opposite" tag.

cache result of the COUNT query used to see if a non unique attribute may be used as rest path on the entity instance to avoid recomputing it later

incontext view of EmailAddress is a mailto: link

add CWProperty for_user CWUser when on the user primary view

move CWProperty rtags from autoform to cwproperties module.

fix Bytes submission pb on POST, due to multiple call to field.process_form_value for a same field. In the case of file, stream.read() doesn't return file's data the second time (since the cursor is at the end of the file). Fix this by having a generic process_form_value method that cache field's value in form.formvalues[field] and so _process_form_value is only called once. You should then override that later method on custom fields.

must skip internal field value from the generic relations combobox

case where 'w' argument is None should be handled in do_paginate

[uicfg] clean dead code, fix indexview_etype_section for ExternalUri and Bookmark

[uicfg] fix reloading pb with the indexview_etype_section

must catch UnmodifiedField exception in has_been_modified

command may now officially be either a string or a list, don't make think it's for backward compat

nicer usage for cubicweb-ctl

get back iterparents implementation from folder cubes

eschema view has been removed

[bfss] make it works when adding/updating entities with an attribute using bfss

d-t-w

fix copyright

XXX quick fix html validation by removing <canvas>

skil internal field value, else we get an error

add source in backup/restore failure message

introduced dependency to lgc > 0.47 for new stacklevel argument to deprecated + new db backup/restore api

handle lgc.adbh api changes within regards of backup/restore: * new backup_commands method instead of backup_command * some backend still return command as string as expected by os.system, not subprocess.call

match_rtype hook selector now accepts frometypes/toetypes optional arguments to match only given subject/object entity types

a selector MUST NO return None

some fixes so that deprecation warning are properly localized

to ease overriding of field.choices using *function* (set using autoform_field_kwargs), give the field as named argument

refactor attributes'value generator to deal with yams special Attribute/NOW/TODAY values that may be used on [Interval]BoundConstraint (BoundConstraint wasn't handled btw, fix this). Besides passing 'entity' to generate_* function (needed to get value for another attribute when computing one for instance): * set nicer method names and makes clearer what's private/protected/public * properly handle choices, constraints on float/date/datetime fields

backport stable

backport stable

3.6 api update

[vreg] object_by_id should not have been deprecated. Fix facets. it was *designed* to be able to force an object retreival when selection is potentially not possible. For instance using select instead of object_by_id in get_facet totally breaks the implementation since in get_facet we've not context result set, and we ends up with a NoSelectableObject exception.

fix stupid typo ...

fix condition to paginate a result set

make rollback available in shell (as commit is)

add a reminder

fix indentation / tab pbs

fix name error

add approximated version number to deprecation warning

oops, missing return

we need extrapath when trying to import site_cubicweb files

move extra path computing as a configuration class property so we can reused it

first draft for a simple hooks based custom attribute storage, with a BytesFileSystemStorage POC implementation. Basically: * a dictionary contains maps from which attribute of which entity types are mapped to which custom storage * hooks check for one of these entity type being added/modified/deleted * read is based on the sql generator callback mecanism (used in vcsfile for instance) * all storages have the same basic interface (read, add, update, delete), and should be pluggable in a transparent way (except at migration time when one want to change from a storage to another) * the sample BytesFileSystemStorage: * may store Bytes attributes content of any entity type as file on the file system * is based on one FSPATH rql/sql function and another _fsopen only available in sql * has a dumb file name allocation algorithm

d-t-w

closes #345410: two_lines_rset, two_cols_rset, two_etypes_rset are badly named replaced by multi_lines_rset, multi_columns_rset, multi_etypes_rset, all taking optional 'nb' argument allowing to specify and exact count. Bw compat is kept, usage of deprecated function updated in cw itself. Also drop custom at_least_two_columns selector (in views.plots) since it was the same as multi_columns_rset. Hopefuly the renaming will help in avoid such pb... We should now decide if we want to deprecate one_* selector in favor of multi_*(nb=1). See note on this at then end of selectors.py

fix #636936: read_permission relation should not be mandatory

fix #615848: undefined 'new' variable was refering to the newly introduced subquery / remove_subquery doesn't take an undefine argument (probable copy/paste from the remove_node call)

some docstring

[doc] reformulate dependencies

[views] FinalView should display an empty string if value is None

merge

move base form renderer label handling into a function to reuse it in CompositeFormRenderer and avoid seeing a tuple in column headers...

minor schema deserialization optimizations

oopb, widget has been renamed

specify formvid=edition to get multiple edition working w/ 3.6

reminder

this clutter startup screen for little benefit, remove it

update copyright

move bookmark related uicfg stuff into bookmark specific module, use the EditableURLWidget widget for Bookmark.path

new field's responsibility POC: EditableURLWidget allow to edit Bookmark.path in two separated fields, displaying unquoted values which are requoted on form post processing

refactor field's value retreiving from the widget (eg 'display value' concept): * kill field's display_value method, since getting value specified in a previous post or in req.form should be the widget responsibility (the widget nows what inputs to display, not the field) * new typed_value / format_value on widgets, mainly to ease overriding

dom_id now accepts a suffix argument as input_name

cleaner input_name implementation

when the vregistry is initialized, no need to call vreg.set_schema (else we trigger appobjects registration twice. This allows significant startup speedup.

new url_parse_qs method on base request to parse unicode url formatted query strings

merge

enable cubicweb-ctl db-dump and db-restore on Windows with SQL Server os.system has some issues on Windows, especially regarding whitespace handling, which subprocess handles correctly.

3.6 api update

merge

allow control of generic relations field display through display_fields

no self._cw on widget objects while '_' is defined locally

delete remaining stuff w/ handling of the generic relations

test update

clear vreg's parent_classes cache to fix etype cache / auto-reloading bug EtypeRegistry.parent_classes()'s is cached. When the registry is reloaded, if the cache is not cleared, we might get the old list of parent classes and that leads to strange bugs. Typical scenario : 1/ start application in debug mode 2/ go to add/Bookmark -> everything's fine 3/ change the source 4/ reload add/Bookmark -> 'creation' not selectable because : a/ cw detects a change in the source and reloads vreg b/ cw tries to select 'creation' view for 'Bookmark' - 'creation' view uses specified_etype_implements('Any') - cw compares Bookmark.__bases__[0] (i.e. new version of AnyEntity) with the old version of AnyEntity cached in the vreg. They don't match => view is not applicable.

merge

fix bad indent

backport stable

cleanup

fix bug: the 'table' argument is overwritten by the loop variable, causing latter crash due to this missing information

don't record deambiguifier when it has no type restriction using 'is', so we don't miss later some available constraints

fix warning stack level

cw 3.6 api update

merge

merge

more input/button fixes

backport stable

cleanup

turn all the stuff used to handle 'generic relations' in forms into proper field / widget. -> regroup code from web.request, web.controller, web.views.autoform, web.views.formrenderers, web.views.editcontroller (!) into GenericRelationsField, GenericRelationsWidget in the editviews module (together with the UnrelatedDiv view). So: * almost everything in one place * no more specific behaviour in the form renderer * almost no custom behaviour in autoform (simply add the field when it think it should) Also, the form renderer now display field's value with colspan=2 when field.label is None.

fix tests

[rql2sql] added test that shows crash during sql generation Original query in cubicweb-drh: Any A,E,CV,group_concat(TN) GROUPBY A,E,CV WHERE A is Application, A for_person P, P has_studied_in E?, T? tags A, T name TN, A curriculum CV? Corresponding bug in tracker: #628798

apply patch proposed by 2web to properly remove hidden input set to represent the button used to submit the form, so forms may be properly reused after a post

fix dumb name error

missing import

remove input from jquery filter, so it works as well with buttons

unicode(arg) else we may get some encoding exception

remove deprecation warnings + name error

remove common/test/data directory from __pkginfo__, MANIFEST and debian rules to allow cubicweb installation

fix syntax error

test fixes

3.6 api update

update selectors.py: change entity.schema with entity._cw.vreg.schema

merge

we should access to __regid__ instead of id since in that case bw compat fail: access to id throuhg a class returns the property object instead of calling the property's method

fix autoform_is_inlined bw compat

[forms] fix implementation of backward compat method form_render previous implemtation used form_default_renderer() which is now replaced by default_renderer()

inherit from FieldWidget to inherit from the process_field_data required by the edit controller

with cw 3.6 we've to specify entity's relation role

fix bad merge

import uicfg.auto_form doc

update i18n doc

Fix element tree import for python2.4

forgotten buffer

backport stable branch

fix pb with bytes field processing: currently when an existing file is edited and no new file is specified, it finds no value in req.form and so try to detach the current file, which is wrong. In that case, nothing should be done. So introduce a new UnmodifiedField exception that may be raised in field's process_form_value method (catched in field.process_posted).

fix NameError

don't call handle_inlined_relation where we're not on the relation'subject

don't add another _cw_edited_field hidden when build_context is called twice (may occurs with inlined relation forms)

cleanup

don't use matching_groups() for is_in_group implementation

a few french translation typo corrections

rename need_navigation into paginable paginable has been recently introduced by changeset d4eeaf0393e2. We already had the need_navigation attribute to control the same thing (pagination). As paginable sounds like a better name, deprecates need_navigation (bw compat ok). Also: * fix main pagination functions responsability * deprecate limit_rset_using_nav in favor of paginate/do_paginate * navigation module should be renamed to pagination at some point

backport tracker permission utility functions into the cw.schemas package

Backed out changeset b8ea99f5e8ea, tags.a escape its content.

fix dumb name errors

fix global errors display when there is more than one error

fix error key / field input detection (field's name include -role when specified, the error key *may* include it

missing xml escapes (but textoutofcontext probably ought to be just outofcontext, with no escaping then)

3.6 api update

move autoform's field_by_name implementation on base EntityFieldsForm

specify name *and* role when raising FieldNotFound helps debugging

if specified, benefit from target_etype information in the [partial_]add_relation selector

ouch, has_perm was always returning False...

more 3.6 api update

iirk reminder

3.6 api update

has_been_modified shouldn't raise ProcessFormError

related entities are returned as tuple since a few months ago

should skip INTERNAL_FIELD_VALUE

should use a set for pending fields

fix process_form_values: we should handle value errors and properly raise ProcessFormError

refactor form error handling: * almost everything is in the base form class, with other form errors related code * deprecate form_field_error in favor of field_error and format_error on the renderer * fix pb with js localization of errors by properly using field.role_name() * rename 'errors' into 'error' in forminfo to avoid confusion

new DBG_ALL debug level

return localized message on parse_datetime errors

raising ConfigurationError is cleaner; remove some unused imports

[javascript] upgrade excanvas.js (rev. M3, mars 2009): this fixes plot widgets rendering in IE

do not attempt to daemonize under windows

[cwctl] reset-admin-pwd was failing when db-host was not set

[javascript] IE doesn't support dynamic enctype modification, we have to set encoding too

[forms] make it easier to override CWProperty form buttons

[forms] make it easier to override StringField's mininum size

[skeleton] remove unused os.path.dirname import, use dname instead of dirname as an additional safetly belt

[web/views] if view has attribute paginable=False, do not try to paginate it

update copyright: welcome 2010

[views] backport progressbar template from shingouz

[forms] fix multiple edit bug introduced by changeset cebdf8ee5ad7 Changeset cebdf8ee5ad7 assumed that edited entity was either explicitly passed to the form or found in first row / first col of the resultset because of the one_line_rset() selector. But one_line_rset() is actually trickier : the selector returns 1 if the resultset has more than one row **if** an explicit row is specified during selection process. This is exactly what is done in the 'muledit' form : for row in xrange(len(self.rset)): form = self.vreg['forms'].select('edition', self.req, rset=self.rset, row=row, #... This changeset thus takes row in consideration to find edited entity if 'row' was explcitly specified.

do not recompute the plot on subsequent onload events #615338

fix stripEmptyTextNodes for IE (part of #615337) this does not seem to make the function really work but it does not fail any more

[javascript] upgrade jquery.flot.js to v0.6 to fix IE6-related bugs

[forms] edited_entity must be set before calling session_key() EntityFieldsForm.__init__ calls FieldsForm.__init__ which in turn calls self.session_key(). self.session_key() uses self.edited_key to compute the correct session key. We thus need edited_entity to be set **before** calling super's __init__. The bug only occured when EntityFieldsForm was selected because of its one_line_rset() selector instead of match_kwargs('entity').

must escape user_rql_callback

backport stable branch

Added tag cubicweb-debian-version-3.5.11-1 for changeset 4920121d41f2

Added tag cubicweb-version-3.5.11 for changeset f48b2f193961

3.5.11

i18nupdate

must now properly use Binary for password (see 4180:42247d70105b). XXX Though this is somewhat backend related (eg store password using a binary type), this should be either well document or handled properly in the db helper.

TYPE_MAPPING expected to be a mapping from yams type to db type, and timestamp is the Datetime yams type

quick and dirty fix to avoid crash when running db-create command with an sqlite source

add es.po to default skel, closes #591625

closes #601987 1) sqlutils.restore_from_file have to use its confirm argument when a command fail, to propose to continue there (this can't be handled by the caller) 2) source.restore method hence needs to take this confirmation callback as argument 3) properly fix places where 'drop' was given instead of 'confirm'

missing one litle char

closes #607344 by simply appending '/' to base url if necessary instead of insulting the user

cleanup

test update. All cw tests OK

fix bad merge

make groupmap argument optional / sort for testing purpose

fix virtual relation detection: erschema is no more a relation type but a relation def in _synchronize_permissions

necessary to fix some security test, unclear why did I set perms below at some point...

import cleanup, check data file exists

should turn password into a Binary properly

should not simplify previous to preprocess

use ._cw instead of .req (reintroduced by merge of stable)

oops

backport stable

more extra_args cleanup

only give extra_args if there is something to be fed (breaks some db connectors otherwise)

merge

SqlServer: support single sign on / Windows credential authentication This is done through a new db-extra-arguments section in instance_dir/sources which is passed as a string to the extra_args named argument of lgc.db.get_connection. If this argument is Trusted_Connection, windows authentication is used instead of login/password. This change requires at least revision 5475ec3f6412 of logilab.common which will be included in logilab-common 0.46. debian/control updated to mention this new dependency.

SQL Server port: convert Password to Binary This conversion is required because pyodbc uses buffers for Binary fields and won't be able to cast a string/unicode value to the db VARBINARY column type otherwise.

[javascript] cleanup, remove tabs

[javascript] remove ajaxHtmlHead from dom response once it has been processed. This fixes #549138: treeview: folding is broken The new, systematic, pageid management (introduced by rev 37b376bb4088) made the treeview return : <ul class="treeview">...</ul> <div class="ajaxHtmlHead">...</div> which was then processed by getDomFromResponse and wrapped into a single div node : <div> <ul class="treeview">...</ul> <div class="ajaxHtmlHead">...</div> </div> In the treeview case, the node inserted into the tree was the wrapping <div> instead of the <ul>, causing the folding bug mentioned in the ticket.

msg isn't defined there, but we've to give traceback information to record error

all web tests OK

make new editcontroller works, based on a _cw_edited_fields hidden input

crecord introduced junk...

strip string by default

nicer StringField __init__

fix render (formerly form_render) prototype

process_posted yield field instead of field's name

proper field's role handling: may be 'subject' / 'object' *in case of entity's relation*, but None in other case. So you should correctly specify it to field_by_name

form_add_hidden -> add_hidden form_needs_multipart -> needs_multipart

substitute _render_attrs by values_and_attributes method, keeping bw compat

replace form_field_[encoding|vocabulary] methods on form by encoding|vocabylary(form) methods on fields

refactor vocabulary handling to avoid having to define methods on form objects, use .choices instead even for non final relations. Details: * deprecated support of <role>_<relation>_vocabulary methods on forms * new utility functions for relations vocabulary * most logic now on the RelationField class

cleanup

refactor form field value handling, to get a nicer api and an easier algorithm to get field's value Details: * new .typed_value / .display_value on fields * droped form_field_value on form * .value attribute of field instead of .initial * nicer field's __init__, allowing to give a lambda as value's value

missing imports

yams api update

drop form_field_name/form_field_id methods from form object, in favor of field.input_name(form) / field.dom_id(form)

NothingToEdit is not a ValidationError, simplify

fix translation of message to view newly created entity: must be done once language is set...

accord avec 'entité'

new catch_error context manager, nicer controller __init__ and new iter_and_commit(datakey) method

this bw compat doesn't work, drop it

don't try to write .row/.col, use new cw_row/cw_col attributes

etype_class('Any') should return bare 'Any' class

cubicweb security #36257: les urls /add/EntityName sont accessibles en anonyme

3.6 remove deprecation warning

Improve warning message

[mq]: fix_es_po_file_creation

[mq]: plural_display_name_fix

[mq]: doc

Add the search javascript to the html layout

improve error message

tweaks output

oops

clearer api: distinguish app_publish / ctrl_publish

override publisher's error handler to ease debugging

dataimport refactoring / improvments, keeping bw compat (for now)

look for cubicweb-ctl plugins in the ccplugin.py file, keeping bw compat on ecplugin.py

check entity has an eid before using absolute_url

force_session_key default to None in base form class...

fix mainvars detection bug with EXISTS (paren, actually)

call super class if choices specified to get std behaviour

merge

check name changed first

no 3.6 code in 3.5...

merge

make cubicweb-ctl db-init -d work with postgresql backend

merge

fix backout

merge

fix NameError

backout a75a6e770717, unmeetable condition and introduce a bug with boolean values

load site_cubicweb as a module instead of execing it, avoid reimport pbs

fix name error

quick and dirty fix trying to avoid rest directive conflicts when using sphinx (which seems to import the code)

merge

oops

merge

Passwords need to be considered as binary fields

TIMESTAMP column type has a special meaning for SQLServer, avoid using it for that driver (with help from logilab.common.adbh)

merge

use edited_attributes and uniformize attribute schema retreival

[mq]: fix_for_forms

fix deprecation warning

schema view fix

disable everything but metadata hooks while inserting schema

more advanced hooks control

fix 3.6 bug

[mq]: small_api_changes_for_3.6

yams api update

missing underscore leads to infinite recursion error

[mq]: fix_typo_and_forms

api update

yams api update

[i18n] use named substitutions for proper localization

remove redundant line

update sys.path at cubicweb startup

changed log severity from critical to info if a plugin cannot be loaded

fix non-xml_escaped url in box

nicer fix

avoid failure by simply not displaying this section for now"

rschema doesn't have may_have_permission

shouldn't be called from here

typos, api update

don't use setdefault with a tuple as value, a set is expected

api update

add hook selector

api update again

more api update

3.6 api update

3.6 api update

avoid infinite recursion error

test fixes

check a permission has been specified first...

api update

missing role argument

no more handled by the renderer

use implements instead of entity_implements

merge

cw 3.6 api update

some api update

deprecates entity_implements / but_etype selectors

fix initargs handling

fix guess_field to handle non internationalizable definition

perms are now held by the relation definition

password should now be named

__cmp__ should *NOT* return False when different

explain how to run as a windows service

be able to run cw instances as windows services

merge

oops, bad indent

backport stable

should not xml_escape rql

backport stable

properly escape arguments of user callbacks

new rset argument

api update

test update

fix infered rdef propagation

more api update

yams api update

move hook tests to hooks package tests

should use match_rtype, not entity_implements in such cases

3.5 api update

had been involontarly dropped

cw 3.6 api update

add a dummy and stupid dummy method for dummy form

cw 3.6 api update

card referenced later

give group mapping where needed

3.6 api update

fix sync_schema*: new syncprops argument to sync relation definition as well

Update generic RQL Based Constraints and RQLUniqueConstraint doc

fix class reference in old hook warning

merge

[mq]: typo

[mq]: fix_set_addition

Update generic RQL Based Constraints and RQLUniqueConstraint doc

fix class reference in old hook warning

missing groupmap propagation to rschema2rql

Update generic RQL Based Constraints and RQLUniqueConstraint doc

test api update

remove debug print, fix error message

missing mainvars

missing cache key

duh???

add regid when tracing selection

duh???

more api update