Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Oct 2013 11:07:57 +0200] rev 9308
Added tag cubicweb-centos-version-3.17.10-1, cubicweb-version-3.17.10, cubicweb-debian-version-3.17.10-1 for changeset fe0e1863a137
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Oct 2013 17:24:19 +0200] rev 9307
[pkg] prepare 3.17.10
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Oct 2013 10:02:29 +0200] rev 9306
[web] don't rename resources in gen-static-datadir
We should use the result from WebConfiguration.locate_resource to know
which file to copy, not what name to copy it to. The destination file
should be the name of the resource, as the client will request it.
This matters in the case of cubicweb.css which locate_resource might
rewrite to cubicweb.old.css.
Closes #3206129
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Oct 2013 14:18:58 +0200] rev 9305
[notification] avoid leaking cnxsets (closes #3243810)
When sending notifications, we get each recipient as either an email
address or a CWUser. In the latter case, we create a temporary session
for that user and use it to send the mail. However, if we later decided
to not send the mail after all, we'd leak the session and its cnxset.
Add a try block inside the loop to make sure the temporary sessions are
closed properly.
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Tue, 22 Oct 2013 11:59:39 +0200] rev 9304
[book] English fix
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 08 Oct 2013 14:25:05 +0200] rev 9303
[serverctl] complete the schema-diff command with options that will fix & enhance it.
Notably:
- filter out eids (doesn't make sense for the filesystem schema)
- handle permissions, trying to detect the default ones
Needs yams #174042.
Closes #2996547.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 18 Oct 2013 16:58:48 +0200] rev 9302
[server] deprecate the old multi-source system
It is removed in 3.19.
Closes #2919299
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Oct 2013 16:04:23 +0200] rev 9301
[doc] document changed attribute default value storage
Julien Cristau <julien.cristau@logilab.fr> [Mon, 16 Sep 2013 11:58:40 +0200] rev 9300
defaultval migration for sqlite
Aurélien Campeas <aurelien.campeas@logilab.fr> [Fri, 23 Aug 2013 15:06:27 +0200] rev 9299
[schema] store default attribute values in a Bytes field, allowing python objects as default values
Notes:
* Binary objects grow two methods
* we depend on a newer yams version
* the code is quite simplified as a result of the whole change
* a very old and nasty bug where bool(default values) evaluating to
False not being properly migrated is killed
Closes #2414591.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 17 Oct 2013 16:30:53 +0200] rev 9298
[source/native] fix sqlserver pattern matcher for unique constraints (closes #3227593)
The matcher is used to parse the low-level error message and extract
meaningful information for the end users.
If broken, the users see an alarming and bewildering message.
A full & definitive fix is scheduled for CubicWeb 3.18.
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 17 Oct 2013 10:30:35 +0200] rev 9297
[dbapi] Fix broken inmemory:// URLs parsing (closes #3225832)
ParseResult.path is what comes after the "domain name" in standard URLs.
So in the case of 'inmemory://<instance' URLs, it is always empty.
ParseResult.netloc contains the "domain name" part that we really want.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 17 Oct 2013 11:34:03 +0200] rev 9296
[metadata hook] rename an operation for the sake of readability
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 16 Oct 2013 15:50:04 +0200] rev 9295
[book] Typo fix and rephrasing in devrepo/migration
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Wed, 16 Oct 2013 11:38:06 +0200] rev 9294
[cwshell] rename history file to .cwshell_history (erudi is dead, long live cw)
Aurelien Campeas [Thu, 11 Jul 2013 13:32:27 +0200] rev 9293
[entity] Entity.related(): add a targettypes argument (closes #2957313)
This allows to restrict the entity types returned by the method
(passed to cw_related_rql).
When such an argument is given, no caching happens.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 28 Aug 2013 12:14:20 +0200] rev 9292
[source configuration] silent lgc 0.60 deprecation warning
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Tue, 15 Oct 2013 14:02:22 +0200] rev 9291
[web] remove action "Got Rhythm" (closes #3093362)
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Oct 2013 10:22:21 +0200] rev 9290
[debian] Break old geocoding
It wants cubicweb.interfaces.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 11 Oct 2013 18:02:48 +0200] rev 9289
[wsgi] remove ages old hack to set base_url
Its meaning has been lost in the mist of time.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 11 Oct 2013 18:00:34 +0200] rev 9288
[wsgi] also provide an example using werkzeug (if available)
Related to #3005509.
Aurelien Campeas [Tue, 01 Oct 2013 16:45:58 +0200] rev 9287
[wsgi] add the simplest possible wsgi (debug) server
This server is able to:
* serve on a given port using the stdlib SimpleHTTPServer
* run looping tasks
Closes #3005509.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 10 Oct 2013 13:46:44 +0200] rev 9286
[querier/security] instrument a bit the querier read security checks
Related to #2920304
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 30 Sep 2013 14:48:59 +0200] rev 9285
[book] Improve PostgreSQL configuration section
* Do not advice for specific PostgreSQL version (point to meta-packages if
available in Linux distros);
* First mention packages from Linux distros, put the link to official postgres
documentation at the end;
Closes #2725302.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 08 Oct 2013 14:02:28 +0200] rev 9284
[js] add a selector string escaping function
will help use id strings in jquery selector expressions, e.g:
"foo.[subject]:42" -> "foo\.\[subject\]\:42"
Related to #3154531.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 10 Oct 2013 13:26:11 +0200] rev 9283
[merge] backport stable fixes
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 10 Oct 2013 13:16:54 +0200] rev 9282
[test/ldapsource] backout 192a748550c7 which broke RQL2LDAPFilterTC
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Oct 2013 14:45:36 +0200] rev 9281
[rset] make sure rset.description is always a list
It's more consistent, and avoids pylint warning
"Instance of 'tuple' has no 'append' member"
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Oct 2013 16:30:27 +0200] rev 9280
[schema] edit syntax tree instead of playing with strings for RQLExpressions
Lets us support more complex expressions involving e.g. "HAVING" clauses.
Closes #3202855
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 10 Oct 2013 12:40:23 +0200] rev 9279
[py3k] note about future warning on __eq__ vs __hash__
Closes #3179561.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Oct 2013 12:11:00 +0200] rev 9278
[formfields] py3k kill future compat warning
Related to #3179561.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 10 Oct 2013 12:42:10 +0200] rev 9277
[entity] do not raise an AssertionError if the kwargs given to set_relations/attributes is empty
Regression was introduced in 3.16 with the new cw_set API.
Old set_relations and set_attributes methods did not crash on empty
kwargs.
Closes #3104019.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Oct 2013 12:30:35 +0200] rev 9276
[packaging] setup.py: don't exclude skeleton/debian/* from being installed
Closes #3192725.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Sep 2013 18:42:34 +0200] rev 9275
[tests/hooks/integrity] kill old and empty skipped test
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 09 Oct 2013 17:42:01 +0200] rev 9274
[server/session] demote log to debug
It can pollute the log very fast.
Closes #3203391.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 01 Aug 2013 13:58:48 +0200] rev 9273
[test] use assertCountEqual instead of assertItemsEqual
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Oct 2013 12:30:02 +0200] rev 9272
[server] fix a number of typos, mostly in docstrings
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 07 Oct 2013 15:13:51 +0200] rev 9271
[skeleton] Install cubes README in Debian packages (Closes #3171971)
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 10 Oct 2013 11:23:01 +0200] rev 9270
[debian] Build-Depends on python-unittest2 | python (>= 2.7)
Closes #3175895.
Paul Tonelli <paul.tonelli@logilab.fr> [Thu, 29 Aug 2013 18:28:10 +0200] rev 9269
[doc] typos and reformulation
Paul Tonelli <paul.tonelli@logilab.fr> [Thu, 29 Aug 2013 18:26:06 +0200] rev 9268
[doc] additional documentation about pip install
under both Windows and Debian
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 30 Aug 2013 15:34:58 +0200] rev 9267
spelling: rollbacked -> rolled back
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Oct 2013 12:10:44 +0200] rev 9266
Added tag cubicweb-version-3.17.9, cubicweb-debian-version-3.17.9-1 for changeset 5668d210e49c
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Oct 2013 11:13:56 +0200] rev 9265
merge two default heads
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Oct 2013 18:10:20 +0200] rev 9264
[pkg] prepare 3.17.9
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 20 Sep 2013 15:42:04 +0200] rev 9263
Use the list of sources instead of an iterator in update-feeds looping task
This prevents RuntimeError due to dictionary size change that may occur (as a
result of a new source being added) during iteration.
Closes #3155843.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 08 Oct 2013 16:10:42 +0200] rev 9262
[security] fix dumb attribute error when inserting read security. Closes #3196891
This has gone undetected because of erroneous tests...
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 08 Oct 2013 10:46:06 +0200] rev 9261
[entity] give a default reasonnable __eq__ and __hash__ to Entity
Using the eid.
Closes #3179560.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Oct 2013 18:16:45 +0200] rev 9260
[debian] add some Breaks for backwards compatibility removal
The person and comment cubes used to import the cubicweb.mixins module.
The inlinedit cube relied on String.startsWith in javascript.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 26 Aug 2013 16:16:22 +0200] rev 9259
[js] remove 3.9 bw compat (where apparently unused)
- cubicweb.ajax.js
- loadxhtml: form.callback support removal
- removal of top-level functions: preprocessAjaxLoad, reloadBox,
replacePageChunk, loadxhtml
- cubicweb.compat.js:
- map is undeprecated (jquery.map being not an acceptable
replacement)
- removal of noop, contains, findValue, filter, addElementClass,
removeElementClass, hasElementClass, KEYS mapping
- htmlhelpers.js: use non-deprecated functions cw.urlEncode
- cubicweb.js:
- removal of startsWith and endsWith monkeypatches
- note deprecated but still used stuff (for action)
- test_utils.js: use cw.utils.sliceList instead of global function
Closes #2782004.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 26 Aug 2013 11:36:19 +0200] rev 9258
Rename cleanup_interface_sobjects into cleanup_unused_appobjects
Interfaces are gone in 3.18
Related to #2782004.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 26 Aug 2013 16:15:29 +0200] rev 9257
remove cw 3.9 bw compat (bw compat other than the interface -> adapter changes)
- cwconfig, doc/admin/setup: docstring adjustment wrt 3.9 & virtualenv
- testing/rst: windmill (which is gone from the testing infrastructure)
- other docs: "stuff introduced in 3.9" cleanup, as we don't care
about the version old features were introduced
- server/hooky.py: bw compat for propagation hooks
- server/schemaserial.py: pre CWUniqueTogetherConstraint migration support
- web.__init__.py: dumps bw import
- autoform.py: .action ppty is gone, also deprecate set_action and get_action
- baseviews: CSVView.subvid gone long ago, secondary view removal
- primary.py: _render_attribute & _render_relation signature change
- reledit.py: rvid/default_value bw compat, should_edit_* dropped
- webconfig.py: resourcefile is gone
- formfields.py: old vocabulary handling
- request.py: build_ajax_replace_url, external_resource
Related to #2782004.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 26 Aug 2013 16:14:09 +0200] rev 9256
remove 3.9 bw compat
In cw 3.9, interfaces are deprecated and replaced with adapters,
yielding a lot of bw compat in many places -- most if this patch is
concerned with the interface bw compat
- cwvreg: interface cleanup
- doc/adapters.rst: interface cleanup
- entities/adapters.py, wfobjs.py: interfaces bw compat
- entity.py: interfaces bw compat, also get_value, delete,
attr_metadata, has_perm, set_related_cache, clear_related_cache,
clear_related_cache, related_rql
- predicates.py: score_interfaces & implements
- interfaces.py & mixins.py: 100% gone
- view.py: implement_adapter_compat, unwrap_adapter_compat
- calendar.py, editcontroller.py, ibreadcrumbs.py, navigation.py, xmlrss.py:
interface bw compat
- treeview.py: salvage one function from mixins.py
Related to #2782004.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 26 Aug 2013 16:12:30 +0200] rev 9255
remove 3.8 bw compat
- cwconfig: old keys such as depends_cubes and non-dict dependencies
- cwctl: fall back to docstring if no short descr, forget
'short_descr'
- dbapi: session_data, get_session_data, set_session_data,
del_session_data
- dbapi & testlib, session: eid_key is gone
- migractions: cachekey is gone
- doc/datamodel/definition, schemaserial: BoundConstraint ->
BoundaryConstraint
- formwidgets: separator
- primary view: render_entity_metadata
Related to #2782004.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 04 Oct 2013 17:05:49 +0200] rev 9254
[hooks/security] Defer entity permission checks to an Operation.
Some of these checks may currently happen twice within the same
transaction and be costly.
This should be semantically safe. If people rely on some internal
transaction ordering to be allowed early (thus pass) while the
condition wouldn't be met at precommit time, their application is
broken. It however seems unlikely to happen in the real life (tm).
Closes #2932033
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 04 Oct 2013 15:59:54 +0200] rev 9253
[schema] drop very old bw compat (pre 3.5.10)
Closes #2925085.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 12 Jul 2013 10:50:56 +0200] rev 9252
[devtools,etwist] rename TwistedConfiguration to WebConfigurationBase (follows #2919310)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 12 Jul 2013 10:51:35 +0200] rev 9251
remove "twisted" configuration (closes #2919310)
This was also known as "web only" instances. Not used in production anywhere today.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Oct 2013 14:28:50 +0200] rev 9250
merge 3.17.8 into default
David Douard <david.douard@logilab.fr> [Thu, 03 Oct 2013 15:37:45 +0200] rev 9249
Added tag cubicweb-centos-version-3.17.8-1, cubicweb-version-3.17.8, cubicweb-debian-version-3.17.8-1 for changeset 909eb8b584c4
David Douard <david.douard@logilab.fr> [Thu, 03 Oct 2013 15:13:08 +0200] rev 9248
[pkg] prepare 3.17.8
David Douard <david.douard@logilab.fr> [Thu, 03 Oct 2013 11:10:08 +0200] rev 9247
[date picker] revert #ec65ca70aac9 which breaks the date picker (closes #3182844)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 30 Sep 2013 18:07:51 +0200] rev 9246
[merge] backport 3.17 fixes into the future 3.18
David Douard <david.douard@logilab.fr> [Thu, 26 Sep 2013 19:04:45 +0200] rev 9245
Added tag cubicweb-centos-version-3.17.7-1, cubicweb-version-3.17.7, cubicweb-debian-version-3.17.7-1 for changeset 483181543899
David Douard <david.douard@logilab.fr> [Thu, 26 Sep 2013 15:15:09 +0200] rev 9244
[pkg] prepare 3.17.7
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Sep 2013 15:12:52 +0200] rev 9243
i18n update
David Douard <david.douard@logilab.fr> [Thu, 26 Sep 2013 15:18:59 +0200] rev 9242
fix typos in workflow constraint error messages
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 17 Sep 2013 17:44:15 +0200] rev 9241
[migractions] rschema.final.inlined -> rschema.inlined
Closes #3153086.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 26 Sep 2013 11:53:13 +0200] rev 9240
[server] Make internal sessions not reset 'safe'-ness on first commit
Increment the ctx_count when disabling integrity hooks so the next
commit/rollback doesn't reset our transaction and magically turn us into
a safe session.
Closes #3168027
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 23 Sep 2013 11:13:28 +0200] rev 9239
[facets] Correctly replace old 'edit box' HTML on facet-induced page refresh (closes #3161100)
Julien Cristau <julien.cristau@logilab.fr> [Mon, 23 Sep 2013 15:03:03 +0200] rev 9238
[debian] replace find | xargs rm with find -delete in cube skeleton. Closes #3161797
Julien Cristau <julien.cristau@logilab.fr> [Mon, 23 Sep 2013 15:02:45 +0200] rev 9237
[debian] don't require (fake)root to run the clean target. Closes #3161797
It works just fine as a normal user.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 23 Sep 2013 15:01:59 +0200] rev 9236
[debian] Add ${misc:Depends} to cube packaging skeleton. Closes #3161797
Best current practice is to have that in Depends in all packages using
debhelper.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 06 Sep 2013 11:01:20 +0200] rev 9235
[devtools] fix race when creating backupdir
If somebody else creates backupdir between our stat() and mkdir() (like,
say, another test running in parallel), we shouldn't crash.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 19 Sep 2013 18:11:12 +0200] rev 9234
[staticcontrollers] Raise Forbidden, not Unauthorized
Unauthorized means "log in to get access", as it results in a HTTP 401.
Here, the error is pretty much permanent, and returning 401 instead of
403 confuses things terribly.
(This seems to be a pretty widespread confusion :/)
David Douard <david.douard@logilab.fr> [Thu, 19 Sep 2013 18:03:09 +0200] rev 9233
[web] allow /data/ url again (closes #2464798)
This feature was broken by 65fecbeb9c3a (which fixed another one itself).
Julien Cristau <julien.cristau@logilab.fr> [Mon, 16 Sep 2013 10:59:59 +0200] rev 9232
[utils] fix typos in make_uid docstring
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 28 Aug 2013 17:15:12 +0200] rev 9231
[c-c i18ncubicweb] fix crash, closes #3096647
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 30 Aug 2013 09:57:38 +0200] rev 9230
[rql2sql] fix bad sql generated when outer joining 'identity' relation and lhs var comes from a subquery. Closes #3099418
The generated SQL was attempting to access table.cw_eid which doesn't exist.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 29 Aug 2013 16:21:52 +0200] rev 9229
[web] stop using deprecated StatusResponse. Closes #3098215
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 29 Aug 2013 16:20:33 +0200] rev 9228
[deprecation] add (approximate) version number to deprecation message and set proper stacklevel
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 29 Aug 2013 12:55:27 +0200] rev 9227
[schema] fix spurious warning when rqlexpr/constraint mainvars specify a non predefined variable. Closes #3098165
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Sep 2013 12:47:12 +0200] rev 9226
[repository] properly use IUserFriendlyError when UniqueTogetherError is raised during entity update. Closes #3096638
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 28 Aug 2013 12:08:31 +0200] rev 9225
[deprecation] add cw version number to the deprecation message and help user to understand the change
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 28 Aug 2013 11:56:07 +0200] rev 9224
[datafeed] fix crash due to bad http_timeout handling. Closes #3096585
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 28 Aug 2013 11:36:44 +0200] rev 9223
[date picker widgets] properly distinguish DOM id and input name. Closes #3096575
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 28 Aug 2013 11:29:58 +0200] rev 9222
[date picker widgets] use bare jquery expression rather than jqNode
Julien Cristau <julien.cristau@logilab.fr> [Wed, 12 Jun 2013 12:28:01 +0200] rev 9221
Use return in CnxSetTracker context manager methods
Just in case.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 15 Jul 2013 11:45:37 +0200] rev 9220
[web/views] make PrimaryView.entity_call accept kwargs
It's useful when using this view in a different context to have it not
crash on random arguments.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Sep 2013 12:47:12 +0200] rev 9219
[ldapparser] demote some logs from warning to debug (closes #2713671)
David Douard <david.douard@logilab.fr> [Fri, 09 Aug 2013 10:00:40 +0200] rev 9218
[doc] add a what's new file for 3.18
David Douard <david.douard@logilab.fr> [Wed, 07 Aug 2013 09:02:47 +0200] rev 9217
merge stable in default (3.18) branch
David Douard <david.douard@logilab.fr> [Tue, 06 Aug 2013 16:53:53 +0200] rev 9216
Added tag cubicweb-centos-version-3.17.6-1, cubicweb-version-3.17.6, cubicweb-debian-version-3.17.6-1 for changeset 5b9fedf67a29
David Douard <david.douard@logilab.fr> [Tue, 06 Aug 2013 11:49:33 +0200] rev 9215
[pkg] prepare 3.17.6
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 06 Aug 2013 11:20:07 +0200] rev 9214
Do not use cubicweb-card in rest_path tests
Card overrides the rest_path method, so it does not make sense to use it in cw
tests.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 01 Aug 2013 13:55:11 +0200] rev 9213
[inlined form field] fix regression introduced in 3.16.4/570208f74a84. Closes #3064653
In the above changeset, we changed ordered entities to be edited according to
mandatory inlined constraints, though this leads to unpredictable order in
cases where there are no constraint. This leads to case where inlined relation
field may think there is no value related to a mandatory relation, while this
is simply because there is a value specified but to an entity that will be
created later (together with the relation).
To fix this, we've to use the fact that the RelationField.process_form_value
return None in cases where there is some entity to be created, while an empty
set when there are no linked entity. The new no_value() method allows to
differentiate between those different notion of 'no-value'.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 01 Aug 2013 10:59:52 +0200] rev 9212
[testlib] temporary_appobjects should call __registered__ if it exists. Closes #3064075
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 01 Aug 2013 15:51:22 +0200] rev 9211
[entities] properly escape in EmailAddress.printable_value when format is html. Closes #3064025
David Douard <david.douard@logilab.fr> [Wed, 31 Jul 2013 21:59:13 +0200] rev 9210
Added tag cubicweb-version-3.17.5, cubicweb-debian-version-3.17.5-1, cubicweb-centos-version-3.17.5-1 for changeset 15dd5b37998b
David Douard <david.douard@logilab.fr> [Wed, 31 Jul 2013 16:58:44 +0200] rev 9209
[pkg] prepare 3.17.5
David Douard <david.douard@logilab.fr> [Wed, 31 Jul 2013 14:48:34 +0200] rev 9208
[pkg] fix debian packaging (closes #3058542)
- remove useless Python 2.4 reference,
- simplify dh_install configuration to install files consistently instead of
having half in /usr/lib/pythonXX and half in /usr/share/pyshared,
- incidentally, this makes the package work on squeeze.
Regression from eaa58d1c7d5f
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 31 Jul 2013 16:04:10 +0200] rev 9207
[testing] add missing generate_bigint method to ValueGenerator. Closes #3059327
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 31 Jul 2013 13:56:00 +0200] rev 9206
[rql / querier] fix bad interpretation of some RQL SET query
when some neged relation is involved. Closes #3058527.
David Douard <david.douard@logilab.fr> [Tue, 30 Jul 2013 20:31:57 +0200] rev 9205
merge stable in default (3.18) branch
David Douard <david.douard@logilab.fr> [Tue, 30 Jul 2013 20:12:20 +0200] rev 9204
Added tag cubicweb-version-3.17.4, cubicweb-debian-version-3.17.4-1, cubicweb-centos-version-3.17.4-1 for changeset c7ba8e5d2e45
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 30 Jul 2013 17:09:02 +0200] rev 9203
[i18n] cleanup dead code
also fix small bug introduced in b0f6e8c14e7f
David Douard <david.douard@logilab.fr> [Tue, 30 Jul 2013 16:48:57 +0200] rev 9202
[i18n test] hack to make i18n tests run using a Python interpreter
they used to work fine when executed via pytest only.
This should be removed as soon as logilab.common.registry is fixed.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 30 Jul 2013 10:06:06 +0200] rev 9201
[i18ncube] fix crash due to duplicated messages in generated schema.pot
Add a test case and fix regression introduced in e713c47a993d.
Relates to #2811282
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 30 Jul 2013 10:05:58 +0200] rev 9200
[i18n test] load_po: fix bug in case of multi-lines msgid and ensure there are no duplicated messages
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 30 Jul 2013 08:23:17 +0200] rev 9199
[i18n test] simplify test cube a bit by only providing a views module, no package
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 29 Jul 2013 16:01:18 +0200] rev 9198
[web] consider inlined relations in has_editable_relation. Closes #3049970
In some cases where the user can only add/edit inlined relations (though
actually edit perms of the inlined relation doesn't seem checked), the "modify"
action doesn't appear while it should.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 29 Jul 2013 16:00:40 +0200] rev 9197
[web test] silent 3.13 warning
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 26 Jul 2013 13:47:52 +0200] rev 9196
[editcontrollers] Account for role in the ordering of entities (Complements #3031719)
Only role='object' was correctly accounted for by 570208f74a84
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 25 Jul 2013 18:14:56 +0200] rev 9195
[migration.sync_schema_props_perms] ensure all participants to a unique together constraint are there
before adding CWUniqueConstraint. Closes #3038345
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 25 Jul 2013 18:12:28 +0200] rev 9194
[session commit] save back exception context to avoid potentiel cluttering if some revert operation raise an exception
David Douard <david.douard@logilab.fr> [Mon, 29 Jul 2013 14:22:40 +0200] rev 9193
[pkg] python-central has been removed from Debian
David Douard <david.douard@logilab.fr> [Fri, 26 Jul 2013 09:46:30 +0200] rev 9192
[pkg] prepare 3.17.4
David Douard <david.douard@logilab.fr> [Fri, 26 Jul 2013 09:49:53 +0200] rev 9191
[pkg] merge centos 3.17.1-2 in stable (prepare 3.17.4)
David Douard <david.douard@logilab.fr> [Fri, 26 Jul 2013 09:47:22 +0200] rev 9190
Added tag cubicweb-centos-version-3.17.1-2 for changeset 965f894b63cb
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 25 Jul 2013 09:07:25 +0200] rev 9189
[rqlrewrite] fix rqlrewrite unpredictability vs relation sharing. Closes #3036144
The relations index used to determine if relation may be shared only
considered a single relation node per relation type. So when the same
relation type occurs several time, dict order give unpredictable result.
We shall properly consider all relations instead.
Tentative test case included (but bug reproduction is by definition
unpredictable...)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 24 Jul 2013 16:55:24 +0200] rev 9188
[rqlrewrite] rewrite doesn't need a solutions argument, always use the Select'ones
Also, do a copy systematically else it may lead to empty solutions depending on
the rewrite path.
Test case tentative included in the following changeset.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 24 Jul 2013 16:49:40 +0200] rev 9187
[rql rewrite] equivalent but much simpler flow
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 25 Jul 2013 10:42:33 +0200] rev 9186
[pkg] Prepare a new RPM release
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 25 Jul 2013 10:25:49 +0200] rev 9185
[pkg] Add log directory to rpm
David Douard <david.douard@logilab.fr> [Thu, 25 Jul 2013 08:52:15 +0200] rev 9184
[repo] normalize ValidationError on edited entity (closes #2509729)
In CubicWeb, ValidationError.entity MUST be the eid of the involved entity,
not the entity iteself (as done by yams).
David Douard <david.douard@logilab.fr> [Wed, 24 Jul 2013 13:59:08 +0200] rev 9183
[doc] one must now manipulate the req.session.data dict (closes #2842345)
instead of deprecated get/set/del_session_data methods.
David Douard <david.douard@logilab.fr> [Wed, 24 Jul 2013 08:20:22 +0200] rev 9182
[datafeed] add a timeout config option (closes #2745677)
So a HTTP GET do not hang forever in the datafeed looping task.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 24 Jul 2013 11:54:35 +0200] rev 9181
[dataimport] ucsvreader should skip empty lines unless specified otherwise. Closes #3035944
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 22 Jul 2013 12:08:37 +0200] rev 9180
[querier] Add timings to debug prints (DBG_RQL)
this may ease to spot some problematic queries
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 24 Jul 2013 08:43:16 +0200] rev 9179
[editcontrollers] Ensure entities are created in an order satisfying schema constraints. Closes #3031719
changes below are also necessary to make the whole thing works:
* stop considering InlinedFormFile as eidparam field since they don't
hold any value
* rework 'pendingfields' handling to have separate processing of inlined fields
whose subject entity is created during the edition
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 22 Jul 2013 12:07:46 +0200] rev 9178
[editcontroller] extract RQLQuery.set_attribute/set_inlined methods from handle_field/handle_inlined_relation
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 22 Jul 2013 11:38:48 +0200] rev 9177
[editcontroller] req=self._cw makes things easier to read
David Douard <david.douard@logilab.fr> [Mon, 22 Jul 2013 15:38:11 +0200] rev 9176
[facets,js] fix bogus checkbox icon appearing after the first interaction (closes #2790332)
This is because of the hardcoding of the data/ url.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 22 Jul 2013 14:57:37 +0200] rev 9175
fix typos in docstring, doc and comments
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Jul 2013 15:02:28 +0200] rev 9174
[debian] remove workaround for broken sphinx/jquery combination
sphinx in squeeze was updated:
http://packages.qa.debian.org/s/sphinx/news/20130112T154737Z.html
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 18 Jul 2013 22:18:50 +0200] rev 9173
[schema] mark CWDataImport as an internal type. Closes #3025536
Paul Tonelli <paul.tonelli@logilab.fr> [Fri, 19 Jul 2013 15:52:06 +0200] rev 9172
[pkg] remove deprecated dependency on pysqlite2
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 18 Jul 2013 12:36:56 +0200] rev 9171
Fix two crashes in db-check (closes #3024964)
Also improves various debugging messages.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 22 Jul 2013 11:09:28 +0200] rev 9170
[rql rewrite] may_be_shared_with should consider relation's scope (closes #3024730)
When a relation's scope is not the current statement, it must not be shared
(instead of comparing the statement).
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 18 Jul 2013 10:19:06 +0200] rev 9169
[rql rewrite] fix may_be_shared_with method so that it actually considers all variable infos and not only the first one
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 22 Jul 2013 14:26:33 +0200] rev 9168
[schema/security] add __hash__ to rql expression. Closes #3013535
This is required so that when some rql expression participate to a dictionary
key, only the expression is considered (consistent with comparison). This
behaviour is expected in security at least, see the related bug for instance.
This scramble msplanner unit tests a bit.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 15 Jul 2013 10:59:34 +0200] rev 9167
[rql rewrite] move some code from querier to rqlrewrite where it makes more sense.
Also, make some minor cleanup/refactoring on the way and try to enhance
docstrings.
Relates to #3013535
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 12 Jul 2013 10:39:01 +0200] rev 9166
Do not compute actions list in TableLayout view when display_actions attribute is unset
Closes #3007281
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 12 Jul 2013 09:55:26 +0200] rev 9165
Use the list of cubes from the filesystem when reading the schema from the filesystem
Closes #3007259
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 22 Jul 2013 10:55:45 +0200] rev 9164
[migration] when adding a cube, skip infered relations (closes #3005576)
Skipped infered relations are recalculated later.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 11 Jul 2013 17:40:28 +0200] rev 9163
[3.17 migration] when some cube is missing, add_cube raise ConfigurationError, not ImportError. Closes #2981477
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 11 Jul 2013 10:20:42 +0200] rev 9162
[migraction] rename_entity_type simply warn if old entity type isn't in the schema. Closes #3004069
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 11 Jul 2013 10:15:25 +0200] rev 9161
[deprecation] fix uihelper deprecation warning, use the rtag name, not the class, so it may be copy/pasted
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 11 Jul 2013 18:43:29 +0200] rev 9160
[test] makes fti test order-agnostic (closes #3005633)
Julien Cristau <julien.cristau@logilab.fr> [Thu, 11 Jul 2013 17:16:49 +0200] rev 9159
[web/views/staticcontrollers] Make ConcatFilesHandler write to a tempfile
In order to be more resistant to errors such as ENOSPC, and against different
threads accessing the same static data, we:
- concatenate data files to a temporary file, and rename it once we're done
- delete the tempfile in case of errors
- protect the creation of the cache_concat file with a lock
Closes #3005547
David Douard <david.douard@logilab.fr> [Fri, 12 Jul 2013 18:03:11 +0200] rev 9158
[test] make unittest_schema.py compatible with cubicweb-file 0.14
David Douard <david.douard@logilab.fr> [Mon, 22 Jul 2013 09:47:56 +0200] rev 9157
merge 3.16.6 branch in 3.17
Florent Cayre <florent.cayre@logilab.fr> [Mon, 15 Jul 2013 17:34:54 +0200] rev 9156
Added tag cubicweb-centos-version-3.16.6-1, cubicweb-debian-version-3.16.6-1, cubicweb-version-3.16.6 for changeset b4ccaf13081d
Florent Cayre <florent.cayre@logilab.fr> [Sat, 13 Jul 2013 05:10:55 +0200] rev 9155
Prepare 3.16.6
David Douard <david.douard@logilab.fr> [Mon, 15 Jul 2013 16:55:13 +0200] rev 9154
[devctl] properly generate i18n messsages for cubes that uses uicfg instances (closes #2811282)
David Douard <david.douard@logilab.fr> [Mon, 15 Jul 2013 16:55:03 +0200] rev 9153
[test/devctl] add a test case for i18ncube command
Florent Cayre <florent.cayre@logilab.fr> [Mon, 15 Jul 2013 10:40:49 +0200] rev 9152
Protect against crash in the `relation_possible` predicate with ambiguous relations.
It was still possible to get a KeyError when using relations that are ambiguous
at both ends, like (Executable, version_of, Program) & (Version, version_of, Project).
Closes #3010148.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 10 Jul 2013 15:03:50 +0200] rev 9151
[test] give a non-ambiguous order to sync_schema assertion (closes #3001959)
Sorting by ordernum alone is unstable since several values have the
same ordernum.
ordernum + name should be stable.
David Douard <david.douard@logilab.fr> [Tue, 09 Jul 2013 17:33:43 +0200] rev 9150
Added tag cubicweb-version-3.17.3, cubicweb-debian-version-3.17.3-1, cubicweb-centos-version-3.17.3-1 for changeset 32b4d5314fd9
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Thu, 04 Jul 2013 09:26:59 +0200] rev 9149
[test] typo
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 25 Jun 2013 12:11:42 +0200] rev 9148
[schema,server] add a security debugging aid (closes #2920304)
- Add a DGB_SEC debugging flag (to be used with set_debug/debugged).
- Add a context manager (tunesecurity) to filter security assertions.
Note: this does not address all read-security mecanisms.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Jun 2013 19:00:40 +0200] rev 9147
[etwist] fix handling of multiple files per field
html5 permits multiple files uploads, which can be expressed as::
<input type='file' multiple='multiple' />
This changeset avoids previous crash. Nothing is changed when a single file is
uploaded (backward compat is thus preserved). When multiple files are uploaded
for a single html input tag, the corresponding web request form key receives a
list of tuples like [('filename-1', IStream1), ('filename-2', IStream2), ...].
closes #2847207.
David Douard <david.douard@logilab.fr> [Tue, 09 Jul 2013 15:58:26 +0200] rev 9146
[merge] start 3.18 development
David Douard <david.douard@logilab.fr> [Tue, 09 Jul 2013 15:11:23 +0200] rev 9145
[pkg] prepare 3.17.3
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Jul 2013 20:48:54 +0200] rev 9144
[pkg] Remove obsolete ubuntu hardy packaging
It's been EOL for a while.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Jul 2013 15:24:43 +0200] rev 9143
[book] fix sphinx documentation generation (closes #2991997)
changeset 17994bf95d6a ([doc] update Session documentation) added
cubicweb.server.session.Session autodoc to the book. This caused errors
from sphinx due to a section title not being allowed in the class's
docstring.
David Douard <david.douard@logilab.fr> [Mon, 08 Jul 2013 12:41:08 +0200] rev 9142
[test/ldap] fix ldap tests
- make sure the url is properly updated on database setup (when the test
database already exists and the ldap URI has changed)
- fix the ldapuser test setup process.
David Douard <david.douard@logilab.fr> [Fri, 05 Jul 2013 10:40:57 +0200] rev 9141
[test] fix unittest_schemaserial.py
A spurious add permission has been added in expected result by d988eec2d5d3
David Douard <david.douard@logilab.fr> [Fri, 05 Jul 2013 10:35:14 +0200] rev 9140
[test] make unittest_schemaserial.py runnable with python
used to run fine only when launched using pytest
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 08 Jul 2013 17:38:10 +0200] rev 9139
[facet] use facet name as input name for text widget (eg has_text)
we need to ba able to distinguish between text-inputs so we can write
a widget for a single facet that uses more than one text input.
This fix consists in the diff in cubicweb.facts.js; modifications in
facet.py result from this former.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 02 Jul 2013 09:36:20 +0200] rev 9138
[web doctype] don't give through reset_xmldecl to avoid double deprecation warning
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 02 Jul 2013 09:35:58 +0200] rev 9137
[web doctype test] don't give reset_xmldecl to avoid deprecation warning
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 03 Jul 2013 14:52:10 +0200] rev 9136
[devtool] randomise available ports search in http test
This lowers the chance of parallel tests to race for the same port.
Katia Saurfelt <katia.saurfelt@logilab.fr> [Wed, 03 Jul 2013 14:48:34 +0200] rev 9135
[facet] don't crash if no title specified on a facet and filtered rset is empty. Closes #2587883
Katia Saurfelt <katia.saurfelt@logilab.fr> [Wed, 03 Jul 2013 14:43:21 +0200] rev 9134
[css, html] add a css_class attribute on Button, allowing to change easily default CSS class for buttons
(think orbui integration)
Katia Saurfelt <katia.saurfelt@logilab.fr> [Wed, 27 Jun 2012 11:53:46 +0200] rev 9133
[view] add 2 missing spaces before the previous link
Julien Cristau <julien.cristau@logilab.fr> [Wed, 26 Jun 2013 09:35:54 +0200] rev 9132
[server/repository] Go through the repo to close pyro sessions
Turns out session.close() doesn't DTRT.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 31 May 2013 11:13:06 +0200] rev 9131
fix migration from pre-3.13.1 versions (closes #2846978)
Need to check the existence of the asource column before the first call
to eid_type_source.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 03 Jul 2013 14:33:27 +0200] rev 9130
[constraint] more robust unicity constraint failures reporting for end-users
Postgres or Sqlserver have limits on the index names (around resp. 64
and 128 characters). Because `logilab.database` encodes the `unique
together` constraint rtypes in the index names, we sometimes get
truncated index names, from which it is impossible to retrieve all
rtypes.
In the long run, the way such index are named should be changed.
In the short term, we try to reduce the end-user confusion resulting
from this design flaw:
* in source/native, the regex filtering ``IntegrityError`` message does
not impose an `_idx` suffix, which indeed may be absent (the result being an
UI message that resembles a catastrophic failure),
* also we avoid including a trailing " (double quote) from the error
message
* in entities/adapters, the well-named ``IUserFriendly`` adapter is made a
bit smarter about how to handle missing rtypes.
* the adapter also always produces a global message explaining the
issue (and the fact that sometimes, the user is not shown all the
relevant info)
* i18n is updated
Closes #2793789
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 03 Jul 2013 14:16:21 +0200] rev 9129
[hooks/security] Streamline attributes default permission check.
The current default permission on attributes delegates the check to
the entity permission update policy.
Since this is already checked it can be skipped.
The equality comparison will work, even with a deserialized schema,
because the default update perm is::
('managers', ERQLExpression(Any X WHERE U has_update_permission X, X eid %(x)s, U eid %(u)s))
which will always be deserialized in this order (groups first).
However this is a slight semantic change: entity type level 'update'
permissions can now be effectively used to encode update-time rules if
the default attribute permissions are used (before this change, the
'update' rules at entity type level were fired at creation time).
Closes #2930861.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 26 Jun 2013 14:22:22 +0200] rev 9128
[test/schemaserial] swap got/expected to get nicer unittest2 diagnostics
Prepares #2965518.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 02 Jul 2013 17:09:04 +0200] rev 9127
[repository] drop safe attribute on ``internal_cnx``
People that need to disable hook can do it explicitly anyway.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 19:18:54 +0200] rev 9126
[dbapi] deprecated the dbapi
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 19:26:14 +0200] rev 9125
[repoapi] deprecate dbapi compat method
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 19:14:22 +0200] rev 9124
[testlib] deprecated the older api to access the repo.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 19:09:23 +0200] rev 9123
[connection] deprecated free_cnset and set_cnxset
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 19:02:06 +0200] rev 9122
[session] deprecate all Connection related method on session
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 18:53:06 +0200] rev 9121
[session] drop dead _current_cnx_id
Not used anymore for a few commit.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 18:47:08 +0200] rev 9120
[session] privatise get_cnx and close_cnx
The only user, repoapi now use ``new_cnx``
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 18:14:35 +0200] rev 9119
[doc] add documentation for the new API in test
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 15:28:15 +0200] rev 9118
[testlib] add an default testcase.adminaccess (and use it for default session)
This adminaccess is the new offical way to get connection, and request on a
repo.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 18:15:57 +0200] rev 9117
[testlib] introduce a RepoAccess class to easily create connection and request
Each RepoAccess hold a session for a user and three helper function to help
create Connection, ClientConnection of WebRequest related to this session.
related to #2920299
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 15:13:47 +0200] rev 9116
[repoapi] make ClientConnection.__enter__ return self
This allow the standard idiom::
with repoapi.connect(repo, login='babar', passwork='elephant') as cnx:
cnx.execute(…)
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 18:16:06 +0200] rev 9115
[documentation] describe repoapi and web side change.
Short version explaining what object replace what and that BC existes for a few
version.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 12:28:17 +0200] rev 9114
[testlib] use internal_cnx instead of internal_session
internal_session is deprecated.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 14:12:00 +0200] rev 9113
[repository] add an ``internal_cnx`` method to replace ``internal_session``
Accessing the repo through a Session is deprecated. We need an easy replacement
for ``internal_session``.
This API change was a good occasion to stop disabling integrity hook by default.
This is huge source of bug in user-code.
related to #2503918
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 12:02:38 +0200] rev 9112
[connection] enforce that a connection must be open to be used
The same than for ClientConnection, we ensure the connection is used inside a
its context.
.. note:: We may rely on that for ClientConnection and remove de dedicated code
in Client Connection but I prefer the current explicite and duplicated
version for now.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 15:11:22 +0200] rev 9111
use standalone Connection to Client Connection
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 14:46:24 +0200] rev 9110
[session] add a new_cnx factory
Having user-code importing cubicweb.server.session.Connection is inconvenient.
We add a simple factory fonction on the session.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 14:26:06 +0200] rev 9109
[connection] allow simple instantiation of standalone Connection
Such connection will automatically pick a connection id. Note, They are not
automatically closed on session close. But they will fails to grab new cnxset
once the session is closed.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 14:35:55 +0200] rev 9108
[connection] handle and explicitly life cycle on Connection
Like ClientConnection, Connection object need to be explicitly started and stop.
They aims to be used as context manager.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 14:00:32 +0200] rev 9107
[sesion] distinction between Connection handled by the session and other.
Not mixing the new and backward compat approach seems a good idea. Let's enforce
it.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 11:58:34 +0200] rev 9106
[session] replace _clear_thread_storage with close_cnx
There is not good reason to keep two distinct method.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 14:01:07 +0200] rev 9105
[session] explicitly take Connection object in close_cnx
Now that ClientConnection explicitly reference and use the Connection object we
do not need to use connectionid here.
We can safely change this signature, ClientConnection is the only use of
close_cnx for now.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 11:41:53 +0200] rev 9104
[session] drop the Session._clear_cnx_storage method
It is just cnx.clear() now.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 11:39:41 +0200] rev 9103
[session] wrap too long line
Too long line is too long.
(Confucius 503 BC)
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 11:39:01 +0200] rev 9102
[session] gather close_cnx with get_cnx and set_cnx
They do the same kind of operation and deserve to be grouped together.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:13:18 +0200] rev 9101
[client-connection] remove the _srv_cnx usage
It does not do anything special now that we use explicite Connection object with
automatic cnx_set handling.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:04:31 +0200] rev 9100
[client-connection] explicitly check that the client-connection is open
The check is also perform by the _srv_cnx property. But we do not need those
property anymore.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:02:30 +0200] rev 9099
[client-connection] handle the lack of connection id while not open
the connection id is computed at opening and forgotten when closing. We can't
rely on it in various messages … like the "connection closed" exception.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 11:21:39 +0200] rev 9098
[connection] transparent cnx_set handling
Connection object while take cares of there cnxset themself (as dbapi connection
does).
The ``set_cnxset`` and ``free_cnxset`` operation are still available for
backward compatibility purpose. The ``_auto_free_cnx_set`` is introduced to
handle mixed usage.
A new context manager ``connection.ensure_cnx_set`` is added for code that
access ``cnx.cnxset`` directly and are not wrapped in any specific
``Connection`` method.
A ``_with_cnx_set`` decorator is used on all Connection method that need a
cnxset.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 10:44:40 +0200] rev 9097
[client-connection] explicit the client part in __repr__
Now that we have real server side connection we need to remove ambiguity.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 25 Jun 2013 19:50:16 +0200] rev 9096
[ClientConnection] directly use the Connection object to access the database
Now that Connection are a full featured standalone object we can directly
reference and use it in the ClientConnection instead of using the session.
The session object is kept around for a while to perform various utility role.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 25 Jun 2013 18:15:45 +0200] rev 9095
[connection] invert __init__ parameter
Takes session first. At some point, the connection_id will become optional for Connection
created explicitly.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 26 Jun 2013 13:43:22 +0200] rev 9094
[service] enforce that Service argument and return are json-serialisable
The call_service API need to be able to run through RPC. So we ensure front
start that it is possible serialise both input and output.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 25 Jun 2013 18:04:08 +0200] rev 9093
[connection] move call_service on Connection
This is the last step toward standalone transaction.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:21:14 +0200] rev 9092
[connection] move the commit method on Connection object
One step closer of standalone Connection!
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:21:09 +0200] rev 9091
[connection] move the rollback method on Connection object
One step closer of standalon Connection.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:20:46 +0200] rev 9090
[connection] pass a Connection object to RQLRewriter
RQLRewriter can now directly use a Connection object. No need for specific
handling session side.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:20:14 +0200] rev 9089
[connection] Connection.execute touch Session timestamp
This allow to keep Session alive while using Connection object only for database
access.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 25 Jun 2013 17:42:12 +0200] rev 9088
[connection] Connection now call _set_user to CWUser object linked to itseld
Session.user is linked to the session.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 25 Jun 2013 14:13:50 +0200] rev 9087
[server/session] better faking of user for InternalManager
Pierre-Yves David <pierre-yves.david@logilab.fr> [Thu, 27 Jun 2013 11:19:58 +0200] rev 9086
[connection] move execute
All necessary method are now available on the Connection object. So the
Connection can handle RQL execution itself.
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 25 Jun 2013 17:10:52 +0200] rev 9085
[connection] mark Connection as "not a request"
The ORM use this information. Having a wrong value will lead to crash.