[javascript] fix some javascript errors and remove some deprecation warnings

[forms] bw compat code for vocabulary function returning typed values

[web config] fix old css compat code: we have to modify locate_resource prototype so it return (potentially hacked) file name as well. Should only impact the file cube which has to be released anyway.

[repository] fix so that when repository is shutting down, internal session in transaction are interrupted

[test] windmill: add a timeout between JS assertion in test_creation use case

backport stable

[selectors] fix dumb name error introduced in parent changeset

[css] old css bw compat with @import in a custom css

backport stable

[selectors] relation_possible selector should check user may read target entity type when specified

imported patch selstrfix.diff

imported patch rql2sqlfix.diff

[migration] fix rename_entity_type to an existant entity type: get back relation from the old entity type non existant on the target type

cleanups

[selectors] avoid spurious warning when using implements by design

[session] don't log reraised error occured during precommit

[doc] proof-reading and improvements

[selectors] fix warning stack level

[schema migration] import refactoring to fix #1109558 and enhances things on the way the main pb demonstrated by #1109558 was due to the fact that in-memory schema was updated in commit_event of operations. This is undesired in most cases, since we want the modification to be taken into account in the interval between the modification detection and the commit_event. I've fixed this by merging in-memory schema / database alteration operations for most important changes, doing in-memory schema changes as they are detected and implementing a revertcommit_event method to revert them if necessary (with exception for removal of stuff from the schema, where this is simply done in a postcommit_event methods). Also, I've benefited from this to support reverting of database alteration for some operations (more to be done there), and to move so system source alteration code to the native source code for a nicer design. There may be some more stuff in syncschema.py that would benefit from similar changes, but most important things are done (at least to close #1109558, w/ unittest_syncschema and unittest_migration green).

backport stable

[test] running transaction while session is closed are now killed, update test accordingly

[security] fix read rql expression insertion: we should not insert rql expr on variables only referenced in neged relation

[rql2sql] test and fix crash when OR in HAVING where both expresion are 'fake' having terms (eg not using aggregat function)

cleanups

[config] use hashlib to avoid warning w/ py2.6

[req] hashlib has no hash function, but has an hash1 function even in python 2.5

[utils] improve repr() of RepeatList

[doc] fix typo

[selectors] use before-registry-reset event to init is_instance cache: cleaner code and avoid reloading bug (making hooks test fail for instance)

[vreg] new [before|after]-registry-reset event, taking vreg as argument

[doc] update book for adapters

[reledit] fix relation cardinality handling

[selectors] provide a new, optimized, is_instance selector that should at some point replace implements (along with the adaptable selector)

[web/views/massmailing] fix cancel button msg/icon

[testlib] improve test description messages

[web/views/reledit] fix typo (-add we used as id component in delete id)

[web/test] fix test (doreledit must have a formid and this is now checked)

[web ui] add missing image

[ITree] small fixes: parent_entity is a IBreadCrumbs method, we should use .parent on ITree

restore bw compat on Entity.related_rql

reledit refactoring * js handling rewritten to exploit all form capabilities (such as file upload ...) * attribute-like composite relations (one ttype, cardinality in '?1' from composite side) are more cutely handled, with a 'add'/'delete' additional actions/icons * a reledit_ctrl rtag to finely control: reloading, edition and default values * a proper chapter in the documentation (book) * many bugfixes

backport stable

cleanup

[idownloadable] make the download view http cache friendly

[publisher] avoid useless rollback after successful commit, which clutters debug logs and may also not be cost-free

[controller] same method defined on the base class

backport stable

merge stable heads

Added tag cubicweb-debian-version-3.8.6-1 for changeset 607a90073911

Added tag cubicweb-version-3.8.6 for changeset 1a24c62aefc5

[dbapi] refactor so that cw 3.8.6 can still speak with a 3.8.5 server

cleanup

[bfss] fix file update to ensure file's content is available on the fs asap... and not only at commit time. So it's consistent with entity creation behaviour. The new file is created at assignement time and removed if the commit is rollbacked.

[ldap] fix exception handling on authentication error

[ldap] cleanup password checking

cleanup

[css] make body bg color configurable

bump version number to trigger migration

3.8.6

[migration] schema should be accessed through .repo

backport stable

[security] use set_operation for relation permission checking operation

[migration] refactor schema migration fix introduced by 5833:d7256ae7c1d1 so the code looks better and avoid clutering lgdb api. Depends on lgdb 1.0.5.

[schema migration] fix name error introduced in parent changeset

[schema migration] avoid potential duplicated ft reindexation due to multiple UpdateFTIndexOp operations by using set_operation

[sql generation] fix bug with inlined relation and referenced by other neged relation we should check in that the column is not null in such cases

[refactor] refactor rtag keys generations.

[fix] fix a uicfg bug in autoform_section When several rtags matches the same relation (for example "* login *" and "CWUser login *") inconsistent rtag could be merged.

[debian] fix logrotate error introduced by 5806:9ef0e95f4d2b: sh don't want spaces here

[debian] fix logrotate error introduced by 5806:9ef0e95f4d2b: sh don't want spaces here

cleanups

[login form] fix bad login field label by using pgettext

updated docstrings on Operation class

do not allow password-less bind: windows accepts this as Anonymous Logon

[#969169] don't display remove link in edition forms if the cardinality is 1

fix name error

fix schema migration hooks (partial) SQL Server requires some additional steps to alter columns (index drop and restore, etc...) and this in turn requires passing a connection on the DB to find out the indexes. Also partially fix an issue where the null_allowed value was not correctly computed. Still some problems in there (see https://www.logilab.net/cwo/ticket/1109558)

delete trailing whitespace

Had thought this could be done in cube, but it really needs to be done earlier in the migration process

EntityFormRenderer redefine open_form and add a div section, so redefine close_form to add the closing div tag

Backed out changeset c29c90223125 which breaks the cw tests

EntityFormRenderer redefine open_form and add a div section, so redefine close_form to add the closing div tag

reduce log verbosity in ldapuser source

[session] refactor session handling so that when calling session.close(), pool of long running transaction of the same session is properly freed

[debug views] set http cache max age to 0 on debug views

cleanup

[schema view] width isn't in authorized th attribute in xhtml DTD. katia, please do it another way.

[schema view] fix typo

[rql2sql] #1089207: do not encode Unicode strings from RQL statements to db encoding

fix bad merge

[css] more css rework, need visual test in compat/new modes

backport stable

[config] fix dumb name error

[form] apply patch #933771: format_single_value / vocabulary methods should *always* return actual value as an unicode string

backport stable

[repo] fix 'c-c start --loglevel LEVEL' for repository only configuration. Closes #1058269.

[transaction w/ separated web/repo processes] the dbapi should explicitly specify a transaction id to avoid confusion when web server / repository run in separated processes

[dbapi] Connection.load_appobjects should load site_cubicweb files as well, they may contains necessary RQL extension function definitions. Also kill some broken deprecated code in this method.

backport stable

Added tag cubicweb-debian-version-3.8.5-1 for changeset 5d05b08adeab

Added tag cubicweb-version-3.8.5 for changeset 2de32c0c293b

[repo] call entity.check() once before_update hooks has been called, to let them a chance to transform data

3.8.5

[debian] #1027463: logrotate script should filter out warnings

[schema migration] fix fix introduced in 5803:589e2e3fb997, test for backend alter column support should be done in the operation, else the associated index is not dropped while this is supported

[schema migration] fix backend compatibility issue by using type_from_constraints / sql_change_col_type instead of bare ALTER COLUMN

[schema migration] don't try to drop column if backend doesn't support column alteration (eg sqlite)

[session] when rollback_on_failure is false, we should not try to reconnect if the sql raised an error

Use SQL standard ALTER TABLE command (with ADD instead of ADD COLUMN)

reduced logging verbosity in ldapuser source

use sessionid in log message

constraints can contain unicode values

[entity] fix .complete so we don't crash on missing mandatory relation. Also simplify code. Closes #1058267

closes #1059729: cw-ctl upgrade : i18n upgrade not performed if DB does not need upgrade

[devtools/qunit] prefix jquery_dir with 'file://' (as this is used from within a web browser)

[devtools/qunit] Locate jquery through cubicwew config to handle installed setup

[rql2sql] use new dbhelper.sql_concat_string function to deal with sql string concatenation. This together with lgdb 1.0.4 fixes #1055133: SQL Server support : string concatenation issue

[session] update session's timestamp in session.execute, so long running transactions are not erroneously closed by the repository

[repo session] expected argument is the source, not the session

[devtools/qunit] in safe mode, ffox launches a stupid popup

[ldapuser] quieter ldap result info, fix commented block style

[qunit] use safe mode for firefox

[qunit] Move qunit.js and qunit.css in devtools/datadirectory

[test] fix stupd name error

[test] fix test w/ closed connection pb

[ms] orderby/groupby/having attributes of Select node should be resetted to empty tuple, not None

[devtools/teslib] be more defensive on rollbacks

[rql2sql] when using HAVING to by-pass rql limitation (not to filter on result of an aggregat function), we should emit SQL that doesn't use HAVING to avoid potential backend error because variables are not grouped. Closes #1061603.

[doc/book/faq] question on security

[qunit] check that the browser has not died by himself before we asked him to stop.

[qunit] improve output of suprocess error The exception message now include the stdout and stderr of the called process

[test] workaround connection leak making tests fail under windows environment (though we've still probably some open connection leak to resolve...)

[web request] in python 2.5 hashlib has no .hash attribute

[web actions] fix recent refactoring, leading to missing redirect parameters in action's url

[packaging] more cleanups, handle javascript test files

backport stable

[facet] use vreg.parse so the rql syntax tree is properly annotated as well

[text search] fix fulltext_container indexation

[md5script] cleanup

[py2.6] use hashlib to silence python 2.6 deprecation warnings

[autoform] do not show remove link for inline form if card == 1

[fti] support for fti ranking: has_text query results sorted by relevance, and provides a way to control weight per entity / entity's attribute

[packaging] MANIFEST.in cleanups, update js/css copyright, remove no more used files

[js tests] fix javascripts tests definition, test_datetime.js now included in test_utils.js, which test other stuff as well

[entity] can't do anymore dict(entity) since entity doesn't inherit from dict

backport stable

[vreg] register_objects lost its force_reload argument, fix dbapi.Connection.load_appobjects consequently

backport stable

[test] unittest_multisources: external source shouldn't use the same database as the main repo...

[test] miss main

imported patch asynchronous multipart parsing.diff

imported patch cookie handling: do not use semicolon as it has some tech meaning (web2 -> web)

[entity] when .related() is called on a not-yet-saved entity, return an empty rset/list instead of raising an assertion error

[filefield] normalized file names to deal with windows files

[c-c exlog] fix code and documentation

[test] support for test on postgres database using the same mecanism as sqlite: one template database generated when necessary + actual test database created from the template * * * [test] reset postgres database between test of the same fixture

fix bad merge

backport stable

[test] properly close connections during test

[repo] on repository initialization, properly shutdown intermediary repository

[repo] on repository shutdown, we've to close the new eid creation connection

[auto-reload] we should never call load_module with use_sys=False, that may lead to inconsistency with module interdependancy (eg module get imported by another one, then is reimported by the vreg to load its appobjects. Cleanup of sys.modules done before reloading should be enough.

[rset] do not filter rsets with __getstate__, ensure whatever flies with pyro has no .req attribute, also set the ._rqlst to None since it will be reconstructed later on demand

[security] SchemaRelation.has_perm grows to new arguments allowing to specify subject/object entity type when actual eid are not known, but their types are

[linkto action] refactor to ease overriding to control redirection

[hooks] entity_oldnewvalue should never return _MARKER: if the attribute isn't in the entity dict (hence unmodified), return the old value

Use the qunit automatic launcher for existing testcase.

Add a QUnitTestCase class to run qunit test case.

[twctl] add missing poststop method #1058268

[rset] make rsets picklable (again ?) #1056422

[jstests] nicer test page title

[jstest] get back more tests writen during the sprint by vgodard

cleanup

backport stable

Added tag cubicweb-debian-version-3.8.4-1 for changeset b7883287f40c

Added tag cubicweb-version-3.8.4 for changeset d00d1fab42af

cleanup

[selectors] relation_possible selector accept None as action, in which case no perms checking is done

3.8.4

[xhtml] fix soup2xhtml to deal with malformed div,body and html tags which may leads to malformed return value

[source] remove debug

[entity] add .clear() for bw compat

[3.9] api update (mostly js) + add support for FCKEditor in formContents js function

[json] fix json serialization for recent simplejson implementation, and test encoding of entities as with earlier simplejson implementation, iterencode internal stuff is a generated function, we can't anymore rely on the _iterencode overriding trick, so move on by stoping isinstance(Entity, dict). This is a much heavier change than expected but it was expected to be done at some point, so let's go that way.

[adapters] enhanced warning

[test] fix test broken by 5721:61d6a4caa963, and update it to proper adapters to avoid deprecation warning

[3.9] update warning message

[iprogress] move adapter to entities.adapters

fix wrong calculation of clean_session_interval

[ITree] more fixes, fix fixes

[idownloadable] depends on a new mtconverter release

[ITree] fix adapter/_done_init to handle tree_[attribute|relation], add maxlevel argument to base tree view since one side effect of the new code is that it find tree view for entity types it didn't find before, hence one may want to limit tree view depth when it wasn't necessary before

[3.9] fix tests

[web] move itree adapter to entities, it may be used outside the web interface

[view] add a new entity_call method to entity view protocol, allowing some to work with not yet created entities. Also, start considering 'eid' form parameters where we only consider 'rql', so we can move on bloquing arbitrary rql inputs (more to do on this...)

[idownloadable] refactor IDownloadable primary view to make overriding easier

[web] ajax_replace_url superseed build_ajax_replace_url, more generic and relying on the json controller (closes #750090)

[form] refactor meta-attributes handling: hide them by default using uicfg.afs instead of returning None (or not, according to skip_meta_attr flag argument) in guess_field

[repo] fix typo

[req] fix format_time w/ 0:0 which is evaluated to False

[view] ensure fallback_oid is specified before trying to select fallback view, else simply raise the exception

fix merge, forgot to save a buffer :(

backport stable

[rql2sql] fix special 'X relation NULL' case (used by security insertion), broken by recent removal of IS operator in RQL

[javascript] add a name property to namespaces, mainly for convenience in helpers such as movedToNamespace

[rql] IS operator killed in rql 0.26.2, use equal instead

[security] consider any rql expression refering to X while X is being created as satisfied

[rql] more update to 0.26.2 api

[querier] fix rset description bug with some union queries

[devtools] fix get_available_port implementation: it should only return the port number if unable to connect

[javascript] move CubicWeb object declaration to cubicweb.js, remove CubicWeb.provide/require, use cw instead of CubicWeb

[javascript] move Deferred implementation to cubicweb.ajax.js

[form] fix untested (unread?) has_been_modified implementation...

backport stable

[autoform] fix vreg module name

[pylint] fix detected name errors

[pylint] fix detected name errors

[repo server] fix startup bug, lgc.daemon.daemonize return 1 for the parent process, not -1

backport stable branch

[source] don't create the eid_creation connection at source initiliaztion time This fixes the "already opened connection bug" in db-restore for instance.

[schema view] only catch key errors

[schema view] improve it slightly by attributing the same color to rdef of the same relation type

[rset] Add a line break the first result in repr of multiple rows rset Improve readability of rset while debugging by aligning the first value with the others if the rset have multiple row. This first line was usually not read as it' was on the same line that the first part of the repr ("<rset <RQL>, (%i rows) ...")

[schema diagram] ticket #191599, make schema image look better

backport stable

[workflow image] remove debug code

[request] fix typo

[security] view was giving web access to every fs file accessible by the web server process. Fix this security hole by storing file in session data, not direct form parameters

[hooks] fix typo in workflow hooks category

[security hooks] fix bad merge

backport stable

Added tag cubicweb-debian-version-3.8.3-1 for changeset 1ccaa9247860

Added tag cubicweb-version-3.8.3 for changeset 7e6c6a2a272d

[edit ctrl] fix bad interaction with fields: the loop on actual fields should be done in has_been_modified

[web test] add basic windmill tests and documentation - connection / deconnection - user creation

[web test] Add windmill functional testing capability.

3.8.3

i18nupdate

[editform] consistent [do]reledit between attributes and relations: check if rdef is hidden in main section of uicfg.afs for both attributes and relations, and in the reledit view, not in doreledit

on entity creation, accept attributes without any update access

[table] propagate paginate

no more need for specific handling of table view's displayaction it's handled as other view arguments in vidargs

[rset] do not break when rset.related_entity(x,y) is not an entity

[migration] fix schema synchronization bug sync_schema_props_perms('Repository', syncprops=False) to synchronize permission of entity's attributes wasn't working as expected: only the entity's permission were updated.

[javascript] refactor execution flow of handleFormValidationResponse so that location hash is set to #header whatever the error is

[package] now depends on yams 0.30 because of xy API changes

[xy] switch order of arguments for register_prefix()

HAVING sql clause don't know about comma...

[web/formwidgets] check on list (entity.related_cache swapped from tuple to list a while ago without known reasons), do not unicode wrap the eids

merge

[win32] defer import of logilab.common.daemon The module is not importable on windows, and etwist.service carefully avoids importing it (but imports etwist.server). Wait until we are sure not to be on windows to do the import)

[ajax] refactor/cleanup low-level ajax functions * loadxhtml/replacePageChunck/reload_component/reload_box deprecated in favor of loadXHTML / ajaxFuncArgs * some other cleanups in cubicweb.ajax.js * add js_render which will replace js_component (more generic, nicer argument passing handling)

[querier] test and fix potential bug in insertion query with multiple relations inside, caused by a name conflict. Also fix another bug non reproduced by using a set instead of a list (list may leads to compare entity instances which isn't allowed).

[form] avoid spurious warning subsequent for form's action refactoring w/ autoforms

backport stable

[web test] Add a CubicWebServerTC class to run test with a cw web serveur available.