[views] rename Edition to Modification and personal information to profile

[cw.utils] avoid spurious warning, ustrftime may be globally imported

typo

add missing msgstr

backport stable

[web/uicfg] better error reporting for reledit_ctrl

merge

merge

fix order of parameters in call to callfunc_every

[test/entity] fix test (following mtconverter 0.8+ plain text transform change)

[doc] add documentation on RealDatabaseConfiguration

[devtools] add url_publish() method on CubicWebTC to test a full publishing process from the url_resolver to the html generation

[devtools] make CubiwebTC.login() context-manager restore the testcase connection on exit

[devtools] restore ability to test on real databases

[migration] fix add_relation_type() for symmetric relations To check if the corresponding SQL table has to created, CWRelationAddOp tests that the tablename is not in the 'createdtables' session variable (i.e. the table hasn't been created before in the same transaction) and that len(rschema.rdefs) is not greater to 1, that is the relation already existed in the database before this transaction. In case of symmetric relations, len(rschema).rdefs will be at least 2 since rdefs will store both (subj, obj) and (obj, subj) relation definitions.

backport stable

Added tag cubicweb-debian-version-3.9.5-1 for changeset 12038ca95f0f

Added tag cubicweb-version-3.9.5 for changeset 0a1fce8ddc67

3.9.5

i18nupdate

[doc, adapters] drop deprecated code from examples

[doc] interesting stuff backported

[doc] clean ITreeAdapter documentation

cleanup

remove useless import

use is_instance in a number of places (esp. documentation) rather than the deprecated implements

[new components] fix dumb name error

remove some deprecated stuff about relation definition

backport stable

[book] more about has_<action>_permission and enhance a bit security definition section

update documentation to follow 6142:8bc6eac1fac1 changes. Try to make it better and move most doc with code on the way

cwconfig module already used by another autodocstring. Drop this currently useless file

more cwctl api update and fixes

[c-c create] argument inversed accidentally

merge

[session] cleanup hook / operation / entity edition api Operation api ~~~~~~~~~~~~~ * commit_event killed, recently introduced postcommit_event is enough and has a better name * kill SingleOperation class, it's a) currently never used b) superseeded by set_operation if needed. Entity edition api ~~~~~~~~~~~~~~~~~~ edited_attributes turned into a special object holding edition specific attributes: - attributes to be edited (simply mirrored in cw_attr_cache, actual values are there) - former _cw_skip_security set (cw_edited) and querier_pending_relations It has also been renamed to `cw_edited` on the way (it may also contains inlined relations) The entity dict interface has been deprecated. One should explicitly use either cw_attr_cache or cw_edited according to the need. Also, there is now a control that we don't try to hi-jack edited attributes once this has no more effect (eg modification have already been saved) At last, _cw_set_defaults/cw_check internal methods have been moved to this special object Hook api ~~~~~~~~ hook.entity_oldnewvalue function now moved to a method of cw_edited object.

[web api] unify 'contentnav' (VComponent) and 'boxes' registries as 'ctxcomponents' (CtxComponent)

[boxes] introduce new boxes system * separate box content generation from its layout * refactor css classes to allow moving boxes and still get consistent ui On the way to contentnavigation/boxes unification (in a later patch) * * * some fixes for the previous (default_new_boxes_system) patch * * * some fixes for the previous (default_new_boxes_system) patch

backport stable

update to lgc.clcommands 0.51 api

[css] make sure the toolbar is clickable because layered over title

[dataimport] refactor commitevery to gain readability

[win32] no os.getuid on windows

use logilab.common.date.ustrftime in json encoder to work around datetime.strftime limitation on dates < 1900

use iter_and_commit in example

[c-c check-mapping] fix dumb name error and add a warning about inlined crossed relation

[ms] more planning bug fixes * fix sourcesterms w/ constant: all occurences of the same constant should be there once one of them is * fix handling of constant and relation in expand_terms: * we should always consider system source there for constants * for relation, we should check its lhs and rhs are in selected terms, not that the relation is in linkedterms (this has no chance to be true) This fixes 3 tests that were either passing erroneously (syt should be punished for copy/paste output as test reulst without triple checking it) or were not optimal.

oops, missing part of 6125:628cf5213154 (mapping file checking)

[ms] fix two planner bugs: one occuring query such as X created_by U where X in a external source and U may come from an ldap source. The other being that when we've to merge input maps, we were modifying the same tree/solutions while a copy were needed. Also, ensure we add type restrictions, necessary for pyro source

cleanups

[ms, c-c] new command checking for consistency / potentian flaws and enhancements of mapping file of a multi-sources instance

[repository] enabled sources refactoring: to avoid error, we should always have all known source in repo.sources_by_uri and only enabled ones in repo.sources, so we still have access to the definition of temporarily disabled sources

[migration] enhance RqlForIterator so we can do 'for e in rqliter(...).entities()'

[ms] when entity is coming from an external source, don't add non final relations on complete

[querier] add_types_restriction_cleanups: remove useless try/except (we already filtered out variables not in newroot.defined_vars) and dict accss. Also systematically set computed solutions instead of modifying existing ones

improvements in dataimport.py * updated the docstrings * fixed small issues in ucsvreader_pb * help user in using RQLObjectStore

add missing semi colon in js

[book] some more documentation and cleanups * merged existing facets documentation with the one I've just written and put almost everything within the code * added a note about __depends__ and __recommends__ and about the recommends semantic (extracted from a post on the ml) * added a note about write security checking (extracted from a post on the ml) * fixed some dumb sphinx errors

new RelationAttributeFacet + other fixes and cleanup + facets test * added documentation to Relation[Attribute]Facet and AttributeFacet explaining how to configure them * fixed behaviour of sorting for various combinaison of attribute values

[migration] remove bad test when constructing attributes to copy in rename_entity_type: the old entity type is not in the fschema due to schema deserialization trick

cleanup

[migration] fix rename_entity_type: avoid removal of attributes on the new entity type from the schema during migration

[migration] we can now specify attributes to backport to rename_entity_type using its attrs argument

[formwidgets] new allow_none attribute on BooleanField allowing a third None value for booleans

[primary view] consider rtypevid flag for relations in the 'relations' section as well

[db-fti-index] simple fix fpr progressbar-related crash when etypes is None in reindex_entities()

[views/reledit] small refactoring

[views/reledit] fix bad role handling in _may_add_related

integrate Celso's work on translation file: proper/complete spanish translation, fixed some typos in french translation, occured -> occurred fix in various places

[web] fix typo in ajax_build_url (s/xtml/xhtml)

[web controller] don't try to translate arbitrary exception message

[selectors] fix match_transition & introduce new edited_attribute selector

RQLUniqueConstraint not in CWConstraintType for some old instances

[tableview] take care, description may include None (try Any NULL)

fix typo

backport stable

[form, migration] etype_relation_field should not raise error, it may block migration if used for a non yet existing field

fix bug introduced by 6098:a0fde9334dd0

work around Apache's mod_proxy limitation with special chars in URLs by not using Rest urls when such a case is detected

[entity] base_url argument may be explicitly specified for other purpose (eg http/https site version control)

[cleanup] remove debug print

backport stable

[dot] oops, should use dc_title here

backport stable

more generic dot graph generator

backport stable

[login template] missing xml_escape

[primary] backport _rel_label method from the default branch

backport stable

[doc] docstring more explicit for pyviews

[debug] change severity of 'site_cubicweb loaded' message to debug

[primary] handle final relation (eg attribute) in the relations section, and give dispctrl to view's extra kwargs as for non final relation

[entity] entity.view now support initargs as req.view

[schema view] use rdef.ACTIONS, attribute/relation don't use the same actions permission, that causes a crash for attribute rdefs

[tabs] take care, vid may not be a valid dom id (for jQuery at least)

[forms] callable field kwargs now always take form _and_ field parameters + make help kwargs accept a callable too

[forms] test abs() rql function

[schema] consider ETYPE_NAME_MAP when deserializing specialization relations

fix the fix

fix missing import in web.request

backport stable

[migration] when some inlined relation definition is added to an entity type which has some specialized types, it should be propagated to those types else they may miss the necessary table column to store the relation

[migration] dont crash if a group doesn't exists (it may not exists yet)

[migration] fix rename_entity_type bug: not putting eids of relation deleted using sql query may cause later error on commit, complaining on missing relation on an entity which has been actually deleted

[migration] fix crash when adding symmetric relation type

[db-create] fix bug introduced by 6060:353bec342e2a (we ask for user while in non verbose mode)

[session] should be _cw, not req

[primary] use a new rtypevid flag in primary view display controller, allowing to tell the view for a non final relation should be called as an attribute view (eg, not on the target rset)

[cwprops] fix callable vocabulary of cwproperties which were inconsistently called. No more argument, should now simply return a list of (untranslated) values

[vreg] rename select* object id argument to avoid name clash with arbitrary kwargs, just in case...

[primary] refactor primary view handling of relation's label to properly handle label optionaly specified in dispctrl (no more default set) and use contextual translation by default. Also, consistent handling in attributes, relations and sideboxes section. Introduce new support_args function to use when possible instead of try/except TypeError.

backport stable

[doc/book] note about bootstrap_cubes file

[request] missing paren

[request] js is defined in uilib, not utils

[request] enhanced user[_rql]_callback method, allowing to call other js variant, eg one of userCallback, userCallbackThenUpdateUI, userCallbackThenReloadPage (the default). Also benefit from the new magic js object.

[pyro] instance id cleanup, ensure config['pyro-instance-id'] is a fully qualified pyro id on the server side

[db create] don't ask user/password if the underlying db doesn't support it (eg sqlite)

added tip on config file migration in scripts

[ms] ensure owned_by/created_by can't be crossed among pyro-rql sources

[ms] cleanups

[ms] fix a ms plannification bug with NOT is

backport stable

Added tag cubicweb-debian-version-3.9.4-1 for changeset 8d32d82134dc

Added tag cubicweb-version-3.9.4 for changeset 6cebb361dcb2

3.9.4

i18nupdate

[rql2sql] add test for rql bug #37423, which triggered a cw bug fixed by this changeset (infinite loop with some queries...)

[doc] started js/css coding standards

fix idownload view pb. for xhtml browsers

backport stable

[selectors] fix is_instance bug w/ parent classes. Also slight performance enhancements by changing what's returned by vreg['etypes'].parent_classes method (dedicated for this usage...) and removing no more necessary methods

[schema view] we don't support multiple inheritance

[view] use the new magic js object to generate javascript func call for auto reload user callbacks

[js/edition] fix pb with IE not handling long GETs #1203789

[migration] commit only sql script migration

[index page] refactor add_entity_link: no need to give request, nicer to check perm before calling the method, and use the new create url factory

[facet] refactor bookmark this search link creation: check perm before calling the method, and use the new create url factory

[view] deprecate create_url in favor of a cw_create_url class method on entity classes also kill view's output_url_builder method, unused anywhere...

small cleanups

[vreg debug] use classid to get cleaner output

[windmill] add xul-ext firefox plugin

[migration] unify process_script command - simplify wrapper by putting the logic in the migration module - enable sql script in shell invocation - adjust cmd_process_script docstring in interactive shell

tests: use larger timeouts in windmill tests

backport stable

[session] session auto reconnect feature has gone with the session-time refactoring in 6012:d56fd78006cd

[debug view] action moved

[test] check_session returns an int since 6012:d56fd78006cd

[editcontroller] turn eid into an int if possible, avoiding pbs. further down (case: preview cube)

[session] this log should be at the debug level, not info

[ms] log after preprocessing, else we don't see the query which is actually planned (may have been modified by security insertion)

backport stable

Added tag cubicweb-debian-version-3.9.3-1 for changeset ab1f9686ff3e

Added tag cubicweb-version-3.9.3 for changeset 900772fd9caa

[forms] default combobox view should accept arbitrary keyword arguments

3.9.3

i18n update

backport stable

backport oldstable

[security] don't put uncrypted password in query parameters, else it may be logged on error

[relations in ui] provide context information when computing label for a relation

[security] do not show sessions information to non managers users. Close security ticket #38246

[dbapi] update renamed argument

[debug] improve debug messages

[dbapi] cleanup shared data api: let access to transaction from dbapi, we can write it after all... Also, querydata is better named txdata

[session] cleanup session-time / cleanup-session-time... which are hard to grasp while there is no actual benefit to handle both. Now repo will close session without any activity since cleanup-session-time (24h by default), and the web authentication chain won't reconnect automatically anymore. I don't think there is a big deal in keeping repo session for such time. Also, ask the repo for latest session usage time, we can't know it for real on the web side (think of long running transactions). Closes #1083245.

[debug] when a loop is detected in a tree, log the entity involved in it to ease repair

[image js] fix image fit screen function

[idownloadable primary view] when file is an image, display attributes below the image

[selector] adjuts score returned by the adaptable selector to get correct priority over is_instance

[navigation] refactor previous / next navigation component to ease overriding

[massmailing] need edition.js for the freeezeFormButtons function

[views] link to public url when trying https without an account

[image] more handy image resizing using javascript

[rql2sql] fix bug with NOT of inlined relation: NULL values are not properly handled and hence some rows won't be returned while the should

[schema sync] if something went wrong while getting rdef in precommit event, rdef adttribute won't be set in revertprecommit. We don't want to fail in such case

[migration] add script to repair instances which have lost some relation due to 3.9 + file 1.9 migration (bad Image -> File entity type renaming)

[uiprops] check that STYLESHEETS* and JAVASCRIPTS are lists

[migration] fix rename_entity_type to avoid to loose some relations on the way

[js] fix bug encountered with IE (result evaluated to true while no response text -> json parse error)

[table view] fix bad arguments given to form_filter method

[deprecation] remove 3.8 deprecation warning

[test] improve windmill integration, new test on relation edition Changes: - display traceback in case of failure - add new use test for relation edition - edition mode is now possible by toggling `edit_test` or with using "pytest -i" - install firebug extension in edition mode - update documentation

backport default into stable. STABLE IS NOW 3.9, default 3.10

backport stable into oldstable. oldstable is now 3.8

cleanup

[css] set 100% width/height on image from idownloadable primary view

[c-c start repo] config log's threshold is upper case while option accepts lower case. This break c-c start of repository instances.

[querier] actually fix bug attempted to be fixed in 5942:f1abba8ccc01. The pb was not in multi-sources but because of missing annotation on rql generated by security insertion

[basetemplate nav] no need for an attribute here

[images] use tags.img and allow to add arbitrary attributes on the image. Use it to set a class when image is the primary entity

[images] add link around main image

Added tag cubicweb-debian-version-3.9.2-1 for changeset 8a23821dc138

Added tag cubicweb-version-3.9.2 for changeset e51796b9caf3

3.9.2

backport stable

[idownloadable] fix download_url prototype: should accept arbitrary kwargs to add as form parameters to the generated url

[entity] fix setdefault implementation: should return actual value

[web] eid key is deprecated

[js] cleanup

[js] fix typo causing blank page...

[transaction] if error on rollbacking a source, replace the connection by a new one

[transaction] do not attempt to reconnect if there has been some write during the transaction

[testlib] when no validator specified, simply return stripped output, not None

[3.6] fix deprecation warnings

[ldap] take care, email address may be a list. In such case, only consider the first one (XXX). Also, fix call to reset_caches.

[ajax] fix the fix introduced in 3.9.1 to avoid duplicated loads: it cause some other errors since the browser may load the script *after* the server-response event is emited, causing pb if the script interact with this event

[broken schema] fix the group_mapping function in case where some standard group isn't found: we currently loop for ever, boring the user by asking ever and ever the same question...

[ldap] fix update script

[c-c shell] script to update the base dn of an ldap source

cleanups

[iprevnext] implements cell_call to remove warning when displayed in the main content zone

Added tag cubicweb-debian-version-3.9.1-1 for changeset 9bd75af3dca3

Added tag cubicweb-version-3.9.1 for changeset 4d75f743ed49

[actions] homogen action/view selectors. Move action together with associated view to avoid such thing in the future

3.9.1

i18nupdate

[config] run time directory created when necessary on startup, don't check it exists while creating the instance (closes #1177687)

backport stable

merge stable heads

Added tag cubicweb-debian-version-3.8.7-1 for changeset 1cccf88d6dfe

Added tag cubicweb-version-3.8.7 for changeset a1a334d93439

[form] take care to not unicodify None values

[fti migration] test and fix reindexation of some specific entity types

[doc/book] fix & enhance rql intro chapter

[ajax box] shouldn't give js object directly to xml_escape

[uilib] js objects implements __unicode__

[test] fix test_ajax js tests. We have to mock some of our js functions / variables (e.g. _ or pageid) in the test environment

[box] provide a new generic base box class to edit relation to simple entities, backported from the 'tag' cube

backport stable

[test] remove deprecated test file

merge

[web/views/reledit] explicitely add the field if the formid is base + line cleanups

[ftirank] when ordered by fti rank, we don't want page navigation. Anyway, sorted nav component shouldn't consider has_text relation.

[multi-sources] we should annotate those queries, else there is a chance to get bad sql...

[tests] make sure controllers created by ctrl_publish() have a valid appli attribute

[test] buggy import make test fails

[uilib] refactor json_dumps code organization

[uiprops] use lazystr and update some variables usage in css to get a chance to change style without having to change all properties. Also had missing boxHeader.png file (formerly header.png).

[uiprops] introduce lazystr to get a chance to change style without having to change all properties

[javascript] more cleanups and deprecation warnings removal

[js] fix misplaced bracket

[forms] we need a wrapping list to avoid bug caused by flatening done by $.map. Closes #1164908

[web configuration] http/https ui properties should not share the same cache directory

[web configuration] ensure data home directory / uicache file belong to daemon user and are writeable

Added tag cubicweb-debian-version-3.9.0-1 for changeset eda4940ffef8

Added tag cubicweb-version-3.9.0 for changeset d9936c39d478

[debian/control] do not forbid shipment with python 2.6

[cube dist] fix default setup.py, well we get the cube also installed in lib/python, that may cause pb (eg the email cube for instance). UPDATE YOUR CUBE's setup.py

[migration] new migration command to change fti weight for an entity t ype

[form] field.vocabulary return values as string, more fixes

backport stable

prepare 3.8.7 release

[book] update rql documentation and some erroneous/deprecated examples

fix bad merge

[interface deprecation] fix bad comment

[test] class has been renamed

backport stable

3.9

i18nupdate

[config] expand_cubes(with_recommends=True) shouldn't return recommened-but-not-installed cubes

[form fields] smarter __str__ / __repr__

[skel] nicer test file skeleton

[form] test update/remove deprecation warnings: form vocabulary should contains unicode values

[test] add default generic test Tags to CubicWeb TestCase class

[itree] backport default combobox view for entities implementing ITree (from folder/zone cube)

[form] vocab function must now return values as unicode

[facets] fix bug w/ vid in facet's js introduced in 3.9, improve navigation component so that show all link use ajax when called from ajax.

[javascript] fix some javascript errors and remove some deprecation warnings

[forms] bw compat code for vocabulary function returning typed values

[web config] fix old css compat code: we have to modify locate_resource prototype so it return (potentially hacked) file name as well. Should only impact the file cube which has to be released anyway.

[repository] fix so that when repository is shutting down, internal session in transaction are interrupted

[test] windmill: add a timeout between JS assertion in test_creation use case

backport stable

[selectors] fix dumb name error introduced in parent changeset

[css] old css bw compat with @import in a custom css

backport stable

[selectors] relation_possible selector should check user may read target entity type when specified

imported patch selstrfix.diff

imported patch rql2sqlfix.diff

[migration] fix rename_entity_type to an existant entity type: get back relation from the old entity type non existant on the target type

cleanups

[selectors] avoid spurious warning when using implements by design

[session] don't log reraised error occured during precommit

[doc] proof-reading and improvements

[selectors] fix warning stack level

[schema migration] import refactoring to fix #1109558 and enhances things on the way the main pb demonstrated by #1109558 was due to the fact that in-memory schema was updated in commit_event of operations. This is undesired in most cases, since we want the modification to be taken into account in the interval between the modification detection and the commit_event. I've fixed this by merging in-memory schema / database alteration operations for most important changes, doing in-memory schema changes as they are detected and implementing a revertcommit_event method to revert them if necessary (with exception for removal of stuff from the schema, where this is simply done in a postcommit_event methods). Also, I've benefited from this to support reverting of database alteration for some operations (more to be done there), and to move so system source alteration code to the native source code for a nicer design. There may be some more stuff in syncschema.py that would benefit from similar changes, but most important things are done (at least to close #1109558, w/ unittest_syncschema and unittest_migration green).

backport stable

[test] running transaction while session is closed are now killed, update test accordingly

[security] fix read rql expression insertion: we should not insert rql expr on variables only referenced in neged relation

[rql2sql] test and fix crash when OR in HAVING where both expresion are 'fake' having terms (eg not using aggregat function)

cleanups

[config] use hashlib to avoid warning w/ py2.6

[req] hashlib has no hash function, but has an hash1 function even in python 2.5

[utils] improve repr() of RepeatList

[doc] fix typo

[selectors] use before-registry-reset event to init is_instance cache: cleaner code and avoid reloading bug (making hooks test fail for instance)

[vreg] new [before|after]-registry-reset event, taking vreg as argument

[doc] update book for adapters

[reledit] fix relation cardinality handling

[selectors] provide a new, optimized, is_instance selector that should at some point replace implements (along with the adaptable selector)

[web/views/massmailing] fix cancel button msg/icon

[testlib] improve test description messages

[web/views/reledit] fix typo (-add we used as id component in delete id)

[web/test] fix test (doreledit must have a formid and this is now checked)

[web ui] add missing image

[ITree] small fixes: parent_entity is a IBreadCrumbs method, we should use .parent on ITree

restore bw compat on Entity.related_rql

reledit refactoring * js handling rewritten to exploit all form capabilities (such as file upload ...) * attribute-like composite relations (one ttype, cardinality in '?1' from composite side) are more cutely handled, with a 'add'/'delete' additional actions/icons * a reledit_ctrl rtag to finely control: reloading, edition and default values * a proper chapter in the documentation (book) * many bugfixes

backport stable

cleanup

[idownloadable] make the download view http cache friendly

[publisher] avoid useless rollback after successful commit, which clutters debug logs and may also not be cost-free

[controller] same method defined on the base class

backport stable

merge stable heads

Added tag cubicweb-debian-version-3.8.6-1 for changeset 607a90073911

Added tag cubicweb-version-3.8.6 for changeset 1a24c62aefc5

[dbapi] refactor so that cw 3.8.6 can still speak with a 3.8.5 server

cleanup

[bfss] fix file update to ensure file's content is available on the fs asap... and not only at commit time. So it's consistent with entity creation behaviour. The new file is created at assignement time and removed if the commit is rollbacked.

[ldap] fix exception handling on authentication error

[ldap] cleanup password checking

cleanup

[css] make body bg color configurable

bump version number to trigger migration

3.8.6

[migration] schema should be accessed through .repo

backport stable

[security] use set_operation for relation permission checking operation

[migration] refactor schema migration fix introduced by 5833:d7256ae7c1d1 so the code looks better and avoid clutering lgdb api. Depends on lgdb 1.0.5.

[schema migration] fix name error introduced in parent changeset

[schema migration] avoid potential duplicated ft reindexation due to multiple UpdateFTIndexOp operations by using set_operation

[sql generation] fix bug with inlined relation and referenced by other neged relation we should check in that the column is not null in such cases

[refactor] refactor rtag keys generations.

[fix] fix a uicfg bug in autoform_section When several rtags matches the same relation (for example "* login *" and "CWUser login *") inconsistent rtag could be merged.

[debian] fix logrotate error introduced by 5806:9ef0e95f4d2b: sh don't want spaces here

[debian] fix logrotate error introduced by 5806:9ef0e95f4d2b: sh don't want spaces here

cleanups

[login form] fix bad login field label by using pgettext

updated docstrings on Operation class

do not allow password-less bind: windows accepts this as Anonymous Logon

[#969169] don't display remove link in edition forms if the cardinality is 1

fix name error

fix schema migration hooks (partial) SQL Server requires some additional steps to alter columns (index drop and restore, etc...) and this in turn requires passing a connection on the DB to find out the indexes. Also partially fix an issue where the null_allowed value was not correctly computed. Still some problems in there (see https://www.logilab.net/cwo/ticket/1109558)

delete trailing whitespace

Had thought this could be done in cube, but it really needs to be done earlier in the migration process

EntityFormRenderer redefine open_form and add a div section, so redefine close_form to add the closing div tag

Backed out changeset c29c90223125 which breaks the cw tests

EntityFormRenderer redefine open_form and add a div section, so redefine close_form to add the closing div tag

reduce log verbosity in ldapuser source

[session] refactor session handling so that when calling session.close(), pool of long running transaction of the same session is properly freed

[debug views] set http cache max age to 0 on debug views

cleanup

[schema view] width isn't in authorized th attribute in xhtml DTD. katia, please do it another way.

[schema view] fix typo

[rql2sql] #1089207: do not encode Unicode strings from RQL statements to db encoding

fix bad merge

[css] more css rework, need visual test in compat/new modes

backport stable

[config] fix dumb name error

[form] apply patch #933771: format_single_value / vocabulary methods should *always* return actual value as an unicode string

backport stable

[repo] fix 'c-c start --loglevel LEVEL' for repository only configuration. Closes #1058269.

[transaction w/ separated web/repo processes] the dbapi should explicitly specify a transaction id to avoid confusion when web server / repository run in separated processes

[dbapi] Connection.load_appobjects should load site_cubicweb files as well, they may contains necessary RQL extension function definitions. Also kill some broken deprecated code in this method.

backport stable

Added tag cubicweb-debian-version-3.8.5-1 for changeset 5d05b08adeab

Added tag cubicweb-version-3.8.5 for changeset 2de32c0c293b

[repo] call entity.check() once before_update hooks has been called, to let them a chance to transform data

3.8.5

[debian] #1027463: logrotate script should filter out warnings

[schema migration] fix fix introduced in 5803:589e2e3fb997, test for backend alter column support should be done in the operation, else the associated index is not dropped while this is supported

[schema migration] fix backend compatibility issue by using type_from_constraints / sql_change_col_type instead of bare ALTER COLUMN

[schema migration] don't try to drop column if backend doesn't support column alteration (eg sqlite)

[session] when rollback_on_failure is false, we should not try to reconnect if the sql raised an error

Use SQL standard ALTER TABLE command (with ADD instead of ADD COLUMN)

reduced logging verbosity in ldapuser source

use sessionid in log message

constraints can contain unicode values

[entity] fix .complete so we don't crash on missing mandatory relation. Also simplify code. Closes #1058267

closes #1059729: cw-ctl upgrade : i18n upgrade not performed if DB does not need upgrade

[devtools/qunit] prefix jquery_dir with 'file://' (as this is used from within a web browser)

[devtools/qunit] Locate jquery through cubicwew config to handle installed setup

[rql2sql] use new dbhelper.sql_concat_string function to deal with sql string concatenation. This together with lgdb 1.0.4 fixes #1055133: SQL Server support : string concatenation issue

[session] update session's timestamp in session.execute, so long running transactions are not erroneously closed by the repository

[repo session] expected argument is the source, not the session

[devtools/qunit] in safe mode, ffox launches a stupid popup

[ldapuser] quieter ldap result info, fix commented block style

[qunit] use safe mode for firefox

[qunit] Move qunit.js and qunit.css in devtools/datadirectory

[test] fix stupd name error

[test] fix test w/ closed connection pb

[ms] orderby/groupby/having attributes of Select node should be resetted to empty tuple, not None

[devtools/teslib] be more defensive on rollbacks

[rql2sql] when using HAVING to by-pass rql limitation (not to filter on result of an aggregat function), we should emit SQL that doesn't use HAVING to avoid potential backend error because variables are not grouped. Closes #1061603.

[doc/book/faq] question on security

[qunit] check that the browser has not died by himself before we asked him to stop.

[qunit] improve output of suprocess error The exception message now include the stdout and stderr of the called process

[test] workaround connection leak making tests fail under windows environment (though we've still probably some open connection leak to resolve...)

[web request] in python 2.5 hashlib has no .hash attribute

[web actions] fix recent refactoring, leading to missing redirect parameters in action's url

[packaging] more cleanups, handle javascript test files

backport stable

[facet] use vreg.parse so the rql syntax tree is properly annotated as well

[text search] fix fulltext_container indexation

[md5script] cleanup

[py2.6] use hashlib to silence python 2.6 deprecation warnings

[autoform] do not show remove link for inline form if card == 1

[fti] support for fti ranking: has_text query results sorted by relevance, and provides a way to control weight per entity / entity's attribute

[packaging] MANIFEST.in cleanups, update js/css copyright, remove no more used files

[js tests] fix javascripts tests definition, test_datetime.js now included in test_utils.js, which test other stuff as well

[entity] can't do anymore dict(entity) since entity doesn't inherit from dict

backport stable

[vreg] register_objects lost its force_reload argument, fix dbapi.Connection.load_appobjects consequently

backport stable

[test] unittest_multisources: external source shouldn't use the same database as the main repo...

[test] miss main

imported patch asynchronous multipart parsing.diff

imported patch cookie handling: do not use semicolon as it has some tech meaning (web2 -> web)

[entity] when .related() is called on a not-yet-saved entity, return an empty rset/list instead of raising an assertion error

[filefield] normalized file names to deal with windows files

[c-c exlog] fix code and documentation

[test] support for test on postgres database using the same mecanism as sqlite: one template database generated when necessary + actual test database created from the template * * * [test] reset postgres database between test of the same fixture

fix bad merge

backport stable

[test] properly close connections during test

[repo] on repository initialization, properly shutdown intermediary repository

[repo] on repository shutdown, we've to close the new eid creation connection

[auto-reload] we should never call load_module with use_sys=False, that may lead to inconsistency with module interdependancy (eg module get imported by another one, then is reimported by the vreg to load its appobjects. Cleanup of sys.modules done before reloading should be enough.

[rset] do not filter rsets with __getstate__, ensure whatever flies with pyro has no .req attribute, also set the ._rqlst to None since it will be reconstructed later on demand

[security] SchemaRelation.has_perm grows to new arguments allowing to specify subject/object entity type when actual eid are not known, but their types are

[linkto action] refactor to ease overriding to control redirection

[hooks] entity_oldnewvalue should never return _MARKER: if the attribute isn't in the entity dict (hence unmodified), return the old value

Use the qunit automatic launcher for existing testcase.

Add a QUnitTestCase class to run qunit test case.

[twctl] add missing poststop method #1058268

[rset] make rsets picklable (again ?) #1056422

[jstests] nicer test page title

[jstest] get back more tests writen during the sprint by vgodard

cleanup

backport stable

Added tag cubicweb-debian-version-3.8.4-1 for changeset b7883287f40c

Added tag cubicweb-version-3.8.4 for changeset d00d1fab42af

cleanup

[selectors] relation_possible selector accept None as action, in which case no perms checking is done

3.8.4

[xhtml] fix soup2xhtml to deal with malformed div,body and html tags which may leads to malformed return value

[source] remove debug

[entity] add .clear() for bw compat

[3.9] api update (mostly js) + add support for FCKEditor in formContents js function

[json] fix json serialization for recent simplejson implementation, and test encoding of entities as with earlier simplejson implementation, iterencode internal stuff is a generated function, we can't anymore rely on the _iterencode overriding trick, so move on by stoping isinstance(Entity, dict). This is a much heavier change than expected but it was expected to be done at some point, so let's go that way.

[adapters] enhanced warning

[test] fix test broken by 5721:61d6a4caa963, and update it to proper adapters to avoid deprecation warning

[3.9] update warning message

[iprogress] move adapter to entities.adapters

fix wrong calculation of clean_session_interval

[ITree] more fixes, fix fixes

[idownloadable] depends on a new mtconverter release

[ITree] fix adapter/_done_init to handle tree_[attribute|relation], add maxlevel argument to base tree view since one side effect of the new code is that it find tree view for entity types it didn't find before, hence one may want to limit tree view depth when it wasn't necessary before

[3.9] fix tests

[web] move itree adapter to entities, it may be used outside the web interface

[view] add a new entity_call method to entity view protocol, allowing some to work with not yet created entities. Also, start considering 'eid' form parameters where we only consider 'rql', so we can move on bloquing arbitrary rql inputs (more to do on this...)

[idownloadable] refactor IDownloadable primary view to make overriding easier

[web] ajax_replace_url superseed build_ajax_replace_url, more generic and relying on the json controller (closes #750090)

[form] refactor meta-attributes handling: hide them by default using uicfg.afs instead of returning None (or not, according to skip_meta_attr flag argument) in guess_field

[repo] fix typo

[req] fix format_time w/ 0:0 which is evaluated to False

[view] ensure fallback_oid is specified before trying to select fallback view, else simply raise the exception

fix merge, forgot to save a buffer :(

backport stable

[rql2sql] fix special 'X relation NULL' case (used by security insertion), broken by recent removal of IS operator in RQL

[javascript] add a name property to namespaces, mainly for convenience in helpers such as movedToNamespace

[rql] IS operator killed in rql 0.26.2, use equal instead

[security] consider any rql expression refering to X while X is being created as satisfied

[rql] more update to 0.26.2 api

[querier] fix rset description bug with some union queries

[devtools] fix get_available_port implementation: it should only return the port number if unable to connect

[javascript] move CubicWeb object declaration to cubicweb.js, remove CubicWeb.provide/require, use cw instead of CubicWeb

[javascript] move Deferred implementation to cubicweb.ajax.js

[form] fix untested (unread?) has_been_modified implementation...

backport stable

[autoform] fix vreg module name

[pylint] fix detected name errors

[pylint] fix detected name errors

[repo server] fix startup bug, lgc.daemon.daemonize return 1 for the parent process, not -1

backport stable branch

[source] don't create the eid_creation connection at source initiliaztion time This fixes the "already opened connection bug" in db-restore for instance.

[schema view] only catch key errors

[schema view] improve it slightly by attributing the same color to rdef of the same relation type

[rset] Add a line break the first result in repr of multiple rows rset Improve readability of rset while debugging by aligning the first value with the others if the rset have multiple row. This first line was usually not read as it' was on the same line that the first part of the repr ("<rset <RQL>, (%i rows) ...")

[schema diagram] ticket #191599, make schema image look better

backport stable

[workflow image] remove debug code

[request] fix typo

[security] view was giving web access to every fs file accessible by the web server process. Fix this security hole by storing file in session data, not direct form parameters

[hooks] fix typo in workflow hooks category

[security hooks] fix bad merge

backport stable

Added tag cubicweb-debian-version-3.8.3-1 for changeset 1ccaa9247860

Added tag cubicweb-version-3.8.3 for changeset 7e6c6a2a272d

[edit ctrl] fix bad interaction with fields: the loop on actual fields should be done in has_been_modified

[web test] add basic windmill tests and documentation - connection / deconnection - user creation

[web test] Add windmill functional testing capability.

3.8.3

i18nupdate

[editform] consistent [do]reledit between attributes and relations: check if rdef is hidden in main section of uicfg.afs for both attributes and relations, and in the reledit view, not in doreledit

on entity creation, accept attributes without any update access

[table] propagate paginate

no more need for specific handling of table view's displayaction it's handled as other view arguments in vidargs

[rset] do not break when rset.related_entity(x,y) is not an entity

[migration] fix schema synchronization bug sync_schema_props_perms('Repository', syncprops=False) to synchronize permission of entity's attributes wasn't working as expected: only the entity's permission were updated.

[javascript] refactor execution flow of handleFormValidationResponse so that location hash is set to #header whatever the error is

[package] now depends on yams 0.30 because of xy API changes

[xy] switch order of arguments for register_prefix()

HAVING sql clause don't know about comma...

[web/formwidgets] check on list (entity.related_cache swapped from tuple to list a while ago without known reasons), do not unicode wrap the eids

merge

[win32] defer import of logilab.common.daemon The module is not importable on windows, and etwist.service carefully avoids importing it (but imports etwist.server). Wait until we are sure not to be on windows to do the import)

[ajax] refactor/cleanup low-level ajax functions * loadxhtml/replacePageChunck/reload_component/reload_box deprecated in favor of loadXHTML / ajaxFuncArgs * some other cleanups in cubicweb.ajax.js * add js_render which will replace js_component (more generic, nicer argument passing handling)

[querier] test and fix potential bug in insertion query with multiple relations inside, caused by a name conflict. Also fix another bug non reproduced by using a set instead of a list (list may leads to compare entity instances which isn't allowed).

[form] avoid spurious warning subsequent for form's action refactoring w/ autoforms

backport stable

[web test] Add a CubicWebServerTC class to run test with a cw web serveur available.

[web server] vregistry may now be passed as named argument in CubicWebRootResource constructor This will be needed to start an http server for testing purpose. Also, server run command has now a debug name argument to set debug mode explicitly

[etwist] twisted won't install signal handler outside the main thread. This patch avoid some warning about this issue.

[vreg] ensure you can register an object from module not known yet. This ease registration of arbitrary objects during testing.

[web] cleanup use of config in web application initialisation

fix unit tests by not using the new create_eid implementation with sqlite Actually, fix a couple of issues with a previous attempt: * do not use double underscores as method patching will fail with these * old method must always be used with sqlite regardless of the no_sqlite_wrap attribute

cleanup the no_sqlite_wrap attribute after this test is executed

merge back on-site fixes

various brown paper bag fixes

merge

fix create_eid for sqlite (and bring back tests)

backport improved on-site change

TimedCache now only accepts values expressed in seconds updated ldapuser.py and pyrorql.py to that new interface.

backported to stable some changes made on site for a customer

logging settings * document helpful log format when dealing with MT issues * on Win32, use a logrotate equivalent so that logs get a bit lighter (requires updates logilab.common)

[win32] fix deadlock occuring on the sequence tables with SQLServer actually, this deadlock would occur with any db backend other that PostgreSQL as the previous code was heavily relying on PG's SEQUENCE facility, not available elsewhere. Deadlock description: Thread1 starts creating entities (and therefore calls create_eid): -> this creates a DB-level lock on the entities_id_seq table, which will last until end of transaction Thread2 calls create_eid, which acquires the Python lock object, but updating the entities_id_seq is held by the DB lock Thread1 wants to create a new entity, calls create_eid, and is stuck by the Python lock object held by Thread2. Solution: use a separate connection to read and write the entities_id_seq table.

log the user name on session opening for easier debugging

more robust handling of looping task configuration in ldap source * use minimum times * updated documentation and help strings * fix the minutes vs. seconds confusion

backport stable

[rql2sql] fix scope computation of variable from temporary table

stop being dumb please

backport stable

[tableview / facets] to work properly with facet, initial table should handle case where actualrql isn't specified

[test] generated html differs w/ pygments version

[storage] source's callback has a new prototype, update usage

grmbl

grmbl

backport stable

cleanup

[external storage] refactor to give session to storage's callback (needed by vcsfile storage)

[navigation] use pageContent instead of paginated-content as default div id, paginated-content doesn't seems used anymore

[test] update test to follow recent navigation/facets fixes

[tableview] use pageContent instead of paginated-content as default div id, paginated-content doesn't seems used anymore

[sparql] improve error reporting and fix one bug

[test] add missing __main__ as expected by apycot pyunit checker

[tableview] don't fail with AttributeError when paginated as main content view

[facet] we must add type restriction for attribute facets as well

[tableview] support for json-paginated table if paginable

[navigation] view may implements page_navigation_url to handle them self url generated for pagination

[navigation] when there are to much results, use a <select> based page navigation

[primary] add missing version number to deprecation warnings

[sparql] fix type inference (test_dctitle_both_project_cwuser) and support for <http://www.w3.org/1999/02/22-rdf-syntax-ns#type tag (test_base_rdftype)

[form] remove double property call

cleanups

[sparql] add failing test for two entities with dc:title

[sparql] adding test for "rdf:type -> is"

proof read documentation some clarifications, some typo fixes, and a couple of other strings fixed on the way

skip flymake junk when reloading this avoids nasty ex aequo scores in selectors in dev. mode

merge back to stable some changes made on site for a customer.

[win32 SQLServer] connection lost detection The pyodbc driver when connected to SQLServer 2005 reports lost connections in a quite strange way, raising a pyodbc.Error exception with a specific exc.args value. This patch catches these and reconnect properly.

ldap: reset cache when a user is deleted When a user is deleted from ldap, reset both caches used by the source otherwise the search is not performed again and exceptions such as UnknownEid: No entity with eid 74078 in the repository will occur

ldap source logging Added some extra logging statement to understand what happens in the ldap source.

forbid looping tasks with an interval of 0 This severly harm the server, and generally are the result of a baaad configuration file. We want to stop the server asap when this is detected to give people a chance to fix the configuration.

/siteinfo page: display information about the names of the running threads

[win32 service] activate logging to the configured file as soon as possible since we don't always have access to the system events of the computer running CW it is important to get as much information as possible in the log file, especially startup failure messages.

[bfss] Rename filenames according to their metadata on entity update.

[form] missing return...

[adapters] fix NameError introduced by adapters refactoring

[security] fix security insertion on DISTINCT queries

[adapters] fix bad copy and past....

backport stable

[rql2sql] properly compute scope for variable from temporary tables

[form] fix bw compat issue introduced by 5588:377c9adfe81e

[web] update to 3.9 Entity api

backport stable

[migration] force 3.8.3 migration, and fix it (same_as not necessarily there, missing group change for max-post-length)

[forms] refactor action handling to ease overriding while keeping action overrideable by instance (closes #969167)

[web] dont attempt to update last login time on ldap users, avoiding spurious tb in logs (closes #914464)

[c-c] use logilab.database, not lgc.db

[sqlite] fix crash on db-create with sqlite abd unexistent database due to missing paren in logical expression (closes #909604)

[web] disallow authenticated users to access to the login form (closes #914873)

[reledit] #894131: use "<`attribute` unset>" instead of generic "<not specified>" when an attribute or relation has no value

[rql2sql] follow rql 0.26.1 changes: NOT nodes normalization, allowing simplification of sql generation, and fix #XXX

[repo] ensure thread is alive before calling .join. Closes #963580

[migration] add migration file commands to follow option group changes

fix 978144: exception with view send-email if empty subject

[test] fix test broken by introduction of adapters

[schema] fix same_as cardinality and bump Bookmark.path max length to approximative max url size

[deprecation] fix 3.9 deprecation warning

no more Image type w/ cw 3.9

[fti] fix name conflict introduced by the new IFTIAdapter

[entity] clearing adapters cache in clear_relations_cache avoid weird caching issue, notably on repository session's user

[vreg] should raise exception on select ambiguity when running in test mode

[adapters compat] make implements_adapter_compat selector compatible with attributes

[test] no more Image type w/ cw 3.9

[adapters] refactoring fixes

[selectors] ensure selector return an int

[selectors] adaptable selector should not accept None in rset

[selectors] lltrace appobject_selectable selector

[selectors] allow to override `accept_none` value of EClassSelector / EntitySelector based selector by specifying a value in selection context

[selectors] move lltrace decorator and traced_selection cm to appobject module so we can apply lltrace to And/Or/Not selectors, fixing #662565

with cw 3.9, no more Image type

[vreg] on registration completed, don't crash if an object depends on an unexistant registry, simply kick the object out

[selectors] ensure adaptable('IDownloadable') takes precedence over implements('Any')

[primary view] fix name error on dispctrl w/ pre 3.5 box definition

[entity] fix access to attribute which has been renamed two revisions ago

[schema migration] make some stuff to ease file 1.9 migration : we want to kill the Image entity so that existing image are turned into (existing entity type) File entities

[entity] continue cleanup of Entity/AnyEntity namespace * prefix by cw_ or _cw all '2nd zone' attributes / methods, other most commonly used will be done later (some methods used by client are made private anyway when they are for internal purpose anyway) * kill set_eid, use direct affectation instead * kill the auto-transmutation feature (pre_add_hook), hence releasing 3.9 will require releasing file cube as well

[entity] introduce a new 'adapters' registry This changeset introduces the notion in adapters (as in Zope Component Architecture) in a cubicweb way, eg using a specific registry of appobjects. This allows nicer code structure, by avoid clutering entity classes and moving code usually specific to a place of the ui (or something else) together with the code that use the interface. We don't use actual interface anymore, they are implied by adapters (which may be abstract), whose reg id is an interface name. Appobjects that used to 'implements(IFace)' should now be rewritten by: * coding an IFaceAdapter(EntityAdapter) defining (implementing if desired) the interface, usually with __regid__ = 'IFace' * use "adaptable('IFace')" as selector instead Also, the implements_adapter_compat decorator eases backward compatibility with adapter's methods that may still be found on entities implementing the interface. Notice that unlike ZCA, we don't support automatic adapters chain (yagni?). All interfaces defined in cubicweb have been turned into adapters, also some new ones have been introduced to cleanup Entity / AnyEntity classes namespace. At the end, the pluggable mixins mecanism should disappear in favor of adapters as well.

backport stable

[config] move web specific config to the web section of the configuration file

* * * [server] move daemonize code to lgc.daemon. Fix on the way pb w/closed standard output on repository config

typo

[migration] fix storage_change migraction to avoid exhausting the server's memory

[repo] set log methods on the actually desired class

[bfss] ensure base name doesn't contain path separator

merge

[web] remove dead code

[forms] consider __action_xxx field if passed to JSonController.validate_form

backport stable

Added tag cubicweb-debian-version-3.8.2-1 for changeset 2b962bb9eee8

Added tag cubicweb-version-3.8.2 for changeset ef2e37d34013

[test] absolute sqlite database names in source initialization, avoid pb when cwd is changed later

clenup

3.8.2

[wdoc] update users changelog

[integrity] keep ordering for schema integrity checks set_operation gained a new containercls argument, so one can choose to use list or set (by default). Use this when registering schema integrity check operation.

[i18ncube] do not crash if cube has nothing to translate

[skel] enable wdoc support in new cubes

[preferences] support dot (.) in registry id of configurable appobjects

[i18ncube] we must load site_cubicweb file before calling set_schema, else we may miss some options or other initialization stuff necessary to appobject loading

[dtd] add unselimg attribute use by widget for HasRelationFacet

remove 3.7 deprecation warning

catch unauthorized when executing rql to check an rql expression. Fix #968824

[startup view] sort startup views by alphabetical order

[table view] should use __regid__ instead of hard-coded 'table' view identifier

cleanup

backport stable

[facet] control i18nization of values on AttributeFacet

[views] tab schema image renamed to schema diagram

[uicfg] fix handling of 'order' in the primaryview_display_ctrl rtag: consider by default only schema order, not order of appearance of rules

[db-check] RQLConstraint is not a 'unique' constraint

[entity] avoid getting w in cw_extra_kwargs when calling .view

[actions box] enhance add related menu generation: don't propose to add relation of single cardinality where entity already have the relation set

[primary view] allow new 'subvid' parameter in primaryview_display_ctrl

[primary view] give dispctrl to side box views as for relations section

[web] unify list views call arguments: use subvid to specify the view to use for each item

[web] refactor side box to use autolimited view

[req] avoid getting w in cw_extra_kwargs when calling .view

[config] rename remaining inputlevel to level in option definitions, as expected by lgc >= 0.50

[fti] simplify UpdateFTIHook code

[twisted] we must set response code before starting to write the answer, else it's ignored

cleanup

[web data] remove files not used by the framework

[css] keep old css according to a configuration variable (true by default)

[3.8 execute] remove deprecation warnings

backport stable

[dbapi] missing import

[ajax] missing html heads processing in reloadComponent (sic\!)

[deprecation] missing version number to old warning message

[table view] we should call the cell view using the table rset, not one rebuilded for a specific entity

[table view] take care to None label

[selectors] new logged_user_in_rset selector

merge

replaced hardcoded 'web/view' by os.path.join('web', 'view') so views path is also valid under windows

fixed bug of non-normalized path under Windows, that broke the reload mechanism

[c-c list] configuration pb cubes directly hold version number now, avoid crash when reporting errors

Handle new way of reporting unmodified FileFields when a FileField has not been modified, value is an empty string. Handle this is raise UnmodifiedField accordingly.

merge

attempt to port windows service to 3.8.1