[dataimport] flake8

[dataimport] enhance a bit sql queries readability

[dataimport] use IF EXISTS when possible it's better than try/except and avoid potential concurrency problems.

[dataimport] PGHelper should be responsible to retrieve the database schema

[dataimport] introduce a new MetadataGenerator to replace former MetaGenerator with a similar-but-different API that will allow its usage by the massive store (no more entity object manipulation), while making it a bit more flexible for customization by subclasses (experience taken from client code). Related to #10338621

[dataimport] Prefer now(pytz.utc) to utcnow

[dataimport] rename nohook store .source attribute so it's clearly not the samething as metagenerator.source. Also add a bit of doc along the way.

[dataimport] make rql store test easier to read and test a few more thing, then reuse it to test nohook start which had no tests at all

[dataimport] remove useless assignment in massive store

[dataimport] move eid attribution from the metagenerator back to the nohook store

[dataimport] rephrase minor bits of the meta generator

[pkg] Depends on logilab-common >= 1.2.2

Merge with 3.22.3

[pkg] Depends on yams >= 0.43 RPM spec file and debian/control got updated previously.

Added tag 3.22.3, debian/3.22.3-1, centos/3.22.3-1 for changeset b1e7de000536

[pkg] Version 3.22.3

[pkg] Depends on yams < 0.43

Define BASE_URL and DATA_URL js variables in the login template. Closes #13385185 Those are expected to be defined in almost every js files. They were not before this patch because login form doesn't use the regular main template.

[web] Remove some unused imports in editforms

Fix cancel action on deletion confirmation form Currently crashed with RequestError: invalid action '__action_cancel'. It's broken as of https://hg.logilab.org/master/cubicweb/rev/cb217b2b3 This fix is similar as the one done in https://hg.logilab.org/master/cubicweb/rev/9f1c89e7426d Closes #13521493

[rql2sql] Test and fix some case of sql generation when an unstable variable (ie whose type change from one solution to another) is used in an EXISTS node but belongs to an outer scope. Closes #13518646.

[test] Add missing os import in unittest_migractions.py Dropped in ^ merge.

backport 3.22 changes

[entity] Make it possible to specify sorting terms in cw_related_rqlst method Closes #12306543.

[sql gen] Properly create UNIQUE index on non string column. Closes #13728492 Unique was previously detected in a loop triggered only for String columns.

[server] some pep8 changes

pep8 schema2sql

[migration] Drop custom "readfunc" for code.interact in shell As the referenced bug http://bugs.python.org/issue1288615 got fixed in Python 2.6, this is no longer needed. Furthermore the implementation is not Python 3 compatible (raw_input, unicode).

[tox] Put development dependencies into a dev-requirements.txt file The latter being sourced in tox.ini. For now this contains references to hg repositories for some dependencies but under normal circumstances it should only contain pytest. This is useful when developping cubicweb itself without using tox but working with a virtualenv so that one can simply do: :: $ virtualenv --system-site-packages venv $ . venv/bin/activate $ pip install -r dev-requirements.txt $ python setup.py develop

[py3k] Fix config-level comparison in "cubicweb-ctl create" command dict.get -> None, and None cannot compare to an int in Python 3.

[pkg] PEP8 fixes in __pkginfo__.py

[pkg] Drop "support" of unused subpackage_of option in setup.py __pkginfo__ does not declare subpackage_of.

Add missing import, eaten by previous merge

Only access once to _cw.message in the login form else the first access may pop the message and the second won't get anything to display. This works on default message implementation but doesn't on the pyramid's one, leading to no message displayed on erroneous authentication attempt, which is not very user friendly.

backport 3.22 changes

backport changes from 3.21

[server,bfss] fix bfss migration test for python 3 (related #13519541)

[pkg] Use io.open with utf-8 encoding to read long description from README This forces decoding so that this is consistent between Python 2 and 3 as, in Python 3, decoding which would occur anyways and may fail depending on the environment locale settings.

[dataimport] order of ExtEntities should be irrelevant (closes #13117472)

Test and fix "pickleability" of Binary objects which has been recently broken while some cubes rely on this (eg fastimport). Do some licensing/pep8 cleanup along the way. Closes #13385274

[server,bfss] fix storage migration when Bytes attributes is None (closes #13519541) When a Bytes attributes is None before the BFSS storage migration, the migration crashes. A Bytes attribute can be None, when the attribute is not required and there is no default value. In this case, the attributes should remained None after migration and no file is stored on the disk.

Let hg Ignore py.test's .cache directory And drop rule for .svn along the way.

[entity] Add a cw_related_rqlst method returning the RQL select node of cw_related method This is useful if one wants to modify the query before execution. A bit a PEP8 style fix in tests along the way. Related to #12306543.

[devtools] set .config in setUpClass instead of using a cache in a classproperty This is much clearer and avoid problem with py.test introspection that triggered creation and caching of the configuration before actual test execution. This caused pb in unittest_postgres.PostgresStatementTimeoutTC where configuration was built before module's setup, hence source configuration was missing information about where to find the pg cluster.

[devtools] Simplify test configuration's init Specify module's __file__ instead of apphome. __file__ is saved on the class as it will be used later (eg to find the proper pg cluster without relying on shared dictionnary modifications). This will require some tests update, but it should be less common in cubes than in cubicweb itself.

[web] Have the LoginController return 403 on failed auth (closes #11569950)

[devtools] Drop old init_test_database backward compat

[devtools] show DeprecationWarning during test execution They are not shown by default since python 2.7

[devtools] deprecate usage of sources file for test This is old support which clutters the code and should no more be used. As this is rarely used (if it is) and test only, it feels ok to drop support at once without a deprecation phase.

[devtools] Set dumb value for postgres's db-host to avoid unexpected connection to a local server Currently, if something goes wrong (eg config built before call to startpgcluster) while a pg server is running on localhost, it may connect to this server and run the test in there unexepectedly.

[ldapfeed] ldap3 do not raise an exception in case of failure of cnx.bind() but return 'False' instead.

[test] add a test to ensure we get an AuthenticationError with ldapfeed when using (correct login, wrong password) credentials

[entity] Exclude computed relations from Entity.copy_relations Closes #12481591.

[pkg] Set version to 3.22.2.dev0 So that cubes used in test dependencies do not install a released CubicWeb.

[devtools] pep8 a bit package's __init__

[test/server] Only use configcls with statement timeout when needed Other tests in PostgresFTITC class apparently do not make use of this particular configuration.