Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Sep 2014 13:43:31 +0200] rev 9947
merge 3.17.17 into 3.18 branch
Christophe de Vienne <christophe@unlish.com> [Wed, 10 Sep 2014 21:28:33 +0200] rev 9946
[wsgi] Fix unicode decoding in POST
The application/x-www-form-urlencoded sent by firefox or chrome is utf-8
encoded BEFORE being urlencoded.
Hence, decoding must urldecode THEN decode the utf-8 string, and not the
other way around.
Christophe de Vienne <christophe@unlish.com> [Thu, 21 Aug 2014 22:42:48 +0200] rev 9945
[wsgi] add the --debug / -D option to the wsgi command
Christophe de Vienne <christophe@unlish.com> [Mon, 08 Sep 2014 10:55:30 +0200] rev 9944
[wsgi] Fix multiple variables reading in params
Closes #4306081
Christophe de Vienne <christophe@unlish.com> [Tue, 02 Sep 2014 13:00:47 +0200] rev 9943
[wsgi] Set self.vreg
Closes #4306049
Christophe de Vienne <christophe@unlish.com> [Tue, 02 Sep 2014 10:31:13 +0200] rev 9942
[wsgi] Add missing import
Closes #4305988
Christophe de Vienne <christophe@unlish.com> [Tue, 02 Sep 2014 10:30:28 +0200] rev 9941
[wsgi] Fix https detection
- 'HTTPS' is not part of wsgi, it is a CGI variable. The right wsgi variable
is 'wsgi.url_scheme'
- Force https if url starts with '/https/' (and remove the prefix from the
path.
Closes #4305985
Christophe de Vienne <christophe@unlish.com> [Thu, 24 Jul 2014 20:57:14 +0200] rev 9940
[wsgi] Re-set the request content after calling the inherited constructor.
Closes #4191813
Christophe de Vienne <christophe@unlish.com> [Thu, 24 Jul 2014 20:53:21 +0200] rev 9939
[wsgi] Honor the 'CONTENT_TYPE' wsgi variable
See http://legacy.python.org/dev/peps/pep-0333/#environ-variables
Closes #4191812
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 17 Sep 2014 10:31:50 +0200] rev 9938
Added tag cubicweb-version-3.17.17, cubicweb-debian-version-3.17.17-1, cubicweb-centos-version-3.17.17-1 for changeset 57e9d1c70512
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 16 Sep 2014 18:39:07 +0200] rev 9937
[pkg] prepare 3.17.17
Julien Cristau <julien.cristau@logilab.fr> [Tue, 29 Jul 2014 16:26:09 +0200] rev 9936
[web/headers] don't list a request header twice in "Vary"
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Jul 2014 17:22:49 +0200] rev 9935
[test] silence a few more deprecation warnings in unittest_hooks
self.session → cnx.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 25 Jul 2014 16:24:44 +0200] rev 9934
[session] call rollback in Connection.__exit__
If we just free the cnxset and clear the Connection, we're missing the
pending operation's rollback_event callbacks, which may be needed for
cleanup.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Jul 2014 14:52:16 +0200] rev 9933
[devtools] pre_setup_database takes a Connection, not a Session
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 18:00:53 +0200] rev 9932
[source/native] cPickle is available in all supported pythons
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 22 Jul 2014 18:16:23 +0200] rev 9931
devtools: deprecate .req_from_url
Which uses .request()
And instead provide .admin_request_from_url, which
is a context manager yielding the request.
Christophe de Vienne <christophe@unlish.com> [Tue, 17 Jun 2014 11:14:20 +0200] rev 9930
[tests] Add a webtest based TestCase class
Closes #4002134
Christophe de Vienne <christophe@unlish.com> [Tue, 17 Jun 2014 11:53:35 +0200] rev 9929
[tests] Move 'anonymous_allowed' property from CubicWebServerTC to CubicWebTC
The effective set of the property on the config is now done later that before,
ie at the end of CubicWebTC.init_config instead of before.
It is believed not to have an impact on the test suites that uses
`anonymous_allowed`.
Related to #4002134
David Douard <david.douard@logilab.fr> [Tue, 02 Sep 2014 12:22:18 +0200] rev 9928
[compat] Remove imports of "any" and "all" from lgc (closes #4306044)
They're builtin since python 2.5.
Florent Cayré <florent.cayre@logilab.fr> [Tue, 26 Aug 2014 10:12:09 +0200] rev 9927
[css] Remove the `div` tag specification of the pendingDelete css rule
The HTML tag was changed by e2f96b16c3bd from a div to a span without
changing the css rule accordingly.
Closes #4285248.
Alain Leufroy <alain.leufroy@logilab.fr> [Wed, 21 May 2014 16:14:17 +0200] rev 9926
[cwvreg] cleanup the event manager when reloading modules
Closes #3848995
The event manager callbacks are not cleaned during reloading.
So the callback defined in the reloaded module appears twice (old and new
version). This may cause problem when the old version is called.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 12 Jun 2014 12:28:10 +0200] rev 9925
[test] Add missing attribute 'add' permission in test schema
Silences yams warning.
Florent Cayré <florent.cayre@gmail.com> [Thu, 01 May 2014 23:35:56 +0200] rev 9924
[facet html] Add surrounding div with "facetBody" class to "has_text" facet.
This makes its html structure consistent with the other facets
and fixes both css and a javascript behaviour (hide the facet body
when clicking on its title).
Closes #3797501.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 13 Jun 2014 11:00:41 +0200] rev 9923
[cwctl] don't prompt for cube options in automatic mode
Closes #3984223
Julien Cristau <julien.cristau@logilab.fr> [Fri, 13 Jun 2014 11:21:45 +0200] rev 9922
[serverctl] fix default value for db-init config-level
Otherwise cubicweb-ctl db-init --automatic complains that "--automatic
and --config-level should not be used together" when they weren't.
Closes #3984336
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 05 Jun 2014 17:41:14 +0200] rev 9921
[web] Return useful error messages when exceptions arise in ajax controllers (closes #3932503)
The call to super() in RemoteCallException passes 'reason' all the way to
python's Exception.__init__() which is then stored in Exception.args. This way,
CubicWebPublisher.ajax_error_handler() gets a useful error message when calling
unicode(exc).
The change to uilib is just to prepend the exception type name. Just a small
improvement.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Jul 2014 19:42:42 +0200] rev 9920
[test] Fix test breakage uncovered by previous changeset
Now that Binary.__eq__ doesn't always return true, this test started
failing. CWAttribute.defaultval is zpickled, and the description_format
attribute is a String, meaning unicode, so adjust the expected test
result.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Jul 2014 11:33:32 +0200] rev 9919
[etwist] use more specific REQUEST_ENTITY_TOO_LARGE instead of BAD_REQUEST
When a request body exceeds the configured limit, return 413 to the
client instead of a generic 400.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Jul 2014 10:34:50 +0200] rev 9918
[entities, view] delete dead code
The auto_unwrap_bw_compat metaclass calls unwrap_adapter_compat, which
was removed in changeset 697a8181ba30 "remove 3.9 bw compat". So this
can't possibly work anymore, meaning we can get rid of it.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Jul 2014 14:37:08 +0200] rev 9917
[book] stop talking about the hg `forest` extension
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Jul 2014 14:28:26 +0200] rev 9916
[book] update sections about dependencies
This is probably incomplete, but it's a start.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Jul 2014 16:24:17 +0200] rev 9915
[web/component] move unicode() call around
Makes Aurélien happier.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Jul 2014 12:07:50 +0200] rev 9914
[web/js] replace callAddOrDeleteThenReload with more generic callAjaxFuncThenReload
That's going to be a more useful replacement for callUserCallbackThenReload.
Closes #4178566.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Jul 2014 17:45:38 +0200] rev 9913
[hooks/syncsession] try to remove cnx vs session confusion
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Jul 2014 17:22:23 +0200] rev 9912
Fix Binary.__eq__ (closes #4172701)
Due to a typo we always returned true, which was unhelpful.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 16:35:02 +0200] rev 9911
[dataimport] stop ignoring errors on flush
That can only result in database corruption.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 16:31:34 +0200] rev 9910
[dataimport] don't commit on flush
Changeset 26cdfc6dd6f8 introduced this confusion for no apparent reason,
and it doesn't make much sense.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:35:28 +0200] rev 9909
[test] Add test for dataimport's RQLObjectStore
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 16:00:21 +0200] rev 9908
[dataimport] Stop swallowing errors from commit/flush
Silent DB corruption is not OK.
Also drop comment from ObjectStore.commit that I don't understand.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:59:34 +0200] rev 9907
[dataimport] Update RQLObjectStore to Connection API
Take a connection instead of a session. Don't play games with set_cnxset.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:51:58 +0200] rev 9906
[dataimport] remove _rql heresy
1) ObjectStore knows nothing about rql, it just drops it on the floor
2) RQLObjectStore has a session, it can run rql that way
3) setting an object's "_rql" attribute is not a reasonable user-facing
interface
Also drop _commit attribute from base ObjectStore, it doesn't use it.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Jul 2014 15:40:50 +0200] rev 9905
[dataimport] remove dead code
The only caller of ObjectStore._put is ObjectStore.create_entity, which
RQLObjectStore overrides (and doesn't call up).
Alain Leufroy <alain.leufroy@logilab.fr> [Tue, 03 Jun 2014 12:41:06 +0200] rev 9904
[dataimport] do not use sys.exit() to raise missing argument error
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 17:51:45 +0200] rev 9903
[dataimport] _create_copyfrom_buffer: add the tests
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 15:53:09 +0200] rev 9902
[dataimport] _create_copyfrom_buffer: do not ignore columns if data is a list
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 17:52:43 +0200] rev 9901
[dataimport] _create_copyfrom_buffer: fix datetime converter + add time converter
Include second and microsecond in the output instead of dropping them on the
floor. The time zone is not supported for now, though.
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 15:45:35 +0200] rev 9900
[dataimport] _create_copyfrom_buffer: raise ValueError if conversion cannot be performed
If the conversion fails, there is no reason to continue execution. One should
notify the error.
Continuing after a misconverted data could corrupt the database.
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 13:50:15 +0200] rev 9899
[dataimport] _create_copyfrom_buffer: fix separator check in string converter
The empty string is a valid replace_sep.
Related to #3845572
Alain Leufroy <alain.leufroy@logilab.fr> [Mon, 02 Jun 2014 13:50:15 +0200] rev 9898
[dataimport] _create_copyfrom_buffer: put converters into a list
Cleans up the code to avoid a succession of ifs.
Related to #3845572
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 17:35:25 +0200] rev 9897
merge 3.19.3 into 3.20 branch
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:44:44 +0200] rev 9896
Added tag cubicweb-version-3.19.3, cubicweb-debian-version-3.19.3-1, cubicweb-centos-version-3.19.3-1 for changeset 37f7c60f89f1
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:16:53 +0200] rev 9895
[pkg] prepare 3.19.3
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:14:58 +0200] rev 9894
merge from 3.18 branch
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 16:11:41 +0200] rev 9893
merge 3.17.16 into 3.18 branch
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 17 Jul 2014 11:08:56 +0200] rev 9892
Remove uses of logilab.common.compat.{all,any}
They're just aliases to the builtin ones on python 2.5+. If anyone needs
convincing:
>>> from logilab.common import compat
>>> compat.any
<built-in function any>
>>> compat.all
<built-in function all>
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 09 Jul 2014 15:44:09 +0200] rev 9891
remove references to global environment variable APYCOT_ROOT
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 11:37:57 +0200] rev 9890
Add warning messages when enabling remote pickle-based repository access
Warn when starting a pyro or zmq-only repo, or when one of these access
methods is enabled. Closes #2919295
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Jul 2014 12:23:01 +0200] rev 9889
[web] Fix expiry of anonymous sessions (closes #4154479)
Things like:
try:
foo
except:
bar
else:
baz
doesn't work very well if you expect baz to run even in the exception
case. Plus, session.cnx.check() is a dbapi remnant, so drop it and just
look at session.mtime.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 16 Jul 2014 17:20:55 +0200] rev 9888
[hooks/syncschema] avoid altering a dropped table
If the constraint's rdef is being removed, CWConstraintDelOp doesn't
need to do anything. Otherwise it may try to alter a removed
table/column. Closes #4154549
Florent Cayré <florent.cayre@logilab.fr> [Thu, 12 Jun 2014 09:59:55 +0200] rev 9887
[js] fix name error
Alain Leufroy <alain.leufroy@logilab.fr> [Tue, 03 Jun 2014 12:37:54 +0200] rev 9886
[devtools] improve error message when postgresql tools are missing
By default in at least Debian, some pg tools are not present in the
PATH. Or they may not be installed. But the tests tools expects them
to be in the PATH, and give an unhelpful 'No such file or directory'
backtrace if they're not found. To help devs using the pg tests we
improve the error message.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 11 Jul 2014 17:13:32 +0200] rev 9885
[server] Replace non portable strftime formatter (closes #4132161)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 12:15:18 +0200] rev 9884
[web/request] use a picklable Counter object for tab index counters
Related to #1381328.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 15 Jul 2014 18:07:31 +0200] rev 9883
[web/auth] The auth retriever's authenticated() callback takes a session, not a cnx
We don't have a cnx at that point.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 11 Jul 2014 16:44:42 +0200] rev 9882
[test] Fix the query-log-file test
Testing this functionality in a CubicWebTC is awkward because the
wrapping happens in handle_request, which tests basically bypass (they
call core_handle directly, and do their own magic for linking the
request with a cnx). The test method worked when ran on its own, but
not together with the rest of the test class. So use a CubicWebServerTC
instead, which goes through the whole stack.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 11 Jul 2014 13:48:07 +0200] rev 9881
[doc/book] spelling fixes in security tutorial
Julien Cristau <julien.cristau@logilab.fr> [Fri, 11 Jul 2014 13:15:11 +0200] rev 9880
[doc/book] spelling fixes in "testing" chapter
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 16:54:31 +0200] rev 9879
[datafeed sources] finish the session -> cnx switch
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 06 Jun 2014 15:56:24 +0200] rev 9878
[doc/book] update examples, using the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 17:20:18 +0200] rev 9877
[test/entities] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 12:52:50 +0200] rev 9876
[web] restore query logging functionality (closes #3972561)
The query-log-file option stopped working when the web stack was moved
from dbapi to repoapi.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Jun 2014 12:03:30 +0200] rev 9875
[cwctl] make cubicweb-ctl versions lighter (closes #4002158)
Set config.quick_start to avoid unnecessary appobjects and schema
loading.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 08 Jul 2014 14:02:43 +0200] rev 9874
Added tag cubicweb-version-3.17.16, cubicweb-debian-version-3.17.16-1, cubicweb-centos-version-3.17.16-1 for changeset a979d1594af6
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Sep 2013 14:55:56 +0200] rev 9873
[forms] consider inline creation form information as linkto info. Closes #3161121
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 07 Jul 2014 19:28:30 +0200] rev 9872
[pkg] prepare 3.17.16
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:37:52 +0200] rev 9871
[reledit] Fix reledit icons jumpiness (closes #4106867)
Introduce an "invisible" class (copied verbatim from Bootstrap) that
only sets the "visibility" property. "display: none" is the reason for
the whole jumpiness as it actually detaches the element from the
rendered layout. "visibility: hidden" only makes it transparent while
keeping its original box properties (width, height, etc).
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:29:37 +0200] rev 9870
[views] Replace poorly named "invisible" class with "list-unstyled"
"li.invisible" actually means "hide bullet". Use a reasonable name
instead, such as bootstrap's "list-unstyled" class.
This patch also changes the DOM element the class is applied to.
"li.invisible" had to be enabled on every "li" tag, whereas the
"list-unstyled" class only needs to be applied to the parent "ul"
element.
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:23:18 +0200] rev 9869
[views] a 'div' with 'display: inline' screams 'span'
(grafted from af6e3db801fcfbd6f562c4a7cfdc89f187042792)
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Jul 2014 14:30:16 +0200] rev 9868
[pkg] remove simplejson dependency
We no longer use it, the stdlib's json module is fine.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Jul 2014 12:18:34 +0200] rev 9867
Added tag cubicweb-version-3.19.2, cubicweb-debian-version-3.19.2-1, cubicweb-centos-version-3.19.2-1 for changeset 8ac2202866e7
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Jul 2014 10:22:36 +0200] rev 9866
[pkg] Fix version number
Note to self: don't phase -p before coffee.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Jul 2014 10:01:58 +0200] rev 9865
[pkg] 3.19.2
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 06 Jun 2014 14:55:26 +0200] rev 9864
[webtests] finish to give all self.view(....) a req=req parameter
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 16:30:58 +0200] rev 9863
[tests/syncsession] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Jul 2014 12:44:04 +0200] rev 9862
[webtests/application] remove unused imports
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 11:56:33 +0200] rev 9861
[webtests/application] .user(...) really wants a request object
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 15:46:16 +0200] rev 9860
[tests/datafeed] use the new connection api (a small leftover)
Test assertions get indented because of self.session -> scoped cnx.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 18:19:47 +0200] rev 9859
[entitiestests/base] don't store an entity on the test case
Make do with an eid.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 17:06:03 +0200] rev 9858
[entitiestests/base] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 15:21:18 +0200] rev 9857
[testlib] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 11:56:19 +0200] rev 9856
[exttests/rest] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:04:40 +0200] rev 9855
[webtests/bookmarks] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:19:56 +0200] rev 9854
[hookstests/integrity] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 18:01:16 +0200] rev 9853
[hookstests/base] use connections instead of web requests
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:55:07 +0200] rev 9852
[hookstests/base] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 14:54:53 +0200] rev 9851
[hookstests/syncschema] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 13:28:24 +0200] rev 9850
[tests/rqlannotation,querier] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 17:31:54 +0200] rev 9849
[webtests/web] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 14:55:02 +0200] rev 9848
[webtests/navigation] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 14:45:32 +0200] rev 9847
[webtests/basetemplates] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 15:14:13 +0200] rev 9846
[webtests/basecontrollers] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 14:43:07 +0200] rev 9845
[testlib] deprecate .remote_call and provide new connection api friendly .remote_calling
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 12:35:25 +0200] rev 9844
[webtests/propertysheet] kill an "import *"
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 12:27:26 +0200] rev 9843
[webtests/breadcrumbs] break long lines
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 17:20:00 +0200] rev 9842
[webtests/views_editforms] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Jul 2014 17:44:06 +0200] rev 9841
[webtests/urlrewrite] do not store a plain entity on the test, only an eid
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 11:17:09 +0200] rev 9840
[webtests/urlrewrite] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 17:16:38 +0200] rev 9839
[webtests/urlpublisher] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 11:00:50 +0200] rev 9838
[webtests/baseviews] use the new connection api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 15:11:00 +0200] rev 9837
[devtools/testlib,fill] use the new connection api (for auto_populate)
Note that this changes API of CubicWebTC's custom_populate and
post_populate methods to take a connection instead of a cursor, which
may affect some cubes.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Jul 2014 14:42:24 +0200] rev 9836
[webtests/automatic views tests] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 12:41:21 +0200] rev 9835
[devtools/repotest] simplify a very small helper
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 11:34:19 +0200] rev 9834
[tests/repotest] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:10:16 +0200] rev 9833
[tests/querier] use the new connection api (part 3/3)
Some adaptations to devtools/repotest:
* dead code removal
* remove session related code
In the tests:
* many tests actually don't check the querier but some generic rql
property -- when such a test needs several statements to complete a
commit, switch to session.new_cnx
* provide an assertRQLEqual helper
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 14:25:20 +0200] rev 9832
[test/querier] use the new connection api (part 2/3)
A couple of tests need a schema constraint to be dropped to pass with
`.qexecute`.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 13:56:24 +0200] rev 9831
[test/querier] use the new connection api (part 1/3)
In devtools/repotest, we provide a simple `.qexecute` with autocommit,
and we use it (where possible) in unittest_querier.
Note that the .session object is a real session, not the magic property
found in CubicWebTC test classes.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Jul 2014 17:25:25 +0200] rev 9830
[dbapi] allow talking to a pre-3.19 remote repository
Closes #4071285
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Jun 2014 11:56:38 +0200] rev 9829
[migration] don't add new elements to config._cubes in remove_cube
We're expanding dependencies based on the current versions of the cubes,
which may well not be the same as the ones known by the db (we're in the
middle of an upgrade, after all). Listing them in config._cubes
prevents us from calling add_cube() later to actually add them.
Closes #4002156
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 02 Jul 2014 11:43:45 +0200] rev 9828
[web test] repair test broken by 0872ac2a1db0
after the above cset, during test instance's url is set before the creation of
core entities (ie created at database initialization), hence they have now a
valid cwuri.
Damien Garaud <damien.garaud@logilab.fr> [Tue, 06 May 2014 18:32:03 +0200] rev 9827
[dataimport] Drop reference to the 'source' column (closes #4067694).
CW 3.19 drops the multi-source support. This column does not exist in 3.19.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 21 May 2014 22:54:46 +0200] rev 9826
[notification] drop on commit sending of message feature of NotificationView
It duplicates feature already provided by
cw.hooks.notification.notify_on_commit function.
Simplify the API on the way.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 21 Mar 2014 08:28:32 +0100] rev 9825
[datafeed parser] enhance retrieve_url to support POSTing data and custom HTTP headers
Closes #3682069
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 25 Mar 2014 09:20:37 +0100] rev 9824
[datafeed parser] fix retrieve_url to always return urllib2.urlopen compatible output
as one should expect to be able to call geturl/getcode/info on the returned
object whatever the url he gave.
Related to #3682069
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 20 Mar 2014 08:55:44 +0100] rev 9823
[datafeed parser] factor out retrieve_url method from DataFeedXMLParser.parse
Related to #3682069
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 20 Mar 2014 08:49:10 +0100] rev 9822
[datafeed] Allow to override use_cwuri_as_url in configuration of a datafeed source
This is necessary because in some case one will want to write parser which
create entities not one-to-one related to entities from the distant source (for
instance see the `vcrs` cube which create entities holding statistics for code
review, while not importing review entities themselves).
Ideally we should provide a way to the parser to indicate the source that cwuri
should not be used, but that's a start...
Closes #3670210
Julien Cristau <julien.cristau@logilab.fr> [Fri, 27 Jun 2014 11:48:26 +0200] rev 9821
merge from 3.19 branch
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:56:05 +0200] rev 9820
[entity/rset] replace scary warnings about ambiguous rdefs by XXX in the code
users can't do anything about that and shouldn't see those warnings.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 18:35:13 +0200] rev 9819
[web/js] Deprecate baseuri() and replace with BASE_URL (closes #3955372)
Added by commit 8bf2337a6f3b and publicly available since 3.11.2
released more than 3 years ago.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 18:17:44 +0200] rev 9818
[request] Ensure base_url() always has a trailing '/' (closes #3955093)
Just as an example, cubicweb.ajax.js is clearly written under the
assumption that BASE_URL/baseuri() - which simply contains req.base_url() - has a
trailing /.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 10:16:13 +0200] rev 9817
[schema] spelling fixes in doc strings
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 12:23:18 +0200] rev 9816
[views] a 'div' with 'display: inline' screams 'span'
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 17 Feb 2014 11:27:25 +0100] rev 9815
[views] Rewrite cw.utils.formContents() with jQuery (closes #3747244)
Use jQuery's serializeArray() method instead. Just keep a bit of
compatibility with FCKEditor...
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 26 May 2014 12:10:22 +0200] rev 9814
[web/data] Remove broken backward compatibility function
popupLoginBox() was deprecated in favor of cw.htmlhelpers.popupLoginBox()
However, the use of cw.utils.deprecatedFunction() is broken. In firebug:
>>> popupLoginBox()
TypeError: newfunc is undefined cubicweb.js:113 (ligne 13)
This function was modified back in 2010, so it's been broken for 4 years.
Let's just get rid of it. Closes #4042978
Julien Cristau <julien.cristau@logilab.fr> [Thu, 19 Jun 2014 17:39:12 +0200] rev 9813
[repoapi] make ClientConnection call RequestSessionBase's init
Not calling up means we're missing some attributes, like encoding.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 18:31:09 +0200] rev 9812
[webtests/views_staticcontrollers] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 18:04:35 +0200] rev 9811
[webtests/views_selectors] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 17:21:52 +0200] rev 9810
[webtests/views_json] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 17:01:38 +0200] rev 9809
[webtests/views_errorform] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:52:34 +0200] rev 9808
[webtests/views_actions] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:48:37 +0200] rev 9807
[webtests/views_xmlrss] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:18:06 +0200] rev 9806
[webtest/pyviews] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 16:13:33 +0200] rev 9805
[tests/sqlutils] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 13:09:14 +0200] rev 9804
[tests/postgres] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 12:36:43 +0200] rev 9803
[tests/repository] use the new connection api (part 2/2)
Some notes:
* module imports cleanup
* the unimplemented `test_transaction_interleaved` is wiped
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 12:28:50 +0200] rev 9802
[repository,tests] use the new connection api (part 1/2)
`add_info` should not play with the cnxset nor the mode.
Static analysis showed that:
* add_info is an internal api called with a non-none cnx.cnxset and
also in write mode
* only the altered test violated this assumption, which is now
somewhat documented
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 17 Jun 2014 14:43:28 +0200] rev 9801
[book] fix various parts of the rql section
* syntax error
* erroneous query
* bad sphinx :func: usage
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 02 Jun 2014 11:47:30 +0200] rev 9800
[repository] session -> cnx renaming (already done in the source object)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:57:55 +0200] rev 9799
[tests/session] remove unused import
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:52:15 +0200] rev 9798
[tests/datafeed] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:46:40 +0200] rev 9797
[tests/checkintegrity] use the new connection api
* serverctl: the db-check command also uses an internal connection
object, which makes more sense in the context of `checkintegrity`.
* checkintegrity: rename srvcnx to just cnx (a bit because in the near
future, there will be one cnx to rule them all)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:40:22 +0200] rev 9796
[tests/schemaserial] kill star import
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:38:14 +0200] rev 9795
[tests/schemaserial] break long lines
Julien Cristau <julien.cristau@logilab.fr> [Mon, 16 Jun 2014 17:22:22 +0200] rev 9794
[tests/ldap] don't leak sessions
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:24:44 +0200] rev 9793
[tests/ldap] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 13 Jun 2014 12:56:45 +0200] rev 9792
[test/migration] fix crash on execution
This assertion is there for unclear reasons.
===================== unittest_migration.py =======================
-> creating tables [====================]
-> inserting default user and default groups.
-> storing the schema in the database [====================]
-> database for instance data initialized.
F
======================================================================
FAIL: test_db_creation (unittest_migration.BaseCreationTC)
make sure database can be created
----------------------------------------------------------------------
Traceback (most recent call last)
File "/home/auc/confs/forges/logilab/common/testlib.py", line 661, in _proceed
testfunc(*args, **kwargs)
File "/home/auc/confs/forges/cubicweb/test/unittest_migration.py", line 106, in test_db_creation
handler.build_db_cache()
File "/home/auc/confs/forges/cubicweb/devtools/__init__.py", line 469, in build_db_cache
self.init_test_database()
File "/home/auc/confs/forges/cubicweb/devtools/__init__.py", line 729, in init_test_database
init_repository(self.config, interactive=False)
File "/home/auc/confs/forges/cubicweb/server/__init__.py", line 217, in init_repository
repo = Repository(config, vreg=vreg)
File "/home/auc/confs/forges/cubicweb/server/repository.py", line 197, in __init__
self.init_cnxset_pool()
File "/home/auc/confs/forges/cubicweb/server/repository.py", line 220, in init_cnxset_pool
config.bootstrap_cubes()
File "/home/auc/confs/forges/cubicweb/devtools/__init__.py", line 176, in bootstrap_cubes
super(TestServerConfiguration, self).bootstrap_cubes()
File "/home/auc/confs/forges/cubicweb/server/serverconfig.py", line 279, in bootstrap_cubes
self.init_cubes(self.expand_cubes(splitstrip(line)))
File "/home/auc/confs/forges/cubicweb/cwconfig.py", line 1022, in init_cubes
super(CubicWebConfiguration, self).init_cubes(cubes)
File "/home/auc/confs/forges/cubicweb/cwconfig.py", line 798, in init_cubes
assert self._cubes is None, repr(self._cubes)
AssertionError: ('card', 'file', 'localperms', 'tag')
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 05 Jun 2014 17:53:27 +0200] rev 9791
[web] Remove unreachable and broken code
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 15 Apr 2014 11:55:37 +0200] rev 9790
[testlib] call init_config once the config has been properly bootstraped
This should be done right after repository instantiation and as such involves
giving CWTC.init_config as a callback to the test database handler (which will
itself gives it to the repository initialization function).
This unfortunatly requires to pass the init_config method to the
server.init_repository function because it has to be called after the config has
been initialized (which is done in Repository.__init__) but before the migration
handler is instantiated (which will call 'server_maintainance' hook, hence may
require the proper config). Another way to fix this would be to change the
initialization sequence, but this is another story.
Closes #3749378
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 17:50:50 +0200] rev 9789
[devtools] even better: use a plain Connection (server-side) object for pre_setup
The previous commit switched from passing a Session to a
ClientConnection.
This fixes unittest_ldapsource's pre_setup_database, which relied on a
server-side object to get at the repo.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 17:25:31 +0200] rev 9788
[devtools] pre_setup_database should take a connection object
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 11:10:54 +0200] rev 9787
[tests/migration] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 28 May 2014 17:33:16 +0200] rev 9786
[tests/undo] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 14:10:02 +0200] rev 9785
[js/ajax] deprecate user-callback support
Related to #3567793.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 07 Mar 2014 14:03:44 +0100] rev 9784
EditRelationMixIn: stop using user_rql_callback
Add generic add_relation/delete_relation ajax functions and use those.
Related to #3567793
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 28 May 2014 17:57:40 +0200] rev 9783
[tests/storage] use the new connection api
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 15:10:04 +0200] rev 9782
[tests/security] use the new connection api
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 02 Jun 2014 10:52:45 +0200] rev 9781
[htmlwidgets] Remove unreachable code
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 24 Apr 2014 12:28:46 +0200] rev 9780
Remove redundant __nonzero__ methods
From https://docs.python.org/2/reference/datamodel.html#specialnames :
When this method is not defined, __len__() is called, if it is
defined, and the object is considered true if its result is nonzero.
Also helpful for an eventual migration to py3k, as __nonzero__ has been
replaced with __bool__, which also defaults to looking at __len__ if
undefined.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 18:12:47 +0200] rev 9779
[etwist] Remove unused host_prefixed_baseurl()
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 23 May 2014 12:26:52 +0200] rev 9778
[basetemplate] Remove misleading comment
The <base> tag was removed in commit 8bf2337a6f3b back in 2011.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 28 May 2014 14:48:09 +0200] rev 9777
[tests/security] break lines > 100 chars
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 14:54:18 +0200] rev 9776
[doc/3.19] Mention [gs]et_shared_data deprecation
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 17:01:11 +0200] rev 9775
[hooks] internal_session -> internal_cnx (including a typo)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 02 May 2014 14:26:14 +0200] rev 9774
deprecate get/set_shared_data API
Session or transaction data must be used instead.
We must forward .transaction_data to web/request from
which it was missing (this is indeed a _cw object API).
Closes #3799036.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 14:46:48 +0200] rev 9773
[migration] Stop setting session.data['rebuild-infered']
It's no longer read anywhere since fe267b7336f3 "[migration] always
rebuild infered relation"
Christophe de Vienne <christophe@unlish.com> [Wed, 04 Jun 2014 23:02:06 +0200] rev 9772
Import PIL modules from the PIL namespace to be Pillow-compatible
Closes #3924726
Julien Cristau <julien.cristau@logilab.fr> [Tue, 10 Jun 2014 14:11:59 +0200] rev 9771
merge two stable heads
Julien Cristau <julien.cristau@logilab.fr> [Tue, 10 Jun 2014 09:49:45 +0200] rev 9770
merge 3.18.5 into 3.19 branch
Julien Cristau <julien.cristau@logilab.fr> [Tue, 10 Jun 2014 09:35:26 +0200] rev 9769
merge 3.17.15 into 3.18 branch
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Fri, 16 May 2014 17:01:34 +0200] rev 9768
[vreg] fix bad super call to lgc.registry.Registry()
Registry() expects a debugmode parameter, ovbiously not a
cubicweb config object.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 16:15:29 +0200] rev 9767
Added tag cubicweb-version-3.18.5, cubicweb-debian-version-3.18.5-1, cubicweb-centos-version-3.18.5-1 for changeset 5071b69b6b0b
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 16:13:48 +0200] rev 9766
[pkg] prepare 3.18.5
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:29:25 +0200] rev 9765
[sobjects] update notifications system to 3.19 api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 04 Jun 2014 17:56:54 +0200] rev 9764
[connection] set language on new Connection for the internal manager
For regular users this is handled by _set_user, but for internal
connections (e.g. used for notifications) we need something else.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 03 Jun 2014 15:07:41 +0200] rev 9763
Added tag cubicweb-version-3.19.1, cubicweb-debian-version-3.19.1-1, cubicweb-centos-version-3.19.1-1 for changeset 1fe4bc4a8ac8
Julien Cristau <julien.cristau@logilab.fr> [Tue, 03 Jun 2014 12:52:52 +0200] rev 9762
[pkg] Add missing data files to MANIFEST
Fonts and svg were missing from web/data.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 03 Jun 2014 12:16:20 +0200] rev 9761
[pkg] prepare 3.19.1
David Douard <david.douard@logilab.fr> [Mon, 05 May 2014 11:26:18 +0200] rev 9760
[views] new cubicweb logo (closes #3803681)
- add the new CubicWeb logo
- use it as a css (background-image)
- change the color of the header bar (gradient made with css)
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Wed, 09 Apr 2014 15:42:27 +0200] rev 9759
[serverctl] rename 'add-source' to 'source-add' for consistency's sake (closes #3732169)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 12:02:51 +0200] rev 9758
[test/hook] use the new connection API
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 30 May 2014 16:36:56 +0200] rev 9757
[testlib] complete the RepoAccess object (closes #3843614)
It was missing the open_session call.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 22 May 2014 18:29:50 +0200] rev 9756
[debian] version cubicweb-bootstrap Breaks
Apparently 0.6.x is OK with cw 3.19.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 06 May 2014 15:58:20 +0200] rev 9755
[wsgi] Delete unused instance_uri and get_full_path methods on CubicWebWsgiRequest
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 15 Apr 2014 11:59:24 +0200] rev 9754
[test] drop unused import
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 18:05:03 +0200] rev 9753
[sobjects] silent 3.19 warnings in sobjects/supervising.py
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 18:30:45 +0200] rev 9752
[test] update entities/test/unittest_wfobjs to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 10 Apr 2014 10:05:20 +0200] rev 9751
[test] Add missing import to fix old yams warning
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:26:57 +0200] rev 9750
[dataimport, migration] silence find_entities / find_one_entity warning
Deprecate associated methods to unify the API
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:14:25 +0200] rev 9749
[repo] fix extid2entity to ensure connection's has a cnxset
else we'll call source.doexec, which attempt to access to cnxset.cu, and crash
in some case (eg unittest_cwxmlparser in sobjects/test).
Also, manually switch to 'write' mode to ensure cnxset is not released until
commit/rollback when some entity is inserted.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:28:58 +0200] rev 9748
[test] update sobjects/test/unittest_cwxmlparser to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 09 Apr 2014 17:15:25 +0200] rev 9747
[repo] make it clear in internal_cnx that security is disabled
as explained in its docstring. It was previously relying on internal
connection's fake user (InternalManager) for read security and on disabling
security hooks for write security. Using the security_enabled context manager is
more readable and more reliable: while the older implementation works thanks to
the InternalManager associated to the session, custom hooks should rely
on session.[read|write]_security being correctly set. This change also
allows selecting Password attributes in internal connections without
explicitly disabling read security.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 18:23:02 +0200] rev 9746
[datafeed] update datafeed internals to use connection instead of session
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:57:58 +0200] rev 9745
[test] update sobjects/test/unittest_notification to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:56:00 +0200] rev 9744
[test] simplify setup of sobjects/test/unittest_supervising.py
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:54:29 +0200] rev 9743
[test] update sobjects/test/unittest_supervising to cw 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 17:53:58 +0200] rev 9742
[test] update sobjects/test/unittest_email to cw 3.19 api
Julien Cristau <julien.cristau@logilab.fr> [Tue, 06 May 2014 16:00:36 +0200] rev 9741
[wsgi] the spec says wsgi.url_scheme *must* be provided
No need to be defensive, anything else is a bug in the gateway.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Mon, 12 May 2014 12:37:19 +0200] rev 9740
[shell] provide autocompletion for rql queries in cubicweb-ctl shell (closes #3560541)
Use the ``rql.suggestions`` component to complete user's input
- readline calls the ``complete`` method with user's input,
- the ``complete`` method asks for each known completers if
it can suggest completions for user's input.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Apr 2014 14:33:40 +0200] rev 9739
[book] avoid '~' in all-in-one.conf, it is not expanded
Closes #3753213
Julien Cristau <julien.cristau@logilab.fr> [Wed, 07 May 2014 09:59:10 +0200] rev 9738
[book] uicfg moved from web to web.views a while ago
Julien Cristau <julien.cristau@logilab.fr> [Tue, 06 May 2014 15:59:39 +0200] rev 9737
[wsgi] look at wsgi.url_scheme to decide if we're on https
The server/gateway is supposed to fill it in for us.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 24 Mar 2014 10:34:58 +0100] rev 9736
[web] Fix HEAD request handling (closes #3677949)
Don't special-case HEAD in CubicWebRequestBase.is_client_cache_valid so
we don't return garbage. HEAD is supposed to return the actual headers
that a GET would return, which we can't do if we bypass all the normal
cubicweb logic. In particular, we no longer always return 200, and
return the right Content-Length/Content-Type/...
Julien Cristau <julien.cristau@logilab.fr> [Fri, 16 May 2014 16:49:29 +0200] rev 9735
[wsgi] avoid reading the entire request body in memory
Import POST form handling code from
https://raw.github.com/defnull/multipart/master/multipart.py to avoid
reading arbitrary amounts of data from the network in memory.
NOTES:
- In the twisted case we limit the max request content-length to 100MB (by
default), which seems kind of arbitrary, but avoids this issue
- werkzeug.formparser has suitable code as well, but I don't know if we want to
add it as a dependency
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 18:47:52 +0200] rev 9734
Added tag cubicweb-version-3.17.15, cubicweb-debian-version-3.17.15-1, cubicweb-centos-version-3.17.15-1 for changeset ee413076752b
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 18:16:18 +0200] rev 9733
[pkg] also bump __pkginfo__
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 17:48:58 +0200] rev 9732
[pkg] prepare 3.17.15
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 13 May 2014 13:12:16 +0200] rev 9731
[cache] fix a cache issue with an entity created without relation cache prefill
Prefilling the relation cache has its benefits sometimes, but for
massive imports it may be a memory hog.
The caches should be kept coherent even if there was no prefill.
Closes #3828155.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Apr 2014 16:12:39 +0200] rev 9730
[web/test] add a test for some http response codes
Related to #3648809
David Douard <david.douard@logilab.fr> [Tue, 06 May 2014 14:11:17 +0200] rev 9729
[views] remove reference to the MAPPING_CHECKERS dict (closes #3810219)
Was removed by by the changeset 65d93a4fd11c
([multi-sources-removal] Drop pyrorql and zmqrql sources)
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Mar 2014 17:03:15 +0100] rev 9728
[web/ajax] Always return a json dict with a 'reason' key in case of ajax errors
Sending sometimes a bare unicode string and sometimes a json-encoded
dict seems like a bad idea.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Mar 2014 17:01:58 +0100] rev 9727
[web/ajax] don't override any status code with 500 in ajax_error_handler
If the request produced an error such as Unauthorized or NotFound,
core_handle sets an appropriate status_out. Which is then overridden by
the ajax error handler.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Mar 2014 11:11:28 +0100] rev 9726
[web] Add asserts to the raw header conversion functions
This API is terrible, but at least this might help us catch some errors
in our conversion definitions.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 07 Mar 2014 11:19:24 +0100] rev 9725
[view] Delete dead(?) code from ReloadableMixIn
Nothing seems to ever call user_callback on the Component, only on the
request. Related to #3567793
Julien Cristau <julien.cristau@logilab.fr> [Tue, 04 Feb 2014 15:06:25 +0100] rev 9724
Add a db-statement-timeout option for postgresql sources
Use that new option to set the statement_timeout option when creating
connections, except for maintenance operations (shell and upgrade).
Closes #2547026
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Apr 2014 14:24:52 +0200] rev 9723
[test] use assertNotIsInstance instead of assert_(not isinstance(...))
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:19:37 +0200] rev 9722
[services] register_user now returns the new CWUser
Closes #3804444
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:41:34 +0200] rev 9721
[server/session] remove json dumps around call_service
This backouts changeset b151beea9cb6. With call_service being
in-process and synchronous, there's no RPC use case.
Christophe de Vienne <cdevienne@gmail.com> [Wed, 30 Apr 2014 08:07:59 +0200] rev 9720
[req.find] Use vreg.schema.eschema for eschema lookup
If an etype is non-existant, using vreg.schema[etype] raises a confusing error
complaining about a non-existing relation. This is because of the
implementation of vreg.schema.__getitem__ that look first in entities and then
in relations.
Using directly vreg.schema.eschema restrict the lookup to etypes only, hence
raises a meaningful error when the etype does not exist.
Christophe de Vienne <cdevienne@gmail.com> [Wed, 30 Apr 2014 10:13:10 +0200] rev 9719
[doc] Typo
Christophe de Vienne <christophe@unlish.com> [Tue, 07 Jan 2014 15:10:57 +0100] rev 9718
[formfields] Handle 'placeholder' attribute for text and textarea
See #636930.
Closes #3406713.
Alain Begey <alain@unlish.com> [Mon, 14 Apr 2014 23:00:19 +0200] rev 9717
[forms] Add autocomplete attribute for formrenderers
If you set form.autocomplete = False, the form renderer
in the open form tag will add the html option 'autocomplete=off'.
It allows to disable the functionality of some browsers to fill in
some forms automatically (for instance a profile with login/password)
Closes #3747294
Alain Begey <alain@unlish.com> [Fri, 11 Apr 2014 17:43:26 +0200] rev 9716
[widget] Addition of EmailInput
Simple input widget with type = 'email'
Closes #3741921
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Mon, 13 Jan 2014 14:21:28 +0100] rev 9715
close branch
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 18:38:24 +0200] rev 9714
Added tag cubicweb-version-3.19.0, cubicweb-debian-version-3.19.0-1, cubicweb-centos-version-3.19.0-1 for changeset 1141927b8494
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 18:35:35 +0200] rev 9713
[debian] set release date
Katia Saurfelt <katia.saurfelt@logilab.fr> [Mon, 28 Apr 2014 18:11:21 +0200] rev 9712
[entity] add a new `cw_linkable_rql` method
* the new method returns the entities that are or may be related to the
current one by the relation passed as an argument.
Closes #3738011.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 07 Apr 2014 12:03:31 +0200] rev 9711
[schema] fix buggy composite_rdef_roles and associated test
it should only look at rdefs involving the considered entity type.
Closes #3712982
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 17:43:35 +0200] rev 9710
[doc] update 3.19 release notes
Christophe de Vienne <cdevienne@gmail.com> [Mon, 28 Apr 2014 12:41:41 +0200] rev 9709
[login form] Fix BaseLogForm.form_action()
The method implementation was calling super() with the wrong class
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 11:20:26 +0200] rev 9708
[migration] move 'entities' table changes from 3.19.0 to bootstrap script
The 'mtime' and 'source' columns need to go away before we attempt to do
anything else with the repo, otherwise any addition of an entity is
going to explode.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 28 Apr 2014 12:54:14 +0200] rev 9707
[server/session] add missing rollback when freeing a db connection
When we let go of a cnxset and give it back to the pool, we need to make
sure it's not in the middle of a transaction.
We got bitten by a migration where the connection used by admin's
repo.connect was not rolled back before attempting the migration,
causing a deadlock because it had a lock on a table. This could
potentially also be an issue for e.g. hooks or looping tasks that didn't
explicitly rollback before calling free_cnxset or moving out of a
ensure_cnx_set block.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Apr 2014 17:52:20 +0200] rev 9706
[debian] add Breaks on cubicweb-bootstrap
Need to be versioned once we know which version fixes
https://www.cubicweb.org/ticket/3728939
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 08 Apr 2014 16:08:31 +0200] rev 9705
Drop duplicated content in ITreeAdapter docstring
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 13:31:19 +0200] rev 9704
an -> a (misc)
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 12:29:01 +0200] rev 9703
an utf-8 -> a utf-8
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 12:27:37 +0200] rev 9702
an URI -> a URI
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 12:07:00 +0200] rev 9701
an unicode string -> a unicode string
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 14 Apr 2014 11:54:33 +0200] rev 9700
an URL -> a URL
Christophe de Vienne <christophe@unlish.com> [Tue, 01 Apr 2014 13:57:25 +0200] rev 9699
Remove a misleading comment about self.render() behavior.
The former comment suggested that View.render called with 'row' or 'col' would
set cw_row or cw_col, which is not (anymore ?) accurate.
Related to #3696871.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 06 Mar 2014 18:41:23 +0100] rev 9698
[migractions] add sanity check in rename_relation_type
If the relation is still present in the fs schema, we probably shouldn't
be renaming it (because it's still in use somewhere, possibly in a
different cube). Closes #3608172
Vincent Michel <vincent.michel@logilab.fr> [Mon, 07 Apr 2014 08:46:41 +0000] rev 9697
[dataimport] Add safety belt on "gen_rtype" in MetaGenerator, closes #3712892
Some cubes may well add to the META_RTYPES set, hence
crashing the gen_<somecubemeta> call.
Vincent Michel <vincent.michel@logilab.fr> [Mon, 07 Apr 2014 08:44:56 +0000] rev 9696
[dataimport] Correctly serialize datetime objects in _create_copyfrom_buffer, closes #3712885
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 03 Apr 2014 15:36:33 +0200] rev 9695
[dataimport] Prevent ucsvreader from skipping the first line when ignore_errors is True (closes #3705791)
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 03 Apr 2014 15:30:37 +0200] rev 9694
[dataimport] Avoid double unicode decoding in ucsvreader (closes #3705752)
Christophe de Vienne <christophe@unlish.com> [Fri, 25 Apr 2014 12:22:07 +0200] rev 9693
[doc] Document the user_data dictionnary content
Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Apr 2014 14:44:58 +0200] rev 9692
[debian] break old cubicweb-vcsfile
We removed call_service's async argument, which it used.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:17:42 +0200] rev 9691
[services] catch missing group early in register_user
Better an assertion than a rql syntax error for such a programming error.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 18:16:46 +0200] rev 9690
[services] rename register_user kwargs to cwuserkwargs
They're attributes/relations for the created CWUser, this makes it clearer.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Apr 2014 15:18:04 +0200] rev 9689
[services] don't hardcode 'users' group for register_user
Let the caller choose which group the user should be in. Related to #3020639
Caveat: this is a possible security hole if untrusted values are allowed.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Apr 2014 15:03:24 +0200] rev 9688
[sobjects/test] check that register_user properly sets user name and email address
Related to #3020639
Vladimir Popescu <vladimir.popescu@logilab.fr> [Fri, 19 Jul 2013 17:38:15 +0200] rev 9687
[server] Refactor Repository.register_user into a CubicWeb service (closes #3020639)
[jcr: move commit to the caller; add item in release notes; fix NameErrors]
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Apr 2014 14:25:36 +0200] rev 9686
[migration] set a cnxset before process_script()
Not pretty, but I don't have a better idea right now and this at least
ensures migration scripts get run in the expected environment and can
access sql stuff as before.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 11:04:13 +0200] rev 9685
[server] make internal_cnx get and keep a connection to the db
- internal_session worked that way
- it's less surprising for users if their internal connections "just
work", rather than having to deal with the cnxset when using low-level
APIs
Includes a backout of 3f62606c01a2 "[repo] Fix register_user" which is
no longer needed.
Depend on logilab-database 1.12.1 to avoid errors due to pointless check
in python's sqlite3 binding.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 22 Apr 2014 14:43:11 +0200] rev 9684
[server/session] make commit/rollback obey ensure_cnx_set
Inside the ensure_cnx_set context manager, commit and rollback aren't
allowed to dispose of the cnxset.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 14:05:54 +0200] rev 9683
[repo] fix deprecation messages for stats and gc_stats
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 17:31:50 +0200] rev 9682
[cwconfig] use "foo not in bar" instead of "not foo in bar"
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 15:28:21 +0200] rev 9681
[debian] Add Breaks on a few cubes that need changes for 3.19
- mercurial_server is affected by composite deletion changes
- forgotpwd relied on session data to be forwarded to notification view
- registration hooks into the authentication stack
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 15:03:01 +0200] rev 9680
[hooks] run cascading delete hook later
Applications may have their own before_delete_entity hooks that rely on the
composite relations still existing.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 13:54:31 +0200] rev 9679
[devtools] set PGPORT/PGHOST when calling pg_ctl start
Helps pg_ctl find the socket on squeeze, otherwise it looks in
/var/run/postgresql.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 23 Apr 2014 17:21:07 +0200] rev 9678
[server/test] update to deal with lgdb sqlserver fix
See https://www.logilab.org/ticket/235748
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Apr 2014 10:59:08 +0200] rev 9677
[test] Fix regressions from 96549de9dd70 "[test] use assertIn where appropriate"
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 18:14:45 +0200] rev 9676
[repo] Fix register_user
Make sure we have a connection to the db around user creation.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Apr 2014 18:00:14 +0200] rev 9675
[test] use assertNotIn where appropriate
Automatically generated with:
find -name unittest_*.py -o -name test_*.py | xargs sed -i -e 's/assertFalse(\([^,]*\) in \([^,]*\))/assertNotIn(\1, \2)/'
plus revert of a couple false matches.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 08 Apr 2014 17:39:39 +0200] rev 9674
[test] use assertIn where appropriate
Automatically generated with:
find -name unittest_*.py -o -name test_*.py | xargs sed -i -e 's/assertTrue(\([^,]*\) in \([^,]*\))/assertIn(\1, \2)/'
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 11:25:45 +0200] rev 9673
[doc] Add removal of old multi-sources to 3.19 release notes
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 11:19:59 +0200] rev 9672
[pkg] Bump to 3.19.0
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 10:51:15 +0200] rev 9671
[web/debug] remove code broken by session refactoring
session.cnx and cnx.check() no longer exist.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Apr 2014 10:49:18 +0200] rev 9670
[web/debug] Fix check for open sessions
itervalues returns an iterator, which never evaluates to False.
Regression from 0bb18407c053 "[toward py3k] rewrite dict.keys() and
dict.values() (part of #2711624)".
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 20 Mar 2014 15:42:23 +0100] rev 9669
[cwconfig] Remove useless 'ui-cube' configuration option (closes #3728904)
The mechanism introduced could never actually be used as it brings dependency
loops to the cube graph. Just get rid of it.
This reverts commit 4032499c701e.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 14:28:47 +0200] rev 9668
[test] Use RepoAccess.shell() in unittest_predicates
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 12:03:06 +0200] rev 9667
[devtools] add 'shell' method to RepoAccess, deprecate CubicWebTC's
Lets us control the connection's lifetime.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 14:44:49 +0200] rev 9666
[repo] make extid2eid work with either a session or a connection
The only place it should matter is for restoring pending_operations in
case of failure. Which is not exercised by the test suite. Here be
dragons.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 14:23:01 +0200] rev 9665
[repository] extid2eid's 'commit' argument no more necessary
This removes the need for creating an internal session.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 12:46:35 +0200] rev 9664
[repository] complete argument is no more needed since we have no more 'true' multisource.
It is always false.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 12:39:59 +0200] rev 9663
[repository] 'session' argument is always given to type[_and_source]_from_eid, make it mandatory and simplify code accordingly
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Apr 2014 14:48:51 +0200] rev 9662
[repository] 'session' argument is always given to extid2eid, make it mandatory and simplify code accordingly
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 28 Mar 2014 14:59:33 +0100] rev 9661
[web/data] Remove broken jquery-json plugin (closes #3590335)
Conversion of Date() objects is somehow broken (don't know why beyond that it's
due to jquery-json's monkeypatched Date.toJSON() method).
Use the now-standard JSON.stringify() instead. http://caniuse.com/#feat=json
says it's supported by all browsers, and even IE going back to version 8.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 27 Jan 2014 14:02:21 +0100] rev 9660
Add missing relation types items in schema global variables
Some of these global variables are used, in particular, to control schema
views (web/views/schema.py).
While they are currently not properly documented (see #3360868), their
definition are currently incomplete (e.g. one could reasonably expect to find
``cw_schema`` in ``SYSTEM_RTYPES``).
Closes #3486114.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Mar 2014 16:57:22 +0100] rev 9659
[web] return 403 for Unauthorized, not 401
401 is reserved to HTTP authentication. Just because it's also called
"unauthorized" doesn't mean it's the same as cubicweb's Unauthorized
exception. Closes #3648809.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:30 +0200] rev 9658
[test] update unittest_repoapi to 3.19 api (sic)
[jcr: while at it, fix typos and add missing __main__ section]
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:19 +0200] rev 9657
[test] update unittest_utils to 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:11 +0200] rev 9656
[test] update unittest_rset to 3.19 api
[jcr: use self.admin_access instead of creating a new one each time]
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:55:03 +0200] rev 9655
[test] update unittest_rqlrewrite to 3.19 api
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:54:54 +0200] rev 9654
[test] update unittest_req to 3.19 api
[jcr: use self.admin_access instead of creating a new one each time]
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:54:45 +0200] rev 9653
[test] update unittest_predicates to 3.19 api
[jcr: use self.admin_access instead of creating a new one each time]
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 18:35:18 +0200] rev 9652
[web/test] port unittest_reledit to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Apr 2014 11:31:39 +0200] rev 9651
[web/test] port unittest_magicsearch to RepoAccess API
request created in setUp makes context manager usage painful, so create
a context manager to do the setup for each test class.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 16:05:54 +0200] rev 9650
[web/test] use real_error_handling context manager instead of open-coding it
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 16:03:19 +0200] rev 9649
[web/test] port unittest_idownloadable to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 15:51:29 +0200] rev 9648
[web/test] remove useless calls to self.request() from CORS tests
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 15:47:04 +0200] rev 9647
[web/test] port unittest_formfields to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 18:20:23 +0200] rev 9646
[web/test] port unittest_form to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 17:44:32 +0200] rev 9645
[web/test] port unittest_facet to RepoAccess API
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 17:03:46 +0200] rev 9644
[web/test] move unittest_controller to RepoAccess test API
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 16:56:26 +0200] rev 9643
[web/test] port unittest_breadcrumbs to 3.19 test api
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 12:44:57 +0200] rev 9642
[web/test] avoid deprecation warnings from find_entities()
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 15:51:01 +0200] rev 9641
[web/test] port unittest_application to new 3.19 API
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 12:46:06 +0200] rev 9640
[test] silence warnings for unittest_schema by upgrading to new 3.19 API
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 12:45:12 +0200] rev 9639
[test] silence warnings for unittest_cwctl by upgrading to new 3.19 API
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 13:49:03 +0200] rev 9638
[test] replace some assert{True,False} with more specific method
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 01 Apr 2014 10:26:37 +0200] rev 9637
[test] silence warnings for unittest_entity by upgrading to new 3.19 API
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 18:04:56 +0200] rev 9636
Fix constraint sync during migration
- restore constraints lost during merge in test schema.
- use constraint_by_eid in BeforeDeleteCWConstraintHook as done in
3.17.14 for BeforeDeleteConstrainedByHook. Fixes handling of multiple
constraints of the same type.
- make sync_schema_props_perms() delete the CWConstraint entity instead
of the constrained_by relation. In 3.19, the latter doesn't
automatically result in the former just because the relation is
composite. Simplify the constraint migration to delete all removed
constraints and recreate new ones even if they share the same type; that
optimization made the code more complicated for (AFAICT) no significant
reason.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 17:02:04 +0200] rev 9635
merge 3.18.4 into default
server/test/unittest_migractions fails due to interaction between new
constraint test (from 3.18) and composite deletion change (in 3.19).
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 15:57:47 +0200] rev 9634
Added tag cubicweb-version-3.18.4, cubicweb-debian-version-3.18.4-1, cubicweb-centos-version-3.18.4-1 for changeset 0176da9bc752
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 04 Apr 2014 12:37:39 +0200] rev 9633
[test/data] Add missing 'add' permission on attribute
Silences a warning introduced in 3.18.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 14:15:35 +0200] rev 9632
[hooks/notification] Fix indentation
Follow-up for changeset 1b8552265f3b "[hooks/notification] use a cnx not a
session"
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 18:16:10 +0200] rev 9631
[devtools] deprecate CWTC.user()
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 18:18:11 +0200] rev 9630
minor cleanups
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 18:16:28 +0200] rev 9629
some copyright updates
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 18:12:48 +0200] rev 9628
[devtools] properly close open access on tearDown
avoiding further warning about living sessions while the repo is turned off.
The doc string says:
The RepoAccess need to be closed to destroy the associated Session.
TestCase usually take care of this aspect for the user.
but that wasn't true until now.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 19:10:40 +0200] rev 9627
[devtools] make comment (a bit) more readable
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 16:09:09 +0200] rev 9626
[devtools] avoid an internal deprecation warning
websession and session are now one and the same.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 12:38:29 +0200] rev 9625
[server/session] undeprecate session.anonymous_session
It's not connection-specific.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 15:42:25 +0200] rev 9624
[web/sessions] use session.sessionid instead of deprecated session.id
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 03 Apr 2014 18:09:57 +0200] rev 9623
[repo] don't set cnxset when getting the session to close it
and avoid warning about that.
session._cnx.rollback won't do anything if it's not set and a newer connection
is now created to run the session_close hook, so there is not need to set
cnxset.
Notice we have to take care about not trying to rollback the underlying cnx when the
session is not 'session_handled' (i.e. bw compat mode). This case only occurs due
to hackish things to keep bw compat in testlib.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 02 Apr 2014 12:38:02 +0200] rev 9622
[repo] handle connection explicitly when calling session open/close hooks
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:48:34 +0200] rev 9621
[hooks/syncschema] work with connections not sessions
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:48:14 +0200] rev 9620
[server/sources] {before,after}_entity_insertion wants a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:35:15 +0200] rev 9619
[hooks/syncsources] use a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:34:38 +0200] rev 9618
[hooks/notification] use a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:33:48 +0200] rev 9617
[hooks/metadata] use a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:32:49 +0200] rev 9616
[hooks/bookmark] use a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:32:28 +0200] rev 9615
[hooks/workflow] use a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:30:35 +0200] rev 9614
[hooks/email] use a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:29:54 +0200] rev 9613
[hooks/integrity] use a cnx not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:28:12 +0200] rev 9612
[hooks/security] let's use a connection, not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:17:03 +0200] rev 9611
[server/sources/native] deal with connections, not sessions
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 16:12:50 +0200] rev 9610
[server] eschema_eid needs a connection, not a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 15:53:21 +0200] rev 9609
[repository] operations get a connection instead of a session
Left extid2eid unchanged because that function scares the shit out of
me.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 15:52:44 +0200] rev 9608
[server/hook] operations get a connection instead of a session
Julien Cristau <julien.cristau@logilab.fr> [Tue, 01 Apr 2014 15:46:17 +0200] rev 9607
[repository] Use an internal connection in register_user
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 01 Apr 2014 10:28:16 +0200] rev 9606
avoid to internally raise 3.19 warnings
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Apr 2014 12:28:25 +0200] rev 9605
[sources] ensure we have a cnxset in undoable_transactions
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Apr 2014 10:46:53 +0200] rev 9604
[server] move security/integrity hook management away from InternalSession.__init__
and to Repository.internal_{session,cnx} instead. Lets internal_cnx avoid
deprecation warnings.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 03 Apr 2014 17:25:53 +0200] rev 9603
[migration] make 'session' object be a server-side Connection, not ClientConnection
I think this better corresponds to the previous behaviour. However,
that Connection does not have a cnxset, which should probably be changed
(for both interactive_shell and cmd_process_script).
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 20 Mar 2014 08:45:52 +0100] rev 9602
[sources] Skip problematic sources when starting shell instead of crashing. Closes #3670208
At least this gives an opportunity to fix the problem in using c-c shell, which
is currently not possible because it crashes during initialization.
Notice that since sources are copy based, it should not be a problem at all to
have some disabled, beside for services such as authentication sources as
ldapfeed.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Apr 2014 17:32:12 +0200] rev 9601
[web] fix language negotiation
Regression caused by commit 6fd0ac6506cb "[web-request] handle default
language earlier". We would handle language negotiation at request
init time, but overwrite the selected language with the site default
when calling set_cnx.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Apr 2014 18:09:46 +0200] rev 9600
[merge] bring the 3.17.14 fixes to 3.18
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Apr 2014 14:46:55 +0200] rev 9599
[test/utils] repair concat-resources test
That was forgotten in 240a620b9cd3.
Related to #3670503.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 31 Mar 2014 19:00:49 +0200] rev 9598
[pkg] bump cubicweb.spec
Vincent Michel <vincent.michel@logilab.fr> [Mon, 31 Mar 2014 11:18:44 +0000] rev 9597
[dataimport] Correctly call rschema(rtype) in SqlGenObjectStore, closes #3694139
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 28 Mar 2014 17:13:38 +0100] rev 9596
[pkg] prepare 3.18.4
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 20 Mar 2014 15:44:59 +0100] rev 9595
[web] Disable 'concat-resources' by default (closes #3670503)
It makes debugging harder and it can actually *break* working JS or CSS files.
This is the first step towards complete removal.
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 12 Mar 2014 08:56:31 +0100] rev 9594
[testlib] Drop override of assertItemsEqual method
The override is not compatible with underlying (standard) method because it
builds sets and rely on eid.
Closes #3641111.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 13 Mar 2014 17:32:40 +0100] rev 9593
[rewrite] Fix crash when the main variable doesn't appear in the snippet's vargraph
Also, the added test discover another bug once the first has been fixed
(erroneous argument given to .rewrite recursive call).
Closes #3661918
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 13 Mar 2014 15:33:22 +0100] rev 9592
[ext/rest] Catch SystemExit raised by docutils
docutils publisher may raise SystemExit which is not caught by
Exception.
Closes #3648763.
Jérôme Roy <jerome.roy@logilab.fr> [Fri, 14 Mar 2014 15:19:31 +0100] rev 9591
[entity] User-defined relation to skip for copy has precedence
Otherwise permission problems can occur on rtypes not yet skipped
Closes #3653459
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 26 Feb 2014 14:50:13 +0100] rev 9590
Make EditController edit_entity method always return an eid
In cases the entity was to be created or copied, eid was None hence the method
returned None despite the dosctring says the method should always return an
eid. Now if the eid variable is None, it is assigned to the newly created
entity eid.
Closes #3593029.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 26 Mar 2014 11:08:09 +0100] rev 9589
[migration] Improve update of in-memory schema during 3.18 CWAttribute.defaultval change
We weren't updating the schema properly so a bunch of structures still
had the old rdef with 'String' as object. That caused failures to add
new attributes later in the migration as their default value would be a
Binary object but the schema would expect a String.
Closes #3683640
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 27 Mar 2014 14:32:21 +0100] rev 9588
[migration] always rebuild infered relation
This was skipped for some bad reason (see 12ad88615a12 which
introduced the change).
Fix for #231956 in Yams is necessary to allow this cset: during a
migration, we want to always reinfer relations while allowing explicit
redefinition of an infered relation later. Else, we may run the
migration with missing parts of the schema (the one that should have
been infered).
Closes #3685463.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 24 Mar 2014 16:29:18 +0100] rev 9587
Backout "[web/navigation] use add_onload instead of inline javascript href"
This reverts changeset 170e1437948d, for at least two reasons: the
PageNavigationSelect component was not updated for the new type of
navigation links, and external cubes defining View.page_navigation_url
exist in the wild and also got broken navigation links. This reopens
#3501626 and closes #3677945.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 14 Mar 2014 10:51:05 +0100] rev 9586
[test] those are rql tests, not cubicweb (and they break with rql 0.31.5). Remove them.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 24 Mar 2014 18:14:22 +0100] rev 9585
[source/native] allow many eid creation per .create_eid call (closes #3526594)
[jcr: move migration code to bootstrapmigration_repository.py to make
sure we stop using the old sequence ASAP]
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 06 Feb 2014 19:04:03 +0100] rev 9584
[pkg] bump the dependency on logilab.database
This will allow use of an extended API.
Related to #3526594.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 10 Mar 2014 15:55:56 +0100] rev 9583
[source/native] refactor eid generation code
This set of related methods clutters the native source API.
It will be better served with a dedicated eid genrator object.
Related to #3526594.
[jcr: allocate the eid generator in __init__]
Julien Cristau <julien.cristau@logilab.fr> [Mon, 24 Mar 2014 11:57:23 +0100] rev 9582
Move entity cache from web.request.ConnectionCubicWebRequestBase to repoapi.ClientConnection
ResultSet._build_entity relies on an entity cache to avoid going round in
circles (stack overflow due to infinite recursion) e.g. in a postcreate script.
Clear the cache at commit/rollback time to avoid unexpected side
effects; and explicitly clear the cache in a few tests where we mix ORM
and RQL using the same connection.
Laura Médioni <laura.medioni@logilab.fr> [Mon, 24 Mar 2014 16:38:57 +0100] rev 9581
[server] Fix AttributeError in extid2eid
Session._tx was renamed in cb87e831c183, use _cnx instead.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 11 Mar 2014 15:56:05 +0100] rev 9580
[book] Update documentation for new repoapi
Quite a few things change in 3.19:
- repoapi instead of dbapi
- ClientConnection / Connection / Session rework
- web authentication process
- test APIs
Closes #3638793
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Mar 2014 11:18:15 +0100] rev 9579
[utils] the json module is always available
It's included since python 2.6, and we don't support earlier versions.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Mar 2014 12:15:20 +0100] rev 9578
[fti] properly close the ProgressBar
Ensures cubicweb-ctl db-rebuild-fti ends its output with a newline.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Mar 2014 12:13:14 +0100] rev 9577
[serverctl] use repoapi for db-check, add-source, rebuild-fti commands
One more step towards getting rid of dbapi.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 05 Mar 2014 12:35:37 +0100] rev 9576
[devtools] make get_repo_and_cnx return a repoapi ClientConnection
And adjust callers accordingly (they need to use it as a context manager to
open/close it properly).
Julien Cristau <julien.cristau@logilab.fr> [Wed, 05 Mar 2014 11:22:20 +0100] rev 9575
[repoapi] Avoid deprecation warnings from session.id
Apparently it's called session.sessionid now.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 18 Feb 2014 15:26:22 +0100] rev 9574
[server] some s/session/cnx/
For merely accessing the database we need a connection, not a session.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 05 Mar 2014 16:58:14 +0100] rev 9573
Move setting session.mtime from dbapi to web session manager
clean_session was broken since the switch away from dbapi on the web
side, since session.mtime wasn't being set anywhere.
David Douard <david.douard@logilab.fr> [Thu, 13 Mar 2014 17:01:13 +0100] rev 9572
[web] whitespace cleanup in http_headers.py
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Fri, 14 Mar 2014 11:20:53 +0100] rev 9571
[web] implement cross origin resource sharing (CORS) (closes #2491768)
Partial implementation that is enough to get started but leaves out
some of the advanced features like caching and non-simple methods
and headers.
David Douard <david.douard@logilab.fr> [Wed, 12 Mar 2014 16:02:44 +0100] rev 9570
[devtools] add a 'method' argument to RepoAccess.web_request
so that one can easily forge a request with any HTTP method.
Also a bunch of clone cleanups.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Mar 2014 11:38:14 +0100] rev 9569
[web] Fix handling of some http headers
The generator takes as argument a list of raw string values, and is
supposed to return the parsed version. Calling str on that list makes
no sense.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 10 Mar 2014 17:54:02 +0100] rev 9568
[web/request] deprecate user_callback
Storing closures in session data considered harmful. Closes #3567793
Julien Cristau <julien.cristau@logilab.fr> [Fri, 07 Mar 2014 10:27:14 +0100] rev 9567
[doc] undocument user_callback
Related to #3567793
Florent Cayré <florent.cayre@logilab.fr> [Wed, 12 Mar 2014 14:08:51 +0100] rev 9566
Added tag cubicweb-centos-version-3.17.14-1, cubicweb-version-3.17.14, cubicweb-debian-version-3.17.14-1 for changeset fa00fc251d57
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 10 Mar 2014 15:17:50 +0100] rev 9565
[migractions] Better handle removal of RQLConstraint in sync_schema
In rdef synchronisation, filter unmodified constraints before processing the
sets of old and new constraints.
Add a new `constraint_by_eid` method on RelationDefinitionSchema, which
eliminates the ambiguity of `constraint_by_type` usage when several
constraints of the same type are involved in the same migration.
Closes #3633644.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 10 Mar 2014 16:07:41 +0100] rev 9564
[test] when the config change, we should cleanup sys.path and sys.modules. Closes #3634164
Without this, modules imported within instance home will be messed up.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 06 Mar 2014 13:59:24 +0100] rev 9563
[wsgi] make sure request.content is available for consumption
The wsgi.input stream is not seekable, so make a copy either to memory
or disk so it's still available to the user even after we've parsed it
(for POST form processing). Closes #3554996
Katia Saurfelt <katia.saurfelt@logilab.fr> [Wed, 29 Jan 2014 10:57:10 +0100] rev 9562
[facet] create a RangeRQLPathFacet (closes #2852512)
This facet is a mix between a RQLPathFacet and a RangeFacet, allowing
to use the FacetRangeWidget on the RQLPathFacet target attribute
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 31 Oct 2013 16:12:37 +0100] rev 9561
[request] Make sure set_message() actually displays its given message (closes #3003425)
The default automatic form sets a standard submit message as session
data. However in some cases, such as the cancellation of a form edition,
another message is intended to be printed on-screen.
This patch makes sure that set_message() really scrubs all previous
messages (and ids) from the request object and from the session data.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 05 Mar 2014 15:49:23 +0100] rev 9560
[pkg] prepare 3.17.14
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 27 Feb 2014 18:10:29 +0100] rev 9559
[hooks/syncschema] do not crash on double removal of a constraint
Some complicated migrations may entail a double constraint removal.
It is not yet known whether this is a genuine cw bug or the result
of a complicated migration story, but we should nevertheless
not crash.
Rather, emit a CRITICAL warning and proceed.
Closes #3595309.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 19 Feb 2014 11:01:19 +0100] rev 9558
[doc/book] Fix typo in import
Julien Cristau <julien.cristau@logilab.fr> [Tue, 18 Feb 2014 13:54:08 +0100] rev 9557
[server/session] fix a couple typos in doc strings
Julien Cristau <julien.cristau@logilab.fr> [Tue, 18 Feb 2014 17:58:45 +0100] rev 9556
[server/migractions] finish migration to repoapi objects
Changeset 241b1232ed7f (Use repoapi instead of dbapi for cwctl shell,
upgrade and db-init) only did half of the job. It left the migration
handler with both a session (cubicweb.server.session.Session) and a cnx
(cubicweb.repoapi.ClientConnection) attribute with different ideas of
what Connection they were talking to.
With this change, we:
- make the caller responsible of disabling security on the Connection if
it wants to
- turn mih.session into an actual attribute, set on __init__
- same for cnx (the client connection)
- drop the "lazy connection" logic, and establish the connection
up-front
- always go through the connection instead of the session when we need
to talk to the db
Julien Cristau <julien.cristau@logilab.fr> [Wed, 05 Mar 2014 10:44:45 +0100] rev 9555
[server] use the ClientConnection directly now that it has more methods available
Gets rid of ugly self.cnx._cnx.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 18 Feb 2014 17:29:34 +0100] rev 9554
[repoapi] add security/hook control and system_sql
Just redirect these methods to the repo-side Connection.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Feb 2014 15:22:21 +0100] rev 9553
[predicates] fix thinko in doc strings
Replace "e.g." with more appropriate "i.e.". These are not examples.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Feb 2014 14:10:53 +0100] rev 9552
[web/basecomponents] remove EtypeRestrictionComponent
Closes #3119951
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Fri, 14 Feb 2014 12:03:20 +0100] rev 9551
[ldapparser, book] document additional error causes
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Feb 2014 14:39:55 +0100] rev 9550
[js] remove leftover dead code in loadxhtml
form.callback support was removed in changeset 68cde7431c2c, but some
signs of it remained.
Damien Garaud <damien.garaud@logilab.fr> [Tue, 04 Mar 2014 18:28:46 +0100] rev 9549
[web] Avoid using an empty dict as default parameter of 'CubicWebRequestBase'.
Also update the related docstring of the __init__ method.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 21 Jan 2014 18:30:16 +0100] rev 9548
[schema] fix composite deletion handling
Do not delete component entities if the composite is not deleted in
the same transaction.
Deletion semantics are thus: if the composite is deleted, the
components are deleted.
Closes #3463112.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 24 Jan 2014 13:08:53 +0100] rev 9547
[schema] add composite handling helpers on EntitySchema (related to #3463112)
These will help write predicates, hooks, etc.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Feb 2014 15:01:23 +0100] rev 9546
[server] Handle unique constraint violations under recent sqlite
The error message changed from "columns foo, bar, baz are not unique" to
"UNIQUE constraint failed: table.foo, table.bar, table.baz".
Closes #3564510
Julien Cristau <julien.cristau@logilab.fr> [Tue, 04 Mar 2014 12:02:11 +0100] rev 9545
[i18n] update
de: 1065 translated messages, 1 fuzzy translation, 259 untranslated messages.
en: 656 translated messages, 669 untranslated messages.
es: 1325 translated messages.
fr: 1314 translated messages, 11 untranslated messages.
Celso FLORES <celso.flores@crealibre.com> [Tue, 04 Mar 2014 12:04:04 +0100] rev 9544
[i18n] es.po updated
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Feb 2014 15:32:50 +0100] rev 9543
merge 3.18.x in 3.19 branch
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Feb 2014 11:13:27 +0100] rev 9542
3.18 is stable
Julien Cristau <julien.cristau@logilab.fr> [Mon, 17 Feb 2014 11:07:38 +0100] rev 9541
[schema] explicitly declare 'add' permissions for a couple attributes
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 14 Feb 2014 17:52:49 +0100] rev 9540
Added tag cubicweb-version-3.17.13, cubicweb-debian-version-3.17.13-1, cubicweb-centos-version-3.17.13-1 for changeset 09b4ebb9b0f1
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Feb 2014 17:07:25 +0100] rev 9539
Added tag cubicweb-version-3.18.3, cubicweb-debian-version-3.18.3-1, cubicweb-centos-version-3.18.3-1 for changeset afd21fea201a
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Feb 2014 17:06:59 +0100] rev 9538
Update translations
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Feb 2014 16:23:46 +0100] rev 9537
[pkg] prepare 3.18.3
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Feb 2014 16:10:36 +0100] rev 9536
merge 3.17.13
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Fri, 14 Feb 2014 15:42:25 +0100] rev 9535
[ldapfeed] fix encode error during initial user import
Closes #3539196.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 12 Feb 2014 17:32:49 +0100] rev 9534
[web/data] Ignore disabled widgets in cw.utils.formContents() (closes #3544492)
17.12.1 Disabled controls : http://www.w3.org/TR/REC-html40/interact/forms.html#h-17.12.1
When set, the disabled attribute has the following effects on an element:
* Disabled controls do not receive focus.
* Disabled controls are skipped in tabbing navigation.
* Disabled controls cannot be successful.
The third one is the important one.
17.13.2 Successful controls : http://www.w3.org/TR/REC-html40/interact/forms.html#successful-controls
A successful control is "valid" for submission. Every successful control has
its control name paired with its current value as part of the submitted form
data set.
Bottom line, disable widgets should not be part of the names and values lists returned by formContents().
Damien Garaud <damien.garaud@logilab.fr> [Fri, 14 Feb 2014 15:22:56 +0100] rev 9533
[etwist] Fix an empty request content after a Twisted processing (closes #3546795).
The content of a POST request could be empty when the Twisted server is used.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Feb 2014 16:50:55 +0100] rev 9532
[web/data] remove images that aren't used anywhere
Julien Cristau <julien.cristau@logilab.fr> [Thu, 13 Feb 2014 16:51:22 +0100] rev 9531
[web/data] Add missing images from jquery-ui 1.10.3
Closes #3175933
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Feb 2014 14:06:56 +0100] rev 9530
[web/navigation] use add_onload instead of inline javascript href
This way our javascript code isn't thrown out by the html cleaner e.g. when
using the rql rest directive and a table view.
To make things simpler, we now always use ajax URLs for navigation,
even when we would previously have used regular links.
Closes #3501626
Julien Cristau <julien.cristau@logilab.fr> [Fri, 14 Feb 2014 14:46:25 +0100] rev 9529
[web/data] fix treeview regression (closes #3526466)
Changeset 68cde7431c2c "[js] remove 3.9 bw compat (where apparently
unused)" removed the use of form.callback from loadxhtml, which treeview
relied on. Update to add a callback on the loadxhtml return value
instead.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 14 Feb 2014 10:39:16 +0100] rev 9528
backout 8f3e963501e2, which is not ready yet
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 13 Feb 2014 19:29:20 +0100] rev 9527
[pkg] also bump it there
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 10 Feb 2014 18:00:26 +0100] rev 9526
[pkg] prepare 3.17.13
Julien Cristau <julien.cristau@logilab.fr> [Tue, 11 Feb 2014 13:50:29 +0100] rev 9525
[navigation] use add_onload instead of inline javascript href
This way our javascript code isn't thrown out by the html cleaner e.g. when
using the rql rest directive and a table view.
Closes #3501626
Julien Cristau <julien.cristau@logilab.fr> [Wed, 05 Feb 2014 15:50:36 +0100] rev 9524
[uilib] allow canvas tags in the html cleaner
Used by the iprogress cube. Closes #3524254.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 05 Feb 2014 16:34:21 +0100] rev 9523
[ajax] use a custom tag to handle dynamically loaded js
Using <pre class="script"> makes it trivial for a malicious user to
inject arbitrary javascript into a html or rest text element (because it
looks innocent to the html sanitizer). Using a custom tag we can be
sure that it actually comes from our code and not from untrusted user
data. IE ignores custom tags, though, so we put it in its own namespace.
https://extranet.logilab.fr/1530578
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 03 Feb 2014 19:07:58 +0100] rev 9522
[dataimport] fix comment
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 12 Feb 2014 18:15:32 +0100] rev 9521
[hooks/security, devtools/fill] silence yams 0.38.0 warnings
Florent Cayré <florent.cayre@logilab.fr> [Mon, 03 Feb 2014 16:30:07 +0100] rev 9520
Drop 3.13 incomplete backward compat in edit controller.
It is very old and broken (there is another non-backward-copmpatible
usage of `_cw_entity_fields`), better to remove it instead of fixing.
Closes #3515223.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 10 Feb 2014 16:06:16 +0100] rev 9519
[devtools] force locale to C for postgresql test clusters
Avoids initdb failure with e.g. iso8859-X locale and utf-8 encoding.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 Dec 2013 08:39:03 +0100] rev 9518
[rql2sql] remove special behaviour of symmetric relation vs DISTINCT
0542a85fe667 replacing SQL OR by hooks for symmetric relations allows that.
This involve a single test value change for a border case: when querying a
symmetric relation without specifying the subject nor the object, you may get
some duplicated result. IMO this is fine to let the user explicitly use DISTINCT
or not and to remove the dedicated handling we had which didn't let any choice.
Related to #3259713
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Tue, 11 Feb 2014 11:03:01 +0100] rev 9517
Typo in comments and error messages
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Thu, 13 Feb 2014 15:11:07 +0100] rev 9516
Fix typo in a setup.py comment
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Thu, 13 Feb 2014 15:09:30 +0100] rev 9515
[dataimport, migration] more fixes in the spirit of a6c32edabc8d:
[entity, metadata] huuum, use resolvable url as cwuri... And fix existing ones.
Closes #3390388
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 06 Feb 2014 15:04:57 +0100] rev 9514
[doc] Fix typo in devrepo/fti
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 04 Feb 2014 11:23:58 +0100] rev 9513
[doc/3.19] Clarify repoapi.get_repository usage
Followup for 9a62c52d167e.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 13:43:42 +0100] rev 9512
[server] use a connection instead of a session for user authentication
Julien Cristau <julien.cristau@logilab.fr> [Tue, 11 Feb 2014 17:29:58 +0100] rev 9511
Use repoapi instead of dbapi for cwctl shell, upgrade and db-init
Hopefully nobody uses dbapi-specific API in their migration scripts. I
guess we'll find out.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 28 Jan 2014 16:07:06 +0100] rev 9510
[server/repo] use internal_cnx in init_sources_from_database
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 15:25:05 +0100] rev 9509
[server/session] avoid spurious warnings from Session.close
Add internal non-noisy _rollback method.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 15:29:49 +0100] rev 9508
[server] rename session to cnx in querier and plan
They don't actually need a session, so let's make that clear.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 15:55:21 +0100] rev 9507
[repo] Use a connection instead of a session for repo.stats()
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 15:55:48 +0100] rev 9506
[repo] Use a connection instead of a session for repo.gc_stats()
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 15:56:44 +0100] rev 9505
[repo] Use a connection instead of a session for repo.get_versions()
Julien Cristau <julien.cristau@logilab.fr> [Thu, 30 Jan 2014 15:52:22 +0100] rev 9504
[webconfig] get_repository moved to repoapi
Julien Cristau <julien.cristau@logilab.fr> [Thu, 30 Jan 2014 16:48:39 +0100] rev 9503
[schemaserial] Replace 'cursor' with 'cnx'
We don't have cursors in rql, since execute is synchronous.
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Mon, 03 Feb 2014 09:38:39 +0100] rev 9502
[book] basic documentation for LDAPfeed
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 16:03:42 +0100] rev 9501
[testlib] Use session.sessionid instead of deprecated session.id
Julien Cristau <julien.cristau@logilab.fr> [Fri, 07 Feb 2014 17:03:11 +0100] rev 9500
Add data/pgdb to hgignore patterns
PostgresTestDataBaseHandler uses it as datadir.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 27 Jan 2014 14:01:03 +0100] rev 9499
[test] make unittest_postgres pass
Use PostgresApptestConfiguration which starts a postgresql cluster
locally for the duration of the test.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 28 Jan 2014 15:03:53 +0100] rev 9498
[devtools] make PostgresTestDataBaseHandler start its own postgresql
Don't depend on postgresql already running on the system, or on a static
config.
To use this, set the configcls attribute of your CubicWebTC-derived test
class to PostgresApptestConfiguration.
Caveats:
- this won't work with several tests running concurrently from the
same directory, since each would start its own cluster with a shared
data directory and stomp on each other's toes
- you need initdb/pg_ctl in $PATH, e.g /usr/lib/postgresql/$version/bin
on Debian/Ubuntu systems.
Closes #3489631
Julien Cristau <julien.cristau@logilab.fr> [Wed, 05 Feb 2014 09:23:36 +0100] rev 9497
[web/staticcontrollers] create a unique temporary file for concat handling
Predictable names means different processes can race against each other.
Let's avoid that and use mkstemp to get a real unique temporary file,
and atomically rename it when we're done.
Closes #3524182
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 15:50:19 +0100] rev 9496
[server/repo] Use session.sessionid instead of session.id
Silences deprecation warning.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 16:19:13 +0100] rev 9495
[server/session] use _free_cnxset instead of free_cnxset to avoid warnings
No need to make DeprecationWarning noise for something the user doesn't
have any control over.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 28 Jan 2014 15:29:23 +0100] rev 9494
[server] Use internal_cnx instead of internal_session in init_repository
Julien Cristau <julien.cristau@logilab.fr> [Thu, 30 Jan 2014 16:33:32 +0100] rev 9493
[server/session] session.id → session.sessionid
The former causes deprecation warnings.
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Tue, 04 Feb 2014 15:29:29 +0100] rev 9492
English typography
Get rid of extra space before `!' and `?'
Julien Cristau <julien.cristau@logilab.fr> [Mon, 03 Feb 2014 19:00:52 +0100] rev 9491
[repo] restore python 2.6 compatibility
Broken in 12dfce15c8ea.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 28 Jan 2014 18:24:29 +0100] rev 9490
[server] use internal_cnx instead of internal_session in deserialize_schema
Julien Cristau <julien.cristau@logilab.fr> [Tue, 28 Jan 2014 18:40:19 +0100] rev 9489
[server/schemaserial] rename cursor argument to cnx
cursor is a sql concept it has no meaning for rql.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 15:57:48 +0100] rev 9488
[repo] Use a connection instead of a session in Repository.properties()
Julien Cristau <julien.cristau@logilab.fr> [Thu, 30 Jan 2014 16:00:29 +0100] rev 9487
[server/sources] replace references to dbapi with repoapi
Julien Cristau <julien.cristau@logilab.fr> [Thu, 30 Jan 2014 16:45:05 +0100] rev 9486
[doc/3.19] Make repoapi description match code
Julien Cristau <julien.cristau@logilab.fr> [Mon, 03 Feb 2014 18:19:26 +0100] rev 9485
[serverctl] remove broken schema-sync command
As far as I can tell the migration handler hasn't had a
cmd_synchronize_schema method since cubicweb 3.2.0.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 30 Jan 2014 18:04:59 +0100] rev 9484
[server/session] Fix docstring typo for InternalSession
Dimitri Papadopoulos <dimitri.papadopoulos@cea.fr> [Fri, 24 Jan 2014 15:32:53 +0100] rev 9483
[book] typo
Julien Cristau <julien.cristau@logilab.fr> [Wed, 29 Jan 2014 13:45:03 +0100] rev 9482
[server] fix TypeErrors
With multisource gone, cnxset.reconnect() doesn't take a source
argument. Broken since d62e13eba033.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Dec 2013 11:50:46 +0100] rev 9481
[notification] use an InternalManager object for notifications if we have an (email, lang) tuple
The non-uniform handling of CWUser vs (email, lang) tuple has caused too
many bugs; this change mostly unifies the two code paths. Closes #3381521
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Dec 2013 11:50:31 +0100] rev 9480
[req] if a user has a None property, fall back to the default
This can happen for InternalManager; the normal CWUser implementation of
property_value already has a similar fallback. Related to #3381521
Julien Cristau <julien.cristau@logilab.fr> [Tue, 17 Dec 2013 11:50:12 +0100] rev 9479
[server] Allow setting an InternalManager's preferred language
Related to #3381521
Julien Cristau <julien.cristau@logilab.fr> [Mon, 27 Jan 2014 16:19:49 +0100] rev 9478
merge 3.18.2 into 3.19 branch
Julien Cristau <julien.cristau@logilab.fr> [Thu, 23 Jan 2014 10:53:24 +0100] rev 9477
[migration/3.18] protect against attributes in db missing from fsschema
Happens if a previous migration forgot a drop_attribute.
Closes #3471609
Arthur Lutz <arthur.lutz@logilab.fr> [Tue, 21 Jan 2014 18:39:32 +0100] rev 9476
[doc] Update copyright date to 2014 (closes #3463136)
Julien Cristau <julien.cristau@logilab.fr> [Fri, 24 Jan 2014 10:04:56 +0100] rev 9475
[repoapi] Fix typos in doc strings and comments
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 17 Dec 2013 13:43:56 +0100] rev 9474
[cwxml parser] minor pylint fixes
Julien Cristau <julien.cristau@logilab.fr> [Tue, 14 Jan 2014 17:30:02 +0100] rev 9473
[devtools] make CubicWebTC.login as admin undo previous logins
Fixes things when login is not used as a context manager.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 14 Jan 2014 17:30:13 +0100] rev 9472
[devtools] fix self.session._cnx vs self.cnx._cnx confusion after self.login
Make sure the client connection and the session refer to the same server
connection.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 23 Jan 2014 18:26:16 +0100] rev 9471
[devtools] _orig_cnx does not exist any more (missing change)
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 06 Jan 2014 17:25:55 +0100] rev 9470
[c-c schema] option to show single etype (closes #3404831)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 23 Jan 2014 13:47:28 +0100] rev 9469
[multi-sources-removal] Drop entities.source column
Since we remove federated multi-sources support, the same value ('system')
is always stored in this column and so could be removed. Also, cleanup
repository caches and a few api where the very same useless information could
be removed.
Closes #2919300, at last
[jcr: restore sanity check of etype against schema in checkintegrity.has_eid]
Julien Cristau <julien.cristau@logilab.fr> [Thu, 23 Jan 2014 12:32:16 +0100] rev 9468
[repo] pylint cleanup, mainly of imports, with a bit of style