Julien Cristau <julien.cristau@logilab.fr> [Thu, 26 Nov 2015 11:23:52 +0100] rev 10934
[devtools] fix QUnitResultController
It needs to return something.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 25 Jun 2015 17:13:33 +0200] rev 10933
[utils] Drop now-unused SizeConstrainedList
It's last usage in CubicWeb got removed from changeset '[views] remove
breadcrumbs usage to retrieve last visited page'
Related to #5456850.
Rabah Meradi <rabah.meradi@logilab.fr> [Wed, 25 Nov 2015 18:31:48 +0100] rev 10932
[views] remove breadcrumbs usage to retrieve last visited page
Use JavaScript history.back to go to the last visited page. Rename
_return_to_lastpage to _redirect as it becomes misnamed.
Drop `test_redirect_default` test in `unittest_views_basecontrollers`
which essentially tested this (now removed) breadcrumbs "feature".
Closes #5456850.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 25 Nov 2015 16:22:42 +0100] rev 10931
[cwconfig] Explicitly close generated config file
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 25 Nov 2015 17:57:07 +0100] rev 10930
[doc] Add 3.21 release date
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Wed, 25 Nov 2015 10:19:52 +0100] rev 10929
[dataimport] fix db-namespace default value handling
In a fresh new instance, the "db-namespace" option is set as empty
by default in the "sources" file.
This seems correct but empty string is not a valid pg_schema and
actually means that we should use "public"
Julien Cristau <julien.cristau@logilab.fr> [Wed, 25 Nov 2015 11:30:36 +0100] rev 10928
[server] unbreak db-restore
Julien Cristau <julien.cristau@logilab.fr> [Tue, 24 Nov 2015 19:00:02 +0100] rev 10927
[doc] add 3.22 changelog
Julien Cristau <julien.cristau@logilab.fr> [Tue, 24 Nov 2015 18:22:26 +0100] rev 10926
[rset] remove stray (commented-out) print
Left from debugging in af266f27c4d5
Julien Cristau <julien.cristau@logilab.fr> [Mon, 23 Nov 2015 19:18:08 +0100] rev 10925
Un-hide jshintrc
dot-files belong in ~, not anywhere else.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 25 Nov 2015 17:31:32 +0100] rev 10924
[views] Use 'pyvaltable' instead of hand-crafted <table> tags
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 24 Nov 2015 17:31:09 +0100] rev 10923
[web] Stop using config.repository()
Since commit 3914388b2d0f, this method creates a new Repository object
and thus reloads all the cubes, taking for ever.
Closes #8634417.
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 24 Nov 2015 16:57:07 +0100] rev 10922
[web] Stop using webconfig.vc_config()
The main issue is that this creates an entirely new Repository object
(since commit 3914388b2d0f) and thus reloads all the cubes, taking for
ever.
Related to #8634417.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 24 Sep 2015 11:26:11 +0200] rev 10921
[migration] don't handle data deletion anymore on schema changes
In most cases when we want to drop some entity/relation type, we don't care
whether hooks are called on their deletion. There is even low chances that some
hooks still exists, based on an old version of the schema. Last but not least,
this is horribly inefficient.
So this should be clearly documented and handled by application's programmer if
desired.
This patch removes unnecessary deletion (because table or column will be later
dropped) and reimplements the case of partial deletion (only one relation
definition among several, hence the database structure isn't modified) using
sql.
Only one test regarding deletion of inlined relation def is added as other cases
seem to be covered by existing tests.
Closes #7023315
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 16:01:43 +0100] rev 10920
[hooks/syncschema] drop unused import
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 16:01:26 +0100] rev 10919
[hooks/syncschema] indentation fix
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 16:00:57 +0100] rev 10918
[server/test] cosmetic whitespace fix
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 16:00:06 +0100] rev 10917
[hooks/syncschema] don't set NOT NULL on inlined relation columns
The NOT NULL constraint was being added on inlined relation cardinality
change while it shouldn't. We don't want this, because this forbids to
add an entity without the relation set at once (it may be added later in
the transaction). This patch fix synchronization hook to stop doing
this.
Closes #6211101
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 24 Sep 2015 12:18:00 +0200] rev 10916
[hooks/syncschema] Turn DropColumnOp into a data operation
While writing a test for a migration issue where "NOT NULL" was added to
an inlined relation column, I ran into a case where the same column was
deleted twice, which of course results in an error. This is because the
"ecrit_par" relation used by the test is ambiguous. I've hence turned
the DropColumnOp into a data operation to ensure we'll delete the column
only once in such case.
Related to #6211101
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 10:16:55 +0100] rev 10915
[server/sources] fix name error in eid_type_source_pre_131
i.e. the eid_type_source implementation used when some pre 3.13.1
database is detected. Regression from 5fbdbbe51867.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 30 Jun 2015 10:06:00 +0200] rev 10914
[repository] deprecate the extid2eid based multi-sources API
This API is cumbersome and lead to obfuscated code because of the callback
mecanism implied when some entity has to be created.
Since we dropped the "true" multi-source, this mecanism is not needed anymore
and one should prefer to use the dataimport API inside its parser instead.
Notice the cwxml parser will trigger the deprecation warning, it should not be
used anymore in favor of ad-hoc parsers.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Nov 2015 14:37:37 +0100] rev 10913
[ldapfeed] use source's extid2eid, the repo's one will be deprecated in a near future.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 14:36:41 +0100] rev 10912
[ldapfeed / dataimport] port ldapfeed parser to dataimport API
This makes the code easier to understand and will allow to deprecate the old
multi-sources api, based on creation callback through repo.extid2eid.
Currently with this patch, modification dates are not checked, hence
entities will be systematically updated.
We run the import with no hooks, because RQLObjectStore can only add
entities to the system source.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Nov 2015 14:34:13 +0100] rev 10911
[server/test] document expected packages to run ldap tests
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Nov 2015 14:28:19 +0100] rev 10910
[ldapfeed] simplify ldap2attrs
* tdict argument is never given
* separate value retrieval from setting output (will ease a latter cset)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Nov 2015 14:26:44 +0100] rev 10909
[ldapfeed] simplify deactivation of unencountered users
there is no need for the by_etype intermediary dictionnary since we only
consider CWUsers.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 10:04:18 +0100] rev 10908
[server/test] display rset content on failure
Julien Cristau <julien.cristau@logilab.fr> [Tue, 24 Nov 2015 14:08:47 +0100] rev 10907
Remove trailing empty lines
Makes pep8 happier
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 24 Nov 2015 14:05:50 +0100] rev 10906
[ldapparser] simplify extid splitting
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 23 Nov 2015 14:23:08 +0100] rev 10905
[test/ldap] a bit of pep8
Samuel Trégouët <samuel.tregouet@logilab.fr> [Wed, 29 Jul 2015 10:05:37 +0200] rev 10904
[js] add configuration file for jshint (closes #5593987)
copied from https://gist.github.com/haschek/2595796
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 16 Oct 2015 11:58:10 +0200] rev 10903
spelling: *aly → *ally
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 16 Oct 2015 11:15:50 +0200] rev 10902
[web] Add a <label> around choices on CheckBox and Radio form widgets
Allows clicking directly on the text rather than only on the widget.
Closes #7672774.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 16 Oct 2015 10:36:34 +0200] rev 10901
[web] xml_escape CheckBox and Radio labels (closes #7672764)
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 20 Nov 2015 14:17:46 +0100] rev 10900
[test/tox] Enforce installation of modified yapps
580a6821713d is not enough for tox apparently...
The thing is that it will first install dependencies (the `deps` option from
tox.ini), actually pulling yapps from Logilab github but then, it will install
the project (that is, CubicWeb) from the sdist *along with its dependencies*,
which will pull yapps again and override the previously installed version for
some mysterious reason.
So add a `pip install` command in tox.ini, so that the modified yapps is the
last one installed.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Sep 2015 11:12:03 +0200] rev 10899
[web] delete unused PropertySheet._sourcefile_mtime
Julien Cristau <julien.cristau@logilab.fr> [Fri, 18 Sep 2015 11:05:47 +0200] rev 10898
[etwist] remove no-longer-necessary uicache cleaning
It was done before we were actually up, which means it could be too
eager when combined with #6893185.
Closes #6893247.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 23 Nov 2015 17:58:10 +0100] rev 10897
[web] remove PropertySheet._cache
Instead of remembering that a css file has been processed, we re-process it at
every request. This prevents our cache getting out of date with the file
system. Closes #6893185
While we're at it, write the file atomically so that we don't risk serving
partial data.
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 23 Nov 2015 17:47:46 +0100] rev 10896
[test] Add missing u''
Test actually works in py3k, but not in python 2... That has to be a
first!
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 13 Nov 2015 14:29:48 +0100] rev 10895
[data] Use correct syntax to unset CSS attributes (closes #8602446)
'default' is actually a recognized CSS cursor name (the regular
pointer). Using this value doesn't revert to whatever cursor DOM
elements have by default ('pointer' on links, 'text' on text, etc).
The proper way to unset a CSS attribute on DOM elements is to set it to
an empty string.
http://stackoverflow.com/questions/2027935/how-to-remove-css-property-using-javascript
Julien Cristau <julien.cristau@logilab.fr> [Wed, 22 Apr 2015 16:09:04 +0200] rev 10894
[server] install custom sql scripts before creating tables for the schema
A cube might need something like 'CREATE EXTENSION postgis' before
creating tables for its entities, to add new final types.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 20 Oct 2015 15:40:17 +0200] rev 10893
[hooks] update internal URL in doc string
Jérôme Roy <jerome.roy@logilab.fr> [Thu, 19 Nov 2015 12:29:42 +0100] rev 10892
[doc] Fix restructured tables + improve english a bit
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 06 Nov 2015 09:41:11 +0100] rev 10891
[debian] Install dataimport package
Closes #8173104.
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 09 Sep 2015 18:52:56 +0200] rev 10890
[web/test] Remove use of old test API to silence warning
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 07 Sep 2015 18:42:47 +0200] rev 10889
[web/views] Fix sqlite unicode warning
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 03 Sep 2015 16:36:08 +0200] rev 10888
[devtools] Fix sqlite unicode warning
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 02 Sep 2015 12:08:31 +0200] rev 10887
[tests] Don't import QUnitTestCase into tests' global namespace
Unittest's test loader will try to execute QUnitTestCase's test_javascripts method. However this class is intended to be subclassed, not to be executed directly.
This change has the following consequences:
* slightly faster test execution
* almost all rtags warnings are gone
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 01 Sep 2015 17:13:16 +0200] rev 10886
[devtools/qunit] Fail quickly if firefox is not installed
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 24 Aug 2015 14:33:14 +0200] rev 10885
[devtools/qunit] Remove unused code
VerboseCalledProcessError is unused since 3905682ece11.
Rémi Cardona <remi.cardona@logilab.fr> [Mon, 23 Nov 2015 15:54:28 +0100] rev 10884
[py3k] import range using six.moves
Also, use create_entity instead of hand-crafting RQL queries.
Fixes regression introduced in commit 768d332de17b.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 09 Nov 2015 17:17:53 +0100] rev 10883
[dataimport] remove size constraint handling
We do not want to silently truncate data. If that is wanted, the
application-specific importer should handle that itself.
[v2: Keep the get_size_constraints function so applications don't have
to reimplement it if they need to keep the truncate behaviour]
Julien Cristau <julien.cristau@logilab.fr> [Mon, 09 Nov 2015 17:08:21 +0100] rev 10882
[dataimport] fix doc string to stop referring to the old API
Julien Cristau <julien.cristau@logilab.fr> [Mon, 09 Nov 2015 17:00:50 +0100] rev 10881
[dataimport] drop duplicate init of MassiveObjectStore.sql
Julien Cristau <julien.cristau@logilab.fr> [Mon, 09 Nov 2015 16:43:50 +0100] rev 10880
[dataimport] remove implicit commits from MassiveObjectStore
Let the user decide when to commit the transaction.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 09 Nov 2015 16:21:29 +0100] rev 10879
[dataimport] drop extra indirection through MassiveObjectStore._initialized dict
We already have self.__dict__, no need to add another one for a static
set of keys.