Alexandre Fayolle <alexandre.fayolle@logilab.fr> [Wed, 20 Jan 2010 09:00:36 +0100] rev 4298
enable cubicweb-ctl db-dump and db-restore on Windows with SQL Server
os.system has some issues on Windows, especially regarding whitespace handling,
which subprocess handles correctly.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 15:03:30 +0100] rev 4297
3.6 api update
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 14:41:04 +0100] rev 4296
merge
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 14:39:44 +0100] rev 4295
allow control of generic relations field display through display_fields
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 14:39:10 +0100] rev 4294
no self._cw on widget objects while '_' is defined locally
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 14:38:45 +0100] rev 4293
delete remaining stuff w/ handling of the generic relations
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 14:34:06 +0100] rev 4292
test update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Wed, 20 Jan 2010 13:03:08 +0100] rev 4291
clear vreg's parent_classes cache to fix etype cache / auto-reloading bug
EtypeRegistry.parent_classes()'s is cached. When the registry is
reloaded, if the cache is not cleared, we might get the old list
of parent classes and that leads to strange bugs.
Typical scenario :
1/ start application in debug mode
2/ go to add/Bookmark -> everything's fine
3/ change the source
4/ reload add/Bookmark -> 'creation' not selectable because :
a/ cw detects a change in the source and reloads vreg
b/ cw tries to select 'creation' view for 'Bookmark'
- 'creation' view uses specified_etype_implements('Any')
- cw compares Bookmark.__bases__[0] (i.e. new version of
AnyEntity) with the old version of AnyEntity cached in
the vreg. They don't match => view is not applicable.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:31:38 +0100] rev 4290
merge
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:31:28 +0100] rev 4289
fix bad indent
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:29:58 +0100] rev 4288
backport stable
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:29:08 +0100] rev 4287
cleanup
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:29:00 +0100] rev 4286
fix bug: the 'table' argument is overwritten by the loop variable, causing latter crash due to this missing information
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:27:41 +0100] rev 4285
don't record deambiguifier when it has no type restriction using 'is', so we don't miss later some available constraints
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:23:27 +0100] rev 4284
fix warning stack level
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 11:23:18 +0100] rev 4283
cw 3.6 api update
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 10:14:14 +0100] rev 4282
merge
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 10:13:45 +0100] rev 4281
merge
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 10:13:02 +0100] rev 4280
more input/button fixes
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 10:10:17 +0100] rev 4279
backport stable
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 10:06:53 +0100] rev 4278
cleanup
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 10:06:12 +0100] rev 4277
turn all the stuff used to handle 'generic relations' in forms into proper
field / widget.
-> regroup code from web.request, web.controller, web.views.autoform, web.views.formrenderers,
web.views.editcontroller (!) into GenericRelationsField, GenericRelationsWidget in the editviews
module (together with the UnrelatedDiv view).
So:
* almost everything in one place
* no more specific behaviour in the form renderer
* almost no custom behaviour in autoform (simply add the field when it think it should)
Also, the form renderer now display field's value with colspan=2 when field.label is None.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2010 08:43:41 +0100] rev 4276
fix tests
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Wed, 20 Jan 2010 10:05:10 +0100] rev 4275
[rql2sql] added test that shows crash during sql generation
Original query in cubicweb-drh:
Any A,E,CV,group_concat(TN) GROUPBY A,E,CV WHERE A is Application, A for_person P, P has_studied_in E?, T? tags A, T name TN, A curriculum CV?
Corresponding bug in tracker: #628798
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 18:26:22 +0100] rev 4274
apply patch proposed by 2web to properly remove hidden input set to represent the button used to submit the form, so forms may be properly reused after a post
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 18:22:05 +0100] rev 4273
fix dumb name error
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 18:21:59 +0100] rev 4272
missing import
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 18:20:43 +0100] rev 4271
remove input from jquery filter, so it works as well with buttons
alex & cheb [Tue, 19 Jan 2010 18:11:31 +0100] rev 4270
unicode(arg) else we may get some encoding exception
alex & cheb [Tue, 19 Jan 2010 18:10:01 +0100] rev 4269
remove deprecation warnings + name error
Stephanie Marcu <stephanie.marcu@logilab.fr> [Tue, 19 Jan 2010 17:50:48 +0100] rev 4268
remove common/test/data directory from __pkginfo__, MANIFEST and debian rules to allow cubicweb installation
Stephanie Marcu <stephanie.marcu@logilab.fr> [Tue, 19 Jan 2010 17:50:36 +0100] rev 4267
fix syntax error
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 14:41:23 +0100] rev 4266
test fixes
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 14:41:19 +0100] rev 4265
3.6 api update
Stephanie Marcu <stephanie.marcu@logilab.fr> [Tue, 19 Jan 2010 12:34:52 +0100] rev 4264
update selectors.py: change entity.schema with entity._cw.vreg.schema
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 12:27:55 +0100] rev 4263
merge
Stephanie Marcu [Tue, 19 Jan 2010 12:19:14 +0100] rev 4262
we should access to __regid__ instead of id since in that case bw compat fail: access to id throuhg a class returns the property object instead of calling the property's method
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 12:17:22 +0100] rev 4261
fix autoform_is_inlined bw compat
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Tue, 19 Jan 2010 11:58:07 +0100] rev 4260
[forms] fix implementation of backward compat method form_render
previous implemtation used form_default_renderer() which is now replaced
by default_renderer()
Stephanie Marcu <stephanie.marcu@logilab.fr> [Tue, 19 Jan 2010 10:43:48 +0100] rev 4259
inherit from FieldWidget to inherit from the process_field_data required by the edit controller
Stephanie Marcu <stephanie.marcu@logilab.fr> [Tue, 19 Jan 2010 10:42:47 +0100] rev 4258
with cw 3.6 we've to specify entity's relation role
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2010 10:19:08 +0100] rev 4257
fix bad merge
Pierre-Yves David <pierre-yves.david@logilab.fr> [Wed, 16 Dec 2009 14:19:01 +0100] rev 4256
import uicfg.auto_form doc
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 19 Jan 2010 09:51:38 +0100] rev 4255
update i18n doc
Pierre-Yves David <pierre-yves.david@logilab.fr> [Tue, 19 Jan 2010 09:49:42 +0100] rev 4254
Fix element tree import for python2.4
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 18 Jan 2010 19:40:59 +0100] rev 4253
forgotten buffer
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 18 Jan 2010 19:21:30 +0100] rev 4252
backport stable branch
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 18 Jan 2010 19:05:08 +0100] rev 4251
fix pb with bytes field processing: currently when an existing file is edited
and no new file is specified, it finds no value in req.form and so try to
detach the current file, which is wrong. In that case, nothing should be done.
So introduce a new UnmodifiedField exception that may be raised in
field's process_form_value method (catched in field.process_posted).
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 18 Jan 2010 15:58:06 +0100] rev 4250
fix NameError
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 18 Jan 2010 12:33:45 +0100] rev 4249
don't call handle_inlined_relation where we're not on the relation'subject
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 18 Jan 2010 11:55:37 +0100] rev 4248
don't add another _cw_edited_field hidden when build_context is called twice (may occurs with inlined relation forms)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 18 Jan 2010 11:50:54 +0100] rev 4247
cleanup
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 18 Jan 2010 11:50:34 +0100] rev 4246
don't use matching_groups() for is_in_group implementation
Alexandre Fayolle <alexandre.fayolle@logilab.fr> [Fri, 15 Jan 2010 09:36:49 +0100] rev 4245
a few french translation typo corrections
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 15 Jan 2010 09:05:40 +0100] rev 4244
rename need_navigation into paginable
paginable has been recently introduced by changeset d4eeaf0393e2.
We already had the need_navigation attribute to control the same
thing (pagination). As paginable sounds like a better name, deprecates
need_navigation (bw compat ok).
Also:
* fix main pagination functions responsability
* deprecate limit_rset_using_nav in favor of paginate/do_paginate
* navigation module should be renamed to pagination at some point
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 14 Jan 2010 11:37:08 +0100] rev 4243
backport tracker permission utility functions into the cw.schemas package
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 14 Jan 2010 11:28:32 +0100] rev 4242
Backed out changeset b8ea99f5e8ea, tags.a escape its content.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 14 Jan 2010 11:14:40 +0100] rev 4241
fix dumb name errors
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 14 Jan 2010 11:13:22 +0100] rev 4240
fix global errors display when there is more than one error
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 14 Jan 2010 11:12:52 +0100] rev 4239
fix error key / field input detection (field's name include -role when specified, the error key *may* include it
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 13 Jan 2010 18:04:29 +0100] rev 4238
missing xml escapes (but textoutofcontext probably ought to be just outofcontext, with no escaping then)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 17:44:29 +0100] rev 4237
3.6 api update
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 17:44:11 +0100] rev 4236
move autoform's field_by_name implementation on base EntityFieldsForm
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 17:42:27 +0100] rev 4235
specify name *and* role when raising FieldNotFound helps debugging
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 17:41:42 +0100] rev 4234
if specified, benefit from target_etype information in the [partial_]add_relation selector
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 17:40:53 +0100] rev 4233
ouch, has_perm was always returning False...
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 16:07:54 +0100] rev 4232
more 3.6 api update
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 16:01:53 +0100] rev 4231
iirk reminder
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 16:01:34 +0100] rev 4230
3.6 api update
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 16:00:42 +0100] rev 4229
has_been_modified shouldn't raise ProcessFormError
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 16:00:06 +0100] rev 4228
related entities are returned as tuple since a few months ago
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 15:59:31 +0100] rev 4227
should skip INTERNAL_FIELD_VALUE
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 15:57:57 +0100] rev 4226
should use a set for pending fields
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 15:56:31 +0100] rev 4225
fix process_form_values: we should handle value errors and properly raise ProcessFormError
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 15:54:07 +0100] rev 4224
refactor form error handling:
* almost everything is in the base form class, with other form errors related code
* deprecate form_field_error in favor of field_error and format_error on the renderer
* fix pb with js localization of errors by properly using field.role_name()
* rename 'errors' into 'error' in forminfo to avoid confusion
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 15:48:24 +0100] rev 4223
new DBG_ALL debug level
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 13 Jan 2010 15:48:07 +0100] rev 4222
return localized message on parse_datetime errors
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 12 Jan 2010 17:24:46 +0100] rev 4221
raising ConfigurationError is cleaner; remove some unused imports
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Tue, 12 Jan 2010 15:12:51 +0100] rev 4220
[javascript] upgrade excanvas.js (rev. M3, mars 2009): this fixes plot widgets rendering in IE
Aurelien Campeas <aurelien.campeas@logilab.fr> [Mon, 11 Jan 2010 14:13:26 +0100] rev 4219
do not attempt to daemonize under windows
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Sat, 09 Jan 2010 15:31:37 +0100] rev 4218
[cwctl] reset-admin-pwd was failing when db-host was not set
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Fri, 08 Jan 2010 18:20:03 +0100] rev 4217
[javascript] IE doesn't support dynamic enctype modification, we have to set encoding too
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Fri, 08 Jan 2010 12:17:42 +0100] rev 4216
[forms] make it easier to override CWProperty form buttons
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Fri, 08 Jan 2010 12:14:29 +0100] rev 4215
[forms] make it easier to override StringField's mininum size
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Fri, 08 Jan 2010 11:45:37 +0100] rev 4214
[skeleton] remove unused os.path.dirname import, use dname instead of dirname as an additional safetly belt
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Thu, 07 Jan 2010 17:41:50 +0100] rev 4213
[web/views] if view has attribute paginable=False, do not try to paginate it
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Thu, 07 Jan 2010 16:52:32 +0100] rev 4212
update copyright: welcome 2010
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Thu, 07 Jan 2010 08:02:52 +0100] rev 4211
[views] backport progressbar template from shingouz
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Tue, 05 Jan 2010 22:11:37 +0100] rev 4210
[forms] fix multiple edit bug introduced by changeset cebdf8ee5ad7
Changeset cebdf8ee5ad7 assumed that edited entity was either explicitly
passed to the form or found in first row / first col of the resultset
because of the one_line_rset() selector.
But one_line_rset() is actually trickier : the selector returns 1
if the resultset has more than one row **if** an explicit row is
specified during selection process. This is exactly what is done
in the 'muledit' form :
for row in xrange(len(self.rset)):
form = self.vreg['forms'].select('edition', self.req,
rset=self.rset, row=row, #...
This changeset thus takes row in consideration to find edited entity
if 'row' was explcitly specified.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 05 Jan 2010 18:28:27 +0100] rev 4209
do not recompute the plot on subsequent onload events #615338
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 05 Jan 2010 17:04:29 +0100] rev 4208
fix stripEmptyTextNodes for IE (part of #615337)
this does not seem to make the function really work but it does not fail any more
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Mon, 04 Jan 2010 19:02:09 +0100] rev 4207
[javascript] upgrade jquery.flot.js to v0.6 to fix IE6-related bugs
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Mon, 04 Jan 2010 18:58:35 +0100] rev 4206
[forms] edited_entity must be set before calling session_key()
EntityFieldsForm.__init__ calls FieldsForm.__init__ which in turn
calls self.session_key().
self.session_key() uses self.edited_key to compute the correct session
key. We thus need edited_entity to be set **before** calling super's __init__.
The bug only occured when EntityFieldsForm was selected because of its
one_line_rset() selector instead of match_kwargs('entity').
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 13:05:53 +0100] rev 4205
must escape user_rql_callback
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 12:20:10 +0100] rev 4204
backport stable branch
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 11:57:03 +0100] rev 4203
Added tag cubicweb-debian-version-3.5.11-1 for changeset 4920121d41f2
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 11:57:02 +0100] rev 4202
Added tag cubicweb-version-3.5.11 for changeset f48b2f193961
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 10:27:33 +0100] rev 4201
3.5.11
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 09:07:17 +0100] rev 4200
i18nupdate
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 08:59:01 +0100] rev 4199
must now properly use Binary for password (see 4180:42247d70105b). XXX Though this is somewhat backend related (eg store password using a binary type), this should be either well document or handled properly in the db helper.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 08:56:38 +0100] rev 4198
TYPE_MAPPING expected to be a mapping from yams type to db type, and timestamp is the Datetime yams type
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Dec 2009 08:22:18 +0100] rev 4197
quick and dirty fix to avoid crash when running db-create command with an sqlite source
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 23:45:43 +0100] rev 4196
add es.po to default skel, closes #591625
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 21:02:37 +0100] rev 4195
closes #601987
1) sqlutils.restore_from_file have to use its confirm argument when
a command fail, to propose to continue there (this can't be handled
by the caller)
2) source.restore method hence needs to take this confirmation callback
as argument
3) properly fix places where 'drop' was given instead of 'confirm'
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 20:06:24 +0100] rev 4194
missing one litle char
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 20:05:52 +0100] rev 4193
closes #607344 by simply appending '/' to base url if necessary instead of insulting the user
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 19:27:51 +0100] rev 4192
cleanup
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 19:27:48 +0100] rev 4191
test update. All cw tests OK
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 19:27:26 +0100] rev 4190
fix bad merge
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 19:26:59 +0100] rev 4189
make groupmap argument optional / sort for testing purpose
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 19:26:12 +0100] rev 4188
fix virtual relation detection: erschema is no more a relation type but a relation def in _synchronize_permissions
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 19:25:08 +0100] rev 4187
necessary to fix some security test, unclear why did I set perms below at some point...
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 19:23:59 +0100] rev 4186
import cleanup, check data file exists
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 18:25:53 +0100] rev 4185
should turn password into a Binary properly
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 13:16:17 +0100] rev 4184
should not simplify previous to preprocess
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 13:14:34 +0100] rev 4183
use ._cw instead of .req (reintroduced by merge of stable)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 13:13:53 +0100] rev 4182
oops
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 22 Dec 2009 10:27:49 +0100] rev 4181
backport stable
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 22 Dec 2009 14:18:48 +0100] rev 4180
more extra_args cleanup
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 22 Dec 2009 13:43:24 +0100] rev 4179
only give extra_args if there is something to be fed (breaks some db connectors otherwise)