Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 17:14:32 +0200] rev 10365
[connection] remove ensure_cnx_set context manager uses
It has been deprecated in a previous changeset and is now a no-op.
Related to #2919309.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 15:32:07 +0200] rev 10364
[server] remove cnxset tracking, it is now unneeded
Indeed, all cnxsets will now be acquired using the following API::
with session.new_cnx() as cnx:
cnx.execute(...)
# do stuff
cnx.commit()
These well-scoped blocks are the only place a cnxset can be acquired.
The old use-case for un-delimited cnxsets (pyro/zmqpickle protocols)
have been removed.
The "mode" of connection objects becomes "write" forever (it will be
removed in a couple of changesets).
Related to #2919309.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 15:58:01 +0200] rev 10363
[devtools] remove the remaining bw compat for old-style tests
It is just:
* dangerously untested right now
* on the path of further bw compat removal (cnxset handling)
webtest drops an apparently pointless .login call
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 14:52:27 +0200] rev 10362
[session] remove session-related bw compat code
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 14:47:50 +0200] rev 10361
[session/transaction] removed unused transaction class
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 11 Jun 2014 13:39:56 +0200] rev 10360
[transactions] cleanup after the dbapi removal
* end req vs cnx dichotomy
* Transaction takes a cnx at __init__ time
* a couple of super calls are fixed
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 15:06:44 +0200] rev 10359
[session/cnx] remove `session_handled` logic
Related to #3837233 .
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 14:44:36 +0200] rev 10358
[web/sessions] reduce repoapi usage where possible
Using session.new_cnx() should be the new preferred way.
Related to #3837233.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 18:17:07 +0200] rev 10357
[entity,storage] remove hackish code from the bfss path
The ClientConnection/Connection duality brought some painful hacks
that are no longer needed.
Hence we can send entity._cw_update_attr_cache and ._cw_dont_cache_attribute
to the grave.
Related to #3837233
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 13 Jun 2014 15:56:08 +0200] rev 10356
[connection] eliminate ClientConnection leftovers
* in the documentation
* in the docstrings
* in code notations (e.g. clt_cnx -> cnx)
Related to #3837233.
From now, there should be just one ClientConnection left in repoapi.py.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 13 Jun 2014 15:42:04 +0200] rev 10355
[session] all cnx._session become cnx.session
The _session belonged to ClientConnection, which is just gone.
Related to #3837233.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 10 Jun 2014 16:01:49 +0200] rev 10354
[repoapi] fold ClientConnection into Connection
Connection replaces ClientConnection everywhere.
Some notes:
* testlib: .client_cnx and .repo_cnx become aliases of .cnx (we might
not want to tell people to update their tests again for just no real
benefit, so we'll live with these aliases for a while)
* entity.as_rset must not be cached because we risk caching result
sets having a Connection object as .req (helps unittest_breadcrumbs)
* entity._cw_dont_cache_attributes loses its repo/request special
paths and only keeps its storage/bfss user (this helps
unittest_wfobjs)
* moreover, entity.cw_instantiate and .cw_set stop overriding the
attributes cache *after* the before_*_entity hooks have run, because
there is no need to (it is now actually harmful to do it and
unittest_hooks.test_html_tidy* tests remain green because of this)
* rset._build_entity sticks its .req onto the entity just fetched from
the cache, because otherwise it might carry a _cw that is a
Connection object where a Request is expected (helps
unittest_views_actions)
* we get overall better cache usages (entity caches were split over
Request + ClientConnection and Connection), hence the changes
unittest_entity and unittest_wfobjs
* void the ecache when providing the cnx to a request object
Having the entity cache pre-filled when we bind it to the request
object hurts because these entities are bound to Connection objects,
that lack e.g. `.form` or `.add_js` and crash the views subsystem.
Thus, the unittest_testlib.test_error_raised test will are kept
green.
Closes #3837233
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 13 Jun 2014 13:54:28 +0200] rev 10353
[migractions] remove any session related leftovers
Also, the migration handler really wants a "repo" session anyway.
This highlights a bug in unittest_wfobjs.test_duplicated_transition
where an old connection is reused. It probably used to work because it
was made of session + set_cnxset magic dust.
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 13 Jun 2014 12:07:51 +0200] rev 10352
[session] provide missing apis to Connection
From this point, Connection provides a superset of ClientConnection.
Related to #3837233.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Jul 2014 16:55:49 +0200] rev 10351
[connection] replace .running_dbapi_query with .hooks_in_progress
The thing was badly named.
It tries to help distinguish between queries issued
directly by the programmer (e.g in the views: cnx.execute(...))
from queries issued from the hooks, operations ... or even
the repository or the native source objects.
It worked heuristically being associated with
the security being disabled.
We provide a better name and an implementation distinct from
the security management methods.
Related to #3933480.
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 05 May 2015 08:41:19 +0200] rev 10350
[dataimport] Turn the module into a package
Just `hg mv` dataimport.py and test/unittest_dataimport.py.
Rémi Cardona <remi.cardona@logilab.fr> [Fri, 07 Nov 2014 15:33:30 +0100] rev 10349
[dataimport] Properly escape strings sent to COPY FROM (closes #5278743)
See http://www.postgresql.org/docs/9.1/static/sql-copy.html#AEN64296
for escaping codes.
Adrien Di Mascio <Adrien.DiMascio@logilab.fr> [Tue, 28 Apr 2015 17:00:35 +0200] rev 10348
[http] fix cache-control syntax in EtagHTTPCacheManager
use , to separate cache response directive
closes #5307539
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Jul 2014 13:19:35 +0200] rev 10347
[connection] provide some missing documentation bits
The previous changesets remove information about session data and transaction data.
We provide the necessary entries in the docstring of the Connection class.
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Fri, 06 Jun 2014 17:08:08 +0200] rev 10346
[repoapi,session] remove all session-as-cnx backward compat
The `dbapi` being gone, we now can drop the session object
bw-compatibility layer. This will allow further simplifications, such
as folding ClientConnection and Connection (without too much pain),
and then having persistent sessions.
Related to #3933480.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 22 Apr 2015 18:28:58 +0200] rev 10345
[server] drop repo.internal_session and InternalSession
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 22 Apr 2015 17:48:32 +0200] rev 10344
Added tag cubicweb-version-3.20.7, cubicweb-debian-version-3.20.7-1, cubicweb-centos-version-3.20.7-1 for changeset 359d68bc1260
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 22 Apr 2015 17:48:00 +0200] rev 10343
[pkg] 3.20.7
Julien Cristau <julien.cristau@logilab.fr> [Wed, 22 Apr 2015 17:45:27 +0200] rev 10342
[dbapi] retire repo.[gs]et_shared_data which were used by the dbapi
Related to #3933480
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 17 Mar 2015 16:00:30 +0100] rev 10341
[dbapi] retire repository transaction methods which were used by the dbapi
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 17 Mar 2015 15:57:22 +0100] rev 10340
[dbapi] retire repo.call_service which was used by the dbapi
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 17 Mar 2015 15:55:52 +0100] rev 10339
[dbapi] retire repo.commit/rollback which was used by the dbapi
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 17 Mar 2015 15:46:40 +0100] rev 10338
[dbapi] retire repo.user_info which was used by the dbapi
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 17 Mar 2015 15:41:54 +0100] rev 10337
[dbapi] retire repo.entity_metas which was used by the dbapi
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 04 Jun 2014 18:21:24 +0200] rev 10336
[dbapi] retire repo.execute, which was used by the dbapi
We will retire or reform pieces, mostly of the Repository class,
that were related to the old dbapi way of life.
Related to #3933480.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 05 Jun 2014 09:51:57 +0200] rev 10335
[devtools/testlib] remove dbapi backward-compat
Related to #3933480.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 13 Mar 2015 16:11:35 +0100] rev 10334
[test] fix copy-pasta in doc string
Julien Cristau <julien.cristau@logilab.fr> [Fri, 13 Mar 2015 16:10:29 +0100] rev 10333
[book] remove dbapi documentation
Move some still-relevant doc related to the RQL connection API to the
'sessions' section. It might make sense to move this back outside of
the "Repository development" chapter at some point since this is
relevant in other contexts.
Alain Leufroy <alain@leufroy.fr> [Fri, 27 Mar 2015 15:29:34 +0100] rev 10332
[uilib] `uilib.js` helper now honors explicit JSString (closes #4959538)
Previously, if a JSString was inside a nested container (i.e. list or
dict), it was handled as a string, not a verbatim js chunk (see
docstring and test). So the following code::
>>> str(js.cw.pouet(1, {'callback': JSString('cw.mycallback')})
resulted in::
"cw.pouet(1, {'callback': 'cw.mycallback')})"
while we expect (note the removed quotes)::
"cw.pouet(1, {'callback': cw.mycallback)})"
We use ``cubiweb.utils.js_dumps`` instead of
``cubicweb.utils.json_dumps`` which is aware of JSString.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 03 Jun 2014 16:57:14 +0200] rev 10331
[dbapi] remove the dbapi module and its immediate remaining users
We suppress toolsutils.config_connect, which has currently
only one known user (the email cube), which is being patched.
It can be replaced with utils.admincnx function for a local
access.
Next will come a series to:
* remove the session backward compatibility
* fold ClientConnection into Connection
Closes #3933480.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 13 Mar 2015 16:57:32 +0100] rev 10330
[web/views] remove dbapi usage from 'gc' view
Christophe de Vienne <christophe@unlish.com> [Tue, 07 Apr 2015 17:08:53 +0200] rev 10329
[sqlite] Fix integrity error parsing
Up to sqlite 3.7, integrity error message may be in the singular form
if only one column is in the unique index.
Closes #5224632
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 06 Apr 2015 21:46:52 +0200] rev 10328
[postgres] fix limit_size regexp to properly remove one char tags like <p>.
Closes #5221847
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 15 Apr 2015 22:08:08 +0200] rev 10327
[postgres] _regproc.postgres.sql should be reloadable
Julien Cristau <julien.cristau@logilab.fr> [Tue, 21 Apr 2015 17:12:36 +0200] rev 10326
[mail] include Date header in generated mails (closes #5271058)
Mails without Date gets flagged as spam. Plus it's wrong anyway.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 02 Apr 2015 10:41:53 +0200] rev 10325
[doc] mention datadir-url configuration option in release notes
Related to #5204550
Julien Cristau <julien.cristau@logilab.fr> [Wed, 22 Apr 2015 12:26:44 +0200] rev 10324
[web] add test for datadir-url option (related to #5204550)
Julien Cristau <julien.cristau@logilab.fr> [Wed, 01 Apr 2015 15:50:59 +0200] rev 10323
[web] Add datadir-url configuration option (closes #5204550)
Makes it possible to use a different host for static data instead of ${base_url}/data
Julien Cristau <julien.cristau@logilab.fr> [Tue, 31 Mar 2015 10:22:05 +0200] rev 10322
[web] kill https-deny-anonymous option (closes #5193687)
It doesn't make much sense to prevent people from using https.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 29 Jan 2015 10:54:41 +0100] rev 10321
[cwctl] don't filter DeprecationWarnings
Julien Cristau <julien.cristau@logilab.fr> [Wed, 28 Jan 2015 15:53:41 +0100] rev 10320
[exceptions] avoid calling UniqueExceptionError.rtypes after closing the session
Rémi Cardona <remi.cardona@logilab.fr> [Wed, 22 Apr 2015 12:05:09 +0200] rev 10319
[web/test] Fix broken tests after commit b81adb5e32f9
Add missing n3rdf view to RDF view list.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 11 Jun 2014 15:33:09 +0200] rev 10318
[web/test] don't delete uicache directory
Other tests use it, so the rmtree was a bit too much. Set CACHEDIR to a
temporary subdirectory, and only delete that.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 20 Feb 2015 16:17:51 +0100] rev 10317
[web/views] add text/n3 rdf view
Less shit than xml.
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Fri, 31 Oct 2014 17:17:26 +0100] rev 10316
[schemas] make CWEType.final default to False (closes #5049201)
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Apr 2014 14:49:18 +0200] rev 10315
[repository] replace session with cnx in a few places
Julien Cristau <julien.cristau@logilab.fr> [Mon, 01 Dec 2014 16:50:41 +0100] rev 10314
Don't pass an encoding to rqlst.as_string()
Rémi Cardona <remi.cardona@free.fr> [Sun, 27 Jul 2014 14:57:51 +0200] rev 10313
[rset] Deprecate the 'encoded' argument to ResultSet.printable_rql()
It's hardly used at all, and when used inside CubicWeb, it's only set as
false. Better make sure that this function always returns a proper
unicode string and let the caller handle conversion on its own.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 22 Apr 2015 09:52:28 +0200] rev 10312
[gcdebug] ignore _NeedAuthAccessMock instances
When looping over gc.get_objects(), we'd crash in
_NeedAuthAccessMock.__getattribute__.
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 10 Feb 2015 14:38:25 +0100] rev 10311
[views] Fix 'gc' view to use 'repo_gc_stats' service
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 10 Feb 2015 14:37:51 +0100] rev 10310
[services] Fix 'repo_gc_stats' to return a list of unreachable objects' repr
David Douard <david.douard@logilab.fr> [Tue, 10 Feb 2015 12:18:38 +0100] rev 10309
[services] Prevent 'repo_stats' service from aggregating information
It's up to the consumer of the service to decide whether it wants
aggregated data or not... Ensure the /siteinfo page rendering is not
modified.
David Douard <david.douard@logilab.fr> [Wed, 22 Apr 2015 11:00:50 +0200] rev 10308
[hooks] add a looping task that dumps the stats regularly in a file
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 23 Feb 2015 09:02:41 +0100] rev 10307
[web/facet] Use an Exists node in HasRelationFacet
The generated RQL now includes an EXISTS clause. For instance, one gets:
::
DISTINCT Any WHERE X is CWUser, EXISTS(X in_group A)
instead of:
::
DISTINCT Any WHERE X is CWUser, X in_group A
for a HasRelationFacet with ``rtype = 'in_group'``, which is more appropriate
for testing the existence of the relation.
Add a test for this facet along the way.
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 01 Apr 2015 13:39:30 +0200] rev 10306
[debian] Add a Breaks for cubicweb-folder which stills use GMTOFFSET
Related to #2154655.