Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 15 Apr 2016 10:20:34 +0200] rev 11290
[entity] Make it possible to specify sorting terms in cw_related_rqlst method
Closes #12306543.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 16 Jun 2016 17:45:16 +0200] rev 11289
[sql gen] Properly create UNIQUE index on non string column. Closes #13728492
Unique was previously detected in a loop triggered only for String columns.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 17 Jun 2016 14:44:59 +0200] rev 11288
[server] some pep8 changes
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 16 Jun 2016 17:35:39 +0200] rev 11287
pep8 schema2sql
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 02 Jun 2016 17:52:43 +0200] rev 11286
[migration] Drop custom "readfunc" for code.interact in shell
As the referenced bug http://bugs.python.org/issue1288615 got fixed in Python
2.6, this is no longer needed. Furthermore the implementation is not Python 3
compatible (raw_input, unicode).
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 02 Jun 2016 09:41:24 +0200] rev 11285
[tox] Put development dependencies into a dev-requirements.txt file
The latter being sourced in tox.ini.
For now this contains references to hg repositories for some dependencies but
under normal circumstances it should only contain pytest.
This is useful when developping cubicweb itself without using tox but working
with a virtualenv so that one can simply do:
::
$ virtualenv --system-site-packages venv
$ . venv/bin/activate
$ pip install -r dev-requirements.txt
$ python setup.py develop
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 02 Jun 2016 10:27:34 +0200] rev 11284
[py3k] Fix config-level comparison in "cubicweb-ctl create" command
dict.get -> None, and None cannot compare to an int in Python 3.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 06 Jun 2016 09:19:38 +0200] rev 11283
[pkg] PEP8 fixes in __pkginfo__.py
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 06 Jun 2016 09:17:06 +0200] rev 11282
[pkg] Drop "support" of unused subpackage_of option in setup.py
__pkginfo__ does not declare subpackage_of.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 16 Jun 2016 17:09:11 +0200] rev 11281
Add missing import, eaten by previous merge
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 01 Jun 2016 17:05:16 +0200] rev 11280
Only access once to _cw.message in the login form
else the first access may pop the message and the second won't get anything to
display. This works on default message implementation but doesn't on the
pyramid's one, leading to no message displayed on erroneous authentication
attempt, which is not very user friendly.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 16 Jun 2016 15:53:01 +0200] rev 11279
backport 3.22 changes
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 16 Jun 2016 14:19:20 +0200] rev 11278
backport changes from 3.21
Alexandre Richardson <alexandre.richardson@logilab.fr> [Fri, 10 Jun 2016 16:45:20 +0200] rev 11277
[server,bfss] fix bfss migration test for python 3 (related #13519541)
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 10 Jun 2016 13:23:54 +0200] rev 11276
[pkg] Use io.open with utf-8 encoding to read long description from README
This forces decoding so that this is consistent between Python 2 and 3 as, in
Python 3, decoding which would occur anyways and may fail depending on the
environment locale settings.
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Wed, 04 May 2016 23:52:36 +0200] rev 11275
[dataimport] order of ExtEntities should be irrelevant (closes #13117472)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 01 Jun 2016 15:36:18 +0200] rev 11274
Test and fix "pickleability" of Binary objects
which has been recently broken while some cubes rely on this (eg fastimport).
Do some licensing/pep8 cleanup along the way.
Closes #13385274
Alexandre Richardson <alexandre.richardson@logilab.fr> [Tue, 07 Jun 2016 10:05:30 +0200] rev 11273
[server,bfss] fix storage migration when Bytes attributes is None (closes #13519541)
When a Bytes attributes is None before the BFSS storage migration,
the migration crashes. A Bytes attribute can be None, when the attribute
is not required and there is no default value. In this case, the attributes
should remained None after migration and no file is stored on the disk.
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 25 May 2016 09:51:51 +0200] rev 11272
Let hg Ignore py.test's .cache directory
And drop rule for .svn along the way.
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 15 Apr 2016 08:59:53 +0200] rev 11271
[entity] Add a cw_related_rqlst method returning the RQL select node of cw_related method
This is useful if one wants to modify the query before execution.
A bit a PEP8 style fix in tests along the way.
Related to #12306543.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 May 2016 17:05:39 +0200] rev 11270
[devtools] set .config in setUpClass instead of using a cache in a classproperty
This is much clearer and avoid problem with py.test introspection that triggered
creation and caching of the configuration before actual test execution. This
caused pb in unittest_postgres.PostgresStatementTimeoutTC where configuration
was built before module's setup, hence source configuration was missing
information about where to find the pg cluster.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 May 2016 12:01:42 +0200] rev 11269
[devtools] Simplify test configuration's init
Specify module's __file__ instead of apphome. __file__ is saved on the class as
it will be used later (eg to find the proper pg cluster without relying on
shared dictionnary modifications).
This will require some tests update, but it should be less common in cubes than
in cubicweb itself.
Rémi Cardona <remi.cardona@logilab.fr> [Thu, 11 Sep 2014 14:22:02 +0200] rev 11268
[web] Have the LoginController return 403 on failed auth (closes #11569950)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 May 2016 11:32:23 +0200] rev 11267
[devtools] Drop old init_test_database backward compat
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 May 2016 14:43:19 +0200] rev 11266
[devtools] show DeprecationWarning during test execution
They are not shown by default since python 2.7
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 May 2016 11:09:46 +0200] rev 11265
[devtools] deprecate usage of sources file for test
This is old support which clutters the code and should no more be used.
As this is rarely used (if it is) and test only, it feels ok to drop support at
once without a deprecation phase.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 May 2016 13:07:21 +0200] rev 11264
[devtools] Set dumb value for postgres's db-host to avoid unexpected connection to a local server
Currently, if something goes wrong (eg config built before call to
startpgcluster) while a pg server is running on localhost, it may connect to
this server and run the test in there unexepectedly.
David Douard <david.douard@logilab.fr> [Wed, 25 May 2016 17:19:14 +0200] rev 11263
[ldapfeed] ldap3 do not raise an exception in case of failure of cnx.bind()
but return 'False' instead.
David Douard <david.douard@logilab.fr> [Wed, 25 May 2016 17:43:53 +0200] rev 11262
[test] add a test to ensure we get an AuthenticationError with ldapfeed
when using (correct login, wrong password) credentials
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 22 Apr 2016 16:16:09 +0200] rev 11261
[entity] Exclude computed relations from Entity.copy_relations
Closes #12481591.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 19 May 2016 10:51:33 +0200] rev 11260
[pkg] Set version to 3.22.2.dev0
So that cubes used in test dependencies do not install a released CubicWeb.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 20 May 2016 12:05:29 +0200] rev 11259
[devtools] pep8 a bit package's __init__
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 19 May 2016 17:57:43 +0200] rev 11258
[test/server] Only use configcls with statement timeout when needed
Other tests in PostgresFTITC class apparently do not make use of this
particular configuration.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 19 May 2016 17:55:26 +0200] rev 11257
[server/test] Add an assertion in test_statement_timeout
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 01 Jul 2015 08:58:39 +0200] rev 11256
[datafeed] minor cleanups to cwxml parser
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 23 Sep 2015 10:59:56 +0200] rev 11255
[datafeed] don't allow arbitrary kwargs on DatafeedParser initializer
else they will be handled nicely by appobject base class, while we rather want an
error in the case of a source parser (arguable).
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 01 Jul 2015 08:53:29 +0200] rev 11254
[datafeed] gives information about moved entities to the parser
Also, don't support anymore arbitrary parameters at parser initialization.
Related to #5414754
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 01 Jul 2015 08:45:29 +0200] rev 11253
[datafeed] simplify SQL query used to retrieve information about entities from an external source
no need to join on cw_source
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 01 Jul 2015 08:42:44 +0200] rev 11252
[datafeed] rename parser.sourceuris to source_uris
Its more readable. Also, uniformize related method and local identifier names.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 30 Jun 2015 10:05:46 +0200] rev 11251
[datafeed] move process_urls to the parser
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 14 Jan 2016 17:14:16 +0100] rev 11250
[tox] Use py.test to run tests
In unittest_rqlrewrite.py and repotest.py, rename utility functions so that
they are not considered as "test functions" by py.test.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 19 May 2016 14:21:21 +0200] rev 11249
[test] Fix devtools unittest_i18n when ran without pytest
There is currently some weird error, requiring both to hack cubicweb.__path__
and to stop using load_module_from_name to load the registry.
Introduce a dependency on to-be-released version of logilab common integrating
fix for https://www.logilab.org/ticket/6085650
Do some extra import cleanups along the way.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 05 Feb 2016 14:48:23 +0100] rev 11248
[server] explicitly set postgres LC_MESSAGES variable to C on connection
We parse some error messages so we need them to be in English. It's not
clear to me exactly when that's not the case, but this fixes running
unittest_postgres' "test_constraint_validationerror" with py.test for
Sylvain.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 19 Mar 2015 21:19:52 +0100] rev 11247
[web] cleanup xmlrss view
Don't trigger exceptions unnecessarily, and add line breaks to the
output.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Feb 2016 14:01:35 +0100] rev 11246
[migration] add rollback when replace_eid_sequence_with_eid_numrange fails
If we get here, the current transaction is aborted, so if we are to
assume everything is fine and continue we need to rollback first.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Feb 2016 14:03:56 +0100] rev 11245
[migration] move CWComputedRType later
The ordering in this file is a mess, and things don't actually work this
way (when upgrading from 3.17).
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 19 May 2016 09:18:56 +0200] rev 11244
docstring fix
David Douard <david.douard@logilab.fr> [Tue, 12 Apr 2016 10:35:06 +0200] rev 11243
[cwctl] make cwctl not depends on cubicweb.wsgi (closes #12210063)
cubicweb.wsgi may not be available at all on Debian.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 07 Oct 2015 18:24:49 +0200] rev 11242
[hooks/workflow] pass eids, not entities, from hooks to operations
Passing entity objects around runs the risk of getting out of date data
from caches.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Mar 2016 14:53:33 +0100] rev 11241
[web/httpcache] fix Last-Modified generation
time.mktime takes a time tuple in *local* time. We have an UTC datetime coming
from the last_modified method, which we were interpreting as local time,
leading to hilarity. Use calendar.timegm instead.
Add tests for Last-Modified generation of the 'download' and 'manage'
views.
Florent Cayré <florent.cayre@logilab.fr> [Wed, 04 May 2016 17:07:41 +0200] rev 11240
[forms] Fix edition of TZDatetime attributes
Parse the submitted web form values into a timezone-aware datetime
(by default, UTC) when such an attribute is edited. This is done using
an automatically-selected (by `web.formfield.guess_field`) field named
`TZDatetimeField`.
Closes #12666598.
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Mon, 02 May 2016 17:14:43 +0200] rev 11239
[doc] fix abstract and example of data import
Nicolas Chauvat <nicolas.chauvat@logilab.fr> [Sun, 01 May 2016 22:00:14 +0200] rev 11238
[doc] fix abstract of data import
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 29 Apr 2016 12:39:08 +0200] rev 11237
[repository] drop remanescence of old multi-sources code
we don't use anymore this inputmap/varmap thing.
David Douard <david.douard@logilab.fr> [Mon, 09 May 2016 17:24:03 +0200] rev 11236
Added tag 3.20.15, debian/3.20.15-1, centos/3.20.15-1 for changeset 636a83e65870
David Douard <david.douard@logilab.fr> [Mon, 09 May 2016 17:05:14 +0200] rev 11235
[pkg] 3.20.15
David Douard <david.douard@logilab.fr> [Wed, 20 Apr 2016 14:43:48 +0200] rev 11234
[views] do not eat the self._cw.message in LogFormView (closes #12421177)
accessing self._cw.message now(?) eat the message, so don't call
"self._cw.message" twice.
David Douard <david.douard@logilab.fr> [Tue, 19 Apr 2016 13:57:12 +0200] rev 11233
[server] make InternalManager.name() return an empty string (closes #12418708)
Otherwise the notification emails sent via an internal_session never honor the
EMAIL.sender-name configuration option.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 21 Mar 2016 17:10:08 +0100] rev 11232
[test/migractions] work around drop_cube not deleting final etypes
Closes #10096736
Julien Cristau <julien.cristau@logilab.fr> [Mon, 21 Mar 2016 17:09:41 +0100] rev 11231
[hooks] deleting a final entity type shouldn't try dropping an sql table
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 05 Apr 2016 09:10:17 +0200] rev 11230
[tox] Use a revision on proper branch for Yams
"default" is not good when some bug fix release suddenly comes out...
Julien Cristau <julien.cristau@logilab.fr> [Tue, 29 Mar 2016 14:35:28 +0200] rev 11229
[webconfig] disable generate-staticdir by default
Its side effects mean it can be inconvenient, and using it requires
manual (web server) config changes anyway, so there's no reason it needs
to be enabled by default.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 21 Mar 2016 15:24:17 +0100] rev 11228
[test] Skip test_deserialization_base (unittest_repository.SchemaDeserialTC)
See ticket #10096736.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 29 Mar 2016 17:00:13 +0200] rev 11227
[devtools] drop unused DumbOrderedDict2 class
Julien Cristau <julien.cristau@logilab.fr> [Tue, 29 Mar 2016 16:56:59 +0200] rev 11226
[devtools] fix sorting in ExecutionPlan._check_permissions on python3
Sort lists instead of dict_items objects to get predictable results.
With this change, unittest_querier.UtilsTC.test_preprocess_security
passes every time instead of once in a blue moon. Closes #11759133.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 21 Mar 2016 13:55:29 +0100] rev 11225
[test] assertItemsEqual → assertCountEqual in unittest_repository.py
Julien Cristau <julien.cristau@logilab.fr> [Thu, 24 Mar 2016 09:43:25 +0100] rev 11224
merge 3.20.14 in 3.21 branch
Julien Cristau <julien.cristau@logilab.fr> [Mon, 21 Mar 2016 18:08:47 +0100] rev 11223
Added tag 3.20.14, debian/3.20.14-1, centos/3.20.14-1 for changeset f66a4895759e
Julien Cristau <julien.cristau@logilab.fr> [Mon, 21 Mar 2016 17:59:40 +0100] rev 11222
[pkg] 3.20.14
Julien Cristau <julien.cristau@logilab.fr> [Mon, 21 Mar 2016 10:53:44 +0100] rev 11221
[tox] use master URL for yams repository
No need to clone from review. This should help get consistent results.
Laura Médioni <laura.medioni@logilab.fr> [Tue, 19 Jan 2016 16:11:16 +0100] rev 11220
[pylint] Avoid invalid-name on schema relation class names
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 20 Jan 2016 08:26:30 +0100] rev 11219
[pylint] more work on the pylint support
* uniformize usage of ClassDef and simplify related import
* don't insert in the ast a python function but an astroid representation of that function
* ignore __pkginfo__ file
* drop attr-rgx, variable-rgx and argument-rgx, put the name in good-names instead
* drop additional-builtins
* add cell_call to the list of methods for which we don't want 'abstract-method'
Laura Médioni <laura.medioni@logilab.fr> [Tue, 19 Jan 2016 14:07:59 +0100] rev 11218
[pylint] remove abstract-method warning
This kind of message is targeted:
"Method 'entity_call' is abstract in class 'EntityView' but is not overridden (abstract-method)"
For now, only "entity_call" and "render_body" are dealt with, the list can be extended.
Laura Médioni <laura.medioni@logilab.fr> [Tue, 19 Jan 2016 11:43:52 +0100] rev 11217
[pylint] upgrade pylintext plugin
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 19 Jan 2016 13:24:44 +0100] rev 11216
update and enhance pylintrc
Julien Cristau <julien.cristau@logilab.fr> [Wed, 16 Mar 2016 11:56:32 +0100] rev 11215
[schema] use json to serialize constraints
Require yams 0.43: constraints are serialized to json, which means we
need to recreate the actual checks in the database on upgrade.
Temporary deps in tox.ini to pull respective changes in yams.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 16 Mar 2016 17:59:10 +0100] rev 11214
[pkg] fix cubicweb.spec syntax
(grafted from 3309ddb970594cd54529f5c205d1ea5b5da4131e)
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 16 Mar 2016 10:06:18 +0100] rev 11213
[pkg] Use Twisted < 16.0.0
We have some test failures with 16.0.0, such as:
- test_put_content (unittest_server.ETwistHTTPTC)
- test_base_url (unittest_httptest.TwistedCWAnonTC)
(grafted from 10c12f31d0fe38c2e8814176fc42bf2ea210efdf)
Julien Cristau <julien.cristau@logilab.fr> [Wed, 16 Mar 2016 17:59:10 +0100] rev 11212
[pkg] fix cubicweb.spec syntax
Julien Cristau <julien.cristau@logilab.fr> [Wed, 16 Mar 2016 15:55:56 +0100] rev 11211
[cwconfig] Use imp.load_source instead of exec() to load site_cubicweb.py from apphome
Lets us return a module object and go back to the previous code in
CubicWebConfiguration._load_site_cubicweb.
Rémi Cardona <remi.cardona@logilab.fr> [Tue, 15 Mar 2016 11:24:51 +0100] rev 11210
[cwconfig] Stop using lgc.modutils to load *config.py and *ctl.py files
Rémi Cardona <remi.cardona@logilab.fr>, Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 16 Mar 2016 13:53:03 +0100] rev 11209
[cwconfig] Stop using lgc.modutils to load site_cubicweb.py files
config.load_site_cubicweb function now takes a list of cubes (instead of
paths) and default to all known cubes.
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 16 Mar 2016 11:31:40 +0100] rev 11208
[test] Use a Popen in i18n tests
Instead of check_call, so that we clearly see the failure.
A bit of flake8 along the way.
Vladimir Popescu <vladimir.popescu@logilab.fr> [Tue, 06 May 2014 17:45:37 +0200] rev 11207
[forms] Fix HTableFormRenderer _render_fields method behavior when display_label is False.
Indeed, now the extra <tr><th>...</th></tr> are not inserted anymore unless
display_label is True.
Closes #3811325.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 17 Mar 2015 15:21:29 +0100] rev 11206
[connection] remove a dead counter
Related to #1381328.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 16 Jul 2014 17:34:21 +0200] rev 11205
[session] drop .is_repo_in_memory
This is deader than a dead dog's bone buried down a blind alley off a
dead-end street in a ghost town.
Related to #1381328.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 16 Mar 2016 11:39:24 +0100] rev 11204
[session] drop session-as-a-context-manager
It made little sense in the 3.19 - session-as-cnx-bw-compat era, maybe.
Related to #1381328.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 18:37:29 +0200] rev 11203
[devtools/repotest] use the RepoAccess object
Quite better than playing tricks with the Repo._sessions.
Related to #1381328.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Tue, 01 Jul 2014 18:25:20 +0200] rev 11202
[devtools] adapt stresstester to current APIs
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 16 Mar 2016 12:11:18 +0100] rev 11201
[session] retire session.vreg
Related to #1381328.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 16 Jul 2014 16:26:16 +0200] rev 11200
[session] fix super call in Connection.__init__
The vile hacks in test fixtures are fixed.
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 16 Jul 2014 15:30:16 +0200] rev 11199
[session,repo] remove last trace of "cnxprops"
Related to #1381328.
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 16 Mar 2016 10:06:18 +0100] rev 11198
[pkg] Use Twisted < 16.0.0
We have some test failures with 16.0.0, such as:
- test_put_content (unittest_server.ETwistHTTPTC)
- test_base_url (unittest_httptest.TwistedCWAnonTC)
Julien Cristau <julien.cristau@logilab.fr> [Tue, 15 Mar 2016 16:58:50 +0100] rev 11197
[web/views] stop using cwaction='cancel'
It's broken as of https://hg.logilab.org/master/cubicweb/rev/cb217b2b3
Julien Cristau <julien.cristau@logilab.fr> [Wed, 16 Mar 2016 00:42:40 +0100] rev 11196
[test] fix test_printable_value_bytes with current pygments
An empty span was added in
https://bitbucket.org/birkenfeld/pygments-main/commits/164574c13533195a555181a2b9c685fea2470403
Aurelien Campeas <aurelien.campeas@logilab.fr> [Thu, 12 Jun 2014 15:54:44 +0200] rev 11195
[session, repository] deprecate repo.connect and move .close reponsibility to session object
Repository.new_session just returns a plain session object, and
`.connect` (which returns a sessionid) is deprecated.
For .close::
session.close() # done !
The session will bear the responsibility to call the "session_close"
event but that's better than the previous idiom::
repo.close(session.sessionid)
which involves both objects.
Related to #1381328.
Related to #2919309.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Mar 2016 14:11:47 +0100] rev 11194
[web/test] fix typo in doc string
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Mar 2016 19:00:09 +0100] rev 11193
[web/httpcache] send weak ETags
There's no way we can provide a strong validator in general (especially
considering how ETags are generated by the current EtagHTTPCacheManager
and EntityHTTPCacheManager). So mark our entity-tags as weak.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 04 Mar 2016 12:17:58 +0100] rev 11192
[server] print backend exception if we fail to execute an sql script
It's more useful to see
could not open extension control file "/usr/share/postgresql/9.4/extension/postgis.control": No such file or directory
rather than merely
-> ERROR, skipping /usr/share/cubicweb/cubes/postgis/schema/_ext.postgres.sql
Julien Cristau <julien.cristau@logilab.fr> [Tue, 15 Mar 2016 14:59:24 +0100] rev 11191
[cwctl] drop unnecessary admincnx call from 'shell'
The connection is done by the migration helper.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Mar 2016 17:51:30 +0100] rev 11190
[serverctl] allow schema-diff when db and fs are not in sync
Aurelien Campeas <aurelien.campeas@logilab.fr> [Wed, 09 Jul 2014 16:33:08 +0200] rev 11189
[cwctl] remove networked remote shell
This was a dbapi leftover.
Related to #3933480.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 15 Mar 2016 14:30:21 +0100] rev 11188
[web/calendar] fix regression in previous changeset
"Enables css customization in CalendarView" was untested, and introduced a crash:
TypeError: not all arguments converted during string formatting
Laura Médioni <laura.medioni@logilab.fr> [Mon, 17 Mar 2014 15:21:47 +0100] rev 11187
Enables css customization in CalendarView
now a custom css class can be set on the calendar div (closes #3654043).
Alexandre Richardson <alexandre.richardson@logilab.fr> [Thu, 17 Sep 2015 12:47:39 +0200] rev 11186
refactor a bit breadcrumbs to ease overriding of the root's display
Julien Cristau <julien.cristau@logilab.fr> [Wed, 14 Jan 2015 13:35:22 +0100] rev 11185
Add migration helper function to delete entity types faster
Bypasses all hooks and (for now) ignores any composite relations.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 14 Mar 2016 15:38:03 +0100] rev 11184
[testlib] Import nocoverage from logilab.common.testlib
This depends on a change in logilab-common 1.2.0
Julien Cristau <julien.cristau@logilab.fr> [Mon, 14 Mar 2016 21:28:44 +0100] rev 11183
[web/test] replace unicode with six.text_type
Some uses of unicode reappeared when merging changes from 3.19.14.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 18 Feb 2016 10:23:05 +0100] rev 11182
[devtools/testlib] Issue a RuntimeError when a generative tests is detected
Otherwise, generative tests *à la logilab-common* in CubicWebTC test cases
would silently not run (at least using logilab.common.pytest runner).
Julien Cristau <julien.cristau@logilab.fr> [Thu, 18 Feb 2016 09:30:58 +0100] rev 11181
[devtools] stop using lgc.testlib.TestCase
It's become incompatible with unittest(2).TestCase due to generative
tests. Just keep the datadir/datapath and assertCountEqual bits in our
BaseTestCase.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 03 Mar 2016 10:25:32 +0100] rev 11180
[test] Replace remaining generative tests by subtests
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 14 Mar 2016 18:15:09 +0100] rev 11179
[tox] Enable all applicable py34 environments
All except etwist.
Comes with a few tricks in tox.ini:
* add ``-e.`` to force installing of cubicweb in development because
dependency cubes would otherwise install cubicweb 3.22 (the latest release),
which is not python3 installable.
* "install" cubes/__init__.py because the file is not installed in
develop mode; maybe this file should be managed by cubes themselves...
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Mar 2016 17:01:42 +0100] rev 11178
[migration/3.10] fix AttributeError
'Connection' object has no attribute 'HOOKS_DENY_ALL'
Julien Cristau <julien.cristau@logilab.fr> [Mon, 07 Mar 2016 17:53:20 +0100] rev 11177
[server/sources] Fix authenticate on pre-3.10 database
When migrating from a pre-3.10 database, the CWSource entity type and
cw_source relation type are not known, but authenticate should still
work to be able to add them.
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 29 Jan 2016 17:11:17 +0100] rev 11176
[test] Add a test ensuring new cube built from skeleton is flake8-compliant
And make skeleton files actually flake8-compliant henceforth.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 25 Jan 2016 08:28:16 +0100] rev 11175
[skeleton] Ship a tox.ini file upon new cube
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Mar 2016 13:47:20 +0100] rev 11174
[web] fix headers on 304 responses (closes #11466875)
The response MUST include the following header fields:
[...]
- ETag and/or Content-Location, if the header would have been sent
in a 200 response to the same request
https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.3.5
Unfortunately we weren't copying headers from what would have been the
200 response, but from the request.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 09 Mar 2016 18:01:44 +0100] rev 11173
[web/httpcache] GMTOFFSET no longer exists
Julien Cristau <julien.cristau@logilab.fr> [Thu, 10 Mar 2016 13:47:20 +0100] rev 11172
[web] fix headers on 304 responses (closes #11466875)
The response MUST include the following header fields:
[...]
- ETag and/or Content-Location, if the header would have been sent
in a 200 response to the same request
https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.3.5
Unfortunately we weren't copying headers from what would have been the
200 response, but from the request.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 29 Feb 2016 12:32:52 +0100] rev 11171
[rset] fix infinite recursion introduced in c1eb5a676c80
The mechanism to avoid loops in c1eb5a676c80 "[rset] Always complete
attribute/relation caches in ResultSet.get_entity" breaks down: we would
loop forever if two entities that were already in the cache were linked
by a relation with ? or 1 cardinality in both directions. To avoid
that, keep a set of already-considered columns. Related to #9942503.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 17 Feb 2016 10:02:03 +0100] rev 11170
pep8 unittest_application and unittest_formfields
Alexandre Richardson <alexandre.richardson@logilab.fr> [Tue, 12 Jan 2016 14:31:14 +0100] rev 11169
[rset] Always complete attribute/relation caches in ResultSet.get_entity
RQL queries are often designed to fill up the ORM's caches when fetching
entities out of the result set. Until now, if an entry already existed
in the entity cache, ResultSet.get_entity would return it unchanged,
not using the new ResultSet's contents to update the attribute cache,
breaking expectations (if the attributes are needed, they'd then be
fetched later one at a time, one entity at a time), resulting in loads
of DB accesses.
So we change ResultSet.get_entity so that:
* if the entity is already cached and has been instantiated from the
same rset, it is returned as-is (to avoid loops)
* if the entity is not yet cached, it is instantiated
* if the entity is cached via another rset, its attribute/relation
caches are completed
Closes #9942503
Alexandre Richardson <alexandre.richardson@logilab.fr> [Tue, 12 Jan 2016 17:36:28 +0100] rev 11168
[rset] refactoring of _build_entity method
define a method for entity instantiation and storage in cache
(related to #9942503)
Julien Cristau <julien.cristau@logilab.fr> [Thu, 25 Feb 2016 09:28:21 +0100] rev 11167
[entity] comparing two entities returns NotImplemented
Fixes a test when using some versions of unittest2, where
assertItemsEqual tries a sort and expects TypeError, which it doesn't
get if we directly raise NotImplementedError. The NotImplemented value
is treated specially by the interpreter:
https://docs.python.org/3.4/library/constants.html#NotImplemented
Julien Cristau <julien.cristau@logilab.fr> [Thu, 18 Feb 2016 09:24:43 +0100] rev 11166
[test] replace one use of lgc.testlib.unittest_main with unittest.main
Julien Cristau <julien.cristau@logilab.fr> [Thu, 18 Feb 2016 09:23:18 +0100] rev 11165
[test] stop using TestCase.set_description
It's a lgc-ism.
Julien Cristau <julien.cristau@logilab.fr> [Thu, 18 Feb 2016 09:20:57 +0100] rev 11164
[test] convert a lgc-style generative test into unittest2-style
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 16:10:22 +0100] rev 11163
[web/application] fix query log handling on python3
Writing bytes to a file opened in text mode doesn't work.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 16:32:36 +0100] rev 11162
[devtools/test] duplicate CubicWebServerTC tests for CubicWebWsgiTC
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 16:32:07 +0100] rev 11161
[devtools/test] fix bytes vs text in test_base_url
Needed for python3 with the next changeset
Julien Cristau <julien.cristau@logilab.fr> [Wed, 24 Feb 2016 17:34:56 +0100] rev 11160
[devtools] skip CubicWebServerTC on python3
People should migrate to wsgi if they're going to use CubicWeb on
python3.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 16:10:51 +0100] rev 11159
[web/test] switch unittest_web from twisted to wsgi
And make it pass on python3 while at it.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 24 Feb 2016 17:31:56 +0100] rev 11158
[devtools] add CubicWebWsgiTC
Similar to CubicWebServerTC, except using wsgiref instead of twisted as
an http server.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 15:37:52 +0100] rev 11157
[web/test] return the hash of uploaded files in FileUploadTC instead of their contents
json must be unicode, which doesn't go well with arbitrary file
contents. Compute the file hash instead, as we know the hexdigest is
(ascii) text.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 15:29:06 +0100] rev 11156
[web/test] open() as a context manager
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 15:28:14 +0100] rev 11155
[web/test] json.loads expects text, not bytes
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 16:39:51 +0100] rev 11154
[wsgi] fix handling of multiple posted files
We were only keeping the last received file.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 05 Feb 2016 18:23:00 +0100] rev 11153
[web/test] Reword doc string for fileupload ajaxfunc
David Douard <david.douard@logilab.fr> [Tue, 03 Mar 2015 12:26:47 +0100] rev 11152
[skeleton] do not import the __pkginfo__.py module to make cubes installable via setuptools
When using a simple "import" statement, running 'python setup.py install' for
a cube fails in a fresh virtualenv due to the fact the install of the
dependencies (here cubicweb iteself) is done by the python process doing the
cube's installation, so the __pkginfo__ module from the cube is already
loaded (thus used) when installing cubicweb...
So we apply the third technique from:
https://packaging.python.org/en/latest/single_source_version.html
Julien Cristau <julien.cristau@logilab.fr> [Tue, 23 Feb 2016 12:18:47 +0100] rev 11151
merge changes from 3.22.2
Julien Cristau <julien.cristau@logilab.fr> [Tue, 23 Feb 2016 12:09:01 +0100] rev 11150
Added tag 3.22.2, debian/3.22.2-1, centos/3.22.2-1 for changeset 1b93ff37755b
Julien Cristau <julien.cristau@logilab.fr> [Tue, 23 Feb 2016 11:45:54 +0100] rev 11149
[pkg] 3.22.2
Samuel Trégouët <samuel.tregouet@logilab.fr> [Fri, 19 Feb 2016 11:23:11 +0100] rev 11148
[pkg] fix centos install
David Douard <david.douard@logilab.fr> [Fri, 19 Feb 2016 11:03:32 +0100] rev 11147
[datafeed] do NOT call commit in DataFeedXMLParser.process() (closes #10928592)
and so, remove more useless code.
Doing a commit in DataFeedXMLParser.process() is a bad idea because this method
is called for every imported/updated entity, before handling deletions. So if
we commit here, odds are quite high that we're violating some integrity
constraint and end up with a ValidationError.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Feb 2016 14:00:39 +0100] rev 11146
[schema] restore constraint checking when running on old sqlite
Old sqlite3 doesn't provide CHECK constraint names in error messages,
preventing us from translating a backend integrity error into a
ValidationError. This was added in 2012, but the sqlite3 version in
RHEL6 is older; so if we run on old sqlite, keep checking the
constraints in python rather than only in SQL.
Closes #10927494
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 17 Feb 2016 17:20:29 +0100] rev 11145
[web/autoform] fix regression introduced by #5758ba784ebd
The changes from cset 5758ba784ebd "[autoform] when building inlined-form view
for a relation, consider related entities intead of other views" lead to
an unexpected 'add new' link on creation of an entity with inlined form for
a relation of cardinality 1. To avoid this, we should consider formviews and not
existing relations when the entity is being created.
Closes #10860258
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 22 Dec 2015 09:23:00 +0100] rev 11144
[tox] Generate test environments for Python 2.7 and 3.4
Test commands for each environment are written down explicitly since I could
not find a way to extract the "package" name (e.g. "hooks") from the
environment name (e.g. "py34-hooks").
For Python 3.4 interpreter, only environments (subpackages) that do not depend
on cubes for their tests are listed since those test dependency cubes are not
yet installable with Python 3.x. etwist is also not included since the Python
3 port is not complete at the moment.
From local testing, py34 tests pass for the following subpackages:
- dataimport
- entities
- ext
- hooks
- wsgi
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 26 Jan 2016 18:04:00 +0100] rev 11143
[notification] avoid using InternalManager when we've got a CWUser
This will avoid potential information leak due to missed security restriction
and is more compatible with legacy code (pb encountered in some client code).
Closes #10294761
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 27 Jan 2016 08:35:51 +0100] rev 11142
[dataimport] rename .time to .now attribute of meta generator
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 18 Feb 2016 14:36:39 +0100] rev 11141
[pkg] Set version to 3.22.2.dev0
So that cubes used in test dependencies do not install a released CubicWeb.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 29 Jan 2016 15:08:34 +0100] rev 11140
[dataimport] cleanup a bit nohook store, mostly protecting some attributes
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 03 Feb 2016 11:13:51 +0100] rev 11139
[dataimport] add a filter function to not fail if some extentity has several values for an attribute of final relation
the function will simply record a warning in the import log and keep a value
randomly.
Notice the function has to be explicitly inserted in the transformation stream.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 03 Feb 2016 11:12:09 +0100] rev 11138
[sources] synchronize source asynchronously when started from the UI
and redirect to the forthcoming import log, for a better user experience (there
is still a lot more to do there though).
Closes #10468967
Julien Cristau <julien.cristau@logilab.fr> [Fri, 19 Feb 2016 12:35:22 +0100] rev 11137
[test] fix unittest_devctl on python3.4
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 21 Jan 2016 09:24:04 +0100] rev 11136
[test] Make sure that newcube command test produces expected files
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 29 Jan 2016 10:04:35 +0100] rev 11135
[server] remove some pre 3.10 compat
Let's assume nobody will try upgrading an instance from pre-3.10
cubicweb to 3.23+. If they do, they're setting themselves up for a lot
of pain anyway.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Feb 2016 10:25:51 +0100] rev 11134
[pkg] use https URLs to pypi.{python.org,debian.net}
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Feb 2016 10:19:14 +0100] rev 11133
[pkg] use https URL for www.cubicweb.org
Julien Cristau <julien.cristau@logilab.fr> [Wed, 17 Feb 2016 10:18:34 +0100] rev 11132
README: use https URLs for docs.cubicweb.org
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 11 Feb 2016 10:03:51 +0100] rev 11131
pep8 bits
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 11 Feb 2016 10:03:31 +0100] rev 11130
[i18n] enhance text formats french translation
Denis Laxalde <denis.laxalde@logilab.fr> [Wed, 17 Feb 2016 13:45:34 +0100] rev 11129
Merge with 3.22 branch
The merge was clean, just dropped cubicweb/web/data/cubicweb.goa.js.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 11 Feb 2016 21:59:49 +0100] rev 11128
[dataimport] update example to use standard importer
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 19:18:37 +0100] rev 11127
merge changes from 3.21.6
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 02 Feb 2016 17:19:13 +0100] rev 11126
flake8 serverctl
Sylvain Thénault <sylvain.thenault@logilab.fr> [Tue, 16 Feb 2016 10:52:00 +0100] rev 11125
c-c source-sync now actually force synchronization
as advertized by its help message. This was because "force" argument wasn't
considered by acquire_synchronization_lock().
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 19:15:48 +0100] rev 11124
Added tag 3.21.6, debian/3.21.6-1, centos/3.21.6-1 for changeset b3cbbb7690b6
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 18:53:27 +0100] rev 11123
[pkg] 3.21.6
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 18:41:40 +0100] rev 11122
merge changes from 3.20.13
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 18:17:35 +0100] rev 11121
Added tag 3.20.13, debian/3.20.13-1, centos/3.20.13-1 for changeset 8c5dabbcd4d9
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 17:54:17 +0100] rev 11120
[pkg] 3.20.13
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 04 Jan 2016 10:43:35 +0100] rev 11119
[pkg] Yams >= 0.42 breaks CubicWeb < 3.21
Closes #9720390.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 17:16:45 +0100] rev 11118
merge changes from 3.19.14
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 14:52:28 +0100] rev 11117
Added tag 3.19.14, debian/3.19.14-1, centos/3.19.14-1 for changeset 72a0f70879ac
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 11:02:04 +0100] rev 11116
[pkg] 3.19.14
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 11:01:09 +0100] rev 11115
[sources/native] remove extra space before colon
This isn't French.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 16 Feb 2016 10:52:38 +0100] rev 11114
[web/views] fix editcontroller regression
unittest_views_basecontrollers.py's
EditControllerTC.test_edit_mandatory_inlined3_object regressed with
changeset dcbb64d3a1d9 because it relied on POSTing nonexisting eids.
This seems like a silly idea, but let's keep the behaviour unchanged.
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 12 Feb 2016 16:13:43 +0100] rev 11113
Added tag 3.22.1, debian/3.22.1-1, centos/3.22.1-1 for changeset d0d86803a804
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 12 Feb 2016 15:31:48 +0100] rev 11112
fix test broken by #012e6c7d02ef
Julien Cristau <julien.cristau@logilab.fr> [Fri, 12 Feb 2016 15:21:21 +0100] rev 11111
[pkg] Attempt to fix rhel6 build
I don't know what I'm doing, but this seems to work.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 12 Feb 2016 15:19:59 +0100] rev 11110
[dataimport/test] fix python2.6 syntax error
Don't use braces for set literals.
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 12 Feb 2016 14:09:38 +0100] rev 11109
Remove unused import in entity.py
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 12 Feb 2016 10:09:13 +0100] rev 11108
[migration] don't ask confirm for those sql queries
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 12 Feb 2016 10:06:03 +0100] rev 11107
quick fix which closes #0673348 - see comment for more info
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 12 Feb 2016 10:39:24 +0100] rev 11106
[migration] test if entity type has been in the deleted in the transaction should protect both clauses
else we may attempt to execute the UPDATE query on a table which has been
deleted.
Closes #10692374
Julien Cristau <julien.cristau@logilab.fr> [Fri, 12 Feb 2016 10:39:14 +0100] rev 11105
[pkg] 3.22.1
David Douard <david.douard@logilab.fr> [Mon, 06 Jul 2015 11:04:42 +0200] rev 11104
[cwctl] remove support for startorder file in /etc/cubicweb.d (closes #5618947)
It's now useless.
Arthur Lutz <arthur.lutz@logilab.fr> [Wed, 10 Feb 2016 14:43:05 +0100] rev 11103
[exceptions] fix string conversion for Unauthorized exception
changeset 3cb87b61b067 changed CubicWebException to define __unicode__
as the main entry point for string conversion, but left Unauthorized's
__str__ definition unchanged, leading to a mismatch. Closes #10646396.
Julien Cristau <julien.cristau@logilab.fr> [Mon, 08 Feb 2016 11:01:46 +0100] rev 11102
Fix Binary on python < 2.7.4 (closes #10593811)
Before the fix for http://bugs.python.org/issue10211 we can't pass a
buffer object to BytesIO, so keep using StringIO in that case. And
because StringIO is an old-style class, we can't use super().
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 11 Feb 2016 22:00:48 +0100] rev 11101
[migration] fix crash on 3.22 upgrade if entity type doesn't exist in fsschema (pending removal)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 04 Feb 2016 12:00:23 +0100] rev 11100
[autoform] when building inlined-form view for a relation, consider related entities intead of other views
by considering previous form-views, we may miss that there exists related
entities but which are not editable.
Closes #10495602
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 29 Jan 2016 17:22:25 +0100] rev 11099
Add a __main__ to cubicweb
This avoids calling cubicweb-ctl relatively in tests and could be useful
in virtualenv.
This is just a copy of bin/cubicweb-ctl file, which should probably be
generated from a setuptools entry points.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 03 Feb 2016 15:12:32 +0100] rev 11098
merge 3.19 heads
Getting an unexpected test error though:
ERROR: test_edit_mandatory_inlined3_object (unittest_views_basecontrollers.EditControllerTC)
Christophe de Vienne <christophe@unlish.com> [Sat, 30 Jan 2016 23:06:18 +0100] rev 11097
[cwvreg] Fix propertyvalues hot updates
When CWProperty instances are touched, the corresponding value gets
updated in vreg['propertyvalues'], but their type was ignored.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 05 Feb 2016 16:49:22 +0100] rev 11096
[pkg] remove useless python >= 3.4 dependency
python is python2 is never >= 3.4.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 05 Feb 2016 16:32:20 +0100] rev 11095
[dataimport/test] fix test failures since 35b29f1eb37a
The index name changed, so we need to follow suit.
Samuel Trégouët <samuel.tregouet@logilab.fr> [Fri, 05 Feb 2016 12:26:28 +0100] rev 11094
[pkg] do not include toplevel directories in rpm (closes #10362119)
Our spec file conflicts with the filesystem package in centos7: we set
permissions to 0755 for /usr/bin and /usr/lib whereas filesystem sets
them to 0555.
So to be compatible with both centos7 and others we simply ignore these
directories.
Julien Cristau <julien.cristau@logilab.fr> [Fri, 05 Feb 2016 10:30:01 +0100] rev 11093
[devtools] fix config.repository signature
Its argument is called 'vreg', not 'x'. Closes #10515113.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 03 Feb 2016 16:23:34 +0100] rev 11092
[predicates] fix paginated_rset when the class has no page_size_property
Fixes test failure introduced by 70733b2dfd2a, which assumed paginated_rset
would only be called on a class with a page_size_property attribute.
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 03 Feb 2016 14:23:17 +0100] rev 11091
[repository] drop usage of no more necessary eschema_eid function
since the previous cset, we are guaranteed that repository's entity schema will
have their eid attribute properly set, so we don't have anymore to check
everytime if some entity schema's .eid attributes is set or not (and retrieve it
if not).
Related to #10450092
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 28 Jan 2016 18:17:30 +0100] rev 11090
[repository] set .eid on eschema when schema is loaded from the filesystem
enforcing the contract that a repository's schema should have .eid attribute of
entity schema set to the eid of the entity used to serialize them in the db.
Before this cset, this was not true during tests or for some c-c commands where
'quick_start' is set (eg db-restore, i18ncube...).
The change in server __init__ makes this assumption true during instance
creation: the serializing code was actually setting eid on schema object, but a
reference to a previously built schema was given instead of the one for the
latest created repository.
Closes #10450092
Sylvain Thénault <sylvain.thenault@logilab.fr> [Fri, 29 Jan 2016 10:06:36 +0100] rev 11089
[dataimport] simplify SQLGenSourceWrapper.add_info
At this point 'CWSource' is a thing (we're not in the middle of a
migration), and source.eid won't be None (we read it from the db)
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 01 Feb 2016 15:10:35 +0100] rev 11088
ensure .tox is blacklisted when recursing on the fs to get some files
among others, avoid crash when using 'c-c i18ncube' on a cube using tox.
Closes #10429317
Sylvain Thénault <sylvain.thenault@logilab.fr> [Wed, 03 Feb 2016 11:12:58 +0100] rev 11087
drop a note about usage of sqls_create_multicol_unique_index and avoid a lgdb warning
Julien Cristau <julien.cristau@logilab.fr> [Thu, 21 Jan 2016 16:08:17 +0100] rev 11086
[devtools] don't auto-populate virtual relations
Denis Laxalde <denis.laxalde@logilab.fr> [Fri, 29 Jan 2016 16:48:58 +0100] rev 11085
[skeleton] Restore verbose output in setup.py
This part of commit fdadf59be612 missing the integration window.
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 01 Dec 2015 16:10:18 +0100] rev 11084
[hooks] Skip modification_date attribute in "notifentityupdated" hook
Depending on the call order of hooks, "modification_date" may come in
entity.cw_edited or not (from "metaattrsupdate" hook usually). It should
however not be considered in the notification context.
Closes #8842064.
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 01 Dec 2015 14:44:55 +0100] rev 11083
[test] Gather tests about mail module
From sobjects/test/unittest_notification.py to test/unittest_mail.py where
other tests for mail.py are already.
Some style fixes along the way.
Julien Cristau <julien.cristau@logilab.fr> [Tue, 05 Jan 2016 10:36:17 +0100] rev 11082
[web/component] guard against invalid page_size form parameter
Same as dff28956f37e, except the almost same code exists in two places
(yay us).
Julien Cristau <julien.cristau@logilab.fr> [Tue, 05 Jan 2016 10:31:29 +0100] rev 11081
[predicates] fix paginated_rset for components that change page_size_property
The predicate and component had better agree on the page size.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 06 Jan 2016 11:47:08 +0100] rev 11080
[devtools] fix get_bounds
Say an attribute has two IntervalBoundConstraints, one with minvalue=0
and the other with maxvalue=10 (not literally, or that could be a single
constraint, but e.g. with references to other attributes). We don't want to
override the minvalue of the former with None just because the latter happens
last in the constraints list.
This doesn't fix the case where two constraints both have a min or a max
value. Meh.
Julien Cristau <julien.cristau@logilab.fr> [Wed, 06 Jan 2016 15:27:59 +0100] rev 11079
[devtools] "fix" boundary condition for autofill
maxvalue in an IntervalBoundConstraint is inclusive. If the min and max
values happened to coincide, we would call random.choice on an empty
list, which it didn't like.
This is still broken in the case of BoundaryConstraint('>', minvalue),
as we assume the minvalue is in the range, but that's something for
another time.
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 19 Jan 2016 16:44:34 +0100] rev 11078
[test] Use stdlib doctest module instead of logilab-common class
The former just works fine now but the later does not play well with py.test.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 14 Jan 2016 17:42:22 +0100] rev 11077
[test] Re-implement generative tests with subtests
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 14 Jan 2016 18:35:07 +0100] rev 11076
[devtools] Re-implement generative tests using subtests
Generative tests as implemented in logilab.common.testib are not compatible
with tests runner other than lgc.pytest and this implementation differs from
the standard library, which has support for subtests_ since Python 3.4. Use
unittest2 to bridge the gap.
Maybe it'd be good to implement this on logilab.common.testlib side at some
point. Let's see how this gets received here first.
.. _subtests: https://docs.python.org/3/library/unittest.html#subtests
Sylvain Thénault <sylvain.thenault@logilab.fr> [Thu, 28 Jan 2016 18:02:49 +0100] rev 11075
cleanups
Samuel Trégouët <samuel.tregouet@logilab.fr> [Tue, 26 Jan 2016 11:49:25 +0100] rev 11074
[pkg] python-tz does not exist in centos should be pytz (closes #10290056)
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 19 Jan 2016 10:03:16 +0100] rev 11073
[test] Skip LDAP tests if any of the underlying programs is not found
Some programs are in ldap-utils or ldapscripts, which may not be installed
despite slapd may.
Follow-up on 282880f81311.
Denis Laxalde <denis.laxalde@logilab.fr> [Mon, 18 Jan 2016 09:23:07 +0100] rev 11072
Handle virtualenv development mode
Looking for VIRTUAL_ENV environment variable as a sign of virtualenv
activation. This at least works for developing CubicWeb itself (not sure yet
about cubes). And it makes `tox --develop` work as well.
Add a test for cwconfig._find_prefix within a virtualenv.
In tox.ini, use `develop option`_ accordingly. This makes tox running
significantly faster since it avoids building and installing the sdist. Aside,
the "develop" install is now performed *after* all test requirements are
processed, which means that the cubicweb package should always be the one from
source -- instead of a released version pulled by a cube through test
dependencies, which may occur in "recreate" step.
.. _`develop option`: <http://tox.readthedocs.org/en/latest/config.html#confval-usedevelop=BOOL
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 14 Jan 2016 18:17:23 +0100] rev 11071
[skeleton] Use os.walk in setup.py for Python3 compatibility
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 14 Jan 2016 18:39:27 +0100] rev 11070
[skeleton] Use unittest.main directly
Instead of lgc.testlib.unittest_main as they are identical.
Denis Laxalde <denis.laxalde@logilab.fr> [Thu, 14 Jan 2016 16:24:01 +0100] rev 11069
[devtools/testlib] Disable pause trace in setUp
Closes #9856028.
Denis Laxalde <denis.laxalde@logilab.fr> [Tue, 12 Jan 2016 19:50:57 +0100] rev 11068
[test] Remove dependency on person cube in devtools package
Julien Cristau <julien.cristau@logilab.fr> [Tue, 26 Jan 2016 11:46:41 +0100] rev 11067
[pkg] add missing python-tz dependency
Florent Cayré <florent.cayre@logilab.fr> [Tue, 26 Jan 2016 14:04:45 +0100] rev 11066
[edit controller] Fix composite entity reparenting when inlined
This implies handling the reparenting case sooner, otherwise the
child entity modifications are cancelled (see 113e9da47afc).
Add a new test to ensure non-regression in all previous tests.
Closes #10291977.
Florent Cayré <florent.cayre@logilab.fr> [Mon, 14 Dec 2015 14:29:22 +0100] rev 11065
[forms] Do not raise errors on composite required relation being deleted
The entity included in the composite will be deleted in such a case, so
the field is not required even when the cardinality is '1' or '+'.
Related to #8529868
Florent Cayré <florent.cayre@logilab.fr> [Mon, 07 Dec 2015 11:58:17 +0100] rev 11064
[edit controller] Cancel RQL queries to be performed on entities to be deleted
Composite relation removal via the EditController trigger an entity
removal. Changes on such a to-be-removed entity must be cancelled as
they may trigger integrity errors before the deletion occurs.
Closes #8529868.
Florent Cayré <florent.cayre@logilab.fr> [Fri, 04 Dec 2015 14:56:20 +0100] rev 11063
[edit controller] fix handling of removal of subentities from an edit form
In CubicWeb 3.18 the semantics of dropping a composite relation were changed.
It had before the effect of deleting the subentities.
Now the edit controller must handle this by itself (it was not adapted then by
mistake).
So if it detects the removal of a composite relation (on the browser side, the
user clicked on the "remove" action), the subentity is now explicitly deleted.
It was chosen not to change the form generation but the EditController:
- to ensure pre-3.18 forms backward compat
- to avoid the introduction of a specific entity-deletion API (RQL is probably
our best API for complex DB operations)
Related to #8529868.
Florent Cayré <florent.cayre@logilab.fr> [Wed, 25 Nov 2015 16:28:41 +0100] rev 11062
remove unused import
Aurelien Campeas <aurelien.campeas@pythonian.fr> [Fri, 20 Nov 2015 12:29:13 +0100] rev 11061
[editcontroller] a slight code reorganisation, in preparation for a fix
* `entity` defined at method entry
* a combined `continue` and a dedent of the next big block
* some vertical white space
Related to #8529868.
Aurelien Campeas <aurelien.campeas@pythonian.fr> [Tue, 20 Oct 2015 16:05:36 +0200] rev 11060
[sources/native] ask permission to continue restoring even if metadata do not match (closes #7771864)
Moreover we try to clarify the message (Expected/Found was never too clear for users).
David Douard <david.douard@logilab.fr> [Mon, 27 Jul 2015 10:00:32 +0200] rev 11059
[views] fix ProcessInformationView: SESSION_MANAGER can be None (closes #5753280)
eg. with pyramid.
(grafted from 6a07c2dc3d85f4de0cf48221607e02c4473e11e4)
Florent Cayré <florent.cayre@logilab.fr> [Wed, 16 Dec 2015 18:08:37 +0100] rev 11058
[web] Move "display all"/ "back to pagination" link generation into the navigation component
This makes the html generation customizable.
Closes #9219057
Denis Laxalde <denis.laxalde@logilab.fr> [Sat, 16 Jan 2016 13:48:51 +0100] rev 11057
Reorganize source tree to have a "cubicweb" top-level package
Basically:
mkdir cubicweb
hg mv *.py -X setup.py cubicweb
hg mv dataimport devtools entities etwist ext hooks i18n misc schemas server skeleton sobjects test web wsgi cubicweb
Other changes:
* adjust path to cubicweb-ctl in devtools tests
* update setup.py to avoid importing __pkginfo__ (exec it instead),
replace os.path.walk by os.walk and prepend `modname` here and there
* update tox.ini to account for new test locations
* update doc/conf.py so that it still finds __pkginfo__.py and CWDIR in
doc/Makefile
Sylvain Thénault <sylvain.thenault@logilab.fr> [Mon, 04 Jan 2016 11:12:30 +0100] rev 11056
clean some remaining dust from goa time
David Douard <david.douard@logilab.fr> [Wed, 06 Jan 2016 08:58:43 +0100] rev 11055
[datafeed] io.BytesIO requires a buffer, not a unicode (closes #9783743)
The URLLibResponseAdapter should probably be refactored (or killed?)
David Douard <david.douard@logilab.fr> [Thu, 07 Jan 2016 12:20:50 +0100] rev 11054
[pkg] rql 0.34 and logilab-database 1.15 break cubicweb 3.21
David Douard <david.douard@logilab.fr> [Thu, 07 Jan 2016 12:20:50 +0100] rev 11053
[pkg] rql 0.34 and logilab-database 1.15 break cubicweb 3.21
Julien Cristau <julien.cristau@logilab.fr> [Mon, 04 Jan 2016 18:40:30 +0100] rev 11052
Added tag 3.22.0, debian/3.22.0-1, centos/3.22.0-1 for changeset de472896fc0a
Julien Cristau <julien.cristau@logilab.fr> [Mon, 04 Jan 2016 17:57:14 +0100] rev 11051
[pkg] 3.22.0