Mercurial
Mercurial
>
pub
>
hg
>
cubicweb
/ graph
summary
|
shortlog
|
changelog
| graph |
tags
|
bookmarks
|
branches
|
files
|
zip
|
gz
|
bz2
|
help
less
more
|
(0)
-3000
-1000
-240
+240
+1000
+3000
tip
Find changesets by keywords (author, files, the commit message), revision number or hash, or
revset expression
.
The revision graph only works with JavaScript-enabled browsers.
fix bad test fix
2010-03-05, by Sylvain Thénault
repair stuff broken by fti handling changes
stable
2010-03-05, by Sylvain Thénault
update test broken by fulltextindexed change on workflow entities
stable
2010-03-05, by Sylvain Thénault
fix another name error
2010-03-05, by Sylvain Thénault
fix name error
2010-03-05, by Sylvain Thénault
backport stable
2010-03-05, by Sylvain Thénault
eschema_type_eid become eschema_eid and always get a schema as argument + misc cleanup
stable
2010-03-05, by Sylvain Thénault
don't issue critical warning about missing text index when we're creating the instance
stable
2010-03-05, by Sylvain Thénault
merge
stable
2010-03-05, by Sylvain Thénault
backport stable
2010-03-04, by Sylvain Thénault
[cleanup] add index_entity to abstract source, add docstring
stable
2010-03-04, by Sylvain Thénault
[fti] refactor and fix full text indexation handling
stable
2010-03-04, by Sylvain Thénault
[schema] do not fulltext index workflow entities'description
stable
2010-03-04, by Sylvain Thénault
no key error subsequent to test module import error
2010-03-04, by Sylvain Thénault
merge
stable
2010-03-04, by Aurelien Campeas
[views/breadcrumbs] fix bad signature
stable
2010-03-04, by Aurelien Campeas
merge
stable
2010-03-04, by Sylvain Thénault
nicer explanation
stable
2010-03-04, by Sylvain Thénault
fix schema serialization bug: groupmap considered as addrdef argument
stable
2010-03-04, by Sylvain Thénault
[cwctl] list will warn about a badly formatted version constraint instead of crashing
stable
2010-03-04, by Nicolas Chauvat
backport stable
2010-03-04, by Sylvain Thénault
oops, 'not' missing
2010-03-04, by Sylvain Thénault
[repo] fix bug introduced by 4757:ec9c20c6b9f7, testing for select.selection is not enough to avoid the substep query, we should check there is no interesting restriction (test added)
2010-03-04, by Sylvain Thénault
[rql2sql] fix potential crash when testing _q_invariant on a ColumnAlias instead of a Variable by always considering _q_invariant to false for them
stable
2010-03-04, by Sylvain Thénault
backport stable
2010-03-04, by Sylvain Thénault
fix test broken by meta relation permissions tweaks
stable
2010-03-04, by Sylvain Thénault
fix schema serialization, bad repartition of changes between stable and default
stable
2010-03-04, by Sylvain Thénault
backport stable
2010-03-04, by Sylvain Thénault
remove stuff from default introduced accidentally in stable
stable
2010-03-04, by Sylvain Thénault
applied vgodard patch for jquery rounded corner w/ MSIE >= 8
stable
2010-03-04, by Sylvain Thénault
backport stable
2010-03-04, by Sylvain Thénault
[fix] #731915 use add_onload instead of plain <script> tag for progress bar.
stable
2010-03-04, by Adrien Chauve
add render_description method to RSSItemView to improve modularity.
stable
2010-03-04, by Pierre-Yves David
le patch documentation-admin-tips a été importé
stable
2010-02-26, by Julien Jehannet
[F] views: fix 2 unicode errors
stable
2010-03-02, by Julien Jehannet
le patch fix-3.6-deprecation-warning a été importé
stable
2010-02-22, by Julien Jehannet
Suppress the hidden logform when the user is already connected
stable
2010-03-04, by Alain Leufroy
fix a Depression Warning
stable
2010-03-04, by Alain Leufroy
fix: Prevent multi pass in restore_previous_post
stable
2010-03-04, by Alain Leufroy
merge
stable
2010-03-04, by Sylvain Thénault
[test] check _shutting_down, not empty dict (empty dict test should go in pytestgc patch)
2010-03-03, by Sylvain Thénault
assert we are not already shutting down
2010-03-03, by Sylvain Thénault
[test] call super class teardown after perms restoration
2010-03-03, by Sylvain Thénault
[test] get a chance to get proper garbage collection when running pytest on whole cw
2010-03-03, by Sylvain Thénault
[testlib] properly close dumb sessions
2010-03-03, by Sylvain Thénault
[debug] more (dirty) gc debuging
2010-03-03, by Sylvain Thénault
custom rest publisher instead of using rest_publish. Avoid to keep a ref on the latest context
2010-03-03, by Sylvain Thénault
cleanup
2010-03-03, by Sylvain Thénault
[rest] cleanup, avoid deprecation warning
2010-03-03, by Sylvain Thénault
delete pyro proxy on connection close, properly raise programming error when working on a closed connection
2010-03-03, by Sylvain Thénault
cleanup
2010-03-03, by Sylvain Thénault
[test] get a chance to get proper garbage collection when running pytest on whole cw
2010-03-03, by Sylvain Thénault
more tests
stable
2010-03-03, by Sylvain Thénault
[repo] improve planning of insert/update queries: do not select affected constants so the don't go and back to/from the source.
2010-03-03, by Sylvain Thénault
schema serialization optimization by using eids instead of type names. Heavy refactoring/cleanup on the way
2010-03-03, by Sylvain Thénault
backport stable
2010-03-03, by Sylvain Thénault
[testlib] automatic test shouldn't try to populate default_workflow
stable
2010-03-03, by Sylvain Thénault
minor schema serialization optimization:
stable
2010-03-03, by Sylvain Thénault
cleanups
stable
2010-03-03, by Sylvain Thénault
fix code and tests broken by 4744:13a5d3a7410e (proper permission on eid/has_text/identity relations)
stable
2010-03-03, by Sylvain Thénault
do not check for use template permission when session is super session or integrity hooks are deactivated
stable
2010-03-02, by Sylvain Thénault
do not check for existant entity when relation of single card is added but integrity hooks are deactivated
stable
2010-03-02, by Sylvain Thénault
[schema] tweaks meta-relations and schema/workflow entities attributes permissions
stable
2010-03-02, by Sylvain Thénault
[schema] new constants for permissions definitions
stable
2010-03-02, by Sylvain Thénault
[book/ldap] note on the role of two options
stable
2010-03-03, by Aurelien Campeas
[book/cwctl] reorganize a bit this page (very messy)
stable
2010-03-02, by Aurelien Campeas
[book] more id -> __regid__
stable
2010-03-02, by Aurelien Campeas
[book/entities] a bit of flesh to the interface chapter
stable
2010-03-02, by Aurelien Campeas
[book/admin/pyro] fix pyro options, give a small setup example
stable
2010-03-02, by Aurelien Campeas
[book/faq] cleanup & complete a bit
stable
2010-03-02, by Aurelien Campeas
[book/admin/setup] notes about configuration of sql server
stable
2010-03-02, by Aurelien Campeas
[book] remove seemingly unused old cruft
stable
2010-03-02, by Aurelien Campeas
merge
stable
2010-03-02, by Aurelien Campeas
[book] cleanup (deleting/moving) old stuff
stable
2010-03-02, by Aurelien Campeas
[book] a few autoclasses for renderers, misc tweaks
stable
2010-03-02, by Aurelien Campeas
[primary] navcontentbottom sections should be in the content table as navcontenttop
stable
2010-03-02, by Sylvain Thénault
[book/controllers] add some content (overview, api super sketch) for the cubicweb controllers
stable
2010-03-02, by Aurelien Campeas
[book/ldap] add missing LDAP section
stable
2010-03-02, by Aurelien Campeas
[reledit] add ajax html head div, which allows to get additional css/js up to the browser #620569
stable
2010-03-02, by Aurelien Campeas
fix open/close/open subnode bug #730709
stable
2010-03-01, by Aurelien Campeas
backport stable to default
2010-02-26, by Sylvain Thénault
Added tag cubicweb-debian-version-3.6.1-1 for changeset b9cdfe3341d1
stable
2010-02-26, by Sylvain Thénault
Added tag cubicweb-version-3.6.1 for changeset 4ae30c9ca11b
stable
cubicweb-debian-version-3.6.1-1
2010-02-26, by Sylvain Thénault
typo
stable
cubicweb-version-3.6.1
2010-02-26, by Sylvain Thénault
3.6.1 depending on yams 0.28
stable
2010-02-26, by Sylvain Thénault
merge
stable
2010-02-26, by Sylvain Thénault
Added tag cubicweb-debian-version-3.6.0-1 for changeset d2ba93fcb8da
2010-02-10, by Sylvain Thénault
Added tag cubicweb-version-3.6.0 for changeset 450804da3ab2
cubicweb-debian-version-3.6.0-1
2010-02-10, by Sylvain Thénault
3.6.1
stable
2010-02-26, by Sylvain Thénault
merge
stable
2010-02-26, by Aurelien Campeas
tabs/lazy views: provide a link for the no js user agents (lynx, blinds, google) #693670
stable
2010-02-26, by Aurelien Campeas
[test] XXX fix to have pytest succeed on whole cw
stable
2010-02-26, by Sylvain Thénault
typo
stable
2010-02-26, by Sylvain Thénault
fix test, broken by the merge of debug and info views
stable
2010-02-26, by Sylvain Thénault
ensure we don't break xhtml
stable
2010-02-26, by Sylvain Thénault
pylint suggested refactorings
stable
2010-02-26, by Sylvain Thénault
pylint style fixes
stable
2010-02-26, by Sylvain Thénault
don't use module doc string as usage string
stable
2010-02-26, by Sylvain Thénault
kill dead/useless code as suggested by pylint
stable
2010-02-26, by Sylvain Thénault
avoid module import in c-c plugins module, and remind it
stable
2010-02-26, by Sylvain Thénault
proper deprecation warning when import class that should be imported from yams
stable
2010-02-26, by Sylvain Thénault
fix some pylint detected errors
stable
2010-02-26, by Sylvain Thénault
[test] fix test broken by arthur processinfo patch
stable
2010-02-26, by Sylvain Thénault
merge debug and info views
stable
2010-02-26, by Sylvain Thénault
[i18n] nothing to translate here
stable
2010-02-26, by Sylvain Thénault
i18nupdate
stable
2010-02-26, by Sylvain Thénault
[test] we should properly use vreg method to compute solutions
stable
2010-02-26, by Sylvain Thénault
[pool] properly close existing connection before reconnection
stable
2010-02-26, by Sylvain Thénault
[web] fix #724769: Use RemoteCallFailed in the publisher's error_handler
stable
2010-02-26, by Adrien Di Mascio
#687194: cubicweb-ctl exlog : fix help message
stable
2010-02-26, by Sylvain Thénault
merge
stable
2010-02-26, by Sylvain Thénault
added stats for munin collecting #615844 - from 027bbff3659f
stable
2010-02-26, by arthur
[dbapi] no more need to monkey patch this in 3.6: vreg/schema/config are all properly accessed through ._cw
stable
2010-02-26, by Sylvain Thénault
[session] fix memory leak: local thread data living in a thread that never finishes (eg, the main thread) may not be properly freed
stable
2010-02-26, by Sylvain Thénault
[session] user.login is usually an unicode string, so implements __unicode__ instead of __str__
stable
2010-02-26, by Sylvain Thénault
fix docstring
stable
2010-02-26, by Sylvain Thénault
[facet] before 3.6 we were sure to have a cw_rset attribute. Restore this for facets
stable
2010-02-26, by Sylvain Thénault
[iprogress] missing js file
stable
2010-02-25, by Sylvain Thénault
[hooks] match_rtype and match_rtype_sets don't need to extend match_search_state
stable
2010-02-25, by Adrien Di Mascio
[uicfg] section='inlined' is acceptable for inlined forms
stable
2010-02-25, by Adrien Di Mascio
[web] fix muledit rendering bug
stable
2010-02-25, by Adrien Di Mascio
merge
stable
2010-02-24, by Sylvain Thénault
3.6 api update
stable
2010-02-24, by Sylvain Thénault
simplejson may not be available with python 2.4
stable
2010-02-24, by Sylvain Thénault
ensure make_uid return something that may be used as dom id
stable
2010-02-24, by Sylvain Thénault
[test] also hide this message during test
stable
2010-02-24, by Sylvain Thénault
[test] fix test inter-dependancies pb. Pytest ok in each individual test dir, though not yet for whole cubicweb, but for different reasons
stable
2010-02-24, by Sylvain Thénault
[testlib] provide ability to control schema/vreg reset using reset_schema/reset_vreg test class attributes
stable
2010-02-24, by Sylvain Thénault
[test] skipping versions checking during test is enough, no need for monkey patch
stable
2010-02-24, by Sylvain Thénault
[goa] we don't use mx anymore
stable
2010-02-24, by Sylvain Thénault
[integrity] skip auto-delete for internal sessions (but *not* for super session, see 4642:921737d2e3a8)
stable
2010-02-24, by Sylvain Thénault
[integrity] temporary fix auto-delete relation (see 4673:6f8b925a29f4 and 4642:921737d2e3a8): we want no read perms, though we want to check delete perms. Should be properly fixed in 3.7 once we've proper security control and [unsafe_]execute behaviour on the repository side
stable
2010-02-24, by Sylvain Thénault
use set_action_permissions is clearer and avoid @cached issue across tests
stable
2010-02-24, by Sylvain Thénault
[cwctl] use l.c.changelog for version comparison
stable
2010-02-24, by Nicolas Chauvat
[form] only set __form_id for the main form, not for sub-forms. Should fix regression introduced by 4668:9f82f81bf13d
stable
2010-02-24, by Sylvain Thénault
don't issue critical message when trying to alter sqlite db during test
stable
2010-02-24, by Sylvain Thénault
[test] cleanup
stable
2010-02-24, by Sylvain Thénault
[test] update tests broken by changes on attributes permissions handling in yams (add/delete replaced by update
stable
2010-02-24, by Sylvain Thénault
remove #<formid> from url used to redirect after a validation error
stable
2010-02-24, by Sylvain Thénault
[test] no more __cubicweb_internal_field__ value displayed on password widget
stable
2010-02-24, by Sylvain Thénault
[test] inline-creation requires petype argument to be selectable. Fix arguments order to make it clearer that 'template' is an argument of the test class .view method
stable
2010-02-24, by Sylvain Thénault
[test] skip test when fop failed
stable
2010-02-24, by Sylvain Thénault
[test] don't display progress bar when testing checkintegrity
stable
2010-02-24, by Sylvain Thénault
[test api] rename _user_session to user_groups_session, fix its arguments and return only the session, not (user, session) to make things clearer
stable
2010-02-24, by Sylvain Thénault
auto-delete relation with single cardinality using execute, not unsafe_execute, so permissions are correctly checked
stable
2010-02-23, by Sylvain Thénault
fix tests
stable
2010-02-23, by Sylvain Thénault
add */*.py to default MANIFEST.in to avoid pb such as #719282 in the future
stable
2010-02-23, by Sylvain Thénault
fix #615379 by checking admin user exists instead of making think everything is fine
stable
2010-02-23, by Sylvain Thénault
cleanup, typos
stable
2010-02-23, by Sylvain Thénault
[form] fix #719285, due to multiple calls to restore_previous_post, by proper refactorings
stable
2010-02-23, by Sylvain Thénault
[fix] Apply fulltextindexed change in the actual index
stable
2010-02-18, by Pierre-Yves David
3.6 api update (introduced by merge)
stable
2010-02-23, by Sylvain Thénault
when validating a form, we should properly call 'actual_fields(form) on edited field else compound field are not correctly processed
stable
2010-02-23, by Sylvain Thénault
#714109: [selectors] non_final_entity should implement score_class
stable
2010-02-23, by Sylvain Thénault
merge
stable
2010-02-23, by Sylvain Thénault
add XXX note
stable
2010-02-23, by Sylvain Thénault
[form] cache field value in form.formvalues using (field, form) key since in some case the same field instance may be shared accross multiple forms, which may share the formvalues dict in case of sub-forms
stable
2010-02-23, by Sylvain Thénault
cleanup
stable
2010-02-23, by Sylvain Thénault
[form] complete 25de2eb0432b by ignore req parameters by default for all hidden fields
stable
2010-02-23, by Sylvain Thénault
[form] add a new ignore_req_params attribute on field controlling value's retreival
stable
2010-02-23, by Sylvain Thénault
[css] fix disappearing image in menu when a:hover
stable
2010-02-23, by Charles Hébert
[cwctl] modify command list to check for cube dependency problems
stable
2010-02-23, by Nicolas Chauvat
merge
stable
2010-02-23, by Alexandre Fayolle
docstring improvement
stable
2010-02-23, by Alexandre Fayolle
import cleanup
stable
2010-02-23, by Sylvain Thénault
restore 3.5 compat for date functions moved to lgc.date in 3.6 (closes #716055)
stable
2010-02-23, by Sylvain Thénault
[devtools/fill] fix date generation and its test
stable
2010-02-22, by Nicolas Chauvat
typo: capitalize migration confirmation messages
stable
2010-02-22, by Nicolas Chauvat
[views/deleteconf] remove action ppty (useless & clashes with form attr, replace buggy non_final_entity selector with implements workaround
stable
2010-02-19, by Aurelien Campeas
merge
stable
2010-02-19, by Sylvain Thénault
[workflow] fix potential destination for go back transition
stable
2010-02-19, by Sylvain Thénault
[workflow] finish refactoring introduced by 021035b9a7ab for 'go back' transition:
stable
2010-02-19, by Sylvain Thénault
deprecate Transition.set_transition_permissions in favor of set_permissions (after all we know we're on a transition entity)
stable
2010-02-19, by Sylvain Thénault
introduce 'go back' transition: transition without destination state will go to the state we were coming from
stable
2010-02-19, by Sylvain Thénault
fix optimisation with super session that may lead to integrity loss
stable
2010-02-19, by Sylvain Thénault
[auto/inline forms] reallow nested inline forms #703910
stable
2010-02-19, by Aurelien Campeas
[reledit] fix #713217: reledit doesn't check 'update' permission on attributes
stable
2010-02-18, by Sylvain Thénault
fix dumb name error
stable
2010-02-18, by Sylvain Thénault
cleanup internal forms parameters in postlogin
stable
2010-02-18, by Sylvain Thénault
grmmbl, bad resolve
stable
2010-02-18, by Sylvain Thénault
missed conflict
stable
2010-02-18, by Sylvain Thénault
backport lost stable head
stable
2010-02-18, by Sylvain Thénault
fix sync_schema_props_perms test
stable
2010-02-18, by Sylvain Thénault
fix create_user function introduced in d6ae30c5d055 for database initialization: messup admin user groups when anon is created due to missing restriction
stable
2010-02-18, by Sylvain Thénault
3.6 api update
stable
2010-02-18, by Sylvain Thénault
fix unittest_hooks: attributes have now update_permission instead of [add/delete]_permission
stable
2010-02-18, by Sylvain Thénault
when modifying a persistent schema, erschema may miss some permissions which wil trigger a key error, but we don't want to crash on such cases
stable
2010-02-18, by Sylvain Thénault
fix #694445: related entity generates weird RQL which in turn generates weird SQL which fails on SQL Server
stable
2010-02-18, by Sylvain Thénault
fix 4626:c26b4df9fc90 (#703911): use can't rely on peid since it's not an actual eid when we're creating the parent entity
stable
2010-02-18, by Sylvain Thénault
[form fields] nicer behaviour of the password field: don't put internal field value on edition (triggering validation error if one validation without removing the value, due to confirmation mismatch), and don't show the field as required in such case
stable
2010-02-18, by Sylvain Thénault
minor cleanup: don't use builtin 'id' as variable name
stable
2010-02-18, by Sylvain Thénault
[forms/inline] fix #703911: add new link disappears if inline box removed. Since we've the information, we must specify the target type else we get random cardinality on ambiguous relations
stable
2010-02-18, by Sylvain Thénault
this is not the form renderer responsability to check for update permissions. Move this to autoform editable_attributes relation
stable
2010-02-18, by Sylvain Thénault
turn default logging threshold to warning (we usually want them), and log 'no schema for eid' pb using warning instead of error, so we see them in logs but not during migration
stable
2010-02-18, by Sylvain Thénault
pfff, sorry to keep messing with default/stable...
stable
2010-02-18, by Sylvain Thénault
specify db port on backup/restore commands (require forth comming lgc 0.48.1)
2010-02-18, by Sylvain Thénault
move captcha view to a place where it will be loaded by the registry...
2010-02-18, by Sylvain Thénault
backport stable
2010-02-18, by Sylvain Thénault
[security] allow to call .check on rql expression with a user eid specified
stable
2010-02-17, by Sylvain Thénault
[facet] rqlst should be the select node
stable
2010-02-17, by Sylvain Thénault
oops, should have been in my previous commit
stable
2010-02-17, by Sylvain Thénault
fix table view facet retreival, necessary since 95ccd84c892b. Also some cleanup in facet box
stable
2010-02-17, by Sylvain Thénault
Fix: RangeFacet is selected (valid rset) but without any values
stable
2010-02-17, by Charles Hébert
fix the bad rqlst syntax tree usage during facets initialization by copying it
stable
2010-02-17, by Charles Hébert
[R] dataimport: refine error detection
stable
2010-02-17, by Julien Jehannet
added a function to create admin/anon user during db initialization process so one get a chance to monkey patch it
stable
2010-02-17, by Sylvain Thénault
fix unittest_schema, remove deprecation warning
stable
2010-02-17, by Sylvain Thénault
when creating an instance, ask for cubes specific options properly (fix #607349)
stable
2010-02-17, by Sylvain Thénault
avoid loading twice site_cubicweb files on instance creation
stable
2010-02-17, by Sylvain Thénault
oops
stable
2010-02-17, by Sylvain Thénault
[schema security] fix so that when cheking attributes perms for an entity being created, 'owners' and has_*_permission in erqlexpr are considered satisfied
stable
2010-02-17, by Sylvain Thénault
dont add CUBES_DIR to cubes search path if it doesn't exists
stable
2010-02-17, by Sylvain Thénault
fix dumb name error triggering crash when some directory in cubes search path doesn't exist
stable
2010-02-17, by Sylvain Thénault
remove 3.6 deprecation warning
stable
2010-02-17, by Sylvain Thénault
login form style fixes
stable
2010-02-17, by Sylvain Thénault
proper deprecation of TabedPrimaryView
stable
2010-02-17, by Sylvain Thénault
missing call to toolbox in tabbed primary view
stable
2010-02-17, by Sylvain Thénault
use needs_css so you can change login form css without redefining LogFormView
stable
2010-02-16, by Sylvain Thénault
bw compat
stable
2010-02-16, by Sylvain Thénault
backport fixes done accidentaly in default
stable
2010-02-16, by Sylvain Thénault
use class, not klass, in widget.attrs
2010-02-16, by Sylvain Thénault
specify login form dom id, don't render progress div
2010-02-16, by Sylvain Thénault
backport crypto/captcha utilities from the registration cube
2010-02-16, by Sylvain Thénault
use an actual form for the login form ease customization from external cubes (eg rememberme)
2010-02-16, by Sylvain Thénault
add space between a checkbox and its label
2010-02-16, by Sylvain Thénault
ensure cnx is set first (necessary to introduce of a form object to handle the login form)
2010-02-16, by Sylvain Thénault
don't let set_schema making commit_event fail
2010-02-16, by Sylvain Thénault
use constant
2010-02-15, by Sylvain Thénault
fix permission of the condition permission
2010-02-15, by Sylvain Thénault
fix *_permissions schema: using the same cardinality/composite properties for cwgroup/rqlexpr leads to important pbs...
2010-02-15, by Sylvain Thénault
backport stable
2010-02-15, by Sylvain Thénault
DEFAULT_ATTRPERMS is now public
stable
2010-02-15, by Sylvain Thénault
[inlined formos] don't pop attributes from kwargs, so they end-up in
stable
2010-02-15, by Sylvain Thénault
[notification] we should use unsafe_execute here
stable
2010-02-15, by Sylvain Thénault
cleanup
stable
2010-02-15, by Sylvain Thénault
[calendar view] fix related to the date_range mess (max value exclusion). Calendar views authors should check if more similar fixes needed
stable
2010-02-15, by Sylvain Thénault
[forms] fix RelationField bug with pending eids (eg inlined forms): we have to override process_form_value to avoid caching when recomputing is needed
stable
2010-02-15, by Sylvain Thénault
[shell] rql() should use unsafe_execute when possible
stable
2010-02-15, by Sylvain Thénault
[autoform] we should consider role when checking delete permission
stable
2010-02-15, by Sylvain Thénault
don't update modification_date in repairing_mode (eg upgrade or shell)
stable
2010-02-15, by Sylvain Thénault
less
more
|
(0)
-3000
-1000
-240
+240
+1000
+3000
tip