[notification] avoid leaking cnxsets (closes #3243810)
When sending notifications, we get each recipient as either an email
address or a CWUser. In the latter case, we create a temporary session
for that user and use it to send the mail. However, if we later decided
to not send the mail after all, we'd leak the session and its cnxset.
Add a try block inside the loop to make sure the temporary sessions are
closed properly.
# copyright 2003-2010 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr
#
# This file is part of CubicWeb.
#
# CubicWeb is free software: you can redistribute it and/or modify it under the
# terms of the GNU Lesser General Public License as published by the Free
# Software Foundation, either version 2.1 of the License, or (at your option)
# any later version.
#
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
# details.
#
# You should have received a copy of the GNU Lesser General Public License along
# with CubicWeb. If not, see <http://www.gnu.org/licenses/>.
import os, os.path as osp, glob
from cubicweb.devtools.testlib import CubicWebTC
from cubicweb.devtools.httptest import CubicWebServerTC
from cubicweb.etwist.server import host_prefixed_baseurl
class HostPrefixedBaseURLTC(CubicWebTC):
def _check(self, baseurl, host, waited):
self.assertEqual(host_prefixed_baseurl(baseurl, host), waited,
'baseurl %s called through host %s should be considered as %s'
% (baseurl, host, waited))
def test1(self):
self._check('http://www.cubicweb.org/hg/', 'code.cubicweb.org',
'http://code.cubicweb.org/hg/')
def test2(self):
self._check('http://www.cubicweb.org/hg/', 'cubicweb.org',
'http://www.cubicweb.org/hg/')
def test3(self):
self._check('http://cubicweb.org/hg/', 'code.cubicweb.org',
'http://code.cubicweb.org/hg/')
def test4(self):
self._check('http://www.cubicweb.org/hg/', 'localhost',
'http://www.cubicweb.org/hg/')
def test5(self):
self._check('http://www.cubicweb.org/cubes/', 'hg.code.cubicweb.org',
'http://hg.code.cubicweb.org/cubes/')
def test6(self):
self._check('http://localhost:8080/hg/', 'code.cubicweb.org',
'http://localhost:8080/hg/')
class ETwistHTTPTC(CubicWebServerTC):
def test_put_content(self):
body = 'hop'
response = self.web_request('?vid=put', method='PUT', body=body)
self.assertEqual(body, response.body)
if __name__ == '__main__':
from logilab.common.testlib import unittest_main
unittest_main()