[edit controller] fix handling of removal of subentities from an edit form
In CubicWeb 3.18 the semantics of dropping a composite relation were changed.
It had before the effect of deleting the subentities.
Now the edit controller must handle this by itself (it was not adapted then by
mistake).
So if it detects the removal of a composite relation (on the browser side, the
user clicked on the "remove" action), the subentity is now explicitly deleted.
It was chosen not to change the form generation but the EditController:
- to ensure pre-3.18 forms backward compat
- to avoid the introduction of a specific entity-deletion API (RQL is probably
our best API for complex DB operations)
Related to #8529868.
# copyright 2003-2014 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr
#
# This file is part of CubicWeb.
#
# CubicWeb is free software: you can redistribute it and/or modify it under the
# terms of the GNU Lesser General Public License as published by the Free
# Software Foundation, either version 2.1 of the License, or (at your option)
# any later version.
#
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
# details.
#
# You should have received a copy of the GNU Lesser General Public License along
# with CubicWeb. If not, see <http://www.gnu.org/licenses/>.
"""core hooks registering some maintainance tasks as server startup time"""
__docformat__ = "restructuredtext en"
from datetime import timedelta, datetime
from cubicweb.server import hook
class TransactionsCleanupStartupHook(hook.Hook):
"""start task to cleanup transaction data"""
__regid__ = 'cw.looping-tasks.transactions-cleanup'
events = ('server_startup',)
def __call__(self):
# XXX use named args and inner functions to avoid referencing globals
# which may cause reloading pb
lifetime = timedelta(days=self.repo.config['keep-transaction-lifetime'])
def cleanup_old_transactions(repo=self.repo, lifetime=lifetime):
mindate = datetime.now() - lifetime
with repo.internal_cnx() as cnx:
cnx.system_sql(
'DELETE FROM transactions WHERE tx_time < %(time)s',
{'time': mindate})
cnx.commit()
if self.repo.config['undo-enabled']:
self.repo.looping_task(60*60*24, cleanup_old_transactions,
self.repo)
class UpdateFeedsStartupHook(hook.Hook):
"""start task to update datafeed based sources"""
__regid__ = 'cw.looping-tasks.update-feeds'
events = ('server_startup',)
def __call__(self):
def update_feeds(repo):
# take a list to avoid iterating on a dictionary whose size may
# change
for uri, source in list(repo.sources_by_uri.iteritems()):
if (uri == 'system'
or not repo.config.source_enabled(source)
or not source.config['synchronize']):
continue
with repo.internal_cnx() as cnx:
try:
source.pull_data(cnx)
except Exception as exc:
cnx.exception('while trying to update feed %s', source)
self.repo.looping_task(60, update_feeds, self.repo)
class DataImportsCleanupStartupHook(hook.Hook):
"""start task to cleanup old data imports (ie datafeed import logs)"""
__regid__ = 'cw.looping-tasks.dataimports-cleanup'
events = ('server_startup',)
def __call__(self):
def expire_dataimports(repo=self.repo):
for uri, source in repo.sources_by_uri.iteritems():
if (uri == 'system'
or not repo.config.source_enabled(source)):
continue
with repo.internal_cnx() as cnx:
mindate = datetime.now() - timedelta(seconds=source.config['logs-lifetime'])
cnx.execute('DELETE CWDataImport X WHERE X start_timestamp < %(time)s',
{'time': mindate})
cnx.commit()
self.repo.looping_task(60*60*24, expire_dataimports, self.repo)