[edit controller] fix handling of removal of subentities from an edit form
In CubicWeb 3.18 the semantics of dropping a composite relation were changed.
It had before the effect of deleting the subentities.
Now the edit controller must handle this by itself (it was not adapted then by
mistake).
So if it detects the removal of a composite relation (on the browser side, the
user clicked on the "remove" action), the subentity is now explicitly deleted.
It was chosen not to change the form generation but the EditController:
- to ensure pre-3.18 forms backward compat
- to avoid the introduction of a specific entity-deletion API (RQL is probably
our best API for complex DB operations)
Related to #8529868.
# copyright 2003-2010 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr
#
# This file is part of CubicWeb.
#
# CubicWeb is free software: you can redistribute it and/or modify it under the
# terms of the GNU Lesser General Public License as published by the Free
# Software Foundation, either version 2.1 of the License, or (at your option)
# any later version.
#
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
# details.
#
# You should have received a copy of the GNU Lesser General Public License along
# with CubicWeb. If not, see <http://www.gnu.org/licenses/>.
"""unit tests for cubicweb.devtools.fill module
"""
import re
from logilab.common.testlib import TestCase, unittest_main
from cubicweb.devtools.fill import ValueGenerator, _ValueGenerator
ISODATE_SRE = re.compile('(?P<year>\d{4})-(?P<month>\d{2})-(?P<day>\d{2})$')
class AutoExtendableTC(TestCase):
def setUp(self):
self.attrvalues = dir(_ValueGenerator)
def tearDown(self):
attrvalues = set(dir(_ValueGenerator))
for attrname in attrvalues - set(self.attrvalues):
delattr(_ValueGenerator, attrname)
def test_autoextend(self):
self.assertNotIn('generate_server', dir(ValueGenerator))
class MyValueGenerator(ValueGenerator):
def generate_server(self, index):
return attrname
self.assertIn('generate_server', dir(ValueGenerator))
def test_bad_signature_detection(self):
self.assertNotIn('generate_server', dir(ValueGenerator))
try:
class MyValueGenerator(ValueGenerator):
def generate_server(self):
pass
except TypeError:
self.assertNotIn('generate_server', dir(ValueGenerator))
else:
self.fail('TypeError not raised')
def test_signature_extension(self):
self.assertNotIn('generate_server', dir(ValueGenerator))
class MyValueGenerator(ValueGenerator):
def generate_server(self, index, foo):
pass
self.assertIn('generate_server', dir(ValueGenerator))
if __name__ == '__main__':
unittest_main()