[migration] don't handle data deletion anymore on schema changes
In most cases when we want to drop some entity/relation type, we don't care
whether hooks are called on their deletion. There is even low chances that some
hooks still exists, based on an old version of the schema. Last but not least,
this is horribly inefficient.
So this should be clearly documented and handled by application's programmer if
desired.
This patch removes unnecessary deletion (because table or column will be later
dropped) and reimplements the case of partial deletion (only one relation
definition among several, hence the database structure isn't modified) using
sql.
Only one test regarding deletion of inlined relation def is added as other cases
seem to be covered by existing tests.
Closes #7023315
# copyright 2003-2015 LOGILAB S.A. (Paris, FRANCE), all rights reserved.# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr## This file is part of CubicWeb.## CubicWeb is free software: you can redistribute it and/or modify it under the# terms of the GNU Lesser General Public License as published by the Free# Software Foundation, either version 2.1 of the License, or (at your option)# any later version.## CubicWeb is distributed in the hope that it will be useful, but WITHOUT# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more# details.## You should have received a copy of the GNU Lesser General Public License along# with CubicWeb. If not, see <http://www.gnu.org/licenses/>.fromdatetimeimportdatetimefromthreadingimportThreadfromsix.movesimportrangefromlogilab.common.testlibimportSkipTestimportlogilab.databaseaslgdbfromcubicwebimportValidationErrorfromcubicweb.devtoolsimportPostgresApptestConfiguration,startpgcluster,stoppgclusterfromcubicweb.devtools.testlibimportCubicWebTCfromcubicweb.predicatesimportis_instancefromcubicweb.entities.adaptersimportIFTIndexableAdapterfromunittest_querierimportFixedOffsetdefsetUpModule():startpgcluster(__file__)deftearDownModule():stoppgcluster(__file__)classPostgresTimeoutConfiguration(PostgresApptestConfiguration):def__init__(self,*args,**kwargs):self.default_sources=PostgresApptestConfiguration.default_sources.copy()self.default_sources['system']=PostgresApptestConfiguration.default_sources['system'].copy()self.default_sources['system']['db-statement-timeout']=200super(PostgresTimeoutConfiguration,self).__init__(*args,**kwargs)classPostgresFTITC(CubicWebTC):configcls=PostgresTimeoutConfiguration@classmethoddefsetUpClass(cls):cls.orig_connect_hooks=lgdb.SQL_CONNECT_HOOKS['postgres'][:]@classmethoddeftearDownClass(cls):lgdb.SQL_CONNECT_HOOKS['postgres']=cls.orig_connect_hooksdeftest_eid_range(self):# concurrent allocation of eid rangessource=self.session.repo.sources_by_uri['system']range1=[]range2=[]defallocate_eid_ranges(session,target):forxinrange(1,10):eid=source.create_eid(session,count=x)target.extend(range(eid-x,eid))t1=Thread(target=lambda:allocate_eid_ranges(self.session,range1))t2=Thread(target=lambda:allocate_eid_ranges(self.session,range2))t1.start()t2.start()t1.join()t2.join()self.assertEqual(range1,sorted(range1))self.assertEqual(range2,sorted(range2))self.assertEqual(set(),set(range1)&set(range2))deftest_occurence_count(self):withself.admin_access.repo_cnx()ascnx:c1=cnx.create_entity('Card',title=u'c1',content=u'cubicweb cubicweb cubicweb')c2=cnx.create_entity('Card',title=u'c3',content=u'cubicweb')c3=cnx.create_entity('Card',title=u'c2',content=u'cubicweb cubicweb')cnx.commit()self.assertEqual(cnx.execute('Card X ORDERBY FTIRANK(X) DESC ''WHERE X has_text "cubicweb"').rows,[[c1.eid,],[c3.eid,],[c2.eid,]])deftest_attr_weight(self):classCardIFTIndexableAdapter(IFTIndexableAdapter):__select__=is_instance('Card')attr_weight={'title':'A'}withself.temporary_appobjects(CardIFTIndexableAdapter):withself.admin_access.repo_cnx()ascnx:c1=cnx.create_entity('Card',title=u'c1',content=u'cubicweb cubicweb cubicweb')c2=cnx.create_entity('Card',title=u'c2',content=u'cubicweb cubicweb')c3=cnx.create_entity('Card',title=u'cubicweb',content=u'autre chose')cnx.commit()self.assertEqual(cnx.execute('Card X ORDERBY FTIRANK(X) DESC ''WHERE X has_text "cubicweb"').rows,[[c3.eid,],[c1.eid,],[c2.eid,]])deftest_entity_weight(self):classPersonneIFTIndexableAdapter(IFTIndexableAdapter):__select__=is_instance('Personne')entity_weight=2.0withself.temporary_appobjects(PersonneIFTIndexableAdapter):withself.admin_access.repo_cnx()ascnx:c1=cnx.create_entity('Personne',nom=u'c1',prenom=u'cubicweb')c2=cnx.create_entity('Comment',content=u'cubicweb cubicweb',comments=c1)c3=cnx.create_entity('Comment',content=u'cubicweb cubicweb cubicweb',comments=c1)cnx.commit()self.assertEqual(cnx.execute('Any X ORDERBY FTIRANK(X) DESC ''WHERE X has_text "cubicweb"').rows,[[c1.eid,],[c3.eid,],[c2.eid,]])deftest_tz_datetime(self):withself.admin_access.repo_cnx()ascnx:cnx.execute("INSERT Personne X: X nom 'bob', X tzdatenaiss %(date)s",{'date':datetime(1977,6,7,2,0,tzinfo=FixedOffset(1))})datenaiss=cnx.execute("Any XD WHERE X nom 'bob', X tzdatenaiss XD")[0][0]self.assertEqual(datenaiss.tzinfo,None)self.assertEqual(datenaiss.utctimetuple()[:5],(1977,6,7,1,0))cnx.commit()cnx.execute("INSERT Personne X: X nom 'boby', X tzdatenaiss %(date)s",{'date':datetime(1977,6,7,2,0)})datenaiss=cnx.execute("Any XD WHERE X nom 'boby', X tzdatenaiss XD")[0][0]self.assertEqual(datenaiss.tzinfo,None)self.assertEqual(datenaiss.utctimetuple()[:5],(1977,6,7,2,0))deftest_constraint_validationerror(self):withself.admin_access.repo_cnx()ascnx:withcnx.allow_all_hooks_but('integrity'):withself.assertRaises(ValidationError)ascm:cnx.execute("INSERT Note N: N type 'nogood'")self.assertEqual(cm.exception.errors,{'type-subject':u'invalid value %(KEY-value)s, it must be one of %(KEY-choices)s'})self.assertEqual(cm.exception.msgargs,{'type-subject-value':u'"nogood"','type-subject-choices':u'"todo", "a", "b", "T", "lalala"'})deftest_statement_timeout(self):withself.admin_access.repo_cnx()ascnx:cnx.system_sql('select pg_sleep(0.1)')withself.assertRaises(Exception):cnx.system_sql('select pg_sleep(0.3)')classPostgresLimitSizeTC(CubicWebTC):configcls=PostgresApptestConfigurationdeftest(self):withself.admin_access.repo_cnx()ascnx:defsql(string):returncnx.system_sql(string).fetchone()[0]yieldself.assertEqual,sql("SELECT limit_size('<p>hello</p>', 'text/html', 20)"), \'<p>hello</p>'yieldself.assertEqual,sql("SELECT limit_size('<p>hello</p>', 'text/html', 2)"), \'he...'yieldself.assertEqual,sql("SELECT limit_size('<br/>hello', 'text/html', 2)"), \'he...'yieldself.assertEqual,sql("SELECT limit_size('<span class=\"1\">he</span>llo', 'text/html', 2)"), \'he...'yieldself.assertEqual,sql("SELECT limit_size('<span>a>b</span>', 'text/html', 2)"), \'a>...'if__name__=='__main__':fromlogilab.common.testlibimportunittest_mainunittest_main()