[pkg] Use sections from requires.txt to populate Recommends and Suggests
As Denis Laxalde pointed out, dh_python can also generate Recommends and
Suggests from Python package names. So let's use that instead of
manually populating these fields in `debian/control`.
Optional dependencies are currently specified in `setup.py` grouped by
feature. These dependency groups are turned into sections in
`requires.txt`. Thankfully `dh_python3` has options to populate
Recommends or Suggests with all package from a given section.
`debian/rules` now contains a list of which sections should go
to Recommends and which section should go to Suggests. Because such
extra list easily gets out-of-sync, we add a third list for ignored
sections, and ensure that all sections currently in `requires.txt`
get a mentioned in `debian/rules`.
Here are the results compared to the previous version with explicit
Recommends and Suggests (only listing Python packages):
|==============================================================|
| only in previous | common | only in new |
|==============================================================|
| Recommends |
|--------------------------------------------------------------|
| | python3-docutils | |
| python3-fyzz | | |
| python3-imaging | | |
| | python3-pycryptodome | |
| | python3-pyramid | |
| | python3-pyramid-multiauth | |
| python3-pysqlite2 | | |
| | python3-rdflib | |
| | python3-repoze.lru | |
| python3-simpletal | | |
| | python3-vobject | |
| | python3-waitress | |
| python3-werkzeug | | |
| | python3-wsgicors | |
|--------------------------------------------------------------|
| Suggests |
|--------------------------------------------------------------|
| | | python3-pil |
We also lose versioned dependencies which should not really be an issue
for Recommends and Suggests.
# copyright 2017 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr
#
# This file is part of CubicWeb.
#
# CubicWeb is free software: you can redistribute it and/or modify it under the
# terms of the GNU Lesser General Public License as published by the Free
# Software Foundation, either version 2.1 of the License, or (at your option)
# any later version.
#
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
# details.
#
# You should have received a copy of the GNU Lesser General Public License along
# with CubicWeb. If not, see <http://www.gnu.org/licenses/>.
"""Tests for cubicweb.pyramid.config module."""
import os
from os import path
from tempfile import TemporaryDirectory
from unittest import TestCase
from unittest.mock import patch
from cubicweb.pyramid import config
from cubicweb.pyramid.pyramidctl import _generate_pyramid_ini_file
class PyramidConfigTC(TestCase):
def test_get_random_secret_key(self):
with patch('random.SystemRandom.choice', return_value='0') as patched_choice:
secret = config.get_random_secret_key()
self.assertEqual(patched_choice.call_count, 50)
self.assertEqual(secret, '0' * 50)
def test_write_pyramid_ini(self):
with TemporaryDirectory() as instancedir:
pyramid_ini_path = path.join(instancedir, "pyramid.ini")
with patch('random.SystemRandom.choice', return_value='0') as patched_choice:
_generate_pyramid_ini_file(pyramid_ini_path)
with open(path.join(instancedir, 'pyramid.ini')) as f:
lines = f.readlines()
self.assertEqual(patched_choice.call_count, 50 * 3)
secret = '0' * 50
for option in ('cubicweb.session.secret',
'cubicweb.auth.authtkt.persistent.secret',
'cubicweb.auth.authtkt.session.secret'):
self.assertIn('{} = {}\n'.format(option, secret), lines)
for option in ('cubicweb.auth.authtkt.persistent.secure',
'cubicweb.auth.authtkt.session.secure'):
self.assertIn('{} = {}\n'.format(option, "no"), lines)
def test_write_development_ini(self):
with TemporaryDirectory() as instancedir:
appid = 'pyramid-instance'
os.makedirs(path.join(instancedir, appid))
os.environ['CW_INSTANCES_DIR'] = instancedir
try:
cfg = config.CubicWebPyramidConfiguration(appid)
with patch('random.SystemRandom.choice', return_value='0') as patched_choice:
cfg.write_development_ini(['foo', 'bar'])
finally:
os.environ.pop('CW_INSTANCES_DIR')
with open(path.join(instancedir, appid, 'development.ini')) as f:
lines = f.readlines()
self.assertEqual(patched_choice.call_count, 50 * 3)
secret = '0' * 50
for option in ('cubicweb.session.secret',
'cubicweb.auth.authtkt.persistent.secret',
'cubicweb.auth.authtkt.session.secret'):
self.assertIn('{} = {}\n'.format(option, secret), lines)
self.assertIn('cubicweb.instance = {}\n'.format(appid), lines)
self.assertIn(' cubicweb_foo\n', lines)
if __name__ == '__main__':
import unittest
unittest.main()