Make the GROUP_CONCAT aggregate function not repeat values (closes #3223975)
Work on sets instead of arrays, so if the same value appears twice it's
not repeated in the concatenated output.
This patch handles the postgresql and sqlite backends, mysql is left
alone at this point (seems doable, but I don't have time or motivation
to fix and test it).
# copyright 2003-2011 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr
#
# This file is part of CubicWeb.
#
# CubicWeb is free software: you can redistribute it and/or modify it under the
# terms of the GNU Lesser General Public License as published by the Free
# Software Foundation, either version 2.1 of the License, or (at your option)
# any later version.
#
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more
# details.
#
# You should have received a copy of the GNU Lesser General Public License along
# with CubicWeb. If not, see <http://www.gnu.org/licenses/>.
from logilab.common.testlib import unittest_main
from logilab.mtconverter import html_unescape
from cubicweb.devtools.testlib import CubicWebTC
from cubicweb.utils import json
from cubicweb.view import StartupView, TRANSITIONAL_DOCTYPE
from cubicweb.web.htmlwidgets import TableWidget
from cubicweb.web.views import vid_from_rset
def loadjson(value):
return json.loads(html_unescape(value))
class VidFromRsetTC(CubicWebTC):
def test_no_rset(self):
req = self.request()
self.assertEqual(vid_from_rset(req, None, self.schema), 'index')
def test_no_entity(self):
req = self.request()
rset = self.execute('Any X WHERE X login "blabla"')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'noresult')
def test_one_entity(self):
req = self.request()
rset = self.execute('Any X WHERE X login "admin"')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'primary')
rset = self.execute('Any X, L WHERE X login "admin", X login L')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'primary')
req.search_state = ('pasnormal',)
rset = self.execute('Any X WHERE X login "admin"')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'outofcontext-search')
def test_one_entity_eid(self):
req = self.request()
rset = self.execute('Any X WHERE X eid 1')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'primary')
def test_more_than_one_entity_same_type(self):
req = self.request()
rset = self.execute('Any X WHERE X is CWUser')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'sameetypelist')
rset = self.execute('Any X, L WHERE X login L')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'sameetypelist')
def test_more_than_one_entity_diff_type(self):
req = self.request()
rset = self.execute('Any X WHERE X is IN (CWUser, CWGroup)')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'list')
def test_more_than_one_entity_by_row(self):
req = self.request()
rset = self.execute('Any X, G WHERE X in_group G')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'table')
def test_more_than_one_entity_by_row_2(self):
req = self.request()
rset = self.execute('Any X, GN WHERE X in_group G, G name GN')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'table')
def test_aggregat(self):
req = self.request()
rset = self.execute('Any X, COUNT(T) GROUPBY X WHERE X is T')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'table')
rset = self.execute('Any MAX(X) WHERE X is CWUser')
self.assertEqual(vid_from_rset(req, rset, self.schema), 'table')
def test_subquery(self):
rset = self.execute(
'DISTINCT Any X,N ORDERBY N '
'WITH X,N BEING ('
' (DISTINCT Any P,N WHERE P is CWUser, P login N)'
' UNION'
' (DISTINCT Any W,N WHERE W is CWGroup, W name N))')
req = self.request()
self.assertEqual(vid_from_rset(req, rset, self.schema), 'table')
class TableViewTC(CubicWebTC):
def _prepare_entity(self):
req = self.request()
e = req.create_entity("State", name=u'<toto>', description=u'loo"ong blabla')
rset = req.execute('Any X, D, CD, NOW - CD WHERE X is State, X description D, X creation_date CD, X eid %(x)s',
{'x': e.eid})
view = self.vreg['views'].select('table', req, rset=rset)
return e, rset, view
def test_headers(self):
self.skipTest('implement me')
def test_sortvalue(self):
e, _, view = self._prepare_entity()
colrenderers = view.build_column_renderers()[:3]
self.assertListEqual([renderer.sortvalue(0) for renderer in colrenderers],
[u'<toto>', u'loo"ong blabla', e.creation_date])
# XXX sqlite does not handle Interval correctly
# value = loadjson(view.sortvalue(0, 3))
# self.assertAlmostEquals(value, rset.rows[0][3].seconds)
class HTMLStreamTests(CubicWebTC):
def test_set_doctype_reset_xmldecl(self):
"""
tests `cubicweb.web.request.CubicWebRequestBase.set_doctype`
with xmldecl reset
"""
class MyView(StartupView):
__regid__ = 'my-view'
def call(self):
self._cw.set_doctype('<!DOCTYPE html>')
with self.temporary_appobjects(MyView):
html_source = self.view('my-view').source
source_lines = [line.strip() for line in html_source.splitlines(False)
if line.strip()]
self.assertListEqual(['<!DOCTYPE html>', '<html lang="en">'], source_lines[:2])
def test_set_doctype_no_reset_xmldecl(self):
"""
tests `cubicweb.web.request.CubicWebRequestBase.set_doctype`
with no xmldecl reset
"""
html_doctype = TRANSITIONAL_DOCTYPE.strip()
class MyView(StartupView):
__regid__ = 'my-view'
def call(self):
self._cw.set_doctype(html_doctype)
self._cw.main_stream.set_htmlattrs([('lang', 'cz')])
with self.temporary_appobjects(MyView):
html_source = self.view('my-view').source
source_lines = [line.strip() for line in html_source.splitlines(False)
if line.strip()]
self.assertListEqual([html_doctype, '<html lang="cz">', '<head>'],
source_lines[:3])
if __name__ == '__main__':
unittest_main()