[server/session] add missing rollback when freeing a db connection
When we let go of a cnxset and give it back to the pool, we need to make
sure it's not in the middle of a transaction.
We got bitten by a migration where the connection used by admin's
repo.connect was not rolled back before attempting the migration,
causing a deadlock because it had a lock on a table. This could
potentially also be an issue for e.g. hooks or looping tasks that didn't
explicitly rollback before calling free_cnxset or moving out of a
ensure_cnx_set block.
function datetuple(d) {
return [d.getFullYear(), d.getMonth()+1, d.getDate(),
d.getHours(), d.getMinutes()];
}
function pprint(obj) {
print('{');
for(k in obj) {
print(' ' + k + ' = ' + obj[k]);
}
print('}');
}
function arrayrepr(array) {
return '[' + array.join(', ') + ']';
}
function assertArrayEquals(array1, array2) {
if (array1.length != array2.length) {
throw new crosscheck.AssertionFailure(array1.join(', ') + ' != ' + array2.join(', '));
}
for (var i=0; i<array1.length; i++) {
if (array1[i] != array2[i]) {
throw new crosscheck.AssertionFailure(arrayrepr(array1) + ' and ' + arrayrepr(array2)
+ ' differs at index ' + i);
}
}
}