[server/session] add missing rollback when freeing a db connection
When we let go of a cnxset and give it back to the pool, we need to make
sure it's not in the middle of a transaction.
We got bitten by a migration where the connection used by admin's
repo.connect was not rolled back before attempting the migration,
causing a deadlock because it had a lock on a table. This could
potentially also be an issue for e.g. hooks or looping tasks that didn't
explicitly rollback before calling free_cnxset or moving out of a
ensure_cnx_set block.
Javascript Coding Standards
---------------------------
(Draft, to be continued)
:Naming: camelCase, except for CONSTANTS
Indentation rules
~~~~~~~~~~~~~~~~~
- espace avant accolade ouvrante
- retour à la ligne après accolade ouvrante (éventuellement pas
de retour à la ligne s'il y a tout sur la même ligne, mais ce n'est
pas le cas ici.
- no tabs
Documentation
~~~~~~~~~~~~~
XXX explain comment format for documentation generation
Coding
~~~~~~
- Don't forget 'var' before variable definition, and semi-colon (';') after **each** statement.
- Check the firebug console for deprecation warnings
API usage
~~~~~~~~~
- unless intended, use jQuery('container') rather than jqNode('container')
See also
~~~~~~~~
http://google-styleguide.googlecode.com/svn/trunk/javascriptguide.xml