[server/session] add missing rollback when freeing a db connection
When we let go of a cnxset and give it back to the pool, we need to make
sure it's not in the middle of a transaction.
We got bitten by a migration where the connection used by admin's
repo.connect was not rolled back before attempting the migration,
causing a deadlock because it had a lock on a table. This could
potentially also be an issue for e.g. hooks or looping tasks that didn't
explicitly rollback before calling free_cnxset or moving out of a
ensure_cnx_set block.
CSS Coding Standards
--------------------
(Draft, to be continued)
:Naming: camelCase
Indentation rules
~~~~~~~~~~~~~~~~~
- 2 espaces avant les propriétés
- pas d'espace avant les ":", un espace après
- 1 seul espace entre les différentes valeurs pour une même propriété
Documentation
~~~~~~~~~~~~~
Please keep rules semantically linked grouped together, with a comment about
what they are for.
Recommendation
~~~~~~~~~~~~~~
- Try to use existing classes rather than introduce new ones
- Keep things as simple as possible while in the framework
- Think about later customization by application
- Avoid introducing a new CSS file for a few lines of CSS, at least while the
framework doesn't include packing functionalities