--- a/server/msplanner.py Fri Feb 26 13:12:01 2010 +0100
+++ b/server/msplanner.py Fri Feb 26 13:19:14 2010 +0100
@@ -90,7 +90,6 @@
from cubicweb.server.ssplanner import (SSPlanner, OneFetchStep,
add_types_restriction)
from cubicweb.server.mssteps import *
-from cubicweb.server.sources import AbstractSource
Variable._ms_table_key = lambda x: x.name
Relation._ms_table_key = lambda x: x.r_type
@@ -465,7 +464,7 @@
try:
lhsv = self._extern_term(lhs, termssources, inserted)
rhsv = self._extern_term(rhs, termssources, inserted)
- except KeyError, ex:
+ except KeyError:
continue
self._remove_term_sources(lhsv, rel, rhsv, termssources)
self._remove_term_sources(rhsv, rel, lhsv, termssources)
@@ -857,7 +856,6 @@
terms = [term]
sources = sorted(sources)
sourcesterms = self._sourcesterms
- nbunlinked = 1
linkedterms = self._linkedterms
# term has to belong to the same scope if there is more
# than the system source remaining
@@ -873,7 +871,7 @@
for source in sources:
cross_rels.update(self._crossrelations.get(source, {}))
exclude = {}
- for rel, crossvars in cross_rels.iteritems():
+ for crossvars in cross_rels.itervalues():
vars = [t for t in crossvars if isinstance(t, Variable)]
try:
exclude[vars[0]] = vars[1]
@@ -897,7 +895,6 @@
modified = False
for term in candidates[:]:
if isinstance(term, Constant):
- relation = term.relation()
if sorted(set(x[0] for x in self._term_sources(term))) != sources:
continue
terms.append(term)
@@ -1023,12 +1020,6 @@
if server.DEBUG & server.DBG_MS:
print '-'*80
print 'PLANNING', rqlst
- for select in rqlst.children:
- if len(select.solutions) > 1:
- hasmultiplesols = True
- break
- else:
- hasmultiplesols = False
# preprocess deals with security insertion and returns a new syntax tree
# which have to be executed to fulfill the query: according
# to permissions for variable's type, different rql queries may have to