cubicweb: comparison repoapi.py

equal deleted inserted replaced

-:b7f7aa1b1123
+:8a1132c7cbd1
 from cubicweb.utils import parse_repo_uri
 from cubicweb import ConnectionError, ProgrammingError, AuthenticationError
 from uuid import uuid4
 from contextlib import contextmanager
 from cubicweb.req import RequestSessionBase
+from functools import wraps
 ### private function for specific method ############################
 def _get_inmemory_repo(config, vreg=None):
 from cubicweb.server.repository import Repository
 def proxy(clt_cnx, *args, **kwargs):
 # the ``with`` dance is transitional. We do not have Standalone
 # Connection yet so we use this trick to unsure the session have the
 # proper cnx loaded. This can be simplified one we have Standalone
 # Connection object
+if not clt_cnx._open:
+raise ProgrammingError('Closed client connection')
 with clt_cnx._srv_cnx as cnx:
 return getattr(cnx, name)(*args, **kwargs)
 return proxy
+def _open_only(func):
+"""decorator for ClientConnection method that check it is open"""
+@wraps(func)
+def check_open(clt_cnx, *args, **kwargs):
+if not clt_cnx._open:
+raise ProgrammingError('Closed client connection')
+return func(clt_cnx, *args, **kwargs)
+return check_open
 class ClientConnection(RequestSessionBase):
 """A Connection object to be used Client side.
 This object is aimed to be used client side (so potential communication
 # Main Connection purpose in life #########################################
 call_service = _srv_cnx_func('call_service')
+@_open_only
 def execute(self, *args, **kwargs):
 # the ``with`` dance is transitional. We do not have Standalone
 # Connection yet so we use this trick to unsure the session have the
 # proper cnx loaded. This can be simplified one we have Standalone
 # Connection object
 get_shared_data = _srv_cnx_func('get_shared_data')
 set_shared_data = _srv_cnx_func('set_shared_data')
 # meta-data accessors ######################################################
+@_open_only
 def source_defs(self):
 """Return the definition of sources used by the repository."""
 return self._session.repo.source_defs()
+@_open_only
 def get_schema(self):
 """Return the schema currently used by the repository."""
 return self._session.repo.source_defs()
+@_open_only
 def get_option_value(self, option, foreid=None):
 """Return the value for `option` in the configuration. If `foreid` is
 specified, the actual repository to which this entity belongs is
 dereferenced and the option value retrieved from it.
 """
 describe = _srv_cnx_func('describe')
 # undo support ############################################################
+@_open_only
 def undoable_transactions(self, ueid=None, req=None, **actionfilters):
 """Return a list of undoable transaction objects by the connection's
 user, ordered by descendant transaction time.
 Managers may filter according to user (eid) who has done the transaction
 txinfos = source.undoable_transactions(cnx, ueid, **actionfilters)
 for txinfo in txinfos:
 txinfo.req = req or self  # XXX mostly wrong
 return txinfos
+@_open_only
 def transaction_info(self, txuuid, req=None):
 """Return transaction object for the given uid.
 raise `NoSuchTransaction` if not found or if session's user is not
 allowed (eg not in managers group and the transaction doesn't belong to
 txinfo.req = req
 else:
 txinfo.cnx = self
 return txinfo
+@_open_only
 def transaction_actions(self, txuuid, public=True):
 """Return an ordered list of action effectued during that transaction.
 If public is true, return only 'public' actions, eg not ones triggered
 under the cover by hooks, else return all actions.
 # proper cnx loaded. This can be simplified one we have Standalone
 # Connection object
 with self._srv_cnx as cnx:
 return cnx.repo.system_source.tx_actions(cnx, txuuid, public)
+@_open_only
 def undo_transaction(self, txuuid):
 """Undo the given transaction. Return potential restoration errors.
 raise `NoSuchTransaction` if not found or if session's user is not
 allowed (eg not in managers group and the transaction doesn't belong to

changeset 9100	8a1132c7cbd1
parent 9099	b7f7aa1b1123
child 9101	e6d1df619949