rqlrewrite: remove element in rewritten when we remove them from the select (closes #2236985) update _cleanup_inserted to avoid leaving rewritten variable behind when removing a snipset. insert_varmap_snippets was impacted too for unclear reason --- Before A KeyError was raised when: * multiple snipset is to be inserted on a statement * some *supported* snipset adds ambiguity (increase the number of solution) * some *unsupported* snipset adds new variable * The new variable require rewritting :: File "/home/pyves/src/fcw/cubicweb/rqlrewrite.py", line 185, in rewrite newsolutions = self.remove_ambiguities(snippets, newsolutions) File "/home/pyves/src/fcw/cubicweb/rqlrewrite.py", line 436, in remove_ambiguities variantes = self.build_variantes(newsolutions) File "/home/pyves/src/fcw/cubicweb/devtools/repotest.py", line 340, in _build_variantes variantes = _orig_build_variantes(self, newsolutions) File "/home/pyves/src/fcw/cubicweb/rqlrewrite.py", line 470, in build_variantes variante.append( (key, sol[newvar]) ) KeyError: u'D' This happen because the mechanism removing unsupported snipset does not remove entry in ``self.rewritten`` when it removes entry from ``self.select.defined_vars``. Iteration on ``self.rewritten`` then crash because values of ``rewritten`` are expected to be found in solution.

     1

#!/bin/sh -e

     2

     3

### BEGIN INIT INFO

     4

# Provides:          cubicweb

     5

# Required-Start:    $remote_fs $syslog $local_fs $network

     6

# Required-Stop:     $remote_fs $syslog $local_fs $network

     7

# Should-Start:      postgresql pyro-nsd

     8

# Should-Stop:       postgresql pyro-nsd

     9

# Default-Start:     2 3 4 5

    10

# Default-Stop:      0 1 6

    11

# Short-Description: Start cubicweb application at boot time

    12

### END INIT INFO

    13

    14

# FIXME Seems to be inadequate here

    15

# FIXME If related to pyro, try instead:

    16

# export PYRO_STORAGE="/tmp"

    17

cd /tmp

    18

    19

# FIXME Work-around about the following lintian error

    20

#     E: cubicweb-ctl: init.d-script-does-not-implement-required-option /etc/init.d/cubicweb start

    21

#

    22

# Check if we are sure to not want the start-stop-daemon machinery here

    23

# Refer to Debian Policy Manual section 9.3.2 (Writing the scripts) for details.

    24

    25

case $1 in

    26

    force-reload)

    27

        python -W ignore /usr/bin/cubicweb-ctl reload --force

    28

        ;;

    29

    status)

    30

        python -W ignore /usr/bin/cubicweb-ctl status

    31

        ;;

    32

    start|stop|restart|*)

    33

        python -W ignore /usr/bin/cubicweb-ctl $1 --force

    34

        ;;

    35

esac