author | Nicolas Chauvat <nicolas.chauvat@logilab.fr> |
Fri, 25 Sep 2009 20:49:41 +0200 | |
branch | stable |
changeset 3486 | ea6bf6f9ba0c |
parent 3309 | 2538daa6651c |
child 3369 | 7b88d12b4ee2 |
child 3631 | 6176ef2f6488 |
permissions | -rw-r--r-- |
0 | 1 |
"""The edit controller, handling form submitting. |
2 |
||
3 |
:organization: Logilab |
|
1977
606923dff11b
big bunch of copyright / docstring update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
1948
diff
changeset
|
4 |
:copyright: 2001-2009 LOGILAB S.A. (Paris, FRANCE), license is LGPL v2. |
0 | 5 |
:contact: http://www.logilab.fr/ -- mailto:contact@logilab.fr |
1977
606923dff11b
big bunch of copyright / docstring update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
1948
diff
changeset
|
6 |
:license: GNU Lesser General Public License, v2.1 - http://www.gnu.org/licenses |
0 | 7 |
""" |
8 |
__docformat__ = "restructuredtext en" |
|
1948 | 9 |
|
0 | 10 |
from decimal import Decimal |
11 |
||
12 |
from rql.utils import rqlvar_maker |
|
13 |
||
14 |
from cubicweb import Binary, ValidationError, typed_eid |
|
15 |
from cubicweb.web import INTERNAL_FIELD_VALUE, RequestError, NothingToEdit |
|
16 |
from cubicweb.web.controller import parse_relations_descr |
|
17 |
from cubicweb.web.views.basecontrollers import ViewController |
|
18 |
||
19 |
||
20 |
class ToDoLater(Exception): |
|
21 |
"""exception used in the edit controller to indicate that a relation |
|
22 |
can't be handled right now and have to be handled later |
|
23 |
""" |
|
24 |
||
25 |
class EditController(ViewController): |
|
26 |
id = 'edit' |
|
27 |
||
2255
c346af0727ca
more generic way to detect json requests (not yet perfect though)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
28 |
def publish(self, rset=None): |
0 | 29 |
"""edit / create / copy / delete entity / relations""" |
884 | 30 |
for key in self.req.form: |
0 | 31 |
# There should be 0 or 1 action |
32 |
if key.startswith('__action_'): |
|
33 |
cbname = key[1:] |
|
34 |
try: |
|
35 |
callback = getattr(self, cbname) |
|
36 |
except AttributeError: |
|
884 | 37 |
raise RequestError(self.req._('invalid action %r' % key)) |
0 | 38 |
else: |
39 |
return callback() |
|
40 |
self._default_publish() |
|
41 |
self.reset() |
|
42 |
||
43 |
def _default_publish(self): |
|
44 |
req = self.req |
|
45 |
form = req.form |
|
46 |
# no specific action, generic edition |
|
47 |
self._to_create = req.data['eidmap'] = {} |
|
48 |
self._pending_relations = [] |
|
49 |
todelete = self.req.get_pending_deletes() |
|
50 |
toinsert = self.req.get_pending_inserts() |
|
51 |
try: |
|
52 |
methodname = form.pop('__method', None) |
|
53 |
for eid in req.edited_eids(): |
|
3309
2538daa6651c
we may have some entity forms with nothing to edit for an entity, no RequestError in that case
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3194
diff
changeset
|
54 |
# __type and eid |
2538daa6651c
we may have some entity forms with nothing to edit for an entity, no RequestError in that case
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3194
diff
changeset
|
55 |
formparams = req.extract_entity_params(eid, minparams=2) |
0 | 56 |
if methodname is not None: |
2680
66472d85d548
[R] use req.entity_from_eid
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2650
diff
changeset
|
57 |
entity = req.entity_from_eid(eid) |
0 | 58 |
method = getattr(entity, methodname) |
59 |
method(formparams) |
|
60 |
eid = self.edit_entity(formparams) |
|
61 |
except (RequestError, NothingToEdit): |
|
62 |
if '__linkto' in form and 'eid' in form: |
|
63 |
self.execute_linkto() |
|
64 |
elif not ('__delete' in form or '__insert' in form or todelete or toinsert): |
|
65 |
raise ValidationError(None, {None: req._('nothing to edit')}) |
|
66 |
# handle relations in newly created entities |
|
67 |
if self._pending_relations: |
|
68 |
for rschema, formparams, x, entity in self._pending_relations: |
|
69 |
self.handle_relation(rschema, formparams, x, entity, True) |
|
1753 | 70 |
|
0 | 71 |
# XXX this processes *all* pending operations of *all* entities |
72 |
if form.has_key('__delete'): |
|
73 |
todelete += req.list_form_param('__delete', form, pop=True) |
|
74 |
if todelete: |
|
75 |
self.delete_relations(parse_relations_descr(todelete)) |
|
76 |
if form.has_key('__insert'): |
|
77 |
toinsert = req.list_form_param('__insert', form, pop=True) |
|
78 |
if toinsert: |
|
79 |
self.insert_relations(parse_relations_descr(toinsert)) |
|
80 |
self.req.remove_pending_operations() |
|
1753 | 81 |
|
0 | 82 |
def edit_entity(self, formparams, multiple=False): |
83 |
"""edit / create / copy an entity and return its eid""" |
|
84 |
etype = formparams['__type'] |
|
2650
18aec79ec3a3
R [vreg] important refactoring of the vregistry, moving behaviour to end dictionnary (and so leaving room for more flexibility ; keep bw compat ; update api usage in cw
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2256
diff
changeset
|
85 |
entity = self.vreg['etypes'].etype_class(etype)(self.req) |
0 | 86 |
entity.eid = eid = self._get_eid(formparams['eid']) |
87 |
edited = self.req.form.get('__maineid') == formparams['eid'] |
|
88 |
# let a chance to do some entity specific stuff. |
|
1753 | 89 |
entity.pre_web_edit() |
0 | 90 |
# create a rql query from parameters |
91 |
self.relations = [] |
|
92 |
self.restrictions = [] |
|
93 |
# process inlined relations at the same time as attributes |
|
94 |
# this is required by some external source such as the svn source which |
|
95 |
# needs some information provided by those inlined relation. Moreover |
|
96 |
# this will generate less write queries. |
|
97 |
for rschema in entity.e_schema.subject_relations(): |
|
98 |
if rschema.is_final(): |
|
99 |
self.handle_attribute(entity, rschema, formparams) |
|
100 |
elif rschema.inlined: |
|
101 |
self.handle_inlined_relation(rschema, formparams, entity) |
|
102 |
execute = self.req.execute |
|
103 |
if eid is None: # creation or copy |
|
1753 | 104 |
if self.relations: |
0 | 105 |
rql = 'INSERT %s X: %s' % (etype, ','.join(self.relations)) |
106 |
else: |
|
107 |
rql = 'INSERT %s X' % etype |
|
108 |
if self.restrictions: |
|
109 |
rql += ' WHERE %s' % ','.join(self.restrictions) |
|
110 |
try: |
|
1753 | 111 |
# get the new entity (in some cases, the type might have |
0 | 112 |
# changed as for the File --> Image mutation) |
113 |
entity = execute(rql, formparams).get_entity(0, 0) |
|
114 |
eid = entity.eid |
|
115 |
except ValidationError, ex: |
|
116 |
self._to_create[formparams['eid']] = ex.entity |
|
2255
c346af0727ca
more generic way to detect json requests (not yet perfect though)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
117 |
if self.req.json_request: # XXX (syt) why? |
0 | 118 |
ex.entity = formparams['eid'] |
119 |
raise |
|
120 |
self._to_create[formparams['eid']] = eid |
|
121 |
elif self.relations: # edition of an existant entity |
|
122 |
varmaker = rqlvar_maker() |
|
123 |
var = varmaker.next() |
|
124 |
while var in formparams: |
|
125 |
var = varmaker.next() |
|
126 |
rql = 'SET %s WHERE X eid %%(%s)s' % (','.join(self.relations), var) |
|
127 |
if self.restrictions: |
|
128 |
rql += ', %s' % ','.join(self.restrictions) |
|
129 |
formparams[var] = eid |
|
130 |
execute(rql, formparams) |
|
131 |
for rschema in entity.e_schema.subject_relations(): |
|
132 |
if rschema.is_final() or rschema.inlined: |
|
133 |
continue |
|
134 |
self.handle_relation(rschema, formparams, 'subject', entity) |
|
135 |
for rschema in entity.e_schema.object_relations(): |
|
136 |
if rschema.is_final(): |
|
137 |
continue |
|
138 |
self.handle_relation(rschema, formparams, 'object', entity) |
|
139 |
if edited: |
|
140 |
self.notify_edited(entity) |
|
141 |
if formparams.has_key('__delete'): |
|
142 |
todelete = self.req.list_form_param('__delete', formparams, pop=True) |
|
143 |
self.delete_relations(parse_relations_descr(todelete)) |
|
144 |
if formparams.has_key('__cloned_eid'): |
|
145 |
entity.copy_relations(formparams['__cloned_eid']) |
|
146 |
if formparams.has_key('__insert'): |
|
147 |
toinsert = self.req.list_form_param('__insert', formparams, pop=True) |
|
148 |
self.insert_relations(parse_relations_descr(toinsert)) |
|
149 |
if edited: # only execute linkto for the main entity |
|
150 |
self.execute_linkto(eid) |
|
151 |
return eid |
|
152 |
||
153 |
def _action_apply(self): |
|
154 |
self._default_publish() |
|
155 |
self.reset() |
|
1753 | 156 |
|
0 | 157 |
def _action_cancel(self): |
158 |
errorurl = self.req.form.get('__errorurl') |
|
159 |
if errorurl: |
|
160 |
self.req.cancel_edition(errorurl) |
|
2998
da622f980470
B #323887 misleading message after hitting cancel form button
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2680
diff
changeset
|
161 |
self.req.message = self.req._('edit canceled') |
0 | 162 |
return self.reset() |
163 |
||
164 |
def _action_delete(self): |
|
165 |
self.delete_entities(self.req.edited_eids(withtype=True)) |
|
166 |
return self.reset() |
|
167 |
||
1162
f210dce0dc47
fix for booelan attribute which have empty string as false value and didn't work if default value for this attribute was True.
Stephanie Marcu <stephanie.marcu@logilab.fr>
parents:
0
diff
changeset
|
168 |
def _needs_edition(self, rtype, formparams, entity): |
0 | 169 |
"""returns True and and the new value if `rtype` was edited""" |
170 |
editkey = 'edits-%s' % rtype |
|
171 |
if not editkey in formparams: |
|
172 |
return False, None # not edited |
|
173 |
value = formparams.get(rtype) or None |
|
1162
f210dce0dc47
fix for booelan attribute which have empty string as false value and didn't work if default value for this attribute was True.
Stephanie Marcu <stephanie.marcu@logilab.fr>
parents:
0
diff
changeset
|
174 |
if entity.has_eid() and (formparams.get(editkey) or None) == value: |
0 | 175 |
return False, None # not modified |
176 |
if value == INTERNAL_FIELD_VALUE: |
|
1753 | 177 |
value = None |
0 | 178 |
return True, value |
179 |
||
180 |
def handle_attribute(self, entity, rschema, formparams): |
|
181 |
"""append to `relations` part of the rql query to edit the |
|
182 |
attribute described by the given schema if necessary |
|
183 |
""" |
|
184 |
attr = rschema.type |
|
1162
f210dce0dc47
fix for booelan attribute which have empty string as false value and didn't work if default value for this attribute was True.
Stephanie Marcu <stephanie.marcu@logilab.fr>
parents:
0
diff
changeset
|
185 |
edition_needed, value = self._needs_edition(attr, formparams, entity) |
0 | 186 |
if not edition_needed: |
187 |
return |
|
188 |
# test if entity class defines a special handler for this attribute |
|
189 |
custom_edit = getattr(entity, 'custom_%s_edit' % attr, None) |
|
190 |
if custom_edit: |
|
191 |
custom_edit(formparams, value, self.relations) |
|
192 |
return |
|
193 |
attrtype = rschema.objects(entity.e_schema)[0].type |
|
194 |
# on checkbox or selection, the field may not be in params |
|
3092
c153b1ae9875
[edition] convert integer and float values coming from edit forms so that values are correctly typed in before_xxx hooks
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
2998
diff
changeset
|
195 |
# NOTE: raising ValidationError here is not a good solution because |
c153b1ae9875
[edition] convert integer and float values coming from edit forms so that values are correctly typed in before_xxx hooks
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
2998
diff
changeset
|
196 |
# we can't gather all errors at once. Hopefully, the new 3.6.x |
c153b1ae9875
[edition] convert integer and float values coming from edit forms so that values are correctly typed in before_xxx hooks
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
2998
diff
changeset
|
197 |
# form handling will fix that |
3164 | 198 |
if attrtype == 'Boolean': |
0 | 199 |
value = bool(value) |
200 |
elif attrtype == 'Decimal': |
|
201 |
value = Decimal(value) |
|
202 |
elif attrtype == 'Bytes': |
|
203 |
# if it is a file, transport it using a Binary (StringIO) |
|
907 | 204 |
# XXX later __detach is for the new widget system, the former is to |
205 |
# be removed once web/widgets.py has been dropped |
|
206 |
if formparams.has_key('__%s_detach' % attr) or formparams.has_key('%s__detach' % attr): |
|
0 | 207 |
# drop current file value |
208 |
value = None |
|
1101
0c067de38e46
unification of meta-attributes handling:
sylvain.thenault@logilab.fr
parents:
907
diff
changeset
|
209 |
# no need to check value when nor explicit detach nor new file |
0c067de38e46
unification of meta-attributes handling:
sylvain.thenault@logilab.fr
parents:
907
diff
changeset
|
210 |
# submitted, since it will think the attribute is not modified |
0 | 211 |
elif isinstance(value, unicode): |
212 |
# file modified using a text widget |
|
1360
13ae1121835e
rename attribute_metadata method to attr_metadata to save a few chars
sylvain.thenault@logilab.fr
parents:
1263
diff
changeset
|
213 |
encoding = entity.attr_metadata(attr, 'encoding') |
13ae1121835e
rename attribute_metadata method to attr_metadata to save a few chars
sylvain.thenault@logilab.fr
parents:
1263
diff
changeset
|
214 |
value = Binary(value.encode(encoding)) |
1765
a25c7c73c8f6
check a file is submitted first
sylvain.thenault@logilab.fr
parents:
1753
diff
changeset
|
215 |
elif value: |
1361
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
216 |
# value is a 3-uple (filename, mimetype, stream) |
0 | 217 |
val = Binary(value[2].read()) |
218 |
if not val.getvalue(): # usually an unexistant file |
|
219 |
value = None |
|
220 |
else: |
|
221 |
val.filename = value[0] |
|
1361
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
222 |
# ignore browser submitted MIME type since it may be buggy |
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
223 |
# XXX add a config option to tell if we should consider it |
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
224 |
# or not? |
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
225 |
#if entity.e_schema.has_metadata(attr, 'format'): |
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
226 |
# key = '%s_format' % attr |
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
227 |
# formparams[key] = value[1] |
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
228 |
# self.relations.append('X %s_format %%(%s)s' |
c558a88bb85d
ignore browser submitted values for file's MIME type
sylvain.thenault@logilab.fr
parents:
1360
diff
changeset
|
229 |
# % (attr, key)) |
1101
0c067de38e46
unification of meta-attributes handling:
sylvain.thenault@logilab.fr
parents:
907
diff
changeset
|
230 |
# XXX suppose a File compatible schema |
0 | 231 |
if entity.e_schema.has_subject_relation('name') \ |
232 |
and not formparams.get('name'): |
|
233 |
formparams['name'] = value[0] |
|
234 |
self.relations.append('X name %(name)s') |
|
235 |
value = val |
|
1940
2565aae48d48
fix so that one can edit an entity with a Bytes field without specifying a new file
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1802
diff
changeset
|
236 |
else: |
2565aae48d48
fix so that one can edit an entity with a Bytes field without specifying a new file
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1802
diff
changeset
|
237 |
# no specified value, skip |
2565aae48d48
fix so that one can edit an entity with a Bytes field without specifying a new file
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1802
diff
changeset
|
238 |
return |
0 | 239 |
elif value is not None: |
3164 | 240 |
if attrtype == 'Int': |
241 |
try: |
|
242 |
value = int(value) |
|
243 |
except ValueError: |
|
244 |
raise ValidationError(entity.eid, |
|
245 |
{attr: self.req._("invalid integer value")}) |
|
246 |
elif attrtype == 'Float': |
|
247 |
try: |
|
248 |
value = float(value) |
|
249 |
except ValueError: |
|
250 |
raise ValidationError(entity.eid, |
|
251 |
{attr: self.req._("invalid float value")}) |
|
3194
650637d4d764
[controllers] fix bad if/elif switch in handle_attribute
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
3164
diff
changeset
|
252 |
elif attrtype in ('Date', 'Datetime', 'Time'): |
0 | 253 |
try: |
254 |
value = self.parse_datetime(value, attrtype) |
|
255 |
except ValueError: |
|
256 |
raise ValidationError(entity.eid, |
|
257 |
{attr: self.req._("invalid date")}) |
|
258 |
elif attrtype == 'Password': |
|
259 |
# check confirmation (see PasswordWidget for confirmation field name) |
|
260 |
confirmval = formparams.get(attr + '-confirm') |
|
261 |
if confirmval != value: |
|
262 |
raise ValidationError(entity.eid, |
|
263 |
{attr: self.req._("password and confirmation don't match")}) |
|
264 |
# password should *always* be utf8 encoded |
|
265 |
value = value.encode('UTF8') |
|
266 |
else: |
|
267 |
# strip strings |
|
268 |
value = value.strip() |
|
269 |
elif attrtype == 'Password': |
|
270 |
# skip None password |
|
271 |
return # unset password |
|
272 |
formparams[attr] = value |
|
273 |
self.relations.append('X %s %%(%s)s' % (attr, attr)) |
|
274 |
||
275 |
def _relation_values(self, rschema, formparams, x, entity, late=False): |
|
276 |
"""handle edition for the (rschema, x) relation of the given entity |
|
277 |
""" |
|
278 |
rtype = rschema.type |
|
279 |
editkey = 'edit%s-%s' % (x[0], rtype) |
|
280 |
if not editkey in formparams: |
|
281 |
return # not edited |
|
282 |
try: |
|
283 |
values = self._linked_eids(self.req.list_form_param(rtype, formparams), late) |
|
284 |
except ToDoLater: |
|
285 |
self._pending_relations.append((rschema, formparams, x, entity)) |
|
286 |
return |
|
287 |
origvalues = set(typed_eid(eid) for eid in self.req.list_form_param(editkey, formparams)) |
|
288 |
return values, origvalues |
|
289 |
||
290 |
def handle_inlined_relation(self, rschema, formparams, entity, late=False): |
|
291 |
"""handle edition for the (rschema, x) relation of the given entity |
|
292 |
""" |
|
293 |
try: |
|
294 |
values, origvalues = self._relation_values(rschema, formparams, |
|
295 |
'subject', entity, late) |
|
296 |
except TypeError: |
|
297 |
return # not edited / to do later |
|
298 |
if values == origvalues: |
|
299 |
return # not modified |
|
300 |
attr = str(rschema) |
|
301 |
if values: |
|
302 |
formparams[attr] = iter(values).next() |
|
303 |
self.relations.append('X %s %s' % (attr, attr.upper())) |
|
304 |
self.restrictions.append('%s eid %%(%s)s' % (attr.upper(), attr)) |
|
305 |
elif entity.has_eid(): |
|
306 |
self.handle_relation(rschema, formparams, 'subject', entity, late) |
|
1753 | 307 |
|
0 | 308 |
def handle_relation(self, rschema, formparams, x, entity, late=False): |
309 |
"""handle edition for the (rschema, x) relation of the given entity |
|
310 |
""" |
|
311 |
try: |
|
312 |
values, origvalues = self._relation_values(rschema, formparams, x, |
|
313 |
entity, late) |
|
314 |
except TypeError: |
|
315 |
return # not edited / to do later |
|
316 |
etype = entity.e_schema |
|
317 |
if values == origvalues: |
|
318 |
return # not modified |
|
319 |
if x == 'subject': |
|
320 |
desttype = rschema.objects(etype)[0] |
|
321 |
card = rschema.rproperty(etype, desttype, 'cardinality')[0] |
|
322 |
subjvar, objvar = 'X', 'Y' |
|
323 |
else: |
|
324 |
desttype = rschema.subjects(etype)[0] |
|
325 |
card = rschema.rproperty(desttype, etype, 'cardinality')[1] |
|
326 |
subjvar, objvar = 'Y', 'X' |
|
327 |
eid = entity.eid |
|
328 |
if x == 'object' or not rschema.inlined or not values: |
|
329 |
# this is not an inlined relation or no values specified, |
|
330 |
# explicty remove relations |
|
1798
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
331 |
rql = 'DELETE %s %s %s WHERE X eid %%(x)s, Y eid %%(y)s' % ( |
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
332 |
subjvar, rschema, objvar) |
0 | 333 |
for reid in origvalues.difference(values): |
334 |
self.req.execute(rql, {'x': eid, 'y': reid}, ('x', 'y')) |
|
1798
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
335 |
seteids = values.difference(origvalues) |
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
336 |
if seteids: |
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
337 |
rql = 'SET %s %s %s WHERE X eid %%(x)s, Y eid %%(y)s' % ( |
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
338 |
subjvar, rschema, objvar) |
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
339 |
for reid in seteids: |
cc86fe8efaaa
pass default values along the whole call chain, fix hidden field update bug
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
1765
diff
changeset
|
340 |
self.req.execute(rql, {'x': eid, 'y': reid}, ('x', 'y')) |
1753 | 341 |
|
0 | 342 |
def _get_eid(self, eid): |
343 |
# should be either an int (existant entity) or a variable (to be |
|
344 |
# created entity) |
|
345 |
assert eid or eid == 0, repr(eid) # 0 is a valid eid |
|
346 |
try: |
|
347 |
return typed_eid(eid) |
|
348 |
except ValueError: |
|
349 |
try: |
|
350 |
return self._to_create[eid] |
|
351 |
except KeyError: |
|
352 |
self._to_create[eid] = None |
|
353 |
return None |
|
354 |
||
355 |
def _linked_eids(self, eids, late=False): |
|
356 |
"""return a list of eids if they are all known, else raise ToDoLater |
|
357 |
""" |
|
358 |
result = set() |
|
359 |
for eid in eids: |
|
360 |
if not eid: # AutoCompletionWidget |
|
361 |
continue |
|
362 |
eid = self._get_eid(eid) |
|
363 |
if eid is None: |
|
364 |
if not late: |
|
365 |
raise ToDoLater() |
|
366 |
# eid is still None while it's already a late call |
|
367 |
# this mean that the associated entity has not been created |
|
368 |
raise Exception('duh') |
|
369 |
result.add(eid) |
|
370 |
return result |
|
371 |
||
1753 | 372 |