author | Julien Cristau <julien.cristau@logilab.fr> |
Fri, 10 Jan 2014 17:12:20 +0100 | |
changeset 9396 | e83cbc116352 |
parent 9294 | 769b8867f8ce |
child 9740 | c0239d8ae742 |
child 9829 | e0e71b45bf8d |
permissions | -rw-r--r-- |
7815
2a164a9cf81c
[exceptions] stop catching any exception in various places (closes #1942716)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7576
diff
changeset
|
1 |
# copyright 2003-2011 LOGILAB S.A. (Paris, FRANCE), all rights reserved. |
5421
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
2 |
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
3 |
# |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
4 |
# This file is part of CubicWeb. |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
5 |
# |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
6 |
# CubicWeb is free software: you can redistribute it and/or modify it under the |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
7 |
# terms of the GNU Lesser General Public License as published by the Free |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
8 |
# Software Foundation, either version 2.1 of the License, or (at your option) |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
9 |
# any later version. |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
10 |
# |
5424
8ecbcbff9777
replace logilab-common by CubicWeb in disclaimer
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5421
diff
changeset
|
11 |
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT |
5421
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
12 |
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
13 |
# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
14 |
# details. |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
15 |
# |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
16 |
# You should have received a copy of the GNU Lesser General Public License along |
8167de96c523
proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
17 |
# with CubicWeb. If not, see <http://www.gnu.org/licenses/>. |
5967 | 18 |
"""utilities for instances migration""" |
0 | 19 |
|
20 |
__docformat__ = "restructuredtext en" |
|
21 |
||
22 |
import sys |
|
23 |
import os |
|
24 |
import logging |
|
2446
440cb4ea7e5c
[refactor] #342855: replace uses of (deprecated) mktemp
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2275
diff
changeset
|
25 |
import tempfile |
0 | 26 |
from os.path import exists, join, basename, splitext |
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
27 |
from itertools import chain |
0 | 28 |
|
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
29 |
from logilab.common import IGNORED_EXTENSIONS |
0 | 30 |
from logilab.common.decorators import cached |
31 |
from logilab.common.configuration import REQUIRED, read_old_config |
|
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
32 |
from logilab.common.shellutils import ASK |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
33 |
from logilab.common.changelog import Version |
0 | 34 |
|
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
35 |
from cubicweb import ConfigurationError, ExecutionError |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
36 |
from cubicweb.cwconfig import CubicWebConfiguration as cwcfg |
8056
8909800a8c51
[cleanup] drop some appengine support junk
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7879
diff
changeset
|
37 |
from cubicweb.toolsutils import show_diffs |
0 | 38 |
|
39 |
def filter_scripts(config, directory, fromversion, toversion, quiet=True): |
|
40 |
"""return a list of paths of migration files to consider to upgrade |
|
41 |
from a version to a greater one |
|
42 |
""" |
|
43 |
from logilab.common.changelog import Version # doesn't work with appengine |
|
44 |
assert fromversion |
|
45 |
assert toversion |
|
46 |
assert isinstance(fromversion, tuple), fromversion.__class__ |
|
47 |
assert isinstance(toversion, tuple), toversion.__class__ |
|
48 |
assert fromversion <= toversion, (fromversion, toversion) |
|
49 |
if not exists(directory): |
|
50 |
if not quiet: |
|
51 |
print directory, "doesn't exists, no migration path" |
|
52 |
return [] |
|
53 |
if fromversion == toversion: |
|
54 |
return [] |
|
55 |
result = [] |
|
56 |
for fname in os.listdir(directory): |
|
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
57 |
if fname.endswith(IGNORED_EXTENSIONS): |
0 | 58 |
continue |
59 |
fpath = join(directory, fname) |
|
60 |
try: |
|
61 |
tver, mode = fname.split('_', 1) |
|
62 |
except ValueError: |
|
63 |
continue |
|
64 |
mode = mode.split('.', 1)[0] |
|
65 |
if not config.accept_mode(mode): |
|
66 |
continue |
|
67 |
try: |
|
68 |
tver = Version(tver) |
|
69 |
except ValueError: |
|
70 |
continue |
|
71 |
if tver <= fromversion: |
|
72 |
continue |
|
73 |
if tver > toversion: |
|
74 |
continue |
|
75 |
result.append((tver, fpath)) |
|
76 |
# be sure scripts are executed in order |
|
77 |
return sorted(result) |
|
78 |
||
79 |
||
80 |
def execscript_confirm(scriptpath): |
|
81 |
"""asks for confirmation before executing a script and provides the |
|
82 |
ability to show the script's content |
|
83 |
""" |
|
84 |
while True: |
|
4553
23201259ffeb
[migration] abort becomes possible when asked for confirmation before migration script
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
4252
diff
changeset
|
85 |
answer = ASK.ask('Execute %r ?' % scriptpath, |
23201259ffeb
[migration] abort becomes possible when asked for confirmation before migration script
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
4252
diff
changeset
|
86 |
('Y','n','show','abort'), 'Y') |
23201259ffeb
[migration] abort becomes possible when asked for confirmation before migration script
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
4252
diff
changeset
|
87 |
if answer == 'abort': |
23201259ffeb
[migration] abort becomes possible when asked for confirmation before migration script
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
4252
diff
changeset
|
88 |
raise SystemExit(1) |
23201259ffeb
[migration] abort becomes possible when asked for confirmation before migration script
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
4252
diff
changeset
|
89 |
elif answer == 'n': |
0 | 90 |
return False |
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
91 |
elif answer == 'show': |
0 | 92 |
stream = open(scriptpath) |
93 |
scriptcontent = stream.read() |
|
94 |
stream.close() |
|
95 |
print |
|
96 |
print scriptcontent |
|
97 |
print |
|
98 |
else: |
|
99 |
return True |
|
100 |
||
101 |
def yes(*args, **kwargs): |
|
102 |
return True |
|
103 |
||
104 |
||
105 |
class MigrationHelper(object): |
|
106 |
"""class holding CubicWeb Migration Actions used by migration scripts""" |
|
107 |
||
108 |
def __init__(self, config, interactive=True, verbosity=1): |
|
109 |
self.config = config |
|
3700
fd550e4dc515
#481017: cubicweb-ctl shell on remote instance
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3230
diff
changeset
|
110 |
if config: |
fd550e4dc515
#481017: cubicweb-ctl shell on remote instance
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3230
diff
changeset
|
111 |
# no config on shell to a remote instance |
5442
3ed8afbbdf70
[webconfig] refactor/cleanup debug mode management on startup: simply use config.debugmode instead of debug argument everywhere...
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5436
diff
changeset
|
112 |
self.config.init_log(logthreshold=logging.ERROR) |
0 | 113 |
# 0: no confirmation, 1: only main commands confirmed, 2 ask for everything |
114 |
self.verbosity = verbosity |
|
115 |
self.need_wrap = True |
|
116 |
if not interactive or not verbosity: |
|
117 |
self.confirm = yes |
|
118 |
self.execscript_confirm = yes |
|
119 |
else: |
|
120 |
self.execscript_confirm = execscript_confirm |
|
121 |
self._option_changes = [] |
|
122 |
self.__context = {'confirm': self.confirm, |
|
123 |
'config': self.config, |
|
124 |
'interactive_mode': interactive, |
|
125 |
} |
|
6217
e2aeb40d5983
[migration] fix so that context modification are reflected on the currently executed migration script
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6187
diff
changeset
|
126 |
self._context_stack = [] |
0 | 127 |
|
2275
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
128 |
def __getattribute__(self, name): |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
129 |
try: |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
130 |
return object.__getattribute__(self, name) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
131 |
except AttributeError: |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
132 |
cmd = 'cmd_%s' % name |
6362
1b5fc8581437
[c-c] fix RuntimeError: 'maximum recursion depth exceeded while calling a Python object' we get when creating/upgrading/shelling an instance: hasattr() call __getattribute__, creating an infinite recursion error catched by the interpretor. Avoid this by testing the method is available on the class instead of the instance
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6221
diff
changeset
|
133 |
# search self.__class__ to avoid infinite recursion |
1b5fc8581437
[c-c] fix RuntimeError: 'maximum recursion depth exceeded while calling a Python object' we get when creating/upgrading/shelling an instance: hasattr() call __getattribute__, creating an infinite recursion error catched by the interpretor. Avoid this by testing the method is available on the class instead of the instance
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6221
diff
changeset
|
134 |
if hasattr(self.__class__, cmd): |
2275
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
135 |
meth = getattr(self, cmd) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
136 |
return lambda *args, **kwargs: self.interact(args, kwargs, |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
137 |
meth=meth) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
138 |
raise |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
139 |
raise AttributeError(name) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
140 |
|
0 | 141 |
def repo_connect(self): |
142 |
return self.config.repository() |
|
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
143 |
|
0 | 144 |
def migrate(self, vcconf, toupgrade, options): |
145 |
"""upgrade the given set of cubes |
|
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
146 |
|
0 | 147 |
`cubes` is an ordered list of 3-uple: |
148 |
(cube, fromversion, toversion) |
|
149 |
""" |
|
150 |
if options.fs_only: |
|
151 |
# monkey path configuration.accept_mode so database mode (e.g. Any) |
|
152 |
# won't be accepted |
|
153 |
orig_accept_mode = self.config.accept_mode |
|
154 |
def accept_mode(mode): |
|
155 |
if mode == 'Any': |
|
156 |
return False |
|
157 |
return orig_accept_mode(mode) |
|
158 |
self.config.accept_mode = accept_mode |
|
2275
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
159 |
# may be an iterator |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
160 |
toupgrade = tuple(toupgrade) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
161 |
vmap = dict( (cube, (fromver, tover)) for cube, fromver, tover in toupgrade) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
162 |
ctx = self.__context |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
163 |
ctx['versions_map'] = vmap |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
164 |
if self.config.accept_mode('Any') and 'cubicweb' in vmap: |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
165 |
migrdir = self.config.migration_scripts_dir() |
3715
e3ccadb126d7
[shell] make process_script available throuhg c-c shell / migration script context
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3700
diff
changeset
|
166 |
self.cmd_process_script(join(migrdir, 'bootstrapmigration_repository.py')) |
2275
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
167 |
for cube, fromversion, toversion in toupgrade: |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
168 |
if cube == 'cubicweb': |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
169 |
migrdir = self.config.migration_scripts_dir() |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
170 |
else: |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
171 |
migrdir = self.config.cube_migration_scripts_dir(cube) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
172 |
scripts = filter_scripts(self.config, migrdir, fromversion, toversion) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
173 |
if scripts: |
2481
24bad65dbebd
take care to migration w/ X.Y.Z_Any.py / X.Y.Z_common.py
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2476
diff
changeset
|
174 |
prevversion = None |
2275
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
175 |
for version, script in scripts: |
2481
24bad65dbebd
take care to migration w/ X.Y.Z_Any.py / X.Y.Z_common.py
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2476
diff
changeset
|
176 |
# take care to X.Y.Z_Any.py / X.Y.Z_common.py: we've to call |
24bad65dbebd
take care to migration w/ X.Y.Z_Any.py / X.Y.Z_common.py
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2476
diff
changeset
|
177 |
# cube_upgraded once all script of X.Y.Z have been executed |
24bad65dbebd
take care to migration w/ X.Y.Z_Any.py / X.Y.Z_common.py
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2476
diff
changeset
|
178 |
if prevversion is not None and version != prevversion: |
2897
2658f432284c
[migration] consider previous version as done, not current version
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2738
diff
changeset
|
179 |
self.cube_upgraded(cube, prevversion) |
2481
24bad65dbebd
take care to migration w/ X.Y.Z_Any.py / X.Y.Z_common.py
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2476
diff
changeset
|
180 |
prevversion = version |
3715
e3ccadb126d7
[shell] make process_script available throuhg c-c shell / migration script context
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3700
diff
changeset
|
181 |
self.cmd_process_script(script) |
2481
24bad65dbebd
take care to migration w/ X.Y.Z_Any.py / X.Y.Z_common.py
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2476
diff
changeset
|
182 |
self.cube_upgraded(cube, toversion) |
2275
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
183 |
else: |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
184 |
self.cube_upgraded(cube, toversion) |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
185 |
|
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
186 |
def cube_upgraded(self, cube, version): |
bc0bed0616a3
fix #344387, remember upgraded version step by step
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2124
diff
changeset
|
187 |
pass |
0 | 188 |
|
189 |
def shutdown(self): |
|
190 |
pass |
|
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
191 |
|
0 | 192 |
def interact(self, args, kwargs, meth): |
193 |
"""execute the given method according to user's confirmation""" |
|
2512
106b2a05dc88
[cleanup] started to improve cubicweb-ctl dialog messages consistency
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
2481
diff
changeset
|
194 |
msg = 'Execute command: %s(%s) ?' % ( |
0 | 195 |
meth.__name__[4:], |
196 |
', '.join([repr(arg) for arg in args] + |
|
197 |
['%s=%r' % (n,v) for n,v in kwargs.items()])) |
|
198 |
if 'ask_confirm' in kwargs: |
|
199 |
ask_confirm = kwargs.pop('ask_confirm') |
|
200 |
else: |
|
201 |
ask_confirm = True |
|
202 |
if not ask_confirm or self.confirm(msg): |
|
203 |
return meth(*args, **kwargs) |
|
204 |
||
7879
9aae456abab5
[pylint] fix pylint detected errors and tweak it so that pylint -E will be much less verbose next time (+ update some copyrights on the way)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7815
diff
changeset
|
205 |
def confirm(self, question, # pylint: disable=E0202 |
9aae456abab5
[pylint] fix pylint detected errors and tweak it so that pylint -E will be much less verbose next time (+ update some copyrights on the way)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7815
diff
changeset
|
206 |
shell=True, abort=True, retry=False, pdb=False, default='y'): |
0 | 207 |
"""ask for confirmation and return true on positive answer |
208 |
||
209 |
if `retry` is true the r[etry] answer may return 2 |
|
210 |
""" |
|
4721
8f63691ccb7f
pylint style fixes
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4553
diff
changeset
|
211 |
possibleanswers = ['y', 'n'] |
0 | 212 |
if abort: |
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
213 |
possibleanswers.append('abort') |
6187
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
214 |
if pdb: |
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
215 |
possibleanswers.append('pdb') |
0 | 216 |
if shell: |
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
217 |
possibleanswers.append('shell') |
0 | 218 |
if retry: |
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
219 |
possibleanswers.append('retry') |
0 | 220 |
try: |
2738
e7e46121a4f9
[migration] mh.confirm support a new default argument, fix default handling for ASK
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2615
diff
changeset
|
221 |
answer = ASK.ask(question, possibleanswers, default) |
0 | 222 |
except (EOFError, KeyboardInterrupt): |
223 |
answer = 'abort' |
|
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
224 |
if answer == 'n': |
0 | 225 |
return False |
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
226 |
if answer == 'retry': |
0 | 227 |
return 2 |
2615
1ea41b7c0836
F [dialog] offer to create backup. refactor to use l.c.shellutils.ASK
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
2512
diff
changeset
|
228 |
if answer == 'abort': |
0 | 229 |
raise SystemExit(1) |
6187
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
230 |
if answer == 'shell': |
0 | 231 |
self.interactive_shell() |
6187
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
232 |
return self.confirm(question, shell, abort, retry, pdb, default) |
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
233 |
if answer == 'pdb': |
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
234 |
import pdb |
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
235 |
pdb.set_trace() |
348c7d93cda3
[migration] propose to open pdb on error during execution of rql/sql query
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6042
diff
changeset
|
236 |
return self.confirm(question, shell, abort, retry, pdb, default) |
0 | 237 |
return True |
238 |
||
239 |
def interactive_shell(self): |
|
240 |
self.confirm = yes |
|
241 |
self.need_wrap = False |
|
242 |
# avoid '_' to be added to builtins by sys.display_hook |
|
243 |
def do_not_add___to_builtins(obj): |
|
244 |
if obj is not None: |
|
245 |
print repr(obj) |
|
246 |
sys.displayhook = do_not_add___to_builtins |
|
247 |
local_ctx = self._create_context() |
|
248 |
try: |
|
249 |
import readline |
|
250 |
from rlcompleter import Completer |
|
251 |
except ImportError: |
|
252 |
# readline not available |
|
253 |
pass |
|
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
254 |
else: |
0 | 255 |
readline.set_completer(Completer(local_ctx).complete) |
256 |
readline.parse_and_bind('tab: complete') |
|
3201 | 257 |
home_key = 'HOME' |
258 |
if sys.platform == 'win32': |
|
259 |
home_key = 'USERPROFILE' |
|
9294
769b8867f8ce
[cwshell] rename history file to .cwshell_history (erudi is dead, long live cw)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
8532
diff
changeset
|
260 |
histfile = os.path.join(os.environ[home_key], ".cwshell_history") |
0 | 261 |
try: |
262 |
readline.read_history_file(histfile) |
|
263 |
except IOError: |
|
264 |
pass |
|
265 |
from code import interact |
|
266 |
banner = """entering the migration python shell |
|
267 |
just type migration commands or arbitrary python code and type ENTER to execute it |
|
268 |
type "exit" or Ctrl-D to quit the shell and resume operation""" |
|
269 |
# give custom readfunc to avoid http://bugs.python.org/issue1288615 |
|
270 |
def unicode_raw_input(prompt): |
|
271 |
return unicode(raw_input(prompt), sys.stdin.encoding) |
|
272 |
interact(banner, readfunc=unicode_raw_input, local=local_ctx) |
|
8108
91868ec92391
[migration] Ignore IOError from readline.write_history_file (closes #2106621)
Julien Cristau <julien.cristau@logilab.fr>
parents:
8107
diff
changeset
|
273 |
try: |
91868ec92391
[migration] Ignore IOError from readline.write_history_file (closes #2106621)
Julien Cristau <julien.cristau@logilab.fr>
parents:
8107
diff
changeset
|
274 |
readline.write_history_file(histfile) |
91868ec92391
[migration] Ignore IOError from readline.write_history_file (closes #2106621)
Julien Cristau <julien.cristau@logilab.fr>
parents:
8107
diff
changeset
|
275 |
except IOError: |
91868ec92391
[migration] Ignore IOError from readline.write_history_file (closes #2106621)
Julien Cristau <julien.cristau@logilab.fr>
parents:
8107
diff
changeset
|
276 |
pass |
0 | 277 |
# delete instance's confirm attribute to avoid questions |
278 |
del self.confirm |
|
279 |
self.need_wrap = True |
|
280 |
||
281 |
@cached |
|
282 |
def _create_context(self): |
|
283 |
"""return a dictionary to use as migration script execution context""" |
|
284 |
context = self.__context |
|
285 |
for attr in dir(self): |
|
286 |
if attr.startswith('cmd_'): |
|
287 |
if self.need_wrap: |
|
288 |
context[attr[4:]] = getattr(self, attr[4:]) |
|
289 |
else: |
|
290 |
context[attr[4:]] = getattr(self, attr) |
|
291 |
return context |
|
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
292 |
|
6217
e2aeb40d5983
[migration] fix so that context modification are reflected on the currently executed migration script
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6187
diff
changeset
|
293 |
def update_context(self, key, value): |
e2aeb40d5983
[migration] fix so that context modification are reflected on the currently executed migration script
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6187
diff
changeset
|
294 |
for context in self._context_stack: |
e2aeb40d5983
[migration] fix so that context modification are reflected on the currently executed migration script
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6187
diff
changeset
|
295 |
context[key] = value |
e2aeb40d5983
[migration] fix so that context modification are reflected on the currently executed migration script
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6187
diff
changeset
|
296 |
self.__context[key] = value |
e2aeb40d5983
[migration] fix so that context modification are reflected on the currently executed migration script
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6187
diff
changeset
|
297 |
|
3715
e3ccadb126d7
[shell] make process_script available throuhg c-c shell / migration script context
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
3700
diff
changeset
|
298 |
def cmd_process_script(self, migrscript, funcname=None, *args, **kwargs): |
5430
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
299 |
"""execute a migration script in interactive mode |
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
300 |
|
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
301 |
Display the migration script path, ask for confirmation and execute it |
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
302 |
if confirmed |
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
303 |
|
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
304 |
Allowed input file formats for migration scripts: |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
305 |
- `python` (.py) |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
306 |
- `sql` (.sql) |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
307 |
- `doctest` (.txt or .rst) |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
308 |
|
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
309 |
.. warning:: sql migration scripts are not available in web-only instance |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
310 |
|
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
311 |
You can pass script parameters with using double dash (--) in the |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
312 |
command line |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
313 |
|
5430
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
314 |
Context environment can have these variables defined: |
5436
2455ca3a2a3a
[c-c shell] make script arguments available as __args__ in the script namespace. Use scriptargs instead of args as process_script argument name.
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5430
diff
changeset
|
315 |
- __name__ : will be determine by funcname parameter |
2455ca3a2a3a
[c-c shell] make script arguments available as __args__ in the script namespace. Use scriptargs instead of args as process_script argument name.
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5430
diff
changeset
|
316 |
- __file__ : is the name of the script if it exists |
2455ca3a2a3a
[c-c shell] make script arguments available as __args__ in the script namespace. Use scriptargs instead of args as process_script argument name.
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5430
diff
changeset
|
317 |
- __args__ : script arguments coming from command-line |
5430
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
318 |
|
ed8f71e244f8
[shell] #715938: support of script parameters (using standard '--' as arguments separator)
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5426
diff
changeset
|
319 |
:param migrscript: name of the script |
5436
2455ca3a2a3a
[c-c shell] make script arguments available as __args__ in the script namespace. Use scriptargs instead of args as process_script argument name.
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5430
diff
changeset
|
320 |
:param funcname: defines __name__ inside the shell (or use __main__) |
2455ca3a2a3a
[c-c shell] make script arguments available as __args__ in the script namespace. Use scriptargs instead of args as process_script argument name.
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5430
diff
changeset
|
321 |
:params args: optional arguments for funcname |
2455ca3a2a3a
[c-c shell] make script arguments available as __args__ in the script namespace. Use scriptargs instead of args as process_script argument name.
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5430
diff
changeset
|
322 |
:keyword scriptargs: optional arguments of the script |
0 | 323 |
""" |
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
324 |
ftypes = {'python': ('.py',), |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
325 |
'doctest': ('.txt', '.rst'), |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
326 |
'sql': ('.sql',)} |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
327 |
# sql migration scripts are not available in web-only instance |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
328 |
if not hasattr(self, "session"): |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
329 |
ftypes.pop('sql') |
3812
d37d7105e15f
[B] migration: normalize migration script path
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
3715
diff
changeset
|
330 |
migrscript = os.path.normpath(migrscript) |
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
331 |
for (script_mode, ftype) in ftypes.items(): |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
332 |
if migrscript.endswith(ftype): |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
333 |
break |
3935
2fbb79054a1a
imported patch cwctl-shell-textfile
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
3812
diff
changeset
|
334 |
else: |
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
335 |
ftypes = ', '.join(chain(*ftypes.values())) |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
336 |
msg = 'ignoring %s, not a valid script extension (%s)' |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
337 |
raise ExecutionError(msg % (migrscript, ftypes)) |
3935
2fbb79054a1a
imported patch cwctl-shell-textfile
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
3812
diff
changeset
|
338 |
if not self.execscript_confirm(migrscript): |
2fbb79054a1a
imported patch cwctl-shell-textfile
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
3812
diff
changeset
|
339 |
return |
2fbb79054a1a
imported patch cwctl-shell-textfile
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
3812
diff
changeset
|
340 |
scriptlocals = self._create_context().copy() |
6696
160ca95eb4cc
[migration] put some migration context info in doctest environment: __file__ and __args__
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6687
diff
changeset
|
341 |
scriptlocals.update({'__file__': migrscript, |
160ca95eb4cc
[migration] put some migration context info in doctest environment: __file__ and __args__
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6687
diff
changeset
|
342 |
'__args__': kwargs.pop("scriptargs", [])}) |
6217
e2aeb40d5983
[migration] fix so that context modification are reflected on the currently executed migration script
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6187
diff
changeset
|
343 |
self._context_stack.append(scriptlocals) |
3935
2fbb79054a1a
imported patch cwctl-shell-textfile
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
3812
diff
changeset
|
344 |
if script_mode == 'python': |
0 | 345 |
if funcname is None: |
346 |
pyname = '__main__' |
|
347 |
else: |
|
348 |
pyname = splitext(basename(migrscript))[0] |
|
6696
160ca95eb4cc
[migration] put some migration context info in doctest environment: __file__ and __args__
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6687
diff
changeset
|
349 |
scriptlocals['__name__'] = pyname |
0 | 350 |
execfile(migrscript, scriptlocals) |
351 |
if funcname is not None: |
|
352 |
try: |
|
353 |
func = scriptlocals[funcname] |
|
354 |
self.info('found %s in locals', funcname) |
|
355 |
assert callable(func), '%s (%s) is not callable' % (func, funcname) |
|
356 |
except KeyError: |
|
357 |
self.critical('no %s in script %s', funcname, migrscript) |
|
358 |
return None |
|
359 |
return func(*args, **kwargs) |
|
6035
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
360 |
elif script_mode == 'sql': |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
361 |
from cubicweb.server.sqlutils import sqlexec |
f8c7aa251782
[migration] unify process_script command
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
5967
diff
changeset
|
362 |
sqlexec(open(migrscript).read(), self.session.system_sql) |
6042
df9cafb8062c
[migration] commit only sql script migration
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6035
diff
changeset
|
363 |
self.commit() |
3935
2fbb79054a1a
imported patch cwctl-shell-textfile
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
3812
diff
changeset
|
364 |
else: # script_mode == 'doctest' |
2fbb79054a1a
imported patch cwctl-shell-textfile
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
3812
diff
changeset
|
365 |
import doctest |
6687
0b1f5c14646e
[shell, testlib] return doc test results in process_script and new assertDocTestFile method on CubicWebTC
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6659
diff
changeset
|
366 |
return doctest.testfile(migrscript, module_relative=False, |
0b1f5c14646e
[shell, testlib] return doc test results in process_script and new assertDocTestFile method on CubicWebTC
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6659
diff
changeset
|
367 |
optionflags=doctest.ELLIPSIS, |
6732
f63cef610b97
[migration] improve doctest report format
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6696
diff
changeset
|
368 |
# verbose mode when user input is expected |
f63cef610b97
[migration] improve doctest report format
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6696
diff
changeset
|
369 |
verbose=self.verbosity==2, |
f63cef610b97
[migration] improve doctest report format
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6696
diff
changeset
|
370 |
report=True, |
6687
0b1f5c14646e
[shell, testlib] return doc test results in process_script and new assertDocTestFile method on CubicWebTC
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6659
diff
changeset
|
371 |
encoding='utf-8', |
0b1f5c14646e
[shell, testlib] return doc test results in process_script and new assertDocTestFile method on CubicWebTC
Julien Jehannet <julien.jehannet@logilab.fr>
parents:
6659
diff
changeset
|
372 |
globs=scriptlocals) |
6219
803c1019138e
[migration] .pop() is more readable
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
6217
diff
changeset
|
373 |
self._context_stack.pop() |
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
374 |
|
0 | 375 |
def cmd_option_renamed(self, oldname, newname): |
376 |
"""a configuration option has been renamed""" |
|
377 |
self._option_changes.append(('renamed', oldname, newname)) |
|
378 |
||
5580
3e9e6dd54ebb
[migration] add migration file commands to follow option group changes
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5488
diff
changeset
|
379 |
def cmd_option_group_changed(self, option, oldgroup, newgroup): |
0 | 380 |
"""a configuration option has been moved in another group""" |
381 |
self._option_changes.append(('moved', option, oldgroup, newgroup)) |
|
382 |
||
383 |
def cmd_option_added(self, optname): |
|
384 |
"""a configuration option has been added""" |
|
385 |
self._option_changes.append(('added', optname)) |
|
386 |
||
387 |
def cmd_option_removed(self, optname): |
|
388 |
"""a configuration option has been removed""" |
|
389 |
# can safely be ignored |
|
390 |
#self._option_changes.append(('removed', optname)) |
|
391 |
||
392 |
def cmd_option_type_changed(self, optname, oldtype, newvalue): |
|
393 |
"""a configuration option's type has changed""" |
|
394 |
self._option_changes.append(('typechanged', optname, oldtype, newvalue)) |
|
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
395 |
|
676
270eb87a768a
provide a new add_cubes() migration function for cases where the new cubes are linked together by new relations
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
447
diff
changeset
|
396 |
def cmd_add_cubes(self, cubes): |
270eb87a768a
provide a new add_cubes() migration function for cases where the new cubes are linked together by new relations
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
447
diff
changeset
|
397 |
"""modify the list of used cubes in the in-memory config |
270eb87a768a
provide a new add_cubes() migration function for cases where the new cubes are linked together by new relations
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
447
diff
changeset
|
398 |
returns newly inserted cubes, including dependencies |
270eb87a768a
provide a new add_cubes() migration function for cases where the new cubes are linked together by new relations
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
447
diff
changeset
|
399 |
""" |
270eb87a768a
provide a new add_cubes() migration function for cases where the new cubes are linked together by new relations
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
447
diff
changeset
|
400 |
if isinstance(cubes, basestring): |
270eb87a768a
provide a new add_cubes() migration function for cases where the new cubes are linked together by new relations
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
447
diff
changeset
|
401 |
cubes = (cubes,) |
0 | 402 |
origcubes = self.config.cubes() |
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
403 |
newcubes = [p for p in self.config.expand_cubes(cubes) |
6221
a5cc5dc15f9d
[migration] remove buggy assertion
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
6219
diff
changeset
|
404 |
if not p in origcubes] |
0 | 405 |
if newcubes: |
406 |
self.config.add_cubes(newcubes) |
|
407 |
return newcubes |
|
408 |
||
2124
5a0b02f37b23
set removedeps to False by default, raise an exception instead of a simple assertion for error, more remove_cube tests
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2122
diff
changeset
|
409 |
def cmd_remove_cube(self, cube, removedeps=False): |
2122
4ea13a828513
add removedeps option to remove_cube to control wether a cube's dependencies should be removed as well or not
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
410 |
if removedeps: |
4ea13a828513
add removedeps option to remove_cube to control wether a cube's dependencies should be removed as well or not
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
411 |
toremove = self.config.expand_cubes([cube]) |
4ea13a828513
add removedeps option to remove_cube to control wether a cube's dependencies should be removed as well or not
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
412 |
else: |
4ea13a828513
add removedeps option to remove_cube to control wether a cube's dependencies should be removed as well or not
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
413 |
toremove = (cube,) |
0 | 414 |
origcubes = self.config._cubes |
2122
4ea13a828513
add removedeps option to remove_cube to control wether a cube's dependencies should be removed as well or not
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
1977
diff
changeset
|
415 |
basecubes = [c for c in origcubes if not c in toremove] |
0 | 416 |
self.config._cubes = tuple(self.config.expand_cubes(basecubes)) |
417 |
removed = [p for p in origcubes if not p in self.config._cubes] |
|
8107
e5858a4a1244
[migration] make remove_cube('foo') not fail if foo is already removed. Closes #2106532
Julien Cristau <julien.cristau@logilab.fr>
parents:
7879
diff
changeset
|
418 |
if not cube in removed and cube in origcubes: |
2124
5a0b02f37b23
set removedeps to False by default, raise an exception instead of a simple assertion for error, more remove_cube tests
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2122
diff
changeset
|
419 |
raise ConfigurationError("can't remove cube %s, " |
5a0b02f37b23
set removedeps to False by default, raise an exception instead of a simple assertion for error, more remove_cube tests
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
2122
diff
changeset
|
420 |
"used as a dependency" % cube) |
0 | 421 |
return removed |
1802
d628defebc17
delete-trailing-whitespace + some copyright update
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents:
676
diff
changeset
|
422 |
|
0 | 423 |
def rewrite_configuration(self): |
424 |
configfile = self.config.main_config_file() |
|
425 |
if self._option_changes: |
|
426 |
read_old_config(self.config, self._option_changes, configfile) |
|
3152 | 427 |
fd, newconfig = tempfile.mkstemp() |
0 | 428 |
for optdescr in self._option_changes: |
429 |
if optdescr[0] == 'added': |
|
430 |
optdict = self.config.get_option_def(optdescr[1]) |
|
431 |
if optdict.get('default') is REQUIRED: |
|
447 | 432 |
self.config.input_option(optdescr[1], optdict) |
0 | 433 |
self.config.generate_config(open(newconfig, 'w')) |
5487
3ab2682a4b37
[migration] ask_confirm argument of show_diff doesn't contain an _
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
5484
diff
changeset
|
434 |
show_diffs(configfile, newconfig, askconfirm=self.confirm is not yes) |
3152 | 435 |
os.close(fd) |
0 | 436 |
if exists(newconfig): |
437 |
os.unlink(newconfig) |
|
438 |
||
7083
b8e35cde46e9
help pylint by explicitely defining some attributes
Alexandre Fayolle <alexandre.fayolle@logilab.fr>
parents:
6732
diff
changeset
|
439 |
# these are overridden by set_log_methods below |
b8e35cde46e9
help pylint by explicitely defining some attributes
Alexandre Fayolle <alexandre.fayolle@logilab.fr>
parents:
6732
diff
changeset
|
440 |
# only defining here to prevent pylint from complaining |
b8e35cde46e9
help pylint by explicitely defining some attributes
Alexandre Fayolle <alexandre.fayolle@logilab.fr>
parents:
6732
diff
changeset
|
441 |
info = warning = error = critical = exception = debug = lambda msg,*a,**kw: None |
0 | 442 |
|
443 |
from logging import getLogger |
|
444 |
from cubicweb import set_log_methods |
|
445 |
set_log_methods(MigrationHelper, getLogger('cubicweb.migration')) |
|
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
446 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
447 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
448 |
def version_strictly_lower(a, b): |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
449 |
if a: |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
450 |
a = Version(a) |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
451 |
if b: |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
452 |
b = Version(b) |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
453 |
return a < b |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
454 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
455 |
def max_version(a, b): |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
456 |
return str(max(Version(a), Version(b))) |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
457 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
458 |
class ConfigurationProblem(object): |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
459 |
"""Each cube has its own list of dependencies on other cubes/versions. |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
460 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
461 |
The ConfigurationProblem is used to record the loaded cubes, then to detect |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
462 |
inconsistencies in their dependencies. |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
463 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
464 |
See configuration management on wikipedia for litterature. |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
465 |
""" |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
466 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
467 |
def __init__(self, config): |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
468 |
self.config = config |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
469 |
self.cubes = {'cubicweb': cwcfg.cubicweb_version()} |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
470 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
471 |
def add_cube(self, name, version): |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
472 |
self.cubes[name] = version |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
473 |
|
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
474 |
def solve(self): |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
475 |
self.warnings = [] |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
476 |
self.errors = [] |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
477 |
self.dependencies = {} |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
478 |
self.reverse_dependencies = {} |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
479 |
self.constraints = {} |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
480 |
# read dependencies |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
481 |
for cube in self.cubes: |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
482 |
if cube == 'cubicweb': continue |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
483 |
self.dependencies[cube] = dict(self.config.cube_dependencies(cube)) |
6659
6205927e927a
fix problem introduced with previous commit
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6657
diff
changeset
|
484 |
self.dependencies[cube]['cubicweb'] = self.config.cube_depends_cubicweb_version(cube) |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
485 |
# compute reverse dependencies |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
486 |
for cube, dependencies in self.dependencies.iteritems(): |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
487 |
for name, constraint in dependencies.iteritems(): |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
488 |
self.reverse_dependencies.setdefault(name,set()) |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
489 |
if constraint: |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
490 |
try: |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
491 |
oper, version = constraint.split() |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
492 |
self.reverse_dependencies[name].add( (oper, version, cube) ) |
7815
2a164a9cf81c
[exceptions] stop catching any exception in various places (closes #1942716)
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
7576
diff
changeset
|
493 |
except Exception: |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
494 |
self.warnings.append( |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
495 |
'cube %s depends on %s but constraint badly ' |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
496 |
'formatted: %s' % (cube, name, constraint)) |
7537
1af162bd78b8
[migration] bugfix: c-c list was not displaying the name of a cube requiring another cube without constraining the version.
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
7083
diff
changeset
|
497 |
else: |
1af162bd78b8
[migration] bugfix: c-c list was not displaying the name of a cube requiring another cube without constraining the version.
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
7083
diff
changeset
|
498 |
self.reverse_dependencies[name].add( (None, None, cube) ) |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
499 |
# check consistency |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
500 |
for cube, versions in sorted(self.reverse_dependencies.items()): |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
501 |
oper, version, source = None, None, None |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
502 |
# simplify constraints |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
503 |
if versions: |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
504 |
for constraint in versions: |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
505 |
op, ver, src = constraint |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
506 |
if oper is None: |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
507 |
oper = op |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
508 |
version = ver |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
509 |
source = src |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
510 |
elif op == '>=' and oper == '>=': |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
511 |
if version_strictly_lower(version, ver): |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
512 |
version = ver |
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
513 |
source = src |
7576
1b7fa4df1f83
[cw-ctl] command list should not break when cube depends on version None (closes #1787209)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
7537
diff
changeset
|
514 |
elif op == None: |
1b7fa4df1f83
[cw-ctl] command list should not break when cube depends on version None (closes #1787209)
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
7537
diff
changeset
|
515 |
continue |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
516 |
else: |
8532
28a346df670e
[cwctl] show a better diagnostic message on version violation (closes #2464800)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
8119
diff
changeset
|
517 |
print ('unable to handle %s in %s, set to `%s %s` ' |
28a346df670e
[cwctl] show a better diagnostic message on version violation (closes #2464800)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
8119
diff
changeset
|
518 |
'but currently up to `%s %s`' % |
28a346df670e
[cwctl] show a better diagnostic message on version violation (closes #2464800)
Aurelien Campeas <aurelien.campeas@logilab.fr>
parents:
8119
diff
changeset
|
519 |
(cube, source, oper, version, op, ver)) |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
520 |
# "solve" constraint satisfaction problem |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
521 |
if cube not in self.cubes: |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
522 |
self.errors.append( ('add', cube, version, source) ) |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
523 |
elif versions: |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
524 |
lower_strict = version_strictly_lower(self.cubes[cube], version) |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
525 |
if oper in ('>=','='): |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
526 |
if lower_strict: |
6657
402bff898024
[cwctl] command list now checks version of cw, not only versions of cubes
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
6362
diff
changeset
|
527 |
self.errors.append( ('update', cube, version, source) ) |
7537
1af162bd78b8
[migration] bugfix: c-c list was not displaying the name of a cube requiring another cube without constraining the version.
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
7083
diff
changeset
|
528 |
elif oper is None: |
1af162bd78b8
[migration] bugfix: c-c list was not displaying the name of a cube requiring another cube without constraining the version.
Nicolas Chauvat <nicolas.chauvat@logilab.fr>
parents:
7083
diff
changeset
|
529 |
pass # no constraint on version |
5027
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
530 |
else: |
d688daf0a62c
[config] move ConfigurationProblem to migration + refactor it to benefit from config methods
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents:
4721
diff
changeset
|
531 |
print 'unknown operator', oper |