Fix constraint sync during migration - restore constraints lost during merge in test schema. - use constraint_by_eid in BeforeDeleteCWConstraintHook as done in 3.17.14 for BeforeDeleteConstrainedByHook. Fixes handling of multiple constraints of the same type. - make sync_schema_props_perms() delete the CWConstraint entity instead of the constrained_by relation. In 3.19, the latter doesn't automatically result in the former just because the relation is composite. Simplify the constraint migration to delete all removed constraints and recreate new ones even if they share the same type; that optimization made the code more complicated for (AFAICT) no significant reason.

     1

function datetuple(d) {

     2

    return [d.getFullYear(), d.getMonth()+1, d.getDate(),

     3

	    d.getHours(), d.getMinutes()];

     4

}

     5

     6

function pprint(obj) {

     7

    print('{');

     8

    for(k in obj) {

     9

	print('  ' + k + ' = ' + obj[k]);

    10

    }

    11

    print('}');

    12

}

    13

    14

function arrayrepr(array) {

    15

    return '[' + array.join(', ') + ']';

    16

}

    17

    18

function assertArrayEquals(array1, array2) {

    19

    if (array1.length != array2.length) {

    20

	throw new crosscheck.AssertionFailure(array1.join(', ') + ' != ' + array2.join(', '));

    21

    }

    22

    for (var i=0; i<array1.length; i++) {

    23

	if (array1[i] != array2[i]) {

    24

    25

	    throw new crosscheck.AssertionFailure(arrayrepr(array1) + ' and ' + arrayrepr(array2)

    26

						 + ' differs at index ' + i);

    27

	}

    28

    }

    29

}