Fix sorting key for rdefs in schema viewer With changeset 234ca3cbbb46, clicking in the schema of an entity with cubicweb in py3 on "vue en boite" will probably result in an infinite spinner (which implies cw > 3.26) What happened ? This "vue en boite" used to work at least until... hg diff -c a8c1ea390400 cubicweb/schema.py @@ -993,10 +992,6 @@ class CubicWebRelationSchema(PermissionM return False return True - @deprecated('use .rdef(subjtype, objtype).role_cardinality(role)') - def cardinality(self, subjtype, objtype, target): - return self.rdef(subjtype, objtype).role_cardinality(target) - class CubicWebSchema(Schema): """set of entities and relations schema defining the possible data sets But, wait ... If I open a shell on an instance of cw 3.24 something seems off >>> list(schema['CWUniqueTogetherConstraint'].relation_definitions())[0][0].cardinality # <bound method CubicWebRelationSchema.wrapped of <constraint_of [CWUniqueTogetherConstraint,CWEType]>> We have been sorting on a method the whole time ? Is it possible what were the effects ? 1) We cannot sort function can't we ? >>> def adder(i): return lambda x: x+i >>> sorted(map(adder,range(10))) [<function __main__.<lambda>>, <function __main__.<lambda>>, ... Yes we can. 2) what does it means. >>> { adder(1) : 1 } Out[19]: {<function __main__.<lambda>>: 1} In fact the function object as a __hash__ method (which is practical for making memoizers (cache)), and return truly random results (pseudo random). My take on this patch is relations have NEVER been sorted by cardinality. No one never ever noticed. Hence, I propose to not fix a bug that never was reported.

     1

# copyright 2003-2010 LOGILAB S.A. (Paris, FRANCE), all rights reserved.

     2

# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr

     3

#

     4

# This file is part of CubicWeb.

     5

#

     6

# CubicWeb is free software: you can redistribute it and/or modify it under the

     7

# terms of the GNU Lesser General Public License as published by the Free

     8

# Software Foundation, either version 2.1 of the License, or (at your option)

     9

# any later version.

    10

#

    11

# CubicWeb is distributed in the hope that it will be useful, but WITHOUT

    12

# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS

    13

# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more

    14

# details.

    15

#

    16

# You should have received a copy of the GNU Lesser General Public License along

    17

# with CubicWeb.  If not, see <http://www.gnu.org/licenses/>.

    18

"""generate list of modules for sphinx doc

    19

    20

"""

    21

    22

EXCLUDE_DIRS = ('test', 'tests', 'examples', 'data', 'doc', 'dist',

    23

                '.hg', 'migration')

    24

if __name__ == '__main__':

    25

    26

    from logilab.common.sphinxutils import ModuleGenerator

    27

    cw_gen = ModuleGenerator('cubicweb', '../..')

    28

    cw_gen.generate("../book/en/annexes/api_cubicweb.rst",

    29

                    EXCLUDE_DIRS + ('cwdesklets', 'misc', 'skel', 'skeleton'))

    30

    for modname in ('logilab', 'rql', 'yams'):

    31

        cw_gen = ModuleGenerator(modname, '../../../' + modname)

    32

        cw_gen.generate("../book/en/annexes/api_%s.rst" % modname,

    33

                        EXCLUDE_DIRS + ('tools',))