debian/source.lintian-overrides
author Denis Laxalde <denis.laxalde@logilab.fr>
Thu, 28 Jun 2018 11:19:14 +0200
branch3.26
changeset 12336 90ff36da4c8e
parent 11402 e60a8e5d29ef
permissions -rw-r--r--
[py3] Avoid setting attribute on Element instance in wdoc view This change is needed to make "wdoc" view work on Python 3. Indeed, before this patch, we used to set a "parent" attribute on Element instances, which is not permitted since Python 3.3 as xml.etree.ElementTree uses the C implementation by default. To get rid of this "parent" attribute, we rework the XML nodes processing logic to return and retrieve a node along with its parent in several place of the code. Namely, build_toc_index() now accepts the "parent" value for "node" and inserts it in the "index" dict (thus avoid `node.parent = <value>`). Respectively, every query to the "index" dict is updated to also retrieve the "parent" (thus avoiding `<value> = node.parent`). Later in InlineHelpView class, the "index" dict is bound to "tocindex" attribute so we adjust how it is queried in respective methods. Tests cubicweb/web/test/unittest_views_wdoc.py now pass on Python 3.
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
11402
e60a8e5d29ef [debian] add a lintian override for source-is-missing about jquery.flot.js
David Douard <david.douard@logilab.fr>
parents:
diff changeset
     1
cubicweb source: source-is-missing cubicweb/web/data/jquery.flot.js line length is * characters (>512)