[ssplanner] Prevent execution of write queries involving computed relations Previously, setting a computed relation upon entity creation or modification (using the ORM or an RQL query) would usually fail with an operational error in the backend ("no such table"). However, under some mysterious circumstances (like passing a string as value in cw_set for a computed relation), the RQL to SQL transformation would simply drop the clause. To prevent this to happen, we add a check for computed relation before adding a relation to an execution plan. This check raises a QueryError. It happens in several places: * in querier.InsertPlan.add_relation_def() (called from several places in ssplanner steps) for INSERT queries, * in ssplanner.UpdateStep.execute() for SET queries and, * in ssplanner.SSplanner.build_delete_plan() for DELETE queries. Tests added to unittest_querier.py because unittest_sslplanner.py looked inappropriate (it has only unit tests) and the former already had a NonRegressionTC class.

     1

[tox]

     2

envlist = py27,py34,flake8

     3

     4

[testenv]

     5

deps =

     6

  pytest

     7

commands =

     8

  {envpython} -m pytest {posargs:test}

     9

    10

[testenv:flake8]

    11

skip_install = true

    12

whitelist_externals =

    13

  flake8

    14

deps =

    15

  flake8

    16

commands = flake8

    17

    18

[flake8]

    19

exclude = cubicweb_%(cubename)s/migration/*,test/data/*,.tox/*