[ssplanner] Prevent execution of write queries involving computed relations Previously, setting a computed relation upon entity creation or modification (using the ORM or an RQL query) would usually fail with an operational error in the backend ("no such table"). However, under some mysterious circumstances (like passing a string as value in cw_set for a computed relation), the RQL to SQL transformation would simply drop the clause. To prevent this to happen, we add a check for computed relation before adding a relation to an execution plan. This check raises a QueryError. It happens in several places: * in querier.InsertPlan.add_relation_def() (called from several places in ssplanner steps) for INSERT queries, * in ssplanner.UpdateStep.execute() for SET queries and, * in ssplanner.SSplanner.build_delete_plan() for DELETE queries. Tests added to unittest_querier.py because unittest_sslplanner.py looked inappropriate (it has only unit tests) and the former already had a NonRegressionTC class.

     1

# copyright 2003-2010 LOGILAB S.A. (Paris, FRANCE), all rights reserved.

     2

# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr

     3

#

     4

# This file is part of CubicWeb.

     5

#

     6

# CubicWeb is free software: you can redistribute it and/or modify it under the

     7

# terms of the GNU Lesser General Public License as published by the Free

     8

# Software Foundation, either version 2.1 of the License, or (at your option)

     9

# any later version.

    10

#

    11

# CubicWeb is distributed in the hope that it will be useful, but WITHOUT

    12

# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS

    13

# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more

    14

# details.

    15

#

    16

# You should have received a copy of the GNU Lesser General Public License along

    17

# with CubicWeb.  If not, see <http://www.gnu.org/licenses/>.