[repoapi] fold ClientConnection into Connection Connection replaces ClientConnection everywhere. Some notes: * testlib: .client_cnx and .repo_cnx become aliases of .cnx (we might not want to tell people to update their tests again for just no real benefit, so we'll live with these aliases for a while) * entity.as_rset must not be cached because we risk caching result sets having a Connection object as .req (helps unittest_breadcrumbs) * entity._cw_dont_cache_attributes loses its repo/request special paths and only keeps its storage/bfss user (this helps unittest_wfobjs) * moreover, entity.cw_instantiate and .cw_set stop overriding the attributes cache *after* the before_*_entity hooks have run, because there is no need to (it is now actually harmful to do it and unittest_hooks.test_html_tidy* tests remain green because of this) * rset._build_entity sticks its .req onto the entity just fetched from the cache, because otherwise it might carry a _cw that is a Connection object where a Request is expected (helps unittest_views_actions) * we get overall better cache usages (entity caches were split over Request + ClientConnection and Connection), hence the changes unittest_entity and unittest_wfobjs * void the ecache when providing the cnx to a request object Having the entity cache pre-filled when we bind it to the request object hurts because these entities are bound to Connection objects, that lack e.g. `.form` or `.add_js` and crash the views subsystem. Thus, the unittest_testlib.test_error_raised test will are kept green. Closes #3837233

     1

/**

     2

 * jQuery Cookie plugin

     3

 *

     4

 * Copyright (c) 2010 Klaus Hartl (stilbuero.de)

     5

 * Dual licensed under the MIT and GPL licenses:

     6

 * http://www.opensource.org/licenses/mit-license.php

     7

 * http://www.gnu.org/licenses/gpl.html

     8

 *

     9

 */

    10

jQuery.cookie = function (key, value, options) {

    11

    12

    // key and at least value given, set cookie...

    13

    if (arguments.length > 1 && String(value) !== "[object Object]") {

    14

        options = jQuery.extend({}, options);

    15

    16

        if (value === null || value === undefined) {

    17

            options.expires = -1;

    18

        }

    19

    20

        if (typeof options.expires === 'number') {

    21

            var days = options.expires, t = options.expires = new Date();

    22

            t.setDate(t.getDate() + days);

    23

        }

    24

    25

        value = String(value);

    26

    27

        return (document.cookie = [

    28

            encodeURIComponent(key), '=',

    29

            options.raw ? value : encodeURIComponent(value),

    30

            options.expires ? '; expires=' + options.expires.toUTCString() : '', // use expires attribute, max-age is not supported by IE

    31

            options.path ? '; path=' + options.path : '',

    32

            options.domain ? '; domain=' + options.domain : '',

    33

            options.secure ? '; secure' : ''

    34

        ].join(''));

    35

    }

    36

    37

    // key and possibly options given, get cookie...

    38

    options = value || {};

    39

    var result, decode = options.raw ? function (s) { return s; } : decodeURIComponent;

    40

    return (result = new RegExp('(?:^|; )' + encodeURIComponent(key) + '=([^;]*)').exec(document.cookie)) ? decode(result[1]) : null;

    41

};