[repoapi] fold ClientConnection into Connection Connection replaces ClientConnection everywhere. Some notes: * testlib: .client_cnx and .repo_cnx become aliases of .cnx (we might not want to tell people to update their tests again for just no real benefit, so we'll live with these aliases for a while) * entity.as_rset must not be cached because we risk caching result sets having a Connection object as .req (helps unittest_breadcrumbs) * entity._cw_dont_cache_attributes loses its repo/request special paths and only keeps its storage/bfss user (this helps unittest_wfobjs) * moreover, entity.cw_instantiate and .cw_set stop overriding the attributes cache *after* the before_*_entity hooks have run, because there is no need to (it is now actually harmful to do it and unittest_hooks.test_html_tidy* tests remain green because of this) * rset._build_entity sticks its .req onto the entity just fetched from the cache, because otherwise it might carry a _cw that is a Connection object where a Request is expected (helps unittest_views_actions) * we get overall better cache usages (entity caches were split over Request + ClientConnection and Connection), hence the changes unittest_entity and unittest_wfobjs * void the ecache when providing the cnx to a request object Having the entity cache pre-filled when we bind it to the request object hurts because these entities are bound to Connection objects, that lack e.g. `.form` or `.add_js` and crash the views subsystem. Thus, the unittest_testlib.test_error_raised test will are kept green. Closes #3837233

     1

# copyright 2003-2012 LOGILAB S.A. (Paris, FRANCE), all rights reserved.

     2

# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr

     3

#

     4

# This file is part of CubicWeb.

     5

#

     6

# CubicWeb is free software: you can redistribute it and/or modify it under the

     7

# terms of the GNU Lesser General Public License as published by the Free

     8

# Software Foundation, either version 2.1 of the License, or (at your option)

     9

# any later version.

    10

#

    11

# CubicWeb is distributed in the hope that it will be useful, but WITHOUT

    12

# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS

    13

# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more

    14

# details.

    15

#

    16

# You should have received a copy of the GNU Lesser General Public License along

    17

# with CubicWeb.  If not, see <http://www.gnu.org/licenses/>.

    18

from warnings import warn

    19

from logilab.common.deprecation import class_moved

    20

warn('[3.15] moved to logilab.common.registry', DeprecationWarning, stacklevel=2)

    21

from logilab.common.registry import *

    22

    23

VRegistry = class_moved(RegistryStore, old_name='VRegistry', message='[3.15] VRegistry moved to logilab.common.registry as RegistryStore')