[entity,views/json] backout 353bbd17a8b6 (reopens #2559931) Calling .complete() unconditionnally from the json encoder is unsafe since on entity creation validation: * an eid may have been drawn (hence even .has_eid() would not help) while processing form data in the edit controller * a ValidationError may have been raised and the entity-creating transaction rollbacked This leads to a crash on the return path from the validation to the browser, where the json_dumps((status, args, entity)) call will stumble upon the .complete() call which will fail because the entity does not (any more) exist in the database.

     1

# type attribute might already be there if migrating from

     2

# version < 3.5 to version >= 3.5.3, BaseTransition being added

     3

# in bootstrap_migration

     4

if versions_map['cubicweb'][0] >= (3, 5, 0):

     5

    add_attribute('BaseTransition', 'type')

     6

    sync_schema_props_perms('state_of')

     7

    sync_schema_props_perms('transition_of')