Mercurial Mercurial > pub > hg > cubicweb / annotate
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | file | latest | revisions | annotate | diff | comparison | raw | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
server/hooksmanager.py
author Aurelien Campeas <aurelien.campeas@logilab.fr>
Tue, 19 Mar 2013 15:18:22 +0100
changeset 8735 5567a5117aeb
parent 5424 8ecbcbff9777
child 9392 dd88d86d780a
permissions -rw-r--r--
[entity] ensure the .related(entities=False) parameter is honored all the way down (closes #2755994) As of today, such a call will always fill the relation cache by calling .entities() on every single related rset entry. As a consequence, the `limit` parameter handling also had to be fixed. It was bogus in the following ways: * not used in the related_rql, hence potentially huge database requests, but also actually * foolishly used in the .entities()-calling cache routine we now bypass (this changeset ticket's main topic) Now: * we set a limit on the rql expression, and * forbid caching if given a non-None limit (as we don't want to make the cache handling code more complicated than it is already) With this, entity.unrelated gets a better limit implementation (so the code in related/unrelated is nice and symmetric) Risk: * _cw_relation_cache disappears completely, which is good, but this is Python, so you never know ...
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
5421
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     1
 
# copyright 2003-2010 LOGILAB S.A. (Paris, FRANCE), all rights reserved.
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     2
 
# contact http://www.logilab.fr/ -- mailto:contact@logilab.fr
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     3
 
#
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     4
 
# This file is part of CubicWeb.
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     5
 
#
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     6
 
# CubicWeb is free software: you can redistribute it and/or modify it under the
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     7
 
# terms of the GNU Lesser General Public License as published by the Free
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     8
 
# Software Foundation, either version 2.1 of the License, or (at your option)
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
     9
 
# any later version.
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
    10
 
#
5424
8ecbcbff9777 replace logilab-common by CubicWeb in disclaimer
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 5421
diff changeset 
    11
 
# CubicWeb is distributed in the hope that it will be useful, but WITHOUT
5421
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
    12
 
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
    13
 
# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
    14
 
# details.
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
    15
 
#
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
    16
 
# You should have received a copy of the GNU Lesser General Public License along
8167de96c523 proper licensing information (LGPL-2.1). Hope I get it right this time.
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 4517
diff changeset 
    17
 
# with CubicWeb.  If not, see <http://www.gnu.org/licenses/>.
2835
04034421b072 [hooks] major refactoring:
Sylvain Thénault <sylvain.thenault@logilab.fr>
parents: 2822
diff changeset 
    18
 
from logilab.common.deprecation import class_renamed, class_moved
3391
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    19
 
from cubicweb.server import hook
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    20
 
SystemHook = class_renamed('SystemHook', hook.Hook)
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    21
 
PropagateSubjectRelationHook = class_renamed('PropagateSubjectRelationHook',
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    22
 
                                             hook.PropagateSubjectRelationHook)
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    23
 
PropagateSubjectRelationAddHook = class_renamed('PropagateSubjectRelationAddHook',
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    24
 
                                                hook.PropagateSubjectRelationAddHook)
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    25
 
PropagateSubjectRelationDelHook = class_renamed('PropagateSubjectRelationDelHook',
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    26
 
                                                hook.PropagateSubjectRelationDelHook)
b6564d9ca872 [hooks] fix deprecation warnings for old hook classes
Adrien Di Mascio <Adrien.DiMascio@logilab.fr>
parents: 3090
diff changeset 
    27
 
Hook = class_moved(hook.Hook)
cubicweb